Hi,
Something wrong with the corrected patch I sent ?
-Message d'origine-
De : mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] De la part de
Olivier PENA
Envoyé : vendredi 10 avril 2015 11:38
À : Jose Fonseca; Emil Velikov; olivier.pena...@gmail.com
Cc : ML mesa-dev
Objet : Re:
From: Dave Airlie
This fixes a number of regressions since
61393bdcdc3b63624bf6e9730444f5e9deeedfc8
u_tile: fix stencil texturing tests under softpipe
should fix:
https://bugs.freedesktop.org/show_bug.cgi?id=89960
Signed-off-by: Dave Airlie
---
src/gallium/drivers/softpipe/sp_fs_exec.c | 2 +-
Reviewed-by: Marek Olšák
Marek
On Wed, Apr 22, 2015 at 3:43 AM, Dave Airlie wrote:
> if we support stencil texturing, enable texture_stencil8
> there is no requirement to support native S8 for this,
> the texture can be converted to x24s8 fine.
>
> v2: fold fixes from Marek in:
>a) put S8 l
Hi!
I took the liberty of fixing a few typos. If anyone's interested, you can
download the Git patch from http://bytenoise.co.uk/misc/fix-a-few-typos.patch .
I've never had much luck compiling other people's projects, so this warrants
vetting by someone smarter than me, I'm afraid. Still, I
Zoë Blade writes:
> Hi!
>
> I took the liberty of fixing a few typos. If anyone's interested, you can
> download the Git patch from http://bytenoise.co.uk/misc/fix-a-few-typos.patch
> . I've never had much luck compiling other people's projects, so this
> warrants vetting by someone smarter
Yes, it fails with Mingw (I only tried with Linux cross-compilation):
$ scons platform=windows osmesa
scons: Reading SConscript files ...
Checking for GCC ... yes
Checking for Clang ... no
scons: Using build cache in /home/jfonseca/.sconscache.
Checking for X11 (x11 xext xdamage xfixes glproto
Hi!
> In this line there is a second typo in "degnerate".
Very well spotted, thank you!
I've now fixed that particular typo, which appears in two different places:
src/mesa/drivers/dri/i965/brw_clip_unfilled.c
src/mesa/vbo/vbo_save_draw.c
While I was at it, I spotted two more typos, now fixed:
Reviewed-by: Roland Scheidegger
Am 22.04.2015 um 09:41 schrieb Dave Airlie:
> From: Dave Airlie
>
> This fixes a number of regressions since
> 61393bdcdc3b63624bf6e9730444f5e9deeedfc8
> u_tile: fix stencil texturing tests under softpipe
>
> should fix:
> https://bugs.freedesktop.org/show_bug.c
https://bugs.freedesktop.org/show_bug.cgi?id=90130
--- Comment #6 from Ken Martin ---
Created attachment 115271
--> https://bugs.freedesktop.org/attachment.cgi?id=115271&action=edit
apitrace file
Here is the apitrace file
--
You are receiving this mail because:
You are the QA Contact for the
https://bugs.freedesktop.org/show_bug.cgi?id=90130
--- Comment #7 from Ken Martin ---
And here is the driver using the propoer LD_LIBRARY_PATH
OpenGL vendor string: VMware, Inc.
OpenGL renderer string: Gallium 0.4 on llvmpipe (LLVM 3.5, 128 bits)
OpenGL version string: 3.0 Mesa 10.5.3
OpenGL sha
On 04/22/2015 01:41 AM, Dave Airlie wrote:
From: Dave Airlie
This fixes a number of regressions since
61393bdcdc3b63624bf6e9730444f5e9deeedfc8
u_tile: fix stencil texturing tests under softpipe
should fix:
https://bugs.freedesktop.org/show_bug.cgi?id=89960
Signed-off-by: Dave Airlie
---
sr
https://bugs.freedesktop.org/show_bug.cgi?id=90130
--- Comment #8 from Ken Martin ---
Created attachment 115274
--> https://bugs.freedesktop.org/attachment.cgi?id=115274&action=edit
Valid Image
Here is what the image should look like, the cells are colored with the red
channel being gl_Primiti
On Wed, Apr 22, 2015 at 12:41 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This fixes a number of regressions since
> 61393bdcdc3b63624bf6e9730444f5e9deeedfc8
> u_tile: fix stencil texturing tests under softpipe
>
> should fix:
> https://bugs.freedesktop.org/show_bug.cgi?id=89960
Bugzilla: htt
I setted up a virtual machine working on linux in order to reproduce (we only
works on windows platform here).
The libraries order doesn't matter, a verbose compilation shows --start-group
and --end-group linker flags.
It seems the def file is not well understood by the linker.
I workaround like
https://bugs.freedesktop.org/show_bug.cgi?id=90130
--- Comment #9 from Ken Martin ---
(In reply to Roland Scheidegger from comment #5)
> Or even better, a piglit test :-).
>
> I suspect there's an issue with the prim assembler in draw.
> Since from a quick look it seems like the prim assembler w
https://bugs.freedesktop.org/show_bug.cgi?id=90130
--- Comment #10 from Ken Martin ---
Bah how do you edit comments? Both of the above comments should be
glPrimitiveId%256/255.0 etc to make sure the resulting value is in the range of
0.0 to 1.0 of course.
--
You are receiving this mail becau
https://bugs.freedesktop.org/show_bug.cgi?id=90130
--- Comment #11 from Roland Scheidegger ---
Well I think there's already piglit tests which test this functionality
(primitive-id-no-gs and similar), but they might not hit it because they only
test a couple of primitives and not that many. Not s
https://bugs.freedesktop.org/show_bug.cgi?id=90130
--- Comment #12 from Ken Martin ---
Created attachment 115275
--> https://bugs.freedesktop.org/attachment.cgi?id=115275&action=edit
Even More Valid Image
Doh. I am working from two different source trees and I suspect I had the
resolution of
https://bugs.freedesktop.org/show_bug.cgi?id=90130
--- Comment #13 from Ilia Mirkin ---
FWIW this is what I get with nouveau on a nvc1: http://i.imgur.com/8QS20cp.png
Matches your "even more valid image" attachment, I think.
--
You are receiving this mail because:
You are the QA Contact for th
This code was added by Brian Paul in 2009 but, as far as Matt and I can
tell, it's been dead ever since the new GLSL compiler was added.
---
src/glsl/standalone_scaffolding.cpp | 3 ---
src/mesa/main/mtypes.h | 13 -
src/mesa/main/shaderapi.c | 6 --
3 file
https://bugs.freedesktop.org/show_bug.cgi?id=90130
--- Comment #14 from Roland Scheidegger ---
(In reply to Ken Martin from comment #12)
> Created attachment 115275 [details]
> Even More Valid Image
>
> Doh. I am working from two different source trees and I suspect I had the
> resolution of th
On Tue, Apr 21, 2015 at 10:08 PM, Kenneth Graunke wrote:
> On Tuesday, April 21, 2015 03:25:07 PM Matt Turner wrote:
>> This was present in Eric's initial implementation of the compaction code
>> for Sandybridge (commit 077d01b6). There is no documentation saying this
>> is necessary, and removing
https://bugs.freedesktop.org/show_bug.cgi?id=90130
--- Comment #15 from Ken Martin ---
(In reply to Ilia Mirkin from comment #13)
> FWIW this is what I get with nouveau on a nvc1:
> http://i.imgur.com/8QS20cp.png
>
> Matches your "even more valid image" attachment, I think.
Yes that matches and
On Fri, Apr 17, 2015 at 1:56 PM, Matt Turner wrote:
> Updated numbers look a lot better!
>
> On Tue, Mar 17, 2015 at 4:23 PM, Matt Turner wrote:
>> Without NIR:
>>
>> total instructions in shared programs: 6190374 -> 6190153 (-0.00%)
>> instructions in affected programs: 61126 -> 60905 (-0.36
From: Olivier Pena
---
src/gallium/SConscript| 5
src/gallium/state_trackers/osmesa/Makefile.am | 2 ++
src/gallium/state_trackers/osmesa/SConscript | 26
src/gallium/targets/osmesa/Makefile.am| 6 +++-
src/gallium/targets/osmesa/SConscri
Reviewed-by: Brian Paul
On 04/22/2015 10:41 AM, Jason Ekstrand wrote:
This code was added by Brian Paul in 2009 but, as far as Matt and I can
tell, it's been dead ever since the new GLSL compiler was added.
---
src/glsl/standalone_scaffolding.cpp | 3 ---
src/mesa/main/mtypes.h
https://bugs.freedesktop.org/show_bug.cgi?id=90130
--- Comment #16 from Ken Martin ---
Created attachment 115276
--> https://bugs.freedesktop.org/attachment.cgi?id=115276&action=edit
New piglit test
Here is a piglit test to go in
piglit/tests/spec/glsl-150/execution/primitive-id-no-gs-high-co
https://bugs.freedesktop.org/show_bug.cgi?id=90130
--- Comment #17 from Roland Scheidegger ---
(In reply to Ken Martin from comment #16)
> Created attachment 115276 [details]
> New piglit test
>
> Here is a piglit test to go in
>
> piglit/tests/spec/glsl-150/execution/primitive-id-no-gs-high-co
Signed-off-by: Anuj Phogat
---
src/mesa/main/texgetimage.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c
index 255d365..908bb9b 100644
--- a/src/mesa/main/texgetimage.c
+++ b/src/mesa/main/texgetimage.c
@@ -285,7
On 04/22/2015 01:15 PM, Anuj Phogat wrote:
Signed-off-by: Anuj Phogat
---
src/mesa/main/texgetimage.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c
index 255d365..908bb9b 100644
--- a/src/mesa/main/texgetimage
Notice that in gen7_wm_surface_state.c there is also indentation
change in the surrounding code removing tabs.
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_context.h | 8 +++
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 28 ---
src/m
Read and write parts of the state stage are also split into
explicit arguments allowing future patches to use constant
program data.
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_binding_tables.c | 21 ++---
src/mesa/drivers/dri/i965/brw_state.h | 7
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_context.h | 4 +++-
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 7 +--
src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 6 +++---
src/mesa/drivers/dri/i965/gen8_surface_state.c| 5 +++--
4 files changed
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_sampler_state.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_sampler_state.c
b/src/mesa/drivers/dri/i965/brw_sampler_state.c
index c4bd949..c78e2e3 1006
All hardware platforms have this in common, so do it in the
hardware independent dispatcher.
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_context.h | 4 ++-
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 30 ---
src/mesa/drivers/dri/i965/g
No functional change but this allows to drop the texture object's
mesa format in later patches.
Stencil buffer has fixed hardware format corresponding to fixed
mesa format. (This is in fact already specfically tested in
intel_fbo.c::intel_validate_framebuffer()).
Signed-off-by: Topi Pohjolainen
Currently batch emission logic is bolted into using the current
gl-state and currently bound user shader programs as input. This
series refactors the api to allow caller to give individual bits of
information needed explicitly instead of the emission logic
deducing them from the current state.
Thi
All generations do the same exacr dispatch and it could be
therefore done in the hardware independent stage.
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_context.h | 3 ---
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 32 +++
src/mesa/dr
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_state.h | 3 +++
src/mesa/drivers/dri/i965/gen8_misc_state.c | 4 ++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_state.h
b/src/mesa/drivers/dri/i965/brw_state.h
index 0c4f65
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_sampler_state.c | 60 +--
src/mesa/drivers/dri/i965/brw_state.h | 9
2 files changed, 47 insertions(+), 22 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_sampler_state.c
b/src/mesa/d
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_state.h | 12 +
src/mesa/drivers/dri/i965/gen8_ps_state.c | 74 ---
2 files changed, 59 insertions(+), 27 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_state.h
b/src/mesa/drivers/dri/
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_state.h | 8 +
src/mesa/drivers/dri/i965/gen6_wm_state.c | 56 ++-
2 files changed, 41 insertions(+), 23 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_state.h
b/src/mesa/drivers/dri/
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_state.h | 5
src/mesa/drivers/dri/i965/gen6_wm_state.c | 50 ++-
2 files changed, 34 insertions(+), 21 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_state.h
b/src/mesa/drivers/dri/i
Also changed a couple of direct shifts into SET_FIELD().
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_context.h | 3 ++-
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 30 +--
src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 14 +---
Note that brw_update_renderbuffer_surfaces() already had a helper
variable which was used in parallel to direct access of the current
draw buffer of the context.
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_state.h| 5 +++
src/mesa/drivers/dri/i965/brw_wm_surfac
Also changed a couple of direct shifts into SET_FIELD().
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_context.h | 2 +-
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 12 +++-
src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 11 +--
src/mes
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_context.h | 4 ++--
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 20 +++-
src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 17 ++---
src/mesa/drivers/dri/i965/gen8_surface_state.c
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_context.h | 4 ++--
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 11 +--
src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 7 +--
src/mesa/drivers/dri/i965/gen8_surface_state.c| 8 +---
4 f
Now the uploading depends only on the input parameters instead
of consulting the current gl-state.
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_state.h | 9 +
src/mesa/drivers/dri/i965/gen7_wm_state.c | 58 ---
2 files changed, 46 inserti
On Fri, Apr 17, 2015 at 10:10 PM, Matt Turner wrote:
> 1-3 are
>
> Reviewed-by: Matt Turner
>
> Patch 4 is missing (from the archives too).
Okay, 4's a pile of churn and got held in moderation.
I've sent comments for 5, 8 (use unreachable), 13 (use unreachable),
14 (remove comments),
Typos in
On Thu, Apr 2, 2015 at 4:30 AM, Predut, Marius wrote:
> Please "review by" feedback please :-)
>
> -Original Message-
> From: Predut, Marius
> Sent: Thursday, March 19, 2015 9:34 PM
> To: mesa-dev@lists.freedesktop.org
> Cc: Predut, Marius
> Subject: [Mesa-dev][PATCH v4] i965/aa: fixing an
I think it would be better to call this "nir_vector" rather than
"nir_array," since this is essentially a poor man's version of
std::vector<>. Is this ok with you?
On Fri, Apr 10, 2015 at 8:48 PM, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir_array.h | 96
>
On Wed, Apr 22, 2015 at 3:03 PM, Connor Abbott wrote:
> I think it would be better to call this "nir_vector" rather than
> "nir_array," since this is essentially a poor man's version of
> std::vector<>. Is this ok with you?
I battled over that one for quite a while. In the end, I settled on
nir_
On Fri, Apr 10, 2015 at 8:48 PM, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir_lower_vars_to_ssa.c | 28 ++--
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/src/glsl/nir/nir_lower_vars_to_ssa.c
> b/src/glsl/nir/nir_lower_vars_to_ssa.c
> index 8b7261
On Tue, Apr 21, 2015 at 10:13 PM, Kenneth Graunke wrote:
> The BLT engine on Gen8+ requires linear surfaces to be cacheline
> aligned. This restriction was added as part of converting the BLT to
> use 48-bit addressing.
>
> intel_emit_linear_blit needs to handle blits that are not cacheline
> ali
On Wed, Apr 22, 2015 at 6:06 PM, Jason Ekstrand wrote:
> On Wed, Apr 22, 2015 at 3:03 PM, Connor Abbott wrote:
>> I think it would be better to call this "nir_vector" rather than
>> "nir_array," since this is essentially a poor man's version of
>> std::vector<>. Is this ok with you?
>
> I battled
On Wed, Apr 22, 2015 at 3:09 PM, Connor Abbott wrote:
> On Fri, Apr 10, 2015 at 8:48 PM, Jason Ekstrand wrote:
>> ---
>> src/glsl/nir/nir_lower_vars_to_ssa.c | 28 ++--
>> 1 file changed, 14 insertions(+), 14 deletions(-)
>>
>> diff --git a/src/glsl/nir/nir_lower_vars_to_
https://bugs.freedesktop.org/show_bug.cgi?id=66346
--- Comment #13 from Julien Isorce ---
Problem still exists:
CXX main/shader_query.lo
main/shader_query.cpp:71:7: error: no matching function for call to
'_mesa_lookup_shader_program_err'
_mesa_lookup_shader_program_err(ctx, program,
https://bugs.freedesktop.org/show_bug.cgi?id=66346
Julien Isorce changed:
What|Removed |Added
Attachment #81814|0 |1
is obsolete|
https://bugs.freedesktop.org/show_bug.cgi?id=66346
--- Comment #15 from Julien Isorce ---
Created attachment 115280
--> https://bugs.freedesktop.org/attachment.cgi?id=115280&action=edit
shader_query: convert GLhandleARB to uintptr_t before troncating to GLuint
Other suggestion.
--
You are re
https://bugs.freedesktop.org/show_bug.cgi?id=90147
Bug ID: 90147
Summary: swrast: build error undeclared _SC_PHYS_PAGES on osx
Product: Mesa
Version: unspecified
Hardware: Other
OS: Mac OS X (All)
Status: NEW
https://bugs.freedesktop.org/show_bug.cgi?id=90147
--- Comment #1 from Julien Isorce ---
Created attachment 115281
--> https://bugs.freedesktop.org/attachment.cgi?id=115281&action=edit
swrast: can retrieve system memory on osx
Based on
https://chromium.googlesource.com/chromium/src/base/+/0fe0
Except for the one minor comment on patch 6, the series (including
patches 13 and 14) is
Reviewed-by: Connor Abbott
On Fri, Apr 10, 2015 at 8:48 PM, Jason Ekstrand wrote:
> Right now, most of the code to handle indirect dereferences of variables is
> dead. However, I have a patch series (which
On Wed, Apr 22, 2015 at 3:34 PM, Connor Abbott wrote:
> Except for the one minor comment on patch 6
Fixed locally.
> , the series (including
> patches 13 and 14) is
>
> Reviewed-by: Connor Abbott
Thanks!
> On Fri, Apr 10, 2015 at 8:48 PM, Jason Ekstrand wrote:
>> Right now, most of the code
From: Roland Scheidegger
We were resetting the prim id count for each run of the prim assembler,
hence this only worked when the draw calls were very small (the exact limit
depending on the vertex size), since larger draw calls get split up.
So, do the same as we do already if there's a gs, reset
On Wednesday, April 22, 2015 03:15:05 PM Anuj Phogat wrote:
> On Tue, Apr 21, 2015 at 10:13 PM, Kenneth Graunke
> wrote:
> > The BLT engine on Gen8+ requires linear surfaces to be cacheline
> > aligned. This restriction was added as part of converting the BLT to
> > use 48-bit addressing.
> >
>
On Wed, Apr 22, 2015 at 4:06 PM, wrote:
> From: Roland Scheidegger
>
> We were resetting the prim id count for each run of the prim assembler,
> hence this only worked when the draw calls were very small (the exact limit
> depending on the vertex size), since larger draw calls get split up.
> So
Color clears can be performed via two separate shaders - one is the
generic "meta clear" shader (in meta.c); the other is the i965 specific
"repclear" shader (in brw_meta_fast_clear.c).
Giving them separate names makes them distinguishable when reading
INTEL_DEBUG=shader_time output.
Signed-off-b
Maybe meta repclear? Either way,
Reviewed-by: Jason Ekstrand
On Wed, Apr 22, 2015 at 5:46 PM, Kenneth Graunke wrote:
> Color clears can be performed via two separate shaders - one is the
> generic "meta clear" shader (in meta.c); the other is the i965 specific
> "repclear" shader (in brw_meta_
Am 23.04.2015 um 02:35 schrieb Matt Turner:
> On Wed, Apr 22, 2015 at 4:06 PM, wrote:
>> From: Roland Scheidegger
>>
>> We were resetting the prim id count for each run of the prim assembler,
>> hence this only worked when the draw calls were very small (the exact limit
>> depending on the verte
70 matches
Mail list logo