https://bugs.freedesktop.org/show_bug.cgi?id=89616
Fabio Pedretti changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=89642
Bug ID: 89642
Summary: dEQP-GLES3:
dEQP-GLES3.functional.shaders.preprocessor.predefined_
macros.line_2_vertex fails because of wrong __LINE__
values
Pro
https://bugs.freedesktop.org/show_bug.cgi?id=89642
Samuel Iglesias changed:
What|Removed |Added
CC||sigles...@igalia.com
--
You are recei
On 03/16/2015 08:30 PM, Ilia Mirkin wrote:
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote:
Patch adds required helper functions to shaderapi.h and
the actual implementation.
The property query functionality can be tested with tests for
following functions that are refactored by later pa
Hi Vinson,
I have mixed feelings about this.
I don't really agree with all things mandated with PEP 8. Comments inline.
On 17/03/15 06:15, Vinson Lee wrote:
Signed-off-by: Vinson Lee
---
SConstruct | 66 --
1 file changed, 34 in
https://bugs.freedesktop.org/show_bug.cgi?id=79629
--- Comment #19 from Axel Davy ---
The proposed patch doesn't seem to have been merged to mesa.
XiongZhang: can you send it to ml ?
--
You are receiving this mail because:
You are the assignee for the bug.
_
https://bugs.freedesktop.org/show_bug.cgi?id=89433
José Fonseca changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Sorry for not reviewing it earlier. I missed this series.
On 13/03/15 19:22, Brian Paul wrote:
_glapi_new_nop_table() creates a new dispatch table populated with
pointers to no-op functions.
_glapi_set_nop_handler() is used to register a callback function which
will be called from each of the
On 14/03/15 22:36, Emil Velikov wrote:
Hi all,
As a follow up to Jose's initial series dropping st/{egl,vega} and
others here is the next round of cleanups,
Namely this series
- removes st/gbm, winsys/sw/{wayland,fbdev}, all of which no longer
used by anyone,
- cleans up libEGL (and config
On 03/17/2015 12:22 AM, Ilia Mirkin wrote:
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote:
(and mark it as DONE in docs/GL3.txt)
And add to relnotes?
ok, sure
Signed-off-by: Tapani Pälli
---
docs/GL3.txt | 4 ++--
src/mesa/main/extensions.c | 1 +
src/mesa/main/
https://bugs.freedesktop.org/show_bug.cgi?id=79629
--- Comment #20 from Emil Velikov ---
(In reply to Axel Davy from comment #19)
> The proposed patch doesn't seem to have been merged to mesa.
>
> XiongZhang: can you send it to ml ?
It's already there but people may have missed it.
http://patch
https://bugs.freedesktop.org/show_bug.cgi?id=79629
--- Comment #21 from Axel Davy ---
The patch is fine, except spacing.
--
You are receiving this mail because:
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=89590
Tapani Pälli changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|mesa-dev@list
On Wed, Mar 18, 2015 at 1:56 AM, Matt Turner wrote:
> Thanks. Looked through stats and at some of the regressions.
>
> Some of the areas I noticed we were doing worse:
>
> We generate two CMPs for discard_if; only one without NIR. I think you
> had an idea about solving this.
>
> SEL peephole inte
First of all, I am sorry for writing you too late. Was kind of
overwhelmed by the process of GSOC.
I have good experience working with C,C++ environments. I use Linux
regularly and have experience with cairo graphics library. Beside
these I am also have interest in embedded systems and system leve
On Wed, Mar 18, 2015 at 7:22 AM, Connor Abbott wrote:
> On Wed, Mar 18, 2015 at 1:56 AM, Matt Turner wrote:
>> Thanks. Looked through stats and at some of the regressions.
>>
>> Some of the areas I noticed we were doing worse:
>>
>> We generate two CMPs for discard_if; only one without NIR. I thi
On Wed, Mar 18, 2015 at 7:22 AM, Connor Abbott wrote:
> On Wed, Mar 18, 2015 at 1:56 AM, Matt Turner wrote:
>> Thanks. Looked through stats and at some of the regressions.
>>
>> Some of the areas I noticed we were doing worse:
>>
>> We generate two CMPs for discard_if; only one without NIR. I thi
On Wed, Mar 18, 2015 at 11:27 AM, Jason Ekstrand wrote:
> On Wed, Mar 18, 2015 at 7:22 AM, Connor Abbott wrote:
>> On Wed, Mar 18, 2015 at 1:56 AM, Matt Turner wrote:
>>> Thanks. Looked through stats and at some of the regressions.
>>>
>>> Some of the areas I noticed we were doing worse:
>>>
>>>
On Wed, Mar 18, 2015 at 11:27 AM, Jason Ekstrand wrote:
> On Wed, Mar 18, 2015 at 7:22 AM, Connor Abbott wrote:
>> On Wed, Mar 18, 2015 at 1:56 AM, Matt Turner wrote:
>>> Thanks. Looked through stats and at some of the regressions.
>>>
>>> Some of the areas I noticed we were doing worse:
>>>
>>>
Hello,
I've run into a situation where a3xx hardware does not natively
support Z32F_S8 (interleaved). However it will happily support Z32F
and S8 separately (and at the same time). Haven't looked at how a4xx
handles this, but wouldn't be surprised if it were the same.
One way to do this is to exp
Bump, is someone want to make a review of this patch set ? Especially
the "core" stuff...
On 03/09/2015 10:09 PM, Samuel Pitoiset wrote:
Hello,
A series I have waited too long to re-submit, but I recently refactored the
code and fixed some minor issues.
This patchset enables GL_AMD_performanc
From: José Fonseca
By default gcc ignores the issue, and as result code that mixes
signed/unsigned is so widespread through the code base that it ends up
being little more than noise, potentially obscuring more pertinent
warnings.
Maybe one day we enable the corresponding gcc warnings and cleanu
Note that GLboolean is an alias for unsigned char, which lacks the
implicit true/false semantics that C++/C99 bool have.
---
src/glsl/linker.cpp | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index 0c44677..1abcb32 100644
--- a/
As VARYING_SLOT_MAX can be bigger than 32.
I'll probably stop building swrast with MSVC in the near future, but this
seems a real bug regardless.
---
src/mesa/swrast/s_span.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/swrast/s_span.c b/src/mesa/swrast/s_span.c
in
program/lex.yy.c and program/program_parse.tab.c is already included in
the PROGRAM_FILES variable.
We still need to specify the dependency relationship though.
---
src/mesa/SConscript | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/src/mesa/SConscript b/src/mesa/S
These get triggered even when using the standard C99 INFINITY/NAN
constants.
---
scons/gallium.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scons/gallium.py b/scons/gallium.py
index 9d53848..b4018e7 100755
--- a/scons/gallium.py
+++ b/scons/gallium.py
@@ -495,8 +495,10 @@ def generate(
Already done below.
---
src/gallium/auxiliary/gallivm/lp_bld_arit.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_arit.c
b/src/gallium/auxiliary/gallivm/lp_bld_arit.c
index cd05f11..0d4eaea 100644
--- a/src/gallium/auxiliary/galli
https://bugs.freedesktop.org/show_bug.cgi?id=89624
--- Comment #3 from Dan Sebald ---
Taking a second look at the Gallium driver PNG, I'm wondering if my original
assessment is correct, i.e., that the scaled image in the frame buffer is
extending past the bottom in the y-dimension. The edges see
On 03/18/2015 10:34 AM, Jose Fonseca wrote:
As VARYING_SLOT_MAX can be bigger than 32.
I'll probably stop building swrast with MSVC in the near future, but this
seems a real bug regardless.
---
src/mesa/swrast/s_span.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/me
On Wed, Mar 18, 2015 at 8:27 AM, Jason Ekstrand wrote:
> On Wed, Mar 18, 2015 at 7:22 AM, Connor Abbott wrote:
>> On Wed, Mar 18, 2015 at 1:56 AM, Matt Turner wrote:
>>> Thanks. Looked through stats and at some of the regressions.
>>>
>>> Some of the areas I noticed we were doing worse:
>>>
>>>
Manual interleaving and deinterleaving in the driver seems to be the
easiest solution. You just need 2 blits. You can reuse u_blitter for
setting up stuff or you can create your own thing.
Adding separate Z+S to Gallium and st/mesa would be quite a lot work,
and what you want to support is an inte
https://bugs.freedesktop.org/show_bug.cgi?id=89662
Bug ID: 89662
Summary: context.c:943: undefined reference to
`_glapi_new_nop_table'
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (All)
https://bugs.freedesktop.org/show_bug.cgi?id=89662
--- Comment #1 from Brian Paul ---
What is your ./configure command line?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
___
mesa-dev mai
https://bugs.freedesktop.org/show_bug.cgi?id=89662
--- Comment #2 from Vinson Lee ---
$ ./autogen.sh --with-dri-drivers=i965 --with-gallium-drivers=
$ make
$ make check
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
On Wed, Mar 18, 2015 at 9:34 AM, Jose Fonseca wrote:
> Already done below.
> ---
> src/gallium/auxiliary/gallivm/lp_bld_arit.c | 9 +
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_arit.c
> b/src/gallium/auxiliary/gallivm/lp_bld_ari
The Gallium interface looked good to me (except where I replied).
Sorry, I probably won't have time to review the st/mesa patch.
Marek
On Wed, Mar 18, 2015 at 5:00 PM, Samuel Pitoiset
wrote:
> Bump, is someone want to make a review of this patch set ? Especially the
> "core" stuff...
>
>
> On 03
On Wed, Mar 18, 2015 at 4:36 AM, Jagmeet Singh wrote:
> So I would like to ask what should be my next step before submitting a
> actual proposal with mesa-dev?
Finding something you want to work on is a really important step. :)
It also helps the people selecting which proposals to accept a lot
---
src/glsl/builtin_functions.cpp | 4 ++--
src/glsl/s_expression.cpp | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp
index c607572..524b8d6 100644
--- a/src/glsl/builtin_functions.cpp
+++ b/src/glsl/bui
On Wed, Mar 18, 2015 at 10:18 AM, Matt Turner wrote:
> diff --git a/src/glsl/s_expression.cpp b/src/glsl/s_expression.cpp
> index 7eaa491..f82e155 100644
> --- a/src/glsl/s_expression.cpp
> +++ b/src/glsl/s_expression.cpp
> @@ -70,7 +70,7 @@ read_atom(void *ctx, const char *&src, char *&symbol_buf
To provide some background why separate attachments aren't supported in
gallium:
1) OpenGL always allowed this, however noone seriously expected this to
actually be supported. At least gaming hardware pretty much was limited
to d24s8.
2) D3D10 also only has one attachment point for both, so there m
OK, makes sense. The other place where separate buffers could be
reasonable is, unrelatedly, ARB_texture_stencil8. My plan for that was
to just let it be though and just disallow any depth attachments next
to that s8 attachment. (The implementation got stymied when I realized
that nvidia hw doesn't
4bdbb588a9d385509f9168e38bfdb76952ba469c introduced link errors for
i965 gtests. This commit links the tests with libglapi, which
contains the missing symbols.
---
src/mesa/drivers/dri/i965/Makefile.am | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/
On Wed, Mar 18, 2015 at 9:52 AM, Matt Turner wrote:
> On Wed, Mar 18, 2015 at 8:27 AM, Jason Ekstrand wrote:
>> On Wed, Mar 18, 2015 at 7:22 AM, Connor Abbott wrote:
>>> On Wed, Mar 18, 2015 at 1:56 AM, Matt Turner wrote:
Thanks. Looked through stats and at some of the regressions.
>>
On 03/18/2015 11:21 AM, Matt Turner wrote:
On Wed, Mar 18, 2015 at 10:18 AM, Matt Turner wrote:
diff --git a/src/glsl/s_expression.cpp b/src/glsl/s_expression.cpp
index 7eaa491..f82e155 100644
--- a/src/glsl/s_expression.cpp
+++ b/src/glsl/s_expression.cpp
@@ -70,7 +70,7 @@ read_atom(void *ctx,
On 03/18/2015 11:38 AM, Mark Janes wrote:
4bdbb588a9d385509f9168e38bfdb76952ba469c introduced link errors for
i965 gtests. This commit links the tests with libglapi, which
contains the missing symbols.
---
src/mesa/drivers/dri/i965/Makefile.am | 10 +-
1 file changed, 9 insertions(+),
On Wed, Mar 18, 2015 at 10:38 AM, Mark Janes wrote:
> 4bdbb588a9d385509f9168e38bfdb76952ba469c introduced link errors for
> i965 gtests. This commit links the tests with libglapi, which
> contains the missing symbols.
I'm not really sure linking to libglapi is the right thing to do.
> ---
> sr
Matt Turner writes:
> On Wed, Mar 18, 2015 at 10:38 AM, Mark Janes wrote:
>> 4bdbb588a9d385509f9168e38bfdb76952ba469c introduced link errors for
>> i965 gtests. This commit links the tests with libglapi, which
>> contains the missing symbols.
>
> I'm not really sure linking to libglapi is the r
Brian Paul writes:
> On 03/18/2015 11:38 AM, Mark Janes wrote:
>> 4bdbb588a9d385509f9168e38bfdb76952ba469c introduced link errors for
>> i965 gtests. This commit links the tests with libglapi, which
>> contains the missing symbols.
>> ---
>> src/mesa/drivers/dri/i965/Makefile.am | 10 +
On 03/18/2015 12:02 PM, Mark Janes wrote:
Brian Paul writes:
On 03/18/2015 11:38 AM, Mark Janes wrote:
4bdbb588a9d385509f9168e38bfdb76952ba469c introduced link errors for
i965 gtests. This commit links the tests with libglapi, which
contains the missing symbols.
---
src/mesa/drivers/dri/i
On 03/18/2015 12:10 PM, Brian Paul wrote:
On 03/18/2015 12:02 PM, Mark Janes wrote:
Brian Paul writes:
On 03/18/2015 11:38 AM, Mark Janes wrote:
4bdbb588a9d385509f9168e38bfdb76952ba469c introduced link errors for
i965 gtests. This commit links the tests with libglapi, which
contains the mis
I wasn't aware of these _glapi_ stub functions when I committed
4bdbb588a9d385509f9168e38bfdb76952ba469c. Fixes "make check"
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89662
---
src/mesa/drivers/dri/common/dri_test.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/sr
https://bugs.freedesktop.org/show_bug.cgi?id=89662
--- Comment #3 from Brian Paul ---
Vinson, can you test the patch I just posted to mesa-dev: "dri: add
_glapi_set_nop_handler(), _glapi_new_nop_table() to dri_test.c"
--
You are receiving this mail because:
You are the QA Contact for the bug.
Y
They're not accessible from the source language, but optimizations are
allowed to generate them.
---
src/glsl/ir_validate.cpp | 6 +++---
src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp | 9 +++--
2 files changed, 6 insertions(+), 9 deletions(-)
diff -
Transform this into b2f(and(a, b)).
total instructions in shared programs: 6190291 -> 6189225 (-0.02%)
instructions in affected programs: 267247 -> 266181 (-0.40%)
helped:866
---
src/glsl/opt_algebraic.cpp | 4
1 file changed, 4 insertions(+)
diff --git a
Transform this into b2f(or(a, b)).
---
src/glsl/opt_algebraic.cpp | 12
1 file changed, 12 insertions(+)
diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp
index 0d1f3fc..98c852a 100644
--- a/src/glsl/opt_algebraic.cpp
+++ b/src/glsl/opt_algebraic.cpp
@@ -421,6 +421
Transform this into b2f(and(a, b)).
total instructions in shared programs: 6205448 -> 6204391 (-0.02%)
instructions in affected programs: 284030 -> 282973 (-0.37%)
helped:903
HURT: 6
---
src/glsl/nir/nir_opt_algebraic.py | 2 ++
Transform this into b2f(or(a, b)).
instructions in affected programs: 432 -> 430 (-0.46%)
helped:2
---
src/glsl/nir/nir_opt_algebraic.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/glsl/nir/nir_opt_algebraic.py
b/src/glsl/nir/nir_opt_algebraic.py
i
Reviewed-by: Mark Janes
Brian Paul writes:
> I wasn't aware of these _glapi_ stub functions when I committed
> 4bdbb588a9d385509f9168e38bfdb76952ba469c. Fixes "make check"
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89662
> ---
> src/mesa/drivers/dri/common/dri_test.c | 11
https://bugs.freedesktop.org/show_bug.cgi?id=89662
Brian Paul changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Did this patch help anything?
On 03/18/2015 11:37 AM, Matt Turner wrote:
> Transform this into b2f(or(a, b)).
> ---
> src/glsl/opt_algebraic.cpp | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp
> index 0d1f3fc..98c852a
Patches 1, 2, and 3 are
Reviewed-by: Ian Romanick
Patches 4 and 5 are
Acked-by: Ian Romanick
On 03/18/2015 11:37 AM, Matt Turner wrote:
> They're not accessible from the source language, but optimizations are
> allowed to generate them.
> ---
> src/glsl/ir_validate.cpp
On Wed, Mar 18, 2015 at 11:51 AM, Ian Romanick wrote:
> Did this patch help anything?
Nope. I guess NIR is able to recognize something here that the GLSL IR can't.
Thanks for reviewing!
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://li
On 03/18/2015 09:34 AM, Jose Fonseca wrote:
> Note that GLboolean is an alias for unsigned char, which lacks the
> implicit true/false semantics that C++/C99 bool have.
> ---
> src/glsl/linker.cpp | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/src/glsl/linker.cpp
On Thu, Mar 12, 2015 at 9:46 PM, Matt Turner wrote:
> Here are some ideas I think might be reasonable GSoC ideas.
>
> - GLSL linking in NIR
> - Would allow us to stop doing optimizations and other expensive
> things on GLSL IR
Ian said this should wait until everything is using NIR so that
On 03/17/2015 08:13 PM, Dave Airlie wrote:
This add primitive restart support to the prim conversion.
This involves changing the API for the translate functions
as we need to pass the prim restart index and the original
number of indices into the translate functions.
primitive restart is suppor
We never did a single hash table lookup in the entire NIR code base that I
found so there was no real benifit to doing it that way. I suppose that
for linking, we'll probably want to be able to lookup by name but we can
leave building that hash table to the linker. In the mean time this was
causi
On Wed, Mar 18, 2015 at 3:36 PM, Jason Ekstrand wrote:
> diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp
> index 047cb51..e3c085a 100644
> --- a/src/glsl/nir/glsl_to_nir.cpp
> +++ b/src/glsl/nir/glsl_to_nir.cpp
> @@ -98,6 +98,9 @@ private:
> /* whether the IR we're ope
On Mar 18, 2015 12:39 PM, "Ilia Mirkin" wrote:
>
> On Wed, Mar 18, 2015 at 3:36 PM, Jason Ekstrand
wrote:
> > diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp
> > index 047cb51..e3c085a 100644
> > --- a/src/glsl/nir/glsl_to_nir.cpp
> > +++ b/src/glsl/nir/glsl_to_nir.cpp
>
Hi,
I am looking for a GSOC project. I am interested in working on driver.
Hardware available:
All AMD gpus (+1 APU)
NVIDIA k40, GTX780, Quadro 3500, GT755M
Intel: Haswell (buying on next pay date)
On Wed, Mar 18, 2015 at 2:58 PM, Matt Turner wrote:
> On Thu, Mar 12, 2015 at 9:46 PM, Matt Turne
So it turns out that this doesn't actually fix any bugs or add any features,
stictly speaking. However, it does avoid a lot of kludginess. Previously, if
you called
glCopyTextureSubImage3D(texcube, 0, 0, 0, zoffset = 3, ...
it would grab the texture image object for face = 0 in teximage.c instea
From: Ian Romanick
We use the idoim
ir_foo *x = y->as_foo();
if (x == NULL)
return;
all over the place. GCC generates some quite lovely code for this.
One such example:
340a5b: 83 7d 18 04 cmpl $0x4,0x18(%rbp)
340a5f: 0f 85 06 04 00 00 jne34
On Wed, Mar 18, 2015 at 4:25 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> We use the idoim
>
>ir_foo *x = y->as_foo();
>if (x == NULL)
> return;
>
> all over the place. GCC generates some quite lovely code for this.
> One such example:
>
> 340a5b: 83 7d 18 04
---
docs/GL3.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index 5d59341..fcbb213 100644
--- a/docs/GL3.txt
+++ b/docs/GL3.txt
@@ -194,10 +194,10 @@ GL 4.5, GLSL 4.50:
GL_ARB_derivative_controlDONE (i965, nv50
On Wed, Mar 18, 2015 at 1:25 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> We use the idoim
typo: idiom
>
>ir_foo *x = y->as_foo();
>if (x == NULL)
> return;
>
> all over the place. GCC generates some quite lovely code for this.
> One such example:
>
> 340a5b: 83 7d 18
https://bugs.freedesktop.org/show_bug.cgi?id=89662
--- Comment #5 from Christoph Haag ---
Created attachment 114451
--> https://bugs.freedesktop.org/attachment.cgi?id=114451&action=edit
similar error in line 525
I seem to get the same error in make install, with
627991dbf74ce5aee9ce75155fc27a4
On 03/18/2015 01:29 PM, Ilia Mirkin wrote:
> On Wed, Mar 18, 2015 at 4:25 PM, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> We use the idoim
>>
>>ir_foo *x = y->as_foo();
>>if (x == NULL)
>> return;
>>
>> all over the place. GCC generates some quite lovely code for this.
>> One s
Acked-by: Matt Turner
Feel free to push it.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Eric's initial patch adding constant expression evaluation for
ir_unop_round_even used nearbyint. The open-coded _mesa_round_to_even
implementation came about without much explanation after a reviewer
asked whether nearbyint depended on the application not modifying the
rounding mode. Of course (as
Reviewed-by: Carl Worth
---
src/util/Makefile.am | 4 +-
src/util/roundeven_test.c | 140 ++
2 files changed, 143 insertions(+), 1 deletion(-)
create mode 100644 src/util/roundeven_test.c
diff --git a/src/util/Makefile.am b/src/util/Makefile.am
The SSE 4.1 ROUND instructions let us implement roundeven directly.
Otherwise we assume that the rounding mode has not been modified (as we
do in the rest of Mesa) and use rint().
glibc uses the ROUND instruction in rint() after a cpuid check. This
patch just lets us inline it directly when we're
total instructions in shared programs: 6263270 -> 6203091 (-0.96%)
instructions in affected programs: 2606529 -> 2546350 (-2.31%)
helped:14301
GAINED:5
LOST: 3
Revewed-by: Jason Ekstrand [v1]
---
On Tue, Mar 17, 2015 at 7:17 PM, Jason Ekstrand wrote:
> From: Matt Turner
>
> Shader-db results for FS instructions with NIR on HSW:
>
> total instructions in shared programs: 4186747 -> 4129871 (-1.36%)
> instructions in affected programs: 2438094 -> 2381218 (-2.33%)
> helped:
On Wed, Mar 18, 2015 at 1:06 PM, Laura Ekstrand wrote:
> So it turns out that this doesn't actually fix any bugs or add any features,
> stictly speaking. However, it does avoid a lot of kludginess. Previously, if
> you called
>
> glCopyTextureSubImage3D(texcube, 0, 0, 0, zoffset = 3, ...
>
> it w
Reviewed-by: Mark Janes
Jason Ekstrand writes:
> Before, we enabled NIR if you set INTEL_USE_NIR to anything which mean that
> INTEL_USE_NIR=false would actually turn on NIR. In preparation for turning
> NIR on by default, this commit makes it smarter by allowing the
> INTEL_USE_NIR variable t
On Wed, Mar 18, 2015 at 3:17 PM, Mark Janes wrote:
> Reviewed-by: Mark Janes
Thanks! Noted.
>
> Jason Ekstrand writes:
>
>> Before, we enabled NIR if you set INTEL_USE_NIR to anything which mean that
>> INTEL_USE_NIR=false would actually turn on NIR. In preparation for turning
>> NIR on by d
Yeah, that looks better. V2 R-B me.
--Jason
On Wed, Mar 18, 2015 at 2:56 PM, Matt Turner wrote:
> total instructions in shared programs: 6263270 -> 6203091 (-0.96%)
> instructions in affected programs: 2606529 -> 2546350 (-2.31%)
> helped:14301
> GAINED:
On 17 March 2015 at 01:39, Matt Turner wrote:
> On Sun, Mar 15, 2015 at 10:22 PM, Dave Airlie wrote:
>> We never reset the string on eglTerminate, so it grows
>> for ever on multiple eglInitialise.
>>
>> Signed-off-by: Dave Airlie
>> ---
>> src/egl/main/eglapi.c | 1 +
>> 1 file changed, 1 inse
On Wed, Mar 18, 2015 at 3:27 PM, Dave Airlie wrote:
> On 17 March 2015 at 01:39, Matt Turner wrote:
>> On Sun, Mar 15, 2015 at 10:22 PM, Dave Airlie wrote:
>>> We never reset the string on eglTerminate, so it grows
>>> for ever on multiple eglInitialise.
>>>
>>> Signed-off-by: Dave Airlie
>>> -
On Wed, Mar 18 2015, Matt Turner wrote:
> This patch implements _mesa_roundeven{f,}, a function similar to the
> roundeven function added by a yet unimplemented technical specification
> (ISO/IEC TS 18661-1:2014), with a small difference in behavior -- we
> don't bother raising the inexact exceptio
This saves the cost of repeated hash table lookups when the same
vertex array object is referenced in a sequence of calls such as:
glVertexArrayAttribFormat(vao, ...);
glVertexArrayAttribBinding(vao, ...);
glEnableVertexArrayAttrib(vao, ...);
...
Note that VAO's are container obje
---
src/mapi/glapi/gen/ARB_direct_state_access.xml | 25 +
src/mesa/main/tests/dispatch_sanity.cpp| 3 +
src/mesa/main/varray.c | 78 ++
src/mesa/main/varray.h | 15 +
4 files changed, 121 insertions(+)
d
---
src/mapi/glapi/gen/ARB_direct_state_access.xml | 14 +++
src/mesa/main/tests/dispatch_sanity.cpp| 2 +
src/mesa/main/varray.c | 117 +
src/mesa/main/varray.h | 10 +++
4 files changed, 143 insertions(+)
diff -
This parameter was added in OpenGL 4.3 and GL_ARB_direct_state_access.
---
src/mesa/main/varray.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c
index bbfe947..ec768f0 100644
--- a/src/mesa/main/varray.c
+++ b/src/mesa/main/varray.c
@@ -872
---
src/mapi/glapi/gen/ARB_direct_state_access.xml | 5
src/mesa/main/arrayobj.c | 34 ++
src/mesa/main/arrayobj.h | 2 ++
src/mesa/main/tests/dispatch_sanity.cpp| 1 +
4 files changed, 42 insertions(+)
diff --git
---
src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 ++
src/mesa/main/tests/dispatch_sanity.cpp| 1 +
src/mesa/main/varray.c | 77 ++
src/mesa/main/varray.h | 4 ++
4 files changed, 66 insertions(+), 22 deletions
This is needed to implement glGetVertexArrayIndexediv and
glGetVertexArrayIndexed64iv.
---
src/mesa/main/varray.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c
index 0faf158..13b9c01 100644
--- a/src/mesa
This is needed to implement VertexArrayAttribBinding.
---
src/mesa/main/varray.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c
index cdda6f3..4347a92 100644
--- a/src/mesa/main/varray.c
+++ b/src/mesa/main/varray
---
src/mapi/glapi/gen/ARB_direct_state_access.xml | 8 +++
src/mesa/main/tests/dispatch_sanity.cpp| 1 +
src/mesa/main/varray.c | 83 ++
src/mesa/main/varray.h | 4 ++
4 files changed, 71 insertions(+), 25 deletion
---
src/mapi/glapi/gen/ARB_direct_state_access.xml | 5 +++
src/mesa/main/tests/dispatch_sanity.cpp| 1 +
src/mesa/main/varray.c | 46 --
src/mesa/main/varray.h | 4 +++
4 files changed, 46 insertions(+), 10 deletio
This is needed to implement VertexArrayAttrib*Format.
---
src/mesa/main/varray.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c
index a6b66a0..93cc0e3 100644
--- a/src/mesa/main/varray.c
+++ b/src/mesa/main/varray
1 - 100 of 155 matches
Mail list logo
