[Mesa-dev] [PATCH 09/23] glsl/parser: Handle image memory qualifiers.

--- src/glsl/glsl_parser.yy | 83 + 1 file changed, 83 insertions(+) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index e436b16..e207510 100644 --- a/src/glsl/glsl_parser.yy +++ b/src/glsl/glsl_parser.yy @@ -1298,6 +1298,63 @@ layo

[Mesa-dev] [PATCH 01/23] glsl: Add ARB_shader_image_load_store extension enables.

--- src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index f401f03..3719f5c 100644 --- a/src/glsl/glsl_parser_extras.cpp +++ b/src/glsl/glsl_parser_extras.

[Mesa-dev] [PATCH 12/23] glsl/ast: Verify that function calls don't discard image format qualifiers.

--- src/glsl/ast_function.cpp | 58 +++ 1 file changed, 58 insertions(+) diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp index 2707522..48003da1 100644 --- a/src/glsl/ast_function.cpp +++ b/src/glsl/ast_function.cpp @@ -93,6 +93,57 @@

[Mesa-dev] [PATCH 04/23] glsl: Add image memory and layout qualifiers to ir_variable.

--- src/glsl/ir.cpp | 2 +- src/glsl/ir.h | 14 ++ src/glsl/ir_clone.cpp | 1 + 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp index 297..ae690ea 100644 --- a/src/glsl/ir.cpp +++ b/src/glsl/ir.cpp @@ -1587,7 +1587,7

[Mesa-dev] [PATCH 07/23] glsl/lexer: Add new tokens for ARB_shader_image_load_store.

--- src/glsl/glsl_lexer.ll | 75 + src/glsl/glsl_parser.yy | 20 +++-- 2 files changed, 56 insertions(+), 39 deletions(-) diff --git a/src/glsl/glsl_lexer.ll b/src/glsl/glsl_lexer.ll index 822d70d..8c76c2d 100644 --- a/src/glsl/glsl_lexer.l

[Mesa-dev] [PATCH 10/23] glsl/parser: Handle image built-in types.

--- src/glsl/glsl_parser.yy | 33 + 1 file changed, 33 insertions(+) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index e207510..b5a1157 100644 --- a/src/glsl/glsl_parser.yy +++ b/src/glsl/glsl_parser.yy @@ -1805,6 +1805,39 @@ basic_type_specifier

[Mesa-dev] [PATCH 11/23] glsl/ast: Validate and apply memory qualifiers to image variables.

--- src/glsl/ast_to_hir.cpp | 51 + 1 file changed, 51 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index e7c4ff4..1d13a2c 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -2154,6 +2154,54 @@ vali

[Mesa-dev] [PATCH 15/23] glsl/ast: Generalize some sampler variable restrictions to all opaque types.

No opaque types may be statically initialized in the shader, all opaque variables must be declared uniform or be part of an "in" function parameter declaration, no opaque types may be used as the return type of a function. --- src/glsl/ast_to_hir.cpp | 45 ++

[Mesa-dev] [PATCH 17/23] glcpp: Add built-in define for ARB_shader_image_load_store.

--- src/glsl/glcpp/glcpp-parse.y | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index 7edc274..69947c5 100644 --- a/src/glsl/glcpp/glcpp-parse.y +++ b/src/glsl/glcpp/glcpp-parse.y @@ -1260,6 +1260,9 @@ glcpp_parser_create (const s

[Mesa-dev] [PATCH 14/23] glsl/ast: Forbid declaration of image variables in structures and uniform blocks.

Aggregating images inside uniform blocks is explicitly disallowed by the standard, aggregating them inside structures is not (as of GL 4.4), but there is a similar problem as with atomic counters: image uniform declarations require either a "writeonly" memory qualifier or an explicit format qualifi

[Mesa-dev] [PATCH 18/23] glsl: Add built-in constants for ARB_shader_image_load_store.

--- src/glsl/builtin_variables.cpp | 19 +++ src/glsl/glsl_parser_extras.cpp | 8 src/glsl/glsl_parser_extras.h | 9 + 3 files changed, 36 insertions(+) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index d57324c..47a6b39 100644

[Mesa-dev] [PATCH 20/23] glsl/linker: Count and check image resources.

--- src/glsl/link_uniforms.cpp | 13 +++- src/glsl/linker.cpp| 50 ++ 2 files changed, 62 insertions(+), 1 deletion(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index 0a15739..c75a38c 100644 --- a/src/glsl/link

[Mesa-dev] [PATCH 03/23] glsl: Add helper methods to glsl_type for dealing with images.

Add predicates to query if a GLSL type is or contains an image. Rename sampler_coordinate_components() to coordinate_components() and fix it to support calculating the number of coordinate dimensions of image types as well as sampler types. --- src/glsl/builtin_functions.cpp| 2 +- src/gl

[Mesa-dev] [PATCH 16/23] glsl: Add built-in types defined by ARB_shader_image_load_store.

--- src/glsl/builtin_type_macros.h | 34 src/glsl/builtin_types.cpp | 70 ++ 2 files changed, 104 insertions(+) diff --git a/src/glsl/builtin_type_macros.h b/src/glsl/builtin_type_macros.h index 263fd83..4795ad9 100644 --- a/src/gls

[Mesa-dev] [PATCH 19/23] glsl: Add image built-in function generator.

Because of the combinatorial explosion of different image built-ins with different image dimensionalities and base data types, enumerating all the 242 possibilities would be annoying and a waste of .text space. Instead use a special path in the built-in builder that loops over all the known image

[Mesa-dev] [PATCH 13/23] glsl/ast: Make sure that image argument qualifiers match the function prototype.

--- src/glsl/ir.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp index ae690ea..b8b0979 100644 --- a/src/glsl/ir.cpp +++ b/src/glsl/ir.cpp @@ -1709,7 +1709,12 @@ ir_function_signature::qualifiers_match(exec_list *params) if (a-

[Mesa-dev] [PATCH 06/23] glsl/ast: Keep track of type qualifiers defined by ARB_shader_image_load_store.

--- src/glsl/ast.h| 32 +++- src/glsl/ast_type.cpp | 5 + 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/src/glsl/ast.h b/src/glsl/ast.h index 5c214b6..b750bb7 100644 --- a/src/glsl/ast.h +++ b/src/glsl/ast.h @@ -413,12 +413,23 @@ struct ast

[Mesa-dev] [PATCH 08/23] glsl/parser: Handle the early_fragment_tests input layout qualifier.

--- src/glsl/glsl_parser.yy | 61 ++--- src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ 3 files changed, 42 insertions(+), 22 deletions(-) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index 44c332d..e43

[Mesa-dev] [PATCH 02/23] glsl: Add image type to the GLSL IR.

--- src/glsl/ast_to_hir.cpp | 1 + src/glsl/glsl_types.cpp | 23 +++ src/glsl/glsl_types.h| 22 ++ src/glsl/ir_clone.cpp| 1 + src/glsl/link_uniform_initializers.cpp

[Mesa-dev] [PATCH 05/23] glsl: Add gl_uniform_storage fields to keep track of image uniform indices.

--- src/glsl/ir_uniform.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/glsl/ir_uniform.h b/src/glsl/ir_uniform.h index 13faab7..0704061 100644 --- a/src/glsl/ir_uniform.h +++ b/src/glsl/ir_uniform.h @@ -118,6 +118,25 @@ struct gl_uniform_storage { bool active

[Mesa-dev] [PATCH 23/23] mesa: Handle binding of uniforms to image units with glUniform*().

--- src/mesa/main/uniform_query.cpp | 36 1 file changed, 36 insertions(+) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 88ad476..fec45be 100644 --- a/src/mesa/main/uniform_query.cpp +++ b/src/mesa/main/uniform_query.cpp

[Mesa-dev] [PATCH 22/23] glsl/linker: Propagate image uniform access qualifiers to the driver.

--- src/glsl/link_uniforms.cpp | 35 +++ 1 file changed, 35 insertions(+) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index 5780bb2..0aa66d3 100644 --- a/src/glsl/link_uniforms.cpp +++ b/src/glsl/link_uniforms.cpp @@ -751,6 +751,40 @@ link_

[Mesa-dev] [PATCH 21/23] glsl/linker: Assign image uniform indices.

--- src/glsl/link_uniforms.cpp | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index c75a38c..5780bb2 100644 --- a/src/glsl/link_uniforms.cpp +++ b/src/glsl/link_uniforms.cpp @@ -374,6 +374,7 @@ pu

Re: [Mesa-dev] [PATCH 02/23] glsl: Add image type to the GLSL IR.

@@ -618,6 +637,9 @@ glsl_type::component_slots() const case GLSL_TYPE_ARRAY: return this->length * this->fields.array->component_ slots(); + case GLSL_TYPE_IMAGE: + return 1; Why is an image type one component, whereas the other opaque types are zero at this level? On Tue, No

[Mesa-dev] radeonsi: always set the scanout flag?

Hi, When importing an handle (src/gallium/drivers/radeon/r600_texture.c), the RADEON_SURF_SCANOUT flag is always set on SI. The code is associated with a comment: /* always set the scanout flags on SI */ I was getting bad tiling mode on Wayland with my radeonsi card, and recent Mesa, and I

Re: [Mesa-dev] [PATCH 03/23] glsl: Add helper methods to glsl_type for dealing with images.

On Tue, Nov 26, 2013 at 12:02:19AM -0800, Francisco Jerez wrote: > Add predicates to query if a GLSL type is or contains an image. > Rename sampler_coordinate_components() to coordinate_components() and > fix it to support calculating the number of coordinate dimensions of > image types as well as

[Mesa-dev] [PATCH] i965: Always reserve binding table space for at least one render target.

In brw_update_renderbuffer_surfaces(), if there are no color draw buffers, we always set up a null render target at surface index 0 so we have something to use with the FB write marking the end of thread. However, when we recently began computing surface indexes dynamically, we failed to reserve s

Re: [Mesa-dev] [PATCH] intel: Track known prime buffers for re-use

On Mon, Nov 25, 2013 at 01:22:41PM -0800, Keith Packard wrote: > If the application sends us a file descriptor pointing at a prime > buffer that we've already got, we have to re-use the same bo_gem > structure or chaos will result. > > Track the set of all known prime objects and look to see if th

Re: [Mesa-dev] [PATCH] R600/SI: Implement spilling of SGPRs v4

Am 26.11.2013 05:32, schrieb Tom Stellard: From: Tom Stellard SGPRs are spilled into VGPRs using the {READ,WRITE}LANE_B32 instructions. v2: - Fix encoding of Lane Mask - Use correct register flags, so we don't overwrite the low dword when restoring multi-dword registers. v3: - R

Re: [Mesa-dev] [PATCH] R600/SI: Implement spilling of SGPRs v4

On Mon, 2013-11-25 at 23:32 -0500, Tom Stellard wrote: > From: Tom Stellard > > SGPRs are spilled into VGPRs using the {READ,WRITE}LANE_B32 instructions. > > v2: > - Fix encoding of Lane Mask > - Use correct register flags, so we don't overwrite the low dword > when restoring multi-dword

Re: [Mesa-dev] [PATCH] intel: Track known prime buffers for re-use

Daniel Vetter writes: > The kernel actually doesn't bother with this, i.e. an open on an flink > name will always create a new handle. Given that it was a major pita to > get the prime reimporting going (due to a pile of funny lifetime issues > around reference loops and some assorted locking fun

Re: [Mesa-dev] [PATCH 3/3] gallium/cso: fix sampler / sampler_view counts

Am 26.11.2013 06:24, schrieb Zack Rusin: > The entire series looks good to me. > >> Now that it is possible to query drivers for the max sampler view it should >> be safe to increase this without crashing. >> Not entirely convinced this really works correctly though if state trackers >> using non-

Re: [Mesa-dev] [PATCH 3/3] gallium/cso: fix sampler / sampler_view counts

In the future, we won't have to save all the sampler views anyway. Note that cso_context only saves the states it needs to save meta ops. It doesn't save the clip state and it also doesn't save all vertex buffers except for the first one, because only the first one needs to be saved and restored fo

[Mesa-dev] [PATCH] Fixed memory leak.

--- src/mesa/main/bufferobj.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 5581a5d..e68d96d 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -420,6 +420,8 @@ _mesa_buffer_data( struct gl_context *ctx, GLe

Re: [Mesa-dev] [PATCH 11/17] Modified _mesa_buffer_data to use _mesa_align_malloc.

Fixed memory leak, thanks for the heads up! http://lists.freedesktop.org/archives/mesa-dev/2013-November/049178.html Best Regards, Siavash Eliasi. On 11/26/2013 01:14 AM, Aaron Watry wrote: On Sun, Nov 24, 2013 at 11:36 PM, Siavash Eliasi wrote: --- src/mesa/main/bufferobj.c | 4 ++-- 1

Re: [Mesa-dev] [PATCH 3/3] gallium/cso: fix sampler / sampler_view counts

Series looks good to me. Thanks for the cleanup. Jose - Original Message - > From: Roland Scheidegger > > Now that it is possible to query drivers for the max sampler view it should > be safe to increase this without crashing. > Not entirely convinced this really works correctly though

Re: [Mesa-dev] [PATCH 11/17] Modified _mesa_buffer_data to use _mesa_align_malloc.

Now I understand why _mesa_realloc is not appropriate to use here. From spec: glBufferData creates a new data store for the buffer object currently bound to target. Any pre-existing data store is deleted. The new data store is created with the specified size in bytes and usage. If data is NULL

Re: [Mesa-dev] [PATCH 02/23] glsl: Add image type to the GLSL IR.

Hi Chris, Chris Forbes writes: > @@ -618,6 +637,9 @@ glsl_type::component_slots() const > case GLSL_TYPE_ARRAY: >return this->length * this->fields.array->component_ > slots(); > > + case GLSL_TYPE_IMAGE: > + return 1; > > Why is an image type one component, whereas the other

Re: [Mesa-dev] [PATCH] Fixed memory leak.

On Tue, Nov 26, 2013 at 1:22 PM, Siavash Eliasi wrote: In general, when you fix problems in prior patches, you should integrate the fix into the original patch(es) where the problems were, update the commit message to note what bugs were fixed and then re-send the patch set. That prevents broken

Re: [Mesa-dev] [PATCH 02/23] glsl: Add image type to the GLSL IR.

Sounds pretty reasonable. Is this a sensible direction for samplers to go in eventually as well? -- Chris On Wed, Nov 27, 2013 at 7:51 AM, Francisco Jerez wrote: > Hi Chris, > > Chris Forbes writes: > >> @@ -618,6 +637,9 @@ glsl_type::component_slots() const >> case GLSL_TYPE_ARRAY: >>

Re: [Mesa-dev] [PATCH 02/23] glsl: Add image type to the GLSL IR.

Do you have a suite of piglit tests for this extension? On Wed, Nov 27, 2013 at 8:01 AM, Chris Forbes wrote: > Sounds pretty reasonable. > > Is this a sensible direction for samplers to go in eventually as well? > > -- Chris > > On Wed, Nov 27, 2013 at 7:51 AM, Francisco Jerez > wrote: >> Hi Ch

Re: [Mesa-dev] [PATCH 02/23] glsl: Add image type to the GLSL IR.

Chris Forbes writes: > Sounds pretty reasonable. > > Is this a sensible direction for samplers to go in eventually as well? > That's my suspicion... It will definitely make variable sampler array indexing for ARB_gpu_shader5 easier. > -- Chris > > On Wed, Nov 27, 2013 at 7:51 AM, Francisco Jere

Re: [Mesa-dev] [PATCH 02/23] glsl: Add image type to the GLSL IR.

Chris Forbes writes: > Do you have a suite of piglit tests for this extension? > Nope, not yet. > On Wed, Nov 27, 2013 at 8:01 AM, Chris Forbes wrote: >> Sounds pretty reasonable. >> >> Is this a sensible direction for samplers to go in eventually as well? >> >> -- Chris >> >> On Wed, Nov 27, 2

Re: [Mesa-dev] [PATCH 08/11] mesa: Implement the GL entry points defined by ARB_shader_image_load_store.

On Monday 25 November 2013, Francisco Jerez wrote: > --- > src/mapi/glapi/gen/gl_genexec.py | 1 + > src/mesa/Makefile.sources| 1 + > src/mesa/main/shaderimage.c | 457 > +++ > src/mesa/main/shaderimage.h | 42 > 4 files changed, 50

Re: [Mesa-dev] [PATCH 08/11] mesa: Implement the GL entry points defined by ARB_shader_image_load_store.

Fredrik Höglund writes: >[...] >> +} >> + >> +void GLAPIENTRY >> +_mesa_MemoryBarrier(GLbitfield barriers) >> +{ >> + GET_CURRENT_CONTEXT(ctx); >> + >> + if (ctx->Driver.MemoryBarrier) >> + ctx->Driver.MemoryBarrier(ctx, barriers); >> +} > > Is this the best place to implement this entry

[Mesa-dev] [PATCH] glsl: Initialize _mesa_glsl_parse_state::atomic_counter_offsets before using it.

Cc: Ian Romanick Cc: "10.0" --- src/glsl/glsl_parser_extras.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index f401f03..d76d94b 100644 --- a/src/glsl/glsl_parser_extras.cpp +++ b/src/glsl/glsl_parser_extras.cpp @@ -19

Re: [Mesa-dev] [Mesa-stable] [PATCH] glsl: Initialize _mesa_glsl_parse_state::atomic_counter_offsets before using it.

On 11/26/2013 12:50 PM, Francisco Jerez wrote: > Cc: Ian Romanick Reviewed-by: Ian Romanick > Cc: "10.0" > --- > src/glsl/glsl_parser_extras.cpp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp > index f401f03..d76d9

Re: [Mesa-dev] [PATCH v2 2/5] meta: fix meta clear of layered framebuffers

On 20 November 2013 14:29, Paul Berry wrote: > From section 4.4.7 (Layered Framebuffers) of the GLSL 3.2 spec: > > When the Clear or ClearBuffer* commands are used to clear a > layered framebuffer attachment, all layers of the attachment are > cleared. > > This patch fixes meta clears

Re: [Mesa-dev] radeonsi: always set the scanout flag?

Does the attached patch fix the issue for you? Marek On Tue, Nov 26, 2013 at 9:20 AM, Axel Davy wrote: > Hi, > > When importing an handle (src/gallium/drivers/radeon/r600_texture.c), > the RADEON_SURF_SCANOUT flag is always set on SI. > > The code is associated with a comment: /* always set the

Re: [Mesa-dev] [PATCH 7/9] mesa: Fill out ARB_texture_view entry points

With these changes, what needs to happen to commit these changes to master? Thanks, Courtney On Mon, Nov 25, 2013 at 6:01 PM, Courtney Goeltzenleuchter < court...@lunarg.com> wrote: > While incorporating Brian's comments I did some refactoring to consolidate > multiple uses of next_mimap_level_

[Mesa-dev] [PATCH 1/2] glsl: extract function for record comparisons

--- src/glsl/glsl_types.cpp | 61 +++-- src/glsl/glsl_types.h | 7 ++ 2 files changed, 41 insertions(+), 27 deletions(-) diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl_types.cpp index f740130..6c9727e 100644 --- a/src/glsl/glsl_types.cpp ++

[Mesa-dev] [PATCH 2/2] glsl: match unnamed record types across stages

Unnamed record types are assigned to separate types per stage, e.g. uniform struct { ... } a; if defined in both vertex and fragment shader, will result in two separate types of different name. When linking the shader, this results in a type conflict. However, there is no reason why this should n

[Mesa-dev] [PATCH 8/8] mesa: Remove GL_MESA_texture_array cruft from gl.h

From: Ian Romanick glext.h has had all the necessary bits for years. Signed-off-by: Ian Romanick --- include/GL/gl.h | 33 - 1 file changed, 33 deletions(-) diff --git a/include/GL/gl.h b/include/GL/gl.h index b484b96..48343f6 100644 --- a/include/GL/gl.h +++ b

[Mesa-dev] [PATCH 1/8] mesa: Add missing checks for GL_TEXTURE_CUBE_MAP_ARRAY

From: Ian Romanick That enum requires GL_ARB_texture_cube_map_array, and it is only available on desktop GL. It looks like this has been an un-noticed issue since GL_ARB_texture_cube_map_array support was added in commit e0e7e295. Signed-off-by: Ian Romanick Cc: Dave Airlie Cc: "9.1 9.2 10.0"

[Mesa-dev] [PATCH 2/8] mesa: Add missing API check for GL_TEXTURE_3D

From: Ian Romanick There are no 3D textures in OpenGL ES 1.x. Signed-off-by: Ian Romanick Cc: "9.1 9.2 10.0" --- Since this just adds a missing error check, it's arguable that this should not be included in stable branches. Opinions? src/mesa/main/texobj.c | 2 +- 1 file changed, 1 insertio

[Mesa-dev] [PATCH 3/8] mesa: Silence GCC warning in _mesa_test_texobj_completeness

From: Ian Romanick main/texobj.c: In function '_mesa_test_texobj_completeness': main/texobj.c:553:34: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] main/texobj.c:553:193: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

[Mesa-dev] [PATCH 7/8] mesa: Remove support for GL_MESA_texture_array

From: Ian Romanick This extension enabled the use of texture array with fixed-function and assembly fragment shaders. No applications are known to use this extension. Signed-off-by: Ian Romanick --- docs/relnotes/10.1.html| 6 +- docs/specs/MESA_texture_array.spec |

[Mesa-dev] [PATCH 5/8] mesa: Minor clean-up of target_enum_to_index

From: Ian Romanick Constify the gl_context parameter, and remove suffixes from enums that have non-suffix versions. Signed-off-by: Ian Romanick --- src/mesa/main/texobj.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/tex

[Mesa-dev] [PATCH 4/8] mesa: Silence GCC warning in count_tex_size

From: Ian Romanick main/texobj.c: In function 'count_tex_size': main/texobj.c:886:23: warning: unused parameter 'key' [-Wunused-parameter] Signed-off-by: Ian Romanick --- src/mesa/main/texobj.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.

[Mesa-dev] [PATCH 6/8] mesa: Use a single enable for GL_EXT_texture_array and GL_MESA_texture_array

From: Ian Romanick Every driver that enables one also enables the other. The difference between the two is MESA adds support for fixed-function and assembly fragment shaders, but EXT only adds support for GLSL. The MESA extension was created back when Mesa did not support GLSL. Signed-off-by:

Re: [Mesa-dev] [PATCH 1/8] mesa: Add missing checks for GL_TEXTURE_CUBE_MAP_ARRAY

On Wed, Nov 27, 2013 at 9:54 AM, Ian Romanick wrote: > From: Ian Romanick > > That enum requires GL_ARB_texture_cube_map_array, and it is only > available on desktop GL. It looks like this has been an un-noticed > issue since GL_ARB_texture_cube_map_array support was added in commit > e0e7e295.

[Mesa-dev] [PATCH 1/3] i965: Fix OACONTROL assertion failures on Ironlake.

I guarded half of the callers to start/stop_oa_counters with generation checks, but missed the other half (which were added later). OACONTROL doesn't exist on Ironlake, so we better not write it. Also, there's no need---Ironlake's performance counters are always running. This patch moves the gen

[Mesa-dev] [PATCH 3/3] i965: Fix BRW_BATCH_STRUCT to specify RENDER_RING, not UNKNOWN_RING.

I missed this in the boolean -> enum conversion. C cheerfully casts false -> 0 -> UNKNOWN_RING. On Gen4-5, this causes the render ring prelude hook to get called in the middle of the batch, which is crazy. BRW_BATCH_STRUCT is not used on Gen6+. Fixes regressions since 395a32717df494353703f3581e

[Mesa-dev] [PATCH 2/3] Revert "i965: Move brw_emit_query_begin() to the render ring prelude."

This reverts commit a4bf7f6b6e612626c4e4fc21507ac213a7ba4b00. It breaks occlusion queries on Gen4-5. Doing this right will likely require larger changes, which should be done at a future date. Some Piglit tests still passed due to other bugs; fixing those revealed this problem. Signed-off-by: Ke

[Mesa-dev] [PATCH] i965: Properly reject __DRI_CTX_FLAG_ROBUST_BUFFER_ACCESS when __DRI2_ROBUSTNESS is not enabled

From: Ian Romanick Only allow __DRI_CTX_FLAG_ROBUST_BUFFER_ACCESS in brwCreateContext if intelInitScreen2 also enabled __DRI2_ROBUSTNESS (thereby enabling GLX_ARB_create_context). This fixes a regression in the piglit test "glx/GLX_ARB_create_context/invalid flag" Signed-off-by: Ian Romanick R

[Mesa-dev] [PATCH 2/2] i965/hsw: Apply non-msrt fast color clear w/a to all HSW GTs

Pre-patch, the workaround was applied to only HSW GT3. However, the workaround also fixes render corruption on the HSW GT1 Chromebook, codenamed Falco. CC: Anuj Phogat CC: Paul Berry OTC-Tracker: CHRMOS-812 Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 6 +++--

[Mesa-dev] [PATCH 1/2] i965/blorp: Update language for fast color clear non-msrt restriction

In an older BSpec, the restriction was documented for HSW GT3. The current BSpec lists the restriction in a table for IVB, HSW, and VLVT. Only the gods know to which hardware the restriction really applies. CC: Paul Berry CC: Anuj Phogat Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 0/2] i965/hsw: Fix fast color bug on ChromeOS Falco

Google disabled fast color clears for all hardware because it causes corruption on Haswell. This patch series fixes it so that Google can re-enable fast clears. Chad Versace (2): i965/blorp: Update language for fast color clear non-msrt restriction i965/hsw: Apply non-msrt fast color clear w/a

[Mesa-dev] Fwd: [PATCH] Fixed memory leak.

Sorry, I accidentally sent my mail to Alex instead of the list. -- Forwarded message -- From: Mario Rugiero Date: 2013/11/26 Subject: Re: [Mesa-dev] [PATCH] Fixed memory leak. To: Alex Deucher Hi, I'm an outsider (for everyone who might have not noticed), I started following th

Re: [Mesa-dev] [PATCH 2/2] i965/hsw: Apply non-msrt fast color clear w/a to all HSW GTs

On 26 November 2013 17:34, Chad Versace wrote: > Pre-patch, the workaround was applied to only HSW GT3. However, the > workaround also fixes render corruption on the HSW GT1 Chromebook, > codenamed Falco. > > CC: Anuj Phogat > CC: Paul Berry > OTC-Tracker: CHRMOS-812 > Signed-off-by: Chad Versac

Re: [Mesa-dev] Enable ARB_map_buffer_alignment in all drivers - first try

Hi Thomas, Looks like Siavash Eliasi beat you to it. But here is some quick feedback. You seem to have made the same mistake with your case statements [1] Also you shouldn't attach the patch to your email but should use git-send-email there is a link to more info on the Newbie page ;) As for the

Re: [Mesa-dev] [PATCH 2/2] i965/hsw: Apply non-msrt fast color clear w/a to all HSW GTs

On 11/26/2013 05:34 PM, Chad Versace wrote: > Pre-patch, the workaround was applied to only HSW GT3. However, the > workaround also fixes render corruption on the HSW GT1 Chromebook, > codenamed Falco. > > CC: Anuj Phogat > CC: Paul Berry > OTC-Tracker: CHRMOS-812 > Signed-off-by: Chad Versace

[Mesa-dev] [PATCH] Modified _mesa_align_free to have consistent behavior

This avoids accidental dereferencing of an invalid memory address by _mesa_align_free when passed pointer is NULL. Also cleaned up different places where it was used, to avoid double check of passed pointer. Now it is safe to pass NULL pointer to this function and expect same behavior like fre

[Mesa-dev] [PATCH] Modified _mesa_align_free to have consistent behavior when dealing with NULL memory address.

--- src/mesa/main/imports.c| 7 +-- src/mesa/math/m_matrix.c | 13 + src/mesa/program/prog_parameter.c | 3 +-- src/mesa/state_tracker/st_cb_texture.c | 6 ++ src/mesa/swrast/s_texture.c| 7 +++ src/mesa/tnl/t_vertex.c

Re: [Mesa-dev] [PATCH] Fixed memory leak.

I'll fix this issue in v2 series of patches, thanks again! Hi, I'm an outsider (for everyone who might have not noticed), I started following the list because I'm interested in the newbie projects, too. I think this free should be called regardless of new_data being null, as this doesn't imply t

[Mesa-dev] [PATCH] i965: Use RED for depth texture formats rather than INTENSITY.

While looking through the documentation, I found this in the Sandybridge PRM (Volume 4, Part 1, Page 140): "Use of sample_c with SURFTYPE_CUBE surfaces is undefined with the following surface formats: I24X8_UNORM, L24X8_UNORM, A24X8_UNORM, I32_FLOAT, L32_FLOAT, A32_FLOAT." I haven't observed thi