Re: [Mesa-dev] [PATCH 1/2] st/egl: Add support for EGL_NOK_swap_region

2011-12-13 Thread Chia-I Wu
On Fri, Dec 9, 2011 at 11:36 PM, Fredrik Höglund wrote: > Backends indicate that they support this extension by returning > EGL_TRUE when native_display::get_param() is called with > NATIVE_PARAM_PRESENT_REGION. > > native_present_control is extended to include the region that should > be presente

Re: [Mesa-dev] [PATCH 1/3] egl: add EGL_NV_post_sub_buffer

2011-12-13 Thread Chia-I Wu
On Sun, Dec 11, 2011 at 1:56 AM, Fredrik Höglund wrote: > Signed-off-by: Fredrik Höglund > --- >  include/EGL/eglext.h      |    9 + >  src/egl/main/eglapi.c     |   24 >  src/egl/main/eglapi.h     |    8 >  src/egl/main/egldisplay.h |    2 ++ >  src/egl/

Re: [Mesa-dev] [PATCH] Add mismatch check for glGetTexImage or it will return -1 and may lead to segment fault.

2011-12-13 Thread Brian Paul
On 12/12/2011 10:31 PM, jian.j.z...@intel.com wrote: > From: Jian Zhao > > --- > src/mesa/main/texgetimage.c |8 > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c > index ae0d51f..3f24187 100644 > --- a/sr

[Mesa-dev] [PATCH] r600g: Fix tiling alignment to match docs

2011-12-13 Thread Simon Farnsworth
R600 and Evergreen have different tiling requirements. Fix Mesa to match the documented requirements. Signed-off-by: Simon Farnsworth --- This doesn't fix my problems with enabling macro tiling, but it does help somewhat. I also need to fix tile shape in the kernel and alignment in the DDX to av

Re: [Mesa-dev] [PATCH] r600g: Fix tiling alignment to match docs

2011-12-13 Thread Simon Farnsworth
On Tuesday 13 December 2011, Simon Farnsworth wrote: > R600 and Evergreen have different tiling requirements. Fix Mesa to match the > documented requirements. > > Signed-off-by: Simon Farnsworth > --- > > This doesn't fix my problems with enabling macro tiling, but it does help > somewhat. I a

Re: [Mesa-dev] [PATCH] mesa: add const flags to skip MaxVarying and MaxUniform linker checks

2011-12-13 Thread Ian Romanick
On 12/10/2011 11:37 PM, Marek Olšák wrote: On Sat, Dec 10, 2011 at 8:19 PM, Ian Romanick wrote: This may not be necessary in the short term. I think r300 is under-reporting it's capabilities. See https://bugs.freedesktop.org/show_bug.cgi?id=34201#c9 The problem is st/mesa is under-reportin

[Mesa-dev] [PATCH 0/2] Add support for clip distances in Gallium

2011-12-13 Thread Bryan Cain
These patches add support for clip distances in the Gallium interface and the Mesa state tracker, respectively. This should take care of gl_ClipDistance, one of the few GLSL 1.30 features not yet implemented in Gallium. If this is merged, driver developers will need to add support to their driver

[Mesa-dev] [PATCH 1/2] gallium: add TGSI_SEMANTIC_CLIPDIST for clip distance

2011-12-13 Thread Bryan Cain
--- src/gallium/auxiliary/tgsi/tgsi_dump.c |3 ++- src/gallium/include/pipe/p_shader_tokens.h |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_dump.c b/src/gallium/auxiliary/tgsi/tgsi_dump.c index e830aa5..bd299b0 100644 --- a/src/

[Mesa-dev] [PATCH 2/2] st/mesa: add support for gl_ClipDistance

2011-12-13 Thread Bryan Cain
--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp |1 + src/mesa/state_tracker/st_program.c| 18 ++ 2 files changed, 19 insertions(+), 0 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 9ef65c8..d50

Re: [Mesa-dev] [PATCH 0/7] Fix GLX files generated by Mesa for the server

2011-12-13 Thread Adam Jackson
On Thu, 2011-12-08 at 12:47 -0800, Ian Romanick wrote: > There has been quite a bit of skew between what's in Mesa and what's > needed in the xserver. This patch series cleans that up. Most of the > changes are quite mundane and just make the code compile inside the > xserver. However, the chang

Re: [Mesa-dev] Bug#651370: libgl1-mesa-glx: need close on exec for dri device

2011-12-13 Thread Adam Jackson
On Sat, 2011-12-10 at 11:46 -0600, David Fries wrote: > Set the close on exec flag when opening dri character devices, so they > will be closed and free any resouces allocated in exec. Reviewed-by: Adam Jackson - ajax signature.asc Description: This is a digitally signed message part _

[Mesa-dev] [PATCH] st/mesa: expose conservative_depth if GLSL 1.3 is supported

2011-12-13 Thread Marek Olšák
It's not yet, but it can be enabled by the override environment variable. --- src/mesa/state_tracker/st_extensions.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 457d5d6..227906b

[Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Bryan Cain
This is an updated version of the patch set I sent to the list a few hours ago. There is now a TGSI property called TGSI_PROPERTY_NUM_CLIP_DISTANCES that drivers can use to determine how many of the 8 available clip distances are actually used by a shader.

[Mesa-dev] [PATCH 1/2] gallium: add support for clip distances

2011-12-13 Thread Bryan Cain
--- src/gallium/auxiliary/tgsi/tgsi_dump.c |6 -- src/gallium/auxiliary/tgsi/tgsi_text.c |3 ++- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 14 ++ src/gallium/auxiliary/tgsi/tgsi_ureg.h |3 +++ src/gallium/include/pipe/p_shader_tokens.h |6 -- 5

[Mesa-dev] [PATCH 2/2] st/mesa: add support for gl_ClipDistance

2011-12-13 Thread Bryan Cain
--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 39 ++- src/mesa/state_tracker/st_program.c| 18 + 2 files changed, 55 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.c

[Mesa-dev] [PATCH] Enable display list support for glClearBuffer functions

2011-12-13 Thread Anuj Phogat
Enabling display list support for glClearBuffer functions with minor fixes Signed-off-by: Anuj Phogat --- Tested this patch with a newly developed piglit testcase (clearbuffer-display-list). Please refer to piglit mailing list for testcase patch. src/mesa/main/dlist.c | 22 +++---

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Jose Fonseca
- Original Message - > This is an updated version of the patch set I sent to the list a few > hours > ago. > There is now a TGSI property called > TGSI_PROPERTY_NUM_CLIP_DISTANCES > that drivers can use to determine how many of the 8 available clip > distances > are actually used by a

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Bryan Cain
On 12/13/2011 02:11 PM, Jose Fonseca wrote: > - Original Message - >> This is an updated version of the patch set I sent to the list a few >> hours >> ago. >> There is now a TGSI property called >> TGSI_PROPERTY_NUM_CLIP_DISTANCES >> that drivers can use to determine how many of the 8 ava

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Christoph Bumiller
On 12/13/2011 09:11 PM, Jose Fonseca wrote: > > > - Original Message - >> This is an updated version of the patch set I sent to the list a few >> hours >> ago. > > >> There is now a TGSI property called >> TGSI_PROPERTY_NUM_CLIP_DISTANCES >> that drivers can use to determine how many

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Christoph Bumiller
On 12/13/2011 09:29 PM, Christoph Bumiller wrote: > On 12/13/2011 09:11 PM, Jose Fonseca wrote: >> >> >> - Original Message - >>> This is an updated version of the patch set I sent to the list a few >>> hours >>> ago. >> >> >>> There is now a TGSI property called >>> TGSI_PROPERTY_NUM_CLI

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Ian Romanick
On 12/13/2011 12:26 PM, Bryan Cain wrote: On 12/13/2011 02:11 PM, Jose Fonseca wrote: - Original Message - This is an updated version of the patch set I sent to the list a few hours ago. There is now a TGSI property called TGSI_PROPERTY_NUM_CLIP_DISTANCES that drivers can use to determi

Re: [Mesa-dev] [PATCH] Enable display list support for glClearBuffer functions

2011-12-13 Thread Ian Romanick
On 12/13/2011 12:01 PM, Anuj Phogat wrote: Enabling display list support for glClearBuffer functions with minor fixes There's also a #if 0 block in that file that should be removed. This is a case where 'git blame' is useful. doing 'git blame src/mesa/main/dlist.c' shows that all of those l

[Mesa-dev] [PATCH 1/3] swrast: Don't do Z24S8 drawpixels fast-paths with Z32_X24S8 input data.

2011-12-13 Thread Eric Anholt
The cool part was that in the "fbo-depthstencil -drawpixels GL_DEPTH24_STENCIL8 32F_24_8_REV" testcase, the shifting happened to end up with a value awfully close to the expected value, except for every other pixel being 0 (the stencil value, shifted away to nothing). --- src/mesa/swrast/s_drawpix

[Mesa-dev] [PATCH 3/3] swrast: Convert the simple glFramebufferBlit path to MapRenderbuffer.

2011-12-13 Thread Eric Anholt
There is one significant functional change here: the simple blit now only handles exact matches of formats. From the ARB_framebuffer_object spec: "If the color formats of the read and draw framebuffers do not match, and includes COLOR_BUFFER_BIT, pixel groups are converted to match

[Mesa-dev] [PATCH 2/3] swrast: Add a note about overlapping support for framebuffer blit.

2011-12-13 Thread Eric Anholt
--- src/mesa/swrast/s_blit.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/src/mesa/swrast/s_blit.c b/src/mesa/swrast/s_blit.c index 2817ec1..803ad2e 100644 --- a/src/mesa/swrast/s_blit.c +++ b/src/mesa/swrast/s_blit.c @@ -478,7 +478,15 @@ simple_blit(struct gl_

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Jose Fonseca
- Original Message - > On 12/13/2011 09:11 PM, Jose Fonseca wrote: > > > > > > - Original Message - > >> This is an updated version of the patch set I sent to the list a > >> few > >> hours > >> ago. > > > > > >> There is now a TGSI property called > >> TGSI_PROPERTY_NUM_CLIP_

Re: [Mesa-dev] [PATCH 06/14] i965/vs: Implement vec4_visitor::generate_tex().

2011-12-13 Thread Eric Anholt
On Thu, 8 Dec 2011 17:07:57 -0800, Kenneth Graunke wrote: > + if (inst->header_present) { > + /* Set up an implied move from g0 to the MRF. */ > + src = retype(brw_vec8_grf(0, 0), BRW_REGISTER_TYPE_UW); > + } It doesn't seem like UW could be the right answer here -- I would think

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_SEMANTIC_CLIPDIST for clip distance

2011-12-13 Thread Brian Paul
On Tue, Dec 13, 2011 at 9:59 AM, Bryan Cain wrote: > --- >  src/gallium/auxiliary/tgsi/tgsi_dump.c     |    3 ++- >  src/gallium/include/pipe/p_shader_tokens.h |    3 ++- >  2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/auxiliary/tgsi/tgsi_dump.c > b/src/gallium/au

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Jose Fonseca
- Original Message - > On 12/13/2011 12:26 PM, Bryan Cain wrote: > > On 12/13/2011 02:11 PM, Jose Fonseca wrote: > >> - Original Message - > >>> This is an updated version of the patch set I sent to the list a > >>> few > >>> hours > >>> ago. > >>> There is now a TGSI property cal

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Jose Fonseca
- Original Message - > > > - Original Message - > > On 12/13/2011 09:11 PM, Jose Fonseca wrote: > > > > > > > > > - Original Message - > > >> This is an updated version of the patch set I sent to the list a > > >> few > > >> hours > > >> ago. > > > > > > > > >> There

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Bryan Cain
On 12/13/2011 03:09 PM, Jose Fonseca wrote: > > - Original Message - >> On 12/13/2011 12:26 PM, Bryan Cain wrote: >>> On 12/13/2011 02:11 PM, Jose Fonseca wrote: - Original Message - > This is an updated version of the patch set I sent to the list a > few > hours >>

Re: [Mesa-dev] [PATCH 07/14] i965/vs: Implement vec4_visitor::visit(ir_texture *).

2011-12-13 Thread Eric Anholt
On Thu, 8 Dec 2011 17:07:58 -0800, Kenneth Graunke wrote: > This translates the GLSL compiler's IR into vec4_instruction IR, > generating code to load coordinates, LOD info, shadow comparitors, and > so on into the appropriate message registers. > > It turns out that the SIMD4x2 parameters are

Re: [Mesa-dev] [PATCH 1/3] swrast: Don't do Z24S8 drawpixels fast-paths with Z32_X24S8 input data.

2011-12-13 Thread Brian Paul
On Tue, Dec 13, 2011 at 1:53 PM, Eric Anholt wrote: > The cool part was that in the "fbo-depthstencil -drawpixels > GL_DEPTH24_STENCIL8 32F_24_8_REV" testcase, the shifting happened to > end up with a value awfully close to the expected value, except for > every other pixel being 0 (the stencil va

Re: [Mesa-dev] [PATCH 2/3] swrast: Add a note about overlapping support for framebuffer blit.

2011-12-13 Thread Brian Paul
On Tue, Dec 13, 2011 at 1:53 PM, Eric Anholt wrote: > --- >  src/mesa/swrast/s_blit.c |   10 +- >  1 files changed, 9 insertions(+), 1 deletions(-) > > diff --git a/src/mesa/swrast/s_blit.c b/src/mesa/swrast/s_blit.c > index 2817ec1..803ad2e 100644 > --- a/src/mesa/swrast/s_blit.c > +++ b/

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_SEMANTIC_CLIPDIST for clip distance

2011-12-13 Thread Bryan Cain
On 12/13/2011 03:07 PM, Brian Paul wrote: > On Tue, Dec 13, 2011 at 9:59 AM, Bryan Cain wrote: >> --- >> src/gallium/auxiliary/tgsi/tgsi_dump.c |3 ++- >> src/gallium/include/pipe/p_shader_tokens.h |3 ++- >> 2 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/src/gall

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Christoph Bumiller
On 12/13/2011 09:58 PM, Jose Fonseca wrote: > > > - Original Message - >> On 12/13/2011 09:11 PM, Jose Fonseca wrote: >>> >>> >>> - Original Message - This is an updated version of the patch set I sent to the list a few hours ago. >>> >>> There is now a TG

Re: [Mesa-dev] [PATCH 13/14] i965/vs: Implement EXT_texture_swizzle support for VS texturing.

2011-12-13 Thread Eric Anholt
On Thu, 8 Dec 2011 17:08:04 -0800, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > + if (one_mask) { > + swizzled_result.writemask = one_mask; > + emit(MOV(swizzled_result, src_reg(1.0f))); > + } > } I think this would be wrong for SWIZZLE_ONE of integer textures. pg

Re: [Mesa-dev] i965 vertex shader texturing support

2011-12-13 Thread Eric Anholt
On Thu, 8 Dec 2011 17:07:51 -0800, Kenneth Graunke wrote: > This series adds vertex shader texturing support to the i965 driver, as > required by OpenGL 3.0. Only two things remain: textureGrad() on shadow > samplers (which isn't supported in hardware), and coordinate clamping to > support prop

Re: [Mesa-dev] [PATCH 01/11] mesa: implement DrawTransformFeedback from ARB_transform_feedback2

2011-12-13 Thread Christoph Bumiller
On 12/12/2011 05:37 PM, Jose Fonseca wrote: > - Original Message - >> On 12/12/2011 02:49 PM, Jose Fonseca wrote: >>> - Original Message - From: Marek Olšák It's like DrawArrays, but the count is taken from a transform feedback object. This remove

Re: [Mesa-dev] [PATCH 3/3] swrast: Convert the simple glFramebufferBlit path to MapRenderbuffer.

2011-12-13 Thread Brian Paul
On Tue, Dec 13, 2011 at 1:53 PM, Eric Anholt wrote: > There is one significant functional change here: the simple blit now > only handles exact matches of formats.  From the > ARB_framebuffer_object spec: > >    "If the color formats of the read and draw framebuffers do not >     match, and inclu

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Jose Fonseca
- Original Message - > On 12/13/2011 03:09 PM, Jose Fonseca wrote: > > > > - Original Message - > >> On 12/13/2011 12:26 PM, Bryan Cain wrote: > >>> On 12/13/2011 02:11 PM, Jose Fonseca wrote: > - Original Message - > > This is an updated version of the patch set

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Bryan Cain
On 12/13/2011 03:25 PM, Jose Fonseca wrote: > > - Original Message - >> On 12/13/2011 03:09 PM, Jose Fonseca wrote: >>> - Original Message - On 12/13/2011 12:26 PM, Bryan Cain wrote: > On 12/13/2011 02:11 PM, Jose Fonseca wrote: >> - Original Message - >>> T

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Jose Fonseca
- Original Message - > On 12/13/2011 03:25 PM, Jose Fonseca wrote: > > > > - Original Message - > >> On 12/13/2011 03:09 PM, Jose Fonseca wrote: > >>> - Original Message - > On 12/13/2011 12:26 PM, Bryan Cain wrote: > > On 12/13/2011 02:11 PM, Jose Fonseca wrote: >

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Bryan Cain
On 12/13/2011 03:48 PM, Jose Fonseca wrote: > - Original Message - >> On 12/13/2011 03:25 PM, Jose Fonseca wrote: >>> - Original Message - On 12/13/2011 03:09 PM, Jose Fonseca wrote: > - Original Message - >> On 12/13/2011 12:26 PM, Bryan Cain wrote: >>> On

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Bryan Cain
On 12/13/2011 03:48 PM, Jose Fonseca wrote: > - Original Message - >> On 12/13/2011 03:25 PM, Jose Fonseca wrote: >>> - Original Message - On 12/13/2011 03:09 PM, Jose Fonseca wrote: > - Original Message - >> On 12/13/2011 12:26 PM, Bryan Cain wrote: >>> On

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Jose Fonseca
- Original Message - > On 12/13/2011 03:48 PM, Jose Fonseca wrote: > > - Original Message - > >> On 12/13/2011 03:25 PM, Jose Fonseca wrote: > >>> - Original Message - > On 12/13/2011 03:09 PM, Jose Fonseca wrote: > > - Original Message - > >> On 12/13

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Jose Fonseca
- Original Message - > On 12/13/2011 03:48 PM, Jose Fonseca wrote: > > - Original Message - > >> On 12/13/2011 03:25 PM, Jose Fonseca wrote: > >>> - Original Message - > On 12/13/2011 03:09 PM, Jose Fonseca wrote: > > - Original Message - > >> On 12/13

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Christoph Bumiller
On 12/13/2011 10:48 PM, Jose Fonseca wrote: > - Original Message - >> On 12/13/2011 03:25 PM, Jose Fonseca wrote: >>> >>> - Original Message - On 12/13/2011 03:09 PM, Jose Fonseca wrote: > - Original Message - >> On 12/13/2011 12:26 PM, Bryan Cain wrote: >>>

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Jose Fonseca
- Original Message - > > > - Original Message - > > On 12/13/2011 03:48 PM, Jose Fonseca wrote: > > > - Original Message - > > >> On 12/13/2011 03:25 PM, Jose Fonseca wrote: > > >>> - Original Message - > > On 12/13/2011 03:09 PM, Jose Fonseca wrote: > > >

Re: [Mesa-dev] [PATCH] Enable display list support for glClearBuffer functions

2011-12-13 Thread Anuj Phogat
On Tue 13 Dec 2011 12:49:28 PM PST, Ian Romanick wrote: > On 12/13/2011 12:01 PM, Anuj Phogat wrote: >> Enabling display list support for glClearBuffer functions with minor >> fixes > > There's also a #if 0 block in that file that should be removed. This > is a case where 'git blame' is useful. d

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Bryan Cain
On 12/13/2011 04:22 PM, Jose Fonseca wrote: > - Original Message - >> >> - Original Message - >>> On 12/13/2011 03:48 PM, Jose Fonseca wrote: - Original Message - > On 12/13/2011 03:25 PM, Jose Fonseca wrote: >> - Original Message - >>> On 12/13/2011

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Alex Deucher
On Tue, Dec 13, 2011 at 4:18 PM, Christoph Bumiller wrote: > On 12/13/2011 09:58 PM, Jose Fonseca wrote: >> >> >> - Original Message - >>> On 12/13/2011 09:11 PM, Jose Fonseca wrote: - Original Message - > This is an updated version of the patch set I sent to the

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Marek Olšák
On Tue, Dec 13, 2011 at 11:22 PM, Jose Fonseca wrote: > Another approach would be just to add the property, and kill output mask. Two > ways of doing the same is what I'd like to avoid. I'll need a day (it's late > here) to think about this and see how output mask is being actually used in > th

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Christoph Bumiller
On 12/14/2011 12:24 AM, Marek Olšák wrote: > On Tue, Dec 13, 2011 at 11:22 PM, Jose Fonseca wrote: >> Another approach would be just to add the property, and kill output mask. >> Two ways of doing the same is what I'd like to avoid. I'll need a day (it's >> late here) to think about this and see

[Mesa-dev] [PATCH 0/8] i965 gen6: Initial implementation of transform feedback.

2011-12-13 Thread Paul Berry
This is a follow up to "i965 gen6: Pass-through GS program for future use by transform feedback". This patch series implements basic transform feedback functionality in i965 Gen6 (Sandy Bridge). Patches 1/8 and 2/8 lay some additional core mesa groundwork for transform feedback, by having the lin

[Mesa-dev] [PATCH 1/8] mesa: Record transform feedback stride in linker output.

2011-12-13 Thread Paul Berry
This patch adds the field gl_transform_feedback_info::BufferStride, which records the total number of components (per vertex) that transform feedback is being instructed to store in each buffer. The i965 gen6 back-end needs this information in order to set up binding tables, and it seems better to

[Mesa-dev] [PATCH 2/8] mesa: Fix off-by-one error in transform feedback size check.

2011-12-13 Thread Paul Berry
In _mesa_BindBufferRange(), we need to verify that the offset and size specified by the client do not exceed the size of the underlying buffer. We were accidentally doing this check using ">=" rather than ">", so we were generating a bogus error if the client specified an offset and size that fit

[Mesa-dev] [PATCH 3/8] i965 gen6+: Use 1-wide null operands for IF instructions

2011-12-13 Thread Paul Berry
The Sandy Bridge PRM, volume 4, part 2, section 5.3.10 ("5.3.10 Register Region Restrictions") contains the following restriction on the execution size and operand width of instructions: "3. ExecSize must be equal to or greater than Width." When emitting an IF instruction in single program flo

[Mesa-dev] [PATCH 4/8] i965 gs: Move vue_map to brw_gs_compile.

2011-12-13 Thread Paul Berry
This patch stores the geometry shader VUE map from a local variable in compile_gs_prog() to a field in the brw_gs_compile struct, so that it will be available while compiling the geometry shader. This is necessary in order to support transform feedback on Gen6, because the Gen6 geometry shader cod

[Mesa-dev] [PATCH 5/8] i965 gen6: Initial implementation of transform feedback.

2011-12-13 Thread Paul Berry
This patch adds basic transform feedback capability for Gen6 hardware. This consists of several related pieces of functionality: (1) In gen6_sol.c, we set up binding table entries for use by transform feedback. We use one binding table entry per transform feedback varying (this allows us to avoid

[Mesa-dev] [PATCH 6/8] i965 gen6: Turn on transform feedback extension.

2011-12-13 Thread Paul Berry
This patch advertises support for EXT_transform_feedback on Intel Gen6 and higher. Since transform feedback support is not completely finished yet, for now we only advertise support for it when MESA_GL_VERSION_OVERRIDE is 3.0 or greater (since transform feedback is required by GL version 3.0). ---

[Mesa-dev] [PATCH 7/8] i965 gen6+: Make intel_batchbuffer_emit_mi_flush() actually flush.

2011-12-13 Thread Paul Berry
Previous to this patch, the function intel_batchbuffer_emit_mi_flush() was a bit of a misnomer. On Gen4+, when not using the blit engine, it didn't actually flush the pipeline--it simply generated a _3DSTATE_PIPE_CONTROL command with the necessary bits set to flush GPU caches. This was usually su

[Mesa-dev] [PATCH 8/8] i965: Flush pipeline on EndTransformFeedback.

2011-12-13 Thread Paul Berry
A common use case for transform feedback is to perform one draw operation that writes transform feedback output to a buffer, followed by a second draw operation that consumes that buffer as vertex input. Since vertex input is consumed at an earlier pipeline stage than writing transform feedback out

Re: [Mesa-dev] [PATCH 1/8] mesa: Record transform feedback stride in linker output.

2011-12-13 Thread Brian Paul
On Tue, Dec 13, 2011 at 4:35 PM, Paul Berry wrote: > This patch adds the field gl_transform_feedback_info::BufferStride, > which records the total number of components (per vertex) that > transform feedback is being instructed to store in each buffer.  The > i965 gen6 back-end needs this informati

Re: [Mesa-dev] [PATCH 07/14] i965/vs: Implement vec4_visitor::visit(ir_texture *).

2011-12-13 Thread Kenneth Graunke
On 12/13/2011 01:12 PM, Eric Anholt wrote: > On Thu, 8 Dec 2011 17:07:58 -0800, Kenneth Graunke > wrote: >> This translates the GLSL compiler's IR into vec4_instruction IR, >> generating code to load coordinates, LOD info, shadow comparitors, and >> so on into the appropriate message registers.

Re: [Mesa-dev] [PATCH 2/8] mesa: Fix off-by-one error in transform feedback size check.

2011-12-13 Thread Brian Paul
On Tue, Dec 13, 2011 at 4:35 PM, Paul Berry wrote: > In _mesa_BindBufferRange(), we need to verify that the offset and size > specified by the client do not exceed the size of the underlying > buffer.  We were accidentally doing this check using ">=" rather than > ">", so we were generating a bogu

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Ian Romanick
On 12/13/2011 01:25 PM, Jose Fonseca wrote: - Original Message - On 12/13/2011 03:09 PM, Jose Fonseca wrote: - Original Message - On 12/13/2011 12:26 PM, Bryan Cain wrote: On 12/13/2011 02:11 PM, Jose Fonseca wrote: - Original Message - This is an updated version

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Ian Romanick
On 12/13/2011 02:12 PM, Jose Fonseca wrote: - Original Message - On 12/13/2011 03:48 PM, Jose Fonseca wrote: - Original Message - On 12/13/2011 03:25 PM, Jose Fonseca wrote: - Original Message - On 12/13/2011 03:09 PM, Jose Fonseca wrote: - Original Message ---

[Mesa-dev] [PATCH 1/2] mesa, gallium: add a cap for GPUs without unified color+generic varying slots

2011-12-13 Thread Marek Olšák
--- src/gallium/drivers/r300/r300_screen.c |3 ++- src/gallium/include/pipe/p_defines.h |3 ++- src/glsl/linker.cpp|6 ++ src/mesa/main/mtypes.h |9 + src/mesa/state_tracker/st_extensions.c |3 +++ 5 files changed, 22 insertions

[Mesa-dev] [PATCH 2/2] glsl: don't include system values in varyings usage

2011-12-13 Thread Marek Olšák
--- src/glsl/linker.cpp |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index e9298bb..1086ef7 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -1811,6 +1811,13 @@ assign_varying_locations(struct gl_context *ctx,

[Mesa-dev] [PATCH] meta: rework dest image allocation in mipmap generation code

2011-12-13 Thread Brian Paul
From: Brian Paul This fixes two things: 1. If the texture object was created with glTexStorage2D, the call to _mesa_TexImage2D() would generate INVALID_OPERATION since the texture is marked as immutable. 2. _mesa_TexImage2D() always frees any existing texture image memory before allocati

Re: [Mesa-dev] [PATCH 0/2 v2] Add support for clip distances in Gallium

2011-12-13 Thread Christoph Bumiller
On 12/14/2011 12:58 AM, Ian Romanick wrote: > On 12/13/2011 01:25 PM, Jose Fonseca wrote: >> >> >> - Original Message - >>> On 12/13/2011 03:09 PM, Jose Fonseca wrote: - Original Message - > On 12/13/2011 12:26 PM, Bryan Cain wrote: >> On 12/13/2011 02:11 PM, Jose