Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-23 Thread Marek Olšák
On Mon, Jul 23, 2012 at 11:42 PM, Jerome Glisse wrote: > No, it helps on evergreen too, redwood,juniper,turks and bart are the > only one i tested with. Evergreen is in a slightly better position but > when it comes to lockup there is no good metrics. > >> Concerning older chipsets, I can do the b

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-23 Thread Jerome Glisse
On Mon, Jul 23, 2012 at 5:28 PM, Marek Olšák wrote: > On Mon, Jul 23, 2012 at 4:25 PM, Jerome Glisse wrote: >> On Sun, Jul 22, 2012 at 8:58 PM, Marek Olšák wrote: >>> On Fri, Jul 20, 2012 at 4:54 AM, Jerome Glisse wrote: On Thu, Jul 19, 2012 at 10:25 PM, Marek Olšák wrote: > On Fri, J

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-23 Thread Jerome Glisse
On Mon, Jul 23, 2012 at 5:28 PM, Marek Olšák wrote: > On Mon, Jul 23, 2012 at 4:25 PM, Jerome Glisse wrote: >> On Sun, Jul 22, 2012 at 8:58 PM, Marek Olšák wrote: >>> On Fri, Jul 20, 2012 at 4:54 AM, Jerome Glisse wrote: On Thu, Jul 19, 2012 at 10:25 PM, Marek Olšák wrote: > On Fri, J

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-23 Thread Marek Olšák
On Mon, Jul 23, 2012 at 4:25 PM, Jerome Glisse wrote: > On Sun, Jul 22, 2012 at 8:58 PM, Marek Olšák wrote: >> On Fri, Jul 20, 2012 at 4:54 AM, Jerome Glisse wrote: >>> On Thu, Jul 19, 2012 at 10:25 PM, Marek Olšák wrote: On Fri, Jul 20, 2012 at 4:17 AM, Jerome Glisse wrote: > On Thu,

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-23 Thread Jerome Glisse
On Sun, Jul 22, 2012 at 8:58 PM, Marek Olšák wrote: > On Fri, Jul 20, 2012 at 4:54 AM, Jerome Glisse wrote: >> On Thu, Jul 19, 2012 at 10:25 PM, Marek Olšák wrote: >>> On Fri, Jul 20, 2012 at 4:17 AM, Jerome Glisse wrote: On Thu, Jul 19, 2012 at 10:06 PM, Marek Olšák wrote: > I actual

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-22 Thread Marek Olšák
On Fri, Jul 20, 2012 at 4:54 AM, Jerome Glisse wrote: > On Thu, Jul 19, 2012 at 10:25 PM, Marek Olšák wrote: >> On Fri, Jul 20, 2012 at 4:17 AM, Jerome Glisse wrote: >>> On Thu, Jul 19, 2012 at 10:06 PM, Marek Olšák wrote: I actually care a lot about lockups. Well, you are complaing about

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-19 Thread Jerome Glisse
On Thu, Jul 19, 2012 at 10:25 PM, Marek Olšák wrote: > On Fri, Jul 20, 2012 at 4:17 AM, Jerome Glisse wrote: >> On Thu, Jul 19, 2012 at 10:06 PM, Marek Olšák wrote: >>> I actually care a lot about lockups. Well, you are complaing about >>> lockups, yet you have quite obvious bugs in your hyperz

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-19 Thread Marek Olšák
On Fri, Jul 20, 2012 at 4:17 AM, Jerome Glisse wrote: > On Thu, Jul 19, 2012 at 10:06 PM, Marek Olšák wrote: >> I actually care a lot about lockups. Well, you are complaing about >> lockups, yet you have quite obvious bugs in your hyperz code, so let's >> fix them first. (I wouldn't even try and

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-19 Thread Jerome Glisse
On Thu, Jul 19, 2012 at 10:06 PM, Marek Olšák wrote: > I actually care a lot about lockups. Well, you are complaing about > lockups, yet you have quite obvious bugs in your hyperz code, so let's > fix them first. (I wouldn't even try and run the hyperz code in its > current state. Please don't tak

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-19 Thread Marek Olšák
I actually care a lot about lockups. Well, you are complaing about lockups, yet you have quite obvious bugs in your hyperz code, so let's fix them first. (I wouldn't even try and run the hyperz code in its current state. Please don't take that personally.) Then, if the lockups persist, we can start

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-19 Thread Jerome Glisse
On Thu, Jul 19, 2012 at 9:00 PM, Marek Olšák wrote: > On Fri, Jul 20, 2012 at 1:34 AM, Jerome Glisse wrote: >> On Thu, Jul 19, 2012 at 6:07 PM, Marek Olšák wrote: >>> I have these issues with the patch: >>> >>> 1) On GPUs without a vertex cache, you flush the texture cache every >>> draw operati

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-19 Thread Marek Olšák
On Fri, Jul 20, 2012 at 1:34 AM, Jerome Glisse wrote: > On Thu, Jul 19, 2012 at 6:07 PM, Marek Olšák wrote: >> I have these issues with the patch: >> >> 1) On GPUs without a vertex cache, you flush the texture cache every >> draw operation. Are you kidding? > > Show me one app with perf regressio

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-19 Thread Marek Olšák
I have these issues with the patch: 1) On GPUs without a vertex cache, you flush the texture cache every draw operation. Are you kidding? 2) All colorbuffers / streamout buffers are flushed, even those which are not enabled. E.g. instead of flushing only CB0 when there is only one, this code flus

[Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-17 Thread j . glisse
From: Jerome Glisse Flushing and synchronization only need to happen at begining and end of cs, and after each draw packet if necessary. This patch is especialy needed for hyperz/htile feature. v2: Separate evergreen and r6xx/r7xx flushing/syncing allow easier specialization of each function