https://bugs.freedesktop.org/show_bug.cgi?id=84566
Jason Ekstrand changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #55 from Jason Ekstrand ---
(In reply to Iago Toral from comment #54)
> Hi Jason,
>
> I think we are close to completing this, so here is a summary of the current
> state and how we intend to submit the patches for review, since we a
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #54 from Iago Toral ---
Hi Jason,
I think we are close to completing this, so here is a summary of the current
state and how we intend to submit the patches for review, since we assume that
you will be reviewing most of these:
(In r
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #53 from Jason Ekstrand ---
(In reply to Samuel Iglesias from comment #52)
> (In reply to Jason Ekstrand from comment #51)
> > (In reply to Samuel Iglesias from comment #48)
> > > (In reply to Jason Ekstrand from comment #34)
> > > >
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #52 from Samuel Iglesias ---
(In reply to Jason Ekstrand from comment #51)
> (In reply to Samuel Iglesias from comment #48)
> > (In reply to Jason Ekstrand from comment #34)
> > > (In reply to Samuel Iglesias from comment #33)
> > > >
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #51 from Jason Ekstrand ---
(In reply to Samuel Iglesias from comment #48)
> (In reply to Jason Ekstrand from comment #34)
> > (In reply to Samuel Iglesias from comment #33)
> > > Jason, I would like to know your opinion about the int
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #50 from Jason Ekstrand ---
(In reply to Iago Toral from comment #49)
> Jason you had this commit in your original branch: "MAYBEREVERT: Fill X
> components with 1"
>
> That basically makes packing to padded formats (like RGBX) set X
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #49 from Iago Toral ---
Jason you had this commit in your original branch: "MAYBEREVERT: Fill X
components with 1"
That basically makes packing to padded formats (like RGBX) set X=1. In the
commit message you mention that you are not
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #48 from Samuel Iglesias ---
(In reply to Jason Ekstrand from comment #34)
> (In reply to Samuel Iglesias from comment #33)
> > Jason, I would like to know your opinion about the integer RGBA clamping
> > done in pack.c (_mesa_pack_rg
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #47 from Iago Toral ---
(In reply to Jason Ekstrand from comment #46)
> (In reply to Iago Toral from comment #43)
> > Jason, we are running into some issues when attempting to use
> > _mesa_format_convert for glReadPixels and glGetTex
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #46 from Jason Ekstrand ---
(In reply to Iago Toral from comment #43)
> Jason, we are running into some issues when attempting to use
> _mesa_format_convert for glReadPixels and glGetTexImage.
>
> Generally, one thing that is differe
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #45 from Jason Ekstrand ---
(In reply to Iago Toral from comment #44)
> (In reply to Iago Toral from comment #43)
> (...)
> > 3) Luminance formats have special requirements. A conversion to Luminance
> > from RGBA requires to do L=R+G
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #44 from Iago Toral ---
(In reply to Iago Toral from comment #43)
(...)
> 3) Luminance formats have special requirements. A conversion to Luminance
> from RGBA requires to do L=R+G+B for example. This is something that
> _mesa_format_
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #43 from Iago Toral ---
Jason, we are running into some issues when attempting to use
_mesa_format_convert for glReadPixels and glGetTexImage.
Generally, one thing that is different in this case is that the current
implementation nev
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #23 from Iago Toral ---
(In reply to Jason Ekstrand from comment #21)
> (In reply to Iago Toral from comment #19)
> > Jason, for conversions where we cannot use a fast path in the master
> > converter (that is, where we need to unpack
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #42 from Jason Ekstrand ---
(In reply to Iago Toral from comment #40)
> Jason, I think we may want to be a bit more conservative with the
> pack/unpack fast paths when we consider the internal base format.
>
> Right now, if the src o
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #41 from Jason Ekstrand ---
(In reply to Iago Toral from comment #39)
> From your explanations I think this is what we should do too. For example,
> when the source type is RGBA ubyte, we will do something like this:
>
> if (src_arra
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #40 from Iago Toral ---
Jason, I think we may want to be a bit more conservative with the pack/unpack
fast paths when we consider the internal base format.
Right now, if the src or dst formats are RGBA we will try the pack/unpack fas
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #39 from Iago Toral ---
(In reply to Jason Ekstrand from comment #37)
> (In reply to Iago Toral from comment #35)
> > Jason, you wrote some fast paths in _mesa_format_convert for the cases where
> > we can directly pack or unpack to t
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #38 from Jason Ekstrand ---
(In reply to Samuel Iglesias from comment #36)
> (In reply to Jason Ekstrand from comment #32)
> > (In reply to Iago Toral from comment #31)
> > > Jason, there is an had-hoc path to deal with MESA_FORMAT_YC
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #37 from Jason Ekstrand ---
(In reply to Iago Toral from comment #35)
> Jason, you wrote some fast paths in _mesa_format_convert for the cases where
> we can directly pack or unpack to the destination format. In these paths, if
> we h
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #36 from Samuel Iglesias ---
(In reply to Jason Ekstrand from comment #32)
> (In reply to Iago Toral from comment #31)
> > Jason, there is an had-hoc path to deal with MESA_FORMAT_YCBCR* in
> > texstore.c. Seems that this path only al
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #35 from Iago Toral ---
Jason, you wrote some fast paths in _mesa_format_convert for the cases where we
can directly pack or unpack to the destination format. In these paths, if we
have to pack from or unpack to RGBA UINT, you hav
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #34 from Jason Ekstrand ---
(In reply to Samuel Iglesias from comment #33)
> Jason, I would like to know your opinion about the integer RGBA clamping
> done in pack.c (_mesa_pack_rgba_span_from_ints()).
>
> glReadPixels() and glGetTe
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #33 from Samuel Iglesias ---
Jason, I would like to know your opinion about the integer RGBA clamping done
in pack.c (_mesa_pack_rgba_span_from_ints()).
glReadPixels() and glGetTexImage() specs said (for example, in OpenGL 3.3. core
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #32 from Jason Ekstrand ---
(In reply to Iago Toral from comment #31)
> Jason, there is an had-hoc path to deal with MESA_FORMAT_YCBCR* in
> texstore.c. Seems that this path only allows conversion between these
> formats, which is mos
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #31 from Iago Toral ---
Jason, there is an had-hoc path to deal with MESA_FORMAT_YCBCR* in texstore.c.
Seems that this path only allows conversion between these formats, which is
mostly a memcpy with some byte swapping when necessary.
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #30 from Jason Ekstrand ---
(In reply to Iago Toral from comment #29)
> (In reply to Jason Ekstrand from comment #26)
> > (In reply to Iago Toral from comment #24)
> > > Jason, what do you think we should do for GL_COLOR_INDEX + GL_BI
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #29 from Iago Toral ---
(In reply to Jason Ekstrand from comment #26)
> (In reply to Iago Toral from comment #24)
> > Jason, what do you think we should do for GL_COLOR_INDEX + GL_BITMAP?
> >
> > Currently this is handled as a specia
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #28 from Iago Toral ---
(In reply to Kenneth Graunke from comment #25)
> I thought we killed color indexing with fire a while back. Did we miss some?
I see multiple references to GL_COLOR_INDEX in src/mesa/main and at least these
pi
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #27 from Jason Ekstrand ---
(In reply to Iago Toral from comment #23)
> (In reply to Jason Ekstrand from comment #21)
> > (In reply to Iago Toral from comment #19)
> > > Jason, for conversions where we cannot use a fast path in the ma
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #26 from Jason Ekstrand ---
(In reply to Iago Toral from comment #24)
> Jason, what do you think we should do for GL_COLOR_INDEX + GL_BITMAP?
>
> Currently this is handled as a special case in the texstore.c ubyte path
> (store_ubyte
On 10/16/2014 08:33 AM, bugzilla-dae...@freedesktop.org wrote:
*Comment # 25
I thought we killed color indexing with fire a while back. Did we miss some?
You can't kill glBitmap (in a non-core context, anyway). Strictly
speaking these aren't color indexed textures, but still hit all the same
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #25 from Kenneth Graunke ---
I thought we killed color indexing with fire a while back. Did we miss some?
--
You are receiving this mail because:
You are the QA Contact for the bug.
___
m
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #24 from Iago Toral ---
Jason, what do you think we should do for GL_COLOR_INDEX + GL_BITMAP?
Currently this is handled as a special case in the texstore.c ubyte path
(store_ubyte_texture), specifically, the special case handles extr
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #22 from Iago Toral ---
(In reply to Jason Ekstrand from comment #20)
> (In reply to Iago Toral from comment #18)
> > (In reply to Jason Ekstrand from comment #17)
> > > (In reply to Iago Toral from comment #16)
> > > > We also need n
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #21 from Jason Ekstrand ---
(In reply to Iago Toral from comment #19)
> Jason, for conversions where we cannot use a fast path in the master
> converter (that is, where we need to unpack the src to rgba and then pack
> from rgba to ds
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #20 from Jason Ekstrand ---
(In reply to Iago Toral from comment #18)
> (In reply to Jason Ekstrand from comment #17)
> > (In reply to Iago Toral from comment #16)
> > > We also need new mesa_format enums and pack/unpack functions for
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #19 from Iago Toral ---
Jason, for conversions where we cannot use a fast path in the master converter
(that is, where we need to unpack the src to rgba and then pack from rgba to
dst) you differentiate between 3 paths: uint (integer)
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #18 from Iago Toral ---
(In reply to Jason Ekstrand from comment #17)
> (In reply to Iago Toral from comment #16)
> > We also need new mesa_format enums and pack/unpack functions for byte
> > swapped variants of non-array types.
>
>
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #17 from Jason Ekstrand ---
(In reply to Iago Toral from comment #16)
> We also need new mesa_format enums and pack/unpack functions for byte
> swapped variants of non-array types.
Why? Is this for the byte_swapped flag on GL upload
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #16 from Iago Toral ---
We also need new mesa_format enums and pack/unpack functions for byte swapped
variants of non-array types.
--
You are receiving this mail because:
You are the QA Contact for the bug.
_
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #15 from Jason Ekstrand ---
(In reply to Iago Toral from comment #14)
> (...)
> > > I don't know yet. For that I would have enable the master convertion
> > > function for all code paths, then run all the piglit tests and then check
>
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #14 from Iago Toral ---
(In reply to Jason Ekstrand from comment #13)
> (In reply to Iago Toral from comment #12)
> > (In reply to Jason Ekstrand from comment #11)
> > > (In reply to Iago Toral from comment #10)
> > > > (In reply to I
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #13 from Jason Ekstrand ---
(In reply to Iago Toral from comment #12)
> (In reply to Jason Ekstrand from comment #11)
> > (In reply to Iago Toral from comment #10)
> > > (In reply to Iago Toral from comment #9)
> > > > Jason, piglit t
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #12 from Iago Toral ---
(In reply to Jason Ekstrand from comment #11)
> (In reply to Iago Toral from comment #10)
> > (In reply to Iago Toral from comment #9)
> > > Jason, piglit tests hit cases where they attempt to convert GL format
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #11 from Jason Ekstrand ---
(In reply to Iago Toral from comment #10)
> (In reply to Iago Toral from comment #9)
> > Jason, piglit tests hit cases where they attempt to convert GL format and
> > data type combinations that do not matc
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #10 from Iago Toral ---
(In reply to Iago Toral from comment #9)
> Jason, piglit tests hit cases where they attempt to convert GL format and
> data type combinations that do not match any of the existing mesa formats.
>
> For example
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #9 from Iago Toral ---
Jason, piglit tests hit cases where they attempt to convert GL format and data
type combinations that do not match any of the existing mesa formats.
For example GL_RGB + GL_UNSIGNED_BYTE_2_3_3_REV (BBGG GRRR).
https://bugs.freedesktop.org/show_bug.cgi?id=84566
Eduardo Lima Mitev changed:
What|Removed |Added
CC||el...@igalia.com
--- Comment #8 fro
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #7 from Iago Toral ---
(In reply to Jason Ekstrand from comment #6)
> (In reply to Iago Toral from comment #5)
> > Jason, in your initial implementation of the master function you have this
> > assert:
> >
> > if (src_array_format.as
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #6 from Jason Ekstrand ---
(In reply to Iago Toral from comment #5)
> Jason, in your initial implementation of the master function you have this
> assert:
>
> if (src_array_format.as_uint && dst_array_format.as_uint) {
>assert(sr
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #5 from Iago Toral ---
Jason, in your initial implementation of the master function you have this
assert:
if (src_array_format.as_uint && dst_array_format.as_uint) {
assert(src_array_format.normalized == dst_array_format.normalize
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #4 from Jason Ekstrand ---
(In reply to Iago Toral from comment #3)
> (...)
> As far as I can see, functions in textstore do not receive a mesa_format
> for their src argument, instead they receive the GL format and data type, so
> i
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #3 from Iago Toral ---
(In reply to Jason Ekstrand from comment #0)
(...)
> 5) Make a masater conversion function that takes a void*, format, width,
> height, and stride for both source and destination and just does the
> conversion.
https://bugs.freedesktop.org/show_bug.cgi?id=84566
Matt Turner changed:
What|Removed |Added
QA Contact||mesa-dev@lists.freedesktop.
https://bugs.freedesktop.org/show_bug.cgi?id=84566
Iago Toral changed:
What|Removed |Added
CC||sigles...@igalia.com
Assignee|mes
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #2 from Iago Toral ---
Hi Jason: Samuel and I will continue your work. We will ask here if we need
input from your side.
--
You are receiving this mail because:
You are the assignee for the bug.
_
https://bugs.freedesktop.org/show_bug.cgi?id=84566
Jason Ekstrand changed:
What|Removed |Added
CC||ja...@jlekstrand.net
--
You are receiv
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #1 from Jason Ekstrand ---
I've already started a lot of this work. I've got an implementation of an
array format enum and master conversion function in this branch:
http://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/format-conv
60 matches
Mail list logo
