[Mesa-dev] [PATCH] st/mesa: Initialize tex_target otherwise it might be used uninitialized.

The initialization of tex_target was dropped and since the value is used uninitialized (e.g. with Unreal Editor), an assertion fires in tgsi/tgsi_util.c:502: tgsi_util_get_texture_coord_dim: Assertion `!"unknown texture target"' failed. Initialize tex_target with the enum that corresponds to the

Re: [Mesa-dev] [PATCH 09/13] mesa: reduce the size of gl_viewport_attrib

Hi, On Friday, 9 February 2018 02:18:44 CET Marek Olšák wrote: > From: Marek Olšák > > All drivers convert these to float, so there is no reason to use double. > The piglit test that expects double precision from glGet will be adjusted > not to require it (there is a piglit patch). I am not awa

Re: [Mesa-dev] [PATCH] disk cache: move path creation back to constructor

Seems reasonable. Thanks! Reviewed-by: Timothy Arceri On 09/02/18 16:44, Tapani Pälli wrote: This patch moves disk cache path and index creation back to the constructor which matches previous behavior. We still allow create to succeed without path so that cache can be used with callback functi

[Mesa-dev] [PATCH 2/2] ac: convert nir_op_f2f32 src to a float

Fixes the following piglit test: ./bin/arb_vertex_attrib_64bit-check-explicit-location -auto -fbo Where we would end up with the nir such as: vec1 64 ssa_11 = pack_64_2x32_split ssa_9, ssa_10 vec1 32 ssa_12 = f2f32 ssa_2 And our pack_64_2x32_split nir to llvm code always produce

[Mesa-dev] [PATCH 1/2] ac: fix some 64bit unpack asserts

Previously the asserts did not take swizzles into account. --- src/amd/common/ac_nir_to_llvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 1301f451d1..5da82cfd05 100644 --- a/src/amd/common/ac_nir_t

Re: [Mesa-dev] [PATCH v2 5/7] disk cache: initialize cache path and index only when used

On 02/09/2018 06:03 AM, Timothy Arceri wrote: On 09/02/18 14:45, Timothy Arceri wrote: On 08/02/18 16:36, Tapani Pälli wrote: Hi; On 02/08/2018 06:00 AM, Timothy Arceri wrote: Hi Tapani, This patch causes deadlock when running piglit on my radeonsi with my ryzen (16 threads all running sh

[Mesa-dev] [PATCH] disk cache: move path creation back to constructor

This patch moves disk cache path and index creation back to the constructor which matches previous behavior. We still allow create to succeed without path so that cache can be used with callback functionality. Fixes: c95d3ed091 "disk cache: create cache even if path creation fails" Signed-off-by:

[Mesa-dev] [PATCH kmscube v2] formats: use weston's egl config matching logic, move format defines up

The GBM surface format has to match the DRM mode. Both are used in a couple of places, so move the defines to a common place so that they can be adjusted easily. Signed-off-by: Ilia Mirkin Reviewed-by: Eric Engestrom --- v1 -> v2: - Take Eric's review comments into account - Use gbm format fr

[Mesa-dev] [ANNOUNCE] Mesa 17.3.4 release candidate

Hello list, The candidate for the Mesa 17.3.4 is now available. Currently we have: - 89 queued - 18 nominated (outstanding) - and 9 rejected patches As always the i965, ANV and RADV drivers have seen dozens of fixes. Additionally the r600, virgl, etnaviv and renderonly drivers have also seen

Re: [Mesa-dev] [PATCH v2 5/7] disk cache: initialize cache path and index only when used

On 09/02/18 14:45, Timothy Arceri wrote: On 08/02/18 16:36, Tapani Pälli wrote: Hi; On 02/08/2018 06:00 AM, Timothy Arceri wrote: Hi Tapani, This patch causes deadlock when running piglit on my radeonsi with my ryzen (16 threads all running shader_runner). Have you tested it on similar Inte

[Mesa-dev] [PATCH 2/3] Revert "disk cache: initialize cache path and index only when used"

This reverts commit 6a651b6b77b68db71a027c826abccc843ace88ef. This change was not thread safe. Applications are allowed to compile multiple programs attached to the same context in different threads which means we can end up with multiple threads inside disk_cache_path_init() or thinking disk_cach

[Mesa-dev] [PATCH 3/3] Revert "i965: add __DRI2_BLOB support and set cache functions"

This reverts commit 9d322fde9781f9fc53c3baac6995ab1cbd8d6135. --- src/mesa/drivers/dri/i965/intel_screen.c | 21 - 1 file changed, 21 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 1f866cf845..8c78b73b64 100

[Mesa-dev] [PATCH 1/3] Revert "disk cache: add callback functionality"

This reverts commit ae00ef270233d7ba44e1a751333db16338b816f2. --- src/util/disk_cache.c | 48 src/util/disk_cache.h | 19 --- 2 files changed, 67 deletions(-) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index ea6808aa

Re: [Mesa-dev] [PATCH] gallium: Mute arrays for several meta like callbacks v3

Good Morning, Thanks to you both for the review! On Thursday, 8 February 2018 21:39:11 CET Marek Olšák wrote: > What is "not perfect" about it? It looks good to me. Well, Brian mentioned that we can probably skip more stages in this case. But I did not take the time to understand which ones in de

Re: [Mesa-dev] [PATCH v2 5/7] disk cache: initialize cache path and index only when used

On 08/02/18 16:36, Tapani Pälli wrote: Hi; On 02/08/2018 06:00 AM, Timothy Arceri wrote: Hi Tapani, This patch causes deadlock when running piglit on my radeonsi with my ryzen (16 threads all running shader_runner). Have you tested it on similar Intel hardware? It passes Intel CI, not sure

[Mesa-dev] [Bug 105013] [regression] GLX+VA-API+clutter-gst video playback is corrupt with Mesa 17.3 (but is fine with 17.2)

https://bugs.freedesktop.org/show_bug.cgi?id=105013 --- Comment #6 from Daniel van Vugt --- Verified (with git master): attachment 137229 does fix the problem. Thanks. -- You are receiving this mail because: You are the QA Contact for the bug.___ mesa

[Mesa-dev] [ANNOUNCE] mesa 18.0.0-rc4

The fourth release candidate for Mesa 18.0.0 is now available. Andres Gomez (1): i965: perform 2 uploads with dual slot *64*PASSTHRU formats on gen<8 Bas Nieuwenhuizen (1): radv: Signal fence correctly after sparse binding. Dave Airlie (4): r600/eg: construct proper rat mask f

Re: [Mesa-dev] [PATCH] glsl/linker: remove ubo explicit binding handling at uniform_initializers

On 08/02/18 18:34, Alejandro Piñeiro wrote: Ping. FWIW, when I sent this patch, I also sent a test to the piglit ml, that got reviewed and pushed: https://cgit.freedesktop.org/piglit/commit/?id=88a9a99794f6108b656d4142cecd373b7995863c To run it: ./bin/shader_runner tests/spec/arb_arrays_of_arra

Re: [Mesa-dev] [PATCH] st/mesa: update the blend before a full color clear

On Thu, Feb 8, 2018 at 6:01 PM, Ilia Mirkin wrote: > On Thu, Feb 8, 2018 at 8:58 PM, Ilia Mirkin wrote: >> On Thu, Feb 8, 2018 at 8:36 PM, Gurchetan Singh >> wrote: >>> On Thu, Feb 8, 2018 at 5:15 PM, Marek Olšák wrote: On Fri, Feb 9, 2018 at 2:12 AM, Gurchetan Singh wrote:

Re: [Mesa-dev] [PATCH 10/13] mesa, glsl, nir: reduce gl_state_index size to 2 bytes

Again, I can't research this right now, but what values in the gl_state_index array are greater than 255? Perhaps you can add a comment about that. And if that's not the case, gl_state_index8? Also, longer term, it might be cleaner in general if the gl_state_index array was encapsulated in a str

Re: [Mesa-dev] [PATCH] st/mesa: update the blend before a full color clear

On Thu, Feb 8, 2018 at 8:58 PM, Ilia Mirkin wrote: > On Thu, Feb 8, 2018 at 8:36 PM, Gurchetan Singh > wrote: >> On Thu, Feb 8, 2018 at 5:15 PM, Marek Olšák wrote: >>> >>> On Fri, Feb 9, 2018 at 2:12 AM, Gurchetan Singh >>> wrote: >>> > On Thu, Feb 8, 2018 at 4:46 PM, Marek Olšák wrote: >>> >>

Re: [Mesa-dev] [PATCH] st/mesa: update the blend before a full color clear

On Thu, Feb 8, 2018 at 8:36 PM, Gurchetan Singh wrote: > On Thu, Feb 8, 2018 at 5:15 PM, Marek Olšák wrote: >> >> On Fri, Feb 9, 2018 at 2:12 AM, Gurchetan Singh >> wrote: >> > On Thu, Feb 8, 2018 at 4:46 PM, Marek Olšák wrote: >> >> >> >> This is not the correct fix. >> >> >> >> clear_with_qua

Re: [Mesa-dev] [PATCH 12/13] mesa: reduce the size of gl_texture_image

On Thu, Feb 8, 2018 at 6:18 PM, Marek Olšák wrote: > From: Marek Olšák > > 80 -> 40 bytes. > --- > src/mesa/main/mtypes.h | 47 -- > - > 1 file changed, 24 insertions(+), 23 deletions(-) > > diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 5/5] ac/nir: add nir_intrinsic_{load, store}_shared support

--- src/amd/common/ac_nir_to_llvm.c | 46 + 1 file changed, 46 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index db692919ce..c69aaed7ed 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir

[Mesa-dev] [PATCH 4/5] ac/nir_to_llvm: add support for nir_intrinsic_shared_atomic_*

--- src/amd/common/ac_nir_to_llvm.c | 48 +++-- 1 file changed, 42 insertions(+), 6 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index e7352cc7d2..db692919ce 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/a

[Mesa-dev] radeonsi add nir support for shared vars/atomics

This adds the missing nir support and allows the nir backend to produce an equivalent shader to the tgsi backend for the only piglit test we have for this [1]. However the test still fails and I've so far been unable to spot the problem. [1] ./bin/shader_runner tests/spec/arb_compute_shader/execu

[Mesa-dev] [PATCH 2/5] radeonsi: make si_declare_compute_memory() more generic and call for nir

--- src/gallium/drivers/radeonsi/si_shader.c| 14 ++ src/gallium/drivers/radeonsi/si_shader_internal.h | 5 +++-- src/gallium/drivers/radeonsi/si_shader_nir.c| 4 src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 2 +- 4 files changed, 18 insertions(+)

[Mesa-dev] [PATCH 3/5] ac: pass ac_nir_context to visit_var_atomic()

Thsi will enable us to use it with the radeonsi backend. --- src/amd/common/ac_nir_to_llvm.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 72105c21e4..e7352cc7d2 100644 --- a/src/amd/commo

[Mesa-dev] [PATCH 1/5] st/glsl: set req_local_mem earlier for compute shaders

Without this is will never be set for backends using nir. --- src/mesa/state_tracker/st_program.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state_tracker/st_program.c index d9b7155a91..145a070573 100644 --- a/src/mesa/stat

Re: [Mesa-dev] [PATCH] st/mesa: update the blend before a full color clear

On Thu, Feb 8, 2018 at 5:15 PM, Marek Olšák wrote: > > On Fri, Feb 9, 2018 at 2:12 AM, Gurchetan Singh > wrote: > > On Thu, Feb 8, 2018 at 4:46 PM, Marek Olšák wrote: > >> > >> This is not the correct fix. > >> > >> clear_with_quad calls cso_set_blend. pipe->clear ignores (and should > >> ignore

Re: [Mesa-dev] [PATCH 19/29] anv/cmd_buffer: Move the rest of clear_subpass into begin_subpass

On Thu, Feb 8, 2018 at 5:20 PM, Jason Ekstrand wrote: > On Fri, Jan 12, 2018 at 2:45 PM, Nanley Chery > wrote: > >> On Mon, Nov 27, 2017 at 07:06:09PM -0800, Jason Ekstrand wrote: >> > --- >> > src/intel/vulkan/anv_blorp.c | 243 -- >> --- >> > src/intel/vu

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

On 8 February 2018 at 04:30, Timothy Arceri wrote: > > > On 07/02/18 19:17, Dieter Nützel wrote: >> >> Am 06.02.2018 00:23, schrieb Timothy Arceri: >>> >>> On 05/02/18 15:04, Dieter Nützel wrote: Am 02.02.2018 10:24, schrieb Timothy Arceri: > > On 02/02/18 19:26, Dieter Nützel wr

Re: [Mesa-dev] [PATCH 19/29] anv/cmd_buffer: Move the rest of clear_subpass into begin_subpass

On Fri, Jan 12, 2018 at 2:45 PM, Nanley Chery wrote: > On Mon, Nov 27, 2017 at 07:06:09PM -0800, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_blorp.c | 243 -- > --- > > src/intel/vulkan/anv_private.h | 17 ++- > > src/intel/vulkan/genX_cmd_bu

[Mesa-dev] [PATCH 12/13] mesa: reduce the size of gl_texture_image

From: Marek Olšák 80 -> 40 bytes. --- src/mesa/main/mtypes.h | 47 --- 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index a589bd4..b619d5c 100644 --- a/src/mesa/main/mtypes.h +++ b/src/

[Mesa-dev] [PATCH 11/13] mesa: reduce the size of gl_program_parameter

From: Marek Olšák 40 -> 24 bytes, which includes the gl_state_index16 change. --- src/mesa/program/prog_parameter.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/prog_parameter.h b/src/mesa/program/prog_parameter.h index ce5d2cb..41b3fe8 100644 --- a

[Mesa-dev] [PATCH 13/13] mesa: move STATE_LENGTH to shader_enums.h and use it everywhere

From: Marek Olšák --- src/compiler/glsl/ir.h | 2 +- src/compiler/nir/nir.h | 10 +- src/compiler/nir/nir_lower_drawpixels.c | 2 +- src/compiler/shader_enums.h | 6 ++ src/mesa/program/prog_statevars.h | 6 -- 5 files chang

[Mesa-dev] [PATCH 09/13] mesa: reduce the size of gl_viewport_attrib

From: Marek Olšák All drivers convert these to float, so there is no reason to use double. The piglit test that expects double precision from glGet will be adjusted not to require it (there is a piglit patch). gl_context::ViewportArray: 512 -> 384 bytes --- src/mesa/drivers/common/meta.h | 2 +-

[Mesa-dev] [PATCH 08/13] mesa: reduce the size of gl_texture_object

From: Marek Olšák --- src/mesa/main/mtypes.h | 58 src/mesa/main/texparam.c | 2 +- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index c80d3b9..d8cb8f8 100644 --- a/src/mesa/ma

[Mesa-dev] [PATCH 10/13] mesa, glsl, nir: reduce gl_state_index size to 2 bytes

From: Marek Olšák Let's use the new gl_state_index16 type everywhere and remove the typecasts. This helps reduce the size of gl_program_parameter. --- src/compiler/glsl/ir.h | 2 +- src/compiler/glsl/serialize.cpp| 2 +- src/compiler/glsl/standalone_sca

[Mesa-dev] [PATCH 02/13] mesa: inline init_texture_unit

From: Marek Olšák because this is going to be changed --- src/mesa/main/texstate.c | 90 +--- 1 file changed, 39 insertions(+), 51 deletions(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index 8f87cac..e24b3c4 100644 --- a/src/me

[Mesa-dev] [PATCH 06/13] mesa: reduce the size of gl_image_unit (v2)

From: Marek Olšák gl_context::ImageUnits: 6144 -> 4608 bytes v2: use ASSERT_BITFIELD_SIZE --- src/mesa/main/mtypes.h | 13 ++--- src/mesa/main/shaderimage.c | 2 ++ 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index

[Mesa-dev] [PATCH 01/13] mesa: use GLenum16 in a few more places

From: Marek Olšák --- src/mesa/main/mtypes.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 4d6b771..46137f5 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -959,21 +959,21 @@ typedef enum /*@}*

[Mesa-dev] [PATCH 07/13] mesa: reduce the size of gl_program

From: Marek Olšák gl_program: 1456 -> 976 bytes --- src/compiler/glsl/link_uniforms.cpp | 9 - src/mesa/main/mtypes.h | 4 ++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp index 158

[Mesa-dev] [PATCH 05/13] mesa: further reduce the size of ctx->Texture

From: Marek Olšák --- src/mesa/main/glheader.h | 5 - src/mesa/main/mtypes.h | 44 ++-- 2 files changed, 26 insertions(+), 23 deletions(-) diff --git a/src/mesa/main/glheader.h b/src/mesa/main/glheader.h index 7a4b4a0..a6e6b6a 100644 --- a/src/mesa

[Mesa-dev] [PATCH 03/13] mesa: separate legacy stuff from gl_texture_unit into gl_fixedfunc_texture_unit

From: Marek Olšák --- src/mesa/drivers/common/meta.c | 18 +++--- src/mesa/drivers/dri/i915/i830_texblend.c | 3 +- src/mesa/drivers/dri/nouveau/nouveau_util.h | 2 +- src/mesa/drivers/dri/nouveau/nv04_context.c | 14 +++-- src/mesa/drivers/dri/nouveau/nv04_state

[Mesa-dev] [PATCH 04/13] mesa: decrease the array size of ctx->Texture.FixedFuncUnit to 8

From: Marek Olšák GL allows doing glTexEnv on 192 texture units, while in reality, only MaxTextureCoordUnits units are used by fixed-func shaders. There is a piglit patch that adjusts piglits/texunits to check only MaxTextureCoordUnits units. --- src/mesa/main/enable.c | 5 + src/mesa/ma

Re: [Mesa-dev] [PATCH] radeonsi/nir: gather some missing fs info

Reviewed-by: Marek Olšák Marek On Fri, Feb 9, 2018 at 1:04 AM, Timothy Arceri wrote: > Fixes some early-z arb_shader_image_load_store piglit tests. > --- > src/gallium/drivers/radeonsi/si_shader_nir.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/gallium/drivers/radeonsi/si

Re: [Mesa-dev] [PATCH] ac: pass struct ac_llvm_context to emit_membar()

Reviewed-by: Marek Olšák Marek On Fri, Feb 9, 2018 at 12:39 AM, Timothy Arceri wrote: > Fixes segfault in piglit test: > > ./bin/arb_shader_image_load_store-shader-mem-barrier --quick -auto -fbo > --- > src/amd/common/ac_nir_to_llvm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(

Re: [Mesa-dev] [PATCH] st/mesa: update the blend before a full color clear

On Fri, Feb 9, 2018 at 2:12 AM, Gurchetan Singh wrote: > On Thu, Feb 8, 2018 at 4:46 PM, Marek Olšák wrote: >> >> This is not the correct fix. >> >> clear_with_quad calls cso_set_blend. pipe->clear ignores (and should >> ignore) the blend state. There is no scenario where you would have to >> cal

[Mesa-dev] [PATCH v3] intel/tools: new intel_sanitize_gpu tool

From: Kevin Rogovin Adds a new debug tool to pad each GEM BO allocated with (weak) pseudo-random noise values which are then checked after each batchbuffer dispatch to the kernel. This can be quite valuable to find diffucult to track down heisenberg style bugs. [scott.d.phill...@intel.com: split

Re: [Mesa-dev] [PATCH] st/mesa: update the blend before a full color clear

On Thu, Feb 8, 2018 at 4:46 PM, Marek Olšák wrote: > This is not the correct fix. > > clear_with_quad calls cso_set_blend. pipe->clear ignores (and should > ignore) the blend state. There is no scenario where you would have to > call st_update_blend for pipe->clear. I think this is a virgl bug in

Re: [Mesa-dev] [PATCH 19/29] anv/cmd_buffer: Move the rest of clear_subpass into begin_subpass

On Mon, Dec 18, 2017 at 11:19 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Mon, Nov 27, 2017 at 07:06:09PM -0800, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_blorp.c | 243 -- > --- > > src/intel/vulkan/anv_private.h | 17 ++

[Mesa-dev] [PATCH 1/4] r600: add PIPE_SHADER_IR_NATIVE to supported shaders for cs

--- src/gallium/drivers/r600/r600_pipe.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 6c021e568d..719ab349ef 100644 --- a/src/gallium/drivers/r600/r600_pipe.c +++ b/src/gallium/dri

[Mesa-dev] [PATCH 3/4] r600: always return PIPE_SHADER_IR_TGSI for PIPE_SHADER_CAP_PREFERRED_IR

We now use PIPE_SHADER_CAP_SUPPORTED_IRS to check for native support in clover. --- src/gallium/drivers/r600/r600_pipe.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 719ab349ef..1a232c36d4 100644 --- a/sr

[Mesa-dev] [PATCH 4/4] radeonsi: stop returning PIPE_SHADER_IR_NATIVE for PIPE_SHADER_CAP_PREFERRED_IR

Clover now checks PIPE_SHADER_CAP_SUPPORTED_IRS for native support instead. This change indirectly enables NIR support for compute shaders on radeonsi. --- src/gallium/drivers/radeonsi/si_get.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gall

[Mesa-dev] [PATCH 2/4] clover: use PIPE_SHADER_CAP_SUPPORTED_IRS to discover IR

PIPE_SHADER_CAP_PREFERRED_IR was conflicting with PIPE_SHADER_IR_NIR for compute shaders, so we let clover pick the one it wants to use. --- src/gallium/state_trackers/clover/core/device.cpp | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

On 09/02/18 11:53, Marek Olšák wrote: On Fri, Feb 9, 2018 at 1:45 AM, Timothy Arceri wrote: On 09/02/18 10:49, Marek Olšák wrote: Does this fix the cache/no cache conflict? diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 26835d6..97f11ea 1

Re: [Mesa-dev] [PATCH] travis: radeonsi and radv need LLVM 4.0

On 6 February 2018 at 15:42, Andres Gomez wrote: > Fixes: 3bf1e036e8a ("amd: remove support for LLVM 3.9") > Cc: Marek Olšák > Cc: Emil Velikov > Cc: Jan Vesely > Signed-off-by: Andres Gomez > --- > > Additionally, AMD's support removal for LLVM 3.9 has also affected the > distcheck target. >

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

On Fri, Feb 9, 2018 at 1:45 AM, Timothy Arceri wrote: > On 09/02/18 10:49, Marek Olšák wrote: >> >> Does this fix the cache/no cache conflict? >> >> diff --git a/src/gallium/drivers/radeonsi/si_pipe.c >> b/src/gallium/drivers/radeonsi/si_pipe.c >> index 26835d6..97f11ea 100644 >> --- a/src/gallium

Re: [Mesa-dev] [PATCH] st/mesa: update the blend before a full color clear

This is not the correct fix. clear_with_quad calls cso_set_blend. pipe->clear ignores (and should ignore) the blend state. There is no scenario where you would have to call st_update_blend for pipe->clear. I think this is a virgl bug in pipe->clear. Marek On Fri, Feb 9, 2018 at 1:28 AM, gurcheta

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

On 09/02/18 10:49, Marek Olšák wrote: Does this fix the cache/no cache conflict? diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 26835d6..97f11ea 100644 --- a/src/gallium/drivers/radeonsi/si_pipe.c +++ b/src/gallium/drivers/radeonsi/si_pipe.c @@

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

Marek, great work. This one solve it. I've tested both ways: NO_NIR -> NIR : OK NIR -> NO_NIR : OK (deleted cache files before both tests) Tested-by: Dieter Nützel Land this stuff...;-) Dieter Am 09.02.2018 00:49, schrieb Marek Olšák: Does this fix the cache/no cache conflict? diff --git a

[Mesa-dev] [PATCH] st/mesa: update the blend before a full color clear

From: Gurchetan Singh Consider this series of events: glColorMask(GL_FALSE, GL_TRUE, GL_TRUE, GL_TRUE); glClearColor(0.125f, 0.25f, 0.5f, 1.0f); glClear(GL_COLOR_BUFFER_BIT); glColorMask(GL_TRUE, GL_TRUE, GL_TRUE, GL_TRUE); glClearColor(0.1f, 0.1f, 0.1f, 1.0f); glClear(GL_COLOR_BUFFER_BIT); Wit

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

Does this fix the cache/no cache conflict? diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 26835d6..97f11ea 100644 --- a/src/gallium/drivers/radeonsi/si_pipe.c +++ b/src/gallium/drivers/radeonsi/si_pipe.c @@ -642,7 +642,8 @@ static void si_disk_ca

Re: [Mesa-dev] [PATCH v3 1/9] meson: use va-api version reported by pkg-config

On 8 February 2018 at 23:36, Dylan Baker wrote: > Quoting Emil Velikov (2018-02-08 15:22:32) >> On 8 February 2018 at 23:16, Dylan Baker wrote: >> > Quoting Emil Velikov (2018-02-08 14:56:27) >> >> On 2 February 2018 at 19:30, Dylan Baker wrote: >> >> > Fixes: 5a785d51a6d6 ("meson: build gallium

Re: [Mesa-dev] Adding a SPIR-V target to libclc

Jan Vesely writes: > On Thu, 2018-02-08 at 23:16 +0100, Pierre Moreau wrote: >> (Moving the conversation to its own thread.) >> >> > target agnostic libclc is rather difficult to do. CLC includes 3 levels >> > of precision on float (fp32) operands; full, half, native. The >> > implementation of

Re: [Mesa-dev] [PATCH v3 5/9] meson: fix vdpau target linkage

On 8 February 2018 at 23:35, Dylan Baker wrote: > Quoting Emil Velikov (2018-02-08 15:17:16) >> On 8 February 2018 at 23:11, Emil Velikov wrote: >> > On 2 February 2018 at 19:30, Dylan Baker wrote: >> >> The VDPAU state tracker needs to be linked with whole-archive (autotools >> >> does this). B

[Mesa-dev] [PATCH] radeonsi/nir: gather some missing fs info

Fixes some early-z arb_shader_image_load_store piglit tests. --- src/gallium/drivers/radeonsi/si_shader_nir.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index ed16345b89..4eda3f3c18 100644 --

Re: [Mesa-dev] [PATCH v3 4/9] meson: Actually link xvmc target with libxvmc

On 8 February 2018 at 23:33, Dylan Baker wrote: > Quoting Emil Velikov (2018-02-08 15:09:13) >> On 2 February 2018 at 19:30, Dylan Baker wrote: >> > Unlike vdpau this is required. >> > >> > Fixes: 22a817af8a89eb3c7 ("meson: build gallium xvmc state tracker") >> > Signed-off-by: Dylan Baker >> >

Re: [Mesa-dev] [Mesa-maintainers] Underlinking issues in 18.0.0~rc3

On 8 February 2018 at 23:02, Igor Gnatenko wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > I've tried to update mesa to 18.0.0~rc3 in Fedora Rawhide, but that fails with > a lot of "undefined reference" errors. Any hints for available patch? > > https://kojipkgs.fedoraproject.org//w

[Mesa-dev] [PATCH] r600/shader: tess_input_info is needed by TES for gl_PatchVerticesIn

From: Dave Airlie This fixes: KHR-GL45.tessellation_shader.tessellation_control_to_tessellation_evaluation.gl_PatchVerticesIn --- src/gallium/drivers/r600/r600_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drive

[Mesa-dev] [PATCH] ac: pass struct ac_llvm_context to emit_membar()

Fixes segfault in piglit test: ./bin/arb_shader_image_load_store-shader-mem-barrier --quick -auto -fbo --- src/amd/common/ac_nir_to_llvm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 82b55d4bc2..

Re: [Mesa-dev] Adding a SPIR-V target to libclc

On Thu, 2018-02-08 at 23:16 +0100, Pierre Moreau wrote: > (Moving the conversation to its own thread.) > > > target agnostic libclc is rather difficult to do. CLC includes 3 levels > > of precision on float (fp32) operands; full, half, native. The > > implementation of each depends on capabilites

Re: [Mesa-dev] [PATCH v3 1/9] meson: use va-api version reported by pkg-config

Quoting Emil Velikov (2018-02-08 15:22:32) > On 8 February 2018 at 23:16, Dylan Baker wrote: > > Quoting Emil Velikov (2018-02-08 14:56:27) > >> On 2 February 2018 at 19:30, Dylan Baker wrote: > >> > Fixes: 5a785d51a6d6 ("meson: build gallium va state tracker") > >> > Signed-off-by: Dylan Baker

Re: [Mesa-dev] [PATCH v3 5/9] meson: fix vdpau target linkage

Quoting Emil Velikov (2018-02-08 15:17:16) > On 8 February 2018 at 23:11, Emil Velikov wrote: > > On 2 February 2018 at 19:30, Dylan Baker wrote: > >> The VDPAU state tracker needs to be linked with whole-archive (autotools > >> does this). Because we are linking the whole archive we alos need to

Re: [Mesa-dev] [PATCH v3 4/9] meson: Actually link xvmc target with libxvmc

Quoting Emil Velikov (2018-02-08 15:09:13) > On 2 February 2018 at 19:30, Dylan Baker wrote: > > Unlike vdpau this is required. > > > > Fixes: 22a817af8a89eb3c7 ("meson: build gallium xvmc state tracker") > > Signed-off-by: Dylan Baker > > --- > > meson.build | 3 --- > > 1 file changed, 3 delet

Re: [Mesa-dev] [PATCH v3 3/9] meson: actually link with libomxil-bellagio

Quoting Dylan Baker (2018-02-08 15:23:23) > Quoting Emil Velikov (2018-02-08 15:06:50) > > On 2 February 2018 at 19:30, Dylan Baker wrote: > > > This state tracker actually needs to link, unlike vdpau. > > > > > > Fixes: 1d36dc674d528b93b ("meson: build gallium omx state tracker") > > > Signed-off

Re: [Mesa-dev] [PATCH v3 3/9] meson: actually link with libomxil-bellagio

Quoting Emil Velikov (2018-02-08 15:06:50) > On 2 February 2018 at 19:30, Dylan Baker wrote: > > This state tracker actually needs to link, unlike vdpau. > > > > Fixes: 1d36dc674d528b93b ("meson: build gallium omx state tracker") > > Signed-off-by: Dylan Baker > > --- > > meson.build | 5 - >

Re: [Mesa-dev] [PATCH v3 1/9] meson: use va-api version reported by pkg-config

On 8 February 2018 at 23:16, Dylan Baker wrote: > Quoting Emil Velikov (2018-02-08 14:56:27) >> On 2 February 2018 at 19:30, Dylan Baker wrote: >> > Fixes: 5a785d51a6d6 ("meson: build gallium va state tracker") >> > Signed-off-by: Dylan Baker >> > --- >> > meson.build

Re: [Mesa-dev] [PATCH v3 2/9] meson: link dri3 xcb libs into vlwinsys instead of into each target

Quoting Emil Velikov (2018-02-08 15:03:37) > On 2 February 2018 at 19:30, Dylan Baker wrote: > > This makes the dependencies easier to manage, since each media target > > doesn't need to worry about linking to half a dozen libraries. > > > > Fixes: b1b65397d0c4978e3 ("meson: Build gallium auxiliar

Re: [Mesa-dev] [PATCH v3 5/9] meson: fix vdpau target linkage

On 8 February 2018 at 23:11, Emil Velikov wrote: > On 2 February 2018 at 19:30, Dylan Baker wrote: >> The VDPAU state tracker needs to be linked with whole-archive (autotools >> does this). Because we are linking the whole archive we alos need to >> link with libswdri and libswkmsdri if those hav

[Mesa-dev] [Bug 102032] nir_op_imod is incorrectly implemented as LLVM's srem

https://bugs.freedesktop.org/show_bug.cgi?id=102032 --- Comment #5 from Bas Nieuwenhuizen --- yes, but GL_ARB_spirv has the same spec language and there currently is no CL driver based on the AMD NIR->LLVM code. So none of the currently supported frontends need it. -- You are receiving this mai

Re: [Mesa-dev] [PATCH] nir: remove the abs call in is_neg_power_of_two

On Mon, Feb 5, 2018 at 7:16 PM, Vlad Golovkin wrote: > val->i32[swizzle[i]] is guaranteed to have non-positive value before the > __is_power_of_two call, so unary minus is equivalent to abs in this case. > --- > src/compiler/nir/nir_search_helpers.h | 2 +- > 1 file changed, 1 insertion(+), 1 del

Re: [Mesa-dev] [PATCH v3 1/9] meson: use va-api version reported by pkg-config

Quoting Emil Velikov (2018-02-08 14:56:27) > On 2 February 2018 at 19:30, Dylan Baker wrote: > > Fixes: 5a785d51a6d6 ("meson: build gallium va state tracker") > > Signed-off-by: Dylan Baker > > --- > > meson.build | 2 +- > > src/gallium/state_trackers/va/meson.buil

Re: [Mesa-dev] [PATCH v3 5/9] meson: fix vdpau target linkage

On 2 February 2018 at 19:30, Dylan Baker wrote: > The VDPAU state tracker needs to be linked with whole-archive (autotools > does this). Because we are linking the whole archive we alos need to > link with libswdri and libswkmsdri if those have been enabled. > > Fixes: 68076b87474e7959 ("meson: bu

Re: [Mesa-dev] [PATCH] radv: Don't expose VK_KHX_multiview on android.

Quoting Emil Velikov (2018-02-08 14:51:57) > On 2 February 2018 at 21:42, Bas Nieuwenhuizen > wrote: > > On Fri, Feb 2, 2018 at 10:31 PM, Dylan Baker wrote: > >> Quoting Bas Nieuwenhuizen (2018-02-02 10:14:04) > >>> On Fri, Feb 2, 2018 at 6:59 PM, Emil Velikov > >>> wrote: > >>> > Hi Bas, > >>

[Mesa-dev] [Bug 102032] nir_op_imod is incorrectly implemented as LLVM's srem

https://bugs.freedesktop.org/show_bug.cgi?id=102032 --- Comment #4 from programmerj...@gmail.com --- (In reply to Bas Nieuwenhuizen from comment #3) > radv is not a CL driver though, so you can't depend on this working on any > unextended vulkan driver. NIR is not specific to Vulkan though. --

Re: [Mesa-dev] [PATCH v3 4/9] meson: Actually link xvmc target with libxvmc

On 2 February 2018 at 19:30, Dylan Baker wrote: > Unlike vdpau this is required. > > Fixes: 22a817af8a89eb3c7 ("meson: build gallium xvmc state tracker") > Signed-off-by: Dylan Baker > --- > meson.build | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/meson.build b/meson.build > index

Re: [Mesa-dev] [PATCH v3 3/9] meson: actually link with libomxil-bellagio

On 2 February 2018 at 19:30, Dylan Baker wrote: > This state tracker actually needs to link, unlike vdpau. > > Fixes: 1d36dc674d528b93b ("meson: build gallium omx state tracker") > Signed-off-by: Dylan Baker > --- > meson.build | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/meson.b

Re: [Mesa-dev] [PATCH v2 0/8] The 2nd version for UVD HEVC encode

On 08/02/18 22:37, Alex Deucher wrote: > On Thu, Feb 8, 2018 at 5:28 PM, Mark Thompson wrote: >> On 06/02/18 20:05, James Zhu wrote: >>> The whole series are the updated version. Changes are made mainly based >>> on the comments from prevous code review from Alex, Leo and Boyuan >>> >>> James Zhu

Re: [Mesa-dev] [PATCH v3 2/9] meson: link dri3 xcb libs into vlwinsys instead of into each target

On 2 February 2018 at 19:30, Dylan Baker wrote: > This makes the dependencies easier to manage, since each media target > doesn't need to worry about linking to half a dozen libraries. > > Fixes: b1b65397d0c4978e3 ("meson: Build gallium auxiliary") > Signed-off-by: Dylan Baker > --- > src/galliu

Re: [Mesa-dev] [PATCH v2 5/7] disk cache: initialize cache path and index only when used

To be sure: Have you tried with current LLVM (at least from yesterday)? (See my related post). [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected https://lists.freedesktop.org/archives/mesa-dev/2018-February/184898.html Dieter Am 08.02.2018 05:00, schrieb Timothy

Re: [Mesa-dev] [PATCH v3 1/9] meson: use va-api version reported by pkg-config

On 2 February 2018 at 19:30, Dylan Baker wrote: > Fixes: 5a785d51a6d6 ("meson: build gallium va state tracker") > Signed-off-by: Dylan Baker > --- > meson.build | 2 +- > src/gallium/state_trackers/va/meson.build | 6 +++--- > 2 files changed, 4 insertions(+), 4 del

Re: [Mesa-dev] [PATCH] radv: Don't expose VK_KHX_multiview on android.

On 2 February 2018 at 21:42, Bas Nieuwenhuizen wrote: > On Fri, Feb 2, 2018 at 10:31 PM, Dylan Baker wrote: >> Quoting Bas Nieuwenhuizen (2018-02-02 10:14:04) >>> On Fri, Feb 2, 2018 at 6:59 PM, Emil Velikov >>> wrote: >>> > Hi Bas, >>> > >>> > On 31 January 2018 at 11:31, Bas Nieuwenhuizen wr

Re: [Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier - bisected

Am 08.02.2018 05:30, schrieb Timothy Arceri: On 07/02/18 19:17, Dieter Nützel wrote: Am 06.02.2018 00:23, schrieb Timothy Arceri: On 05/02/18 15:04, Dieter Nützel wrote: Am 02.02.2018 10:24, schrieb Timothy Arceri: On 02/02/18 19:26, Dieter Nützel wrote: Hello Tim, _this_ version brake UH,

Re: [Mesa-dev] [PATCH 00/18] Wayland/GBM format cleanups and 10bpc BGR

On 8 February 2018 at 14:05, Daniel Stone wrote: > Hi, > When Ilia asked for suggestions on where to look to add 10bpc BGR > support to the GBM and Wayland EGL backends, I had a quick look; the > number of places the formats were duplicated and lossily/inconsistently > translated between rapidly a

Re: [Mesa-dev] [PATCH v2 0/8] The 2nd version for UVD HEVC encode

On Thu, Feb 8, 2018 at 5:28 PM, Mark Thompson wrote: > On 06/02/18 20:05, James Zhu wrote: >> The whole series are the updated version. Changes are made mainly based >> on the comments from prevous code review from Alex, Leo and Boyuan >> >> James Zhu (8): >> amd/common:add uvd hevc enc support

Re: [Mesa-dev] [PATCH v2 0/8] The 2nd version for UVD HEVC encode

On 06/02/18 20:05, James Zhu wrote: > The whole series are the updated version. Changes are made mainly based > on the comments from prevous code review from Alex, Leo and Boyuan > > James Zhu (8): > amd/common:add uvd hevc enc support check in hw query > winsys/amdgpu:add uvd hevc enc suppor

Re: [Mesa-dev] [PATCH v2 5/8] radeon/uvd:add uvd hevc enc functions

On 06/02/18 20:05, James Zhu wrote: > Implement UVD hevc encode functions > > Signed-off-by: James Zhu > --- > src/gallium/drivers/radeon/radeon_uvd_enc.c | 370 > > 1 file changed, 370 insertions(+) > create mode 100644 src/gallium/drivers/radeon/radeon_uvd_enc.c

[Mesa-dev] Adding a SPIR-V target to libclc

(Moving the conversation to its own thread.) > target agnostic libclc is rather difficult to do. CLC includes 3 levels > of precision on float (fp32) operands; full, half, native. The > implementation of each depends on capabilites of specific device (e.g. > vega(VI+?) can do 1 ULP log2/exp2 in hw

  1   2   3   >