On 8 February 2018 at 04:30, Timothy Arceri <tarc...@itsqueeze.com> wrote: > > > On 07/02/18 19:17, Dieter Nützel wrote: >> >> Am 06.02.2018 00:23, schrieb Timothy Arceri: >>> >>> On 05/02/18 15:04, Dieter Nützel wrote: >>>> >>>> Am 02.02.2018 10:24, schrieb Timothy Arceri: >>>>> >>>>> On 02/02/18 19:26, Dieter Nützel wrote: >>>>>> >>>>>> Hello Tim, >>>>>> >>>>>> _this_ version brake UH, UV, mpv, blender 2.79 (some test files not >>>>>> all). >>>>>> Must be something with the cache file(s). >>>>> >>>>> >>>>> The cache currently needs to be deleted when switching between nir and >>>>> tgsi. I'm not sure it I should try to avoid this or not ... I guess it >>>>> will probably save some bug reports so I'll try send a follow up >>>>> patch. >>>> >>>> >>>> Hi Tim, >>>> >>>> it is NOT your fault. >>>> I tracked it down to Marek's commit commit >>>> be973ed21f6e456ebd753f26a99151d9ea6e765c >>> >>> >>> This should fix things for now: >>> >>> https://patchwork.freedesktop.org/patch/202759/ >> >> >> Apart that it landed already: >> >> Tested-by: Dieter Nützel <die...@nuetzel-hh.de> >> >> But I get some severe hangs with current git code on Polaris 20. >> Steam (Linux only, NOT Wine), UH and UV hang full system. >> I could remotely log in but nothing in the logs. >> Have to bisect, again... > > > I'm seeing deadlocks in piglit caused by the following patch, could be what > you are seeing. > > commit 6a651b6b77b68db71a027c826abccc843ace88ef (HEAD) > Author: Tapani Pälli <tapani.pa...@intel.com> > Date: Mon Jan 22 11:55:06 2018 +0200 > > disk cache: initialize cache path and index only when used > > This patch makes disk_cache initialize path and index lazily so > that we can utilize disk_cache without a path using callback > functionality introduced by next patch. > > v2: unmap mmap and destroy queue only if index_mmap exists > Just a fly-by comment.
While the issue may be elsewhere, an orthogonal approach is to allow selecting the old/new behaviour. Say by adding a "bool delayed/immediate" to disk_cache_create()? Off the top of my head - the old behaviour might be even good for the Vulkan drivers. You don't want app. developers having a wtf moment as they see the odd stall where there it shouldn't be ;-) -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
