Re: [Mesa-dev] [PATCH 00/17] i965 ARB_get_program_binary support

2017-11-10 Thread Timothy Arceri
On 09/11/17 21:46, Timothy Arceri wrote: On 09/11/17 17:42, Jordan Justen wrote: git://people.freedesktop.org/~jljusten/mesa i965-get-program-binary-v1 This series adds i965 support for ARB_get_program_binary with greater than 0 supported formats. Today we support this extension, but advertise

[Mesa-dev] [PATCH] freedreno/meson: Only build the compiler if building freedreno

2017-11-10 Thread Jason Ekstrand
Setting build_by_default to true makes it suddenly pull in freedreno and all of gallium unconditionally. Cc: Rob Clark Cc: Dylan Baker --- src/gallium/drivers/freedreno/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/meson.build b/s

[Mesa-dev] [PATCH 1/2] nv50/ir: optimize signed integer modulo by pow-of-2

2017-11-10 Thread Ilia Mirkin
It's common to use signed int modulo in GLSL. As it happens, the GLSL specs allow the result to be undefined, but that seems fairly surprising. It's not that much more effort to get it right, at least for positive modulo operators. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codeg

[Mesa-dev] [PATCH 2/2] nv50/ir: add optimization for modulo by a non-power-of-2 value

2017-11-10 Thread Ilia Mirkin
We can still use the optimized division methods which make use of multiplication with overflow. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir

Re: [Mesa-dev] [PATCH 0/5] Volatile and invariant LDS memory ops

2017-11-10 Thread Marek Olšák
On Fri, Nov 10, 2017 at 9:58 PM, Nicolai Hähnle wrote: > On 10.11.2017 19:24, Connor Abbott wrote: >> >> On Fri, Nov 10, 2017 at 1:19 PM, Marek Olšák wrote: >>> >>> On Fri, Nov 10, 2017 at 6:55 PM, Nicolai Hähnle >>> wrote: On 10.11.2017 18:43, Marek Olšák wrote: > > > On F

[Mesa-dev] [PATCH] docs: update llvmpipe.html build instructions

2017-11-10 Thread Brian Paul
--- docs/llvmpipe.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/llvmpipe.html b/docs/llvmpipe.html index 2efbbd4..e467692 100644 --- a/docs/llvmpipe.html +++ b/docs/llvmpipe.html @@ -108,10 +108,10 @@ To build everything on Linux invoke scons as: scons buil

[Mesa-dev] [PATCH] svga: issue debug warning for unsupported two-sided stencil state

2017-11-10 Thread Brian Paul
We only have a single stencil read mask and write mask. Issue a warning if different front/back values are used. The Piglit gl-2.0-two-sided-stencil test hits this. --- src/gallium/drivers/svga/svga_pipe_depthstencil.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/gall

[Mesa-dev] [PATCH 1/2] st/mesa: move st_init_driver_flags() earlier in file

2017-11-10 Thread Brian Paul
To get rid of forward declaration. --- src/mesa/state_tracker/st_context.c | 123 ++-- 1 file changed, 62 insertions(+), 61 deletions(-) diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c index 8abf879..c52f42b 100644 --- a/src/

[Mesa-dev] [PATCH 2/2] st/mesa: move st_manager_destroy() earlier in file

2017-11-10 Thread Brian Paul
To avoid forward declaration. --- src/mesa/state_tracker/st_manager.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c index aedbc13..8a933d4 100644 --- a/src/mesa/state_tra

Re: [Mesa-dev] [PATCH 16/17] util: Add Mesa ARB_get_program_binary helper functions

2017-11-10 Thread Jordan Justen
On 2017-11-09 19:40:40, Jordan Justen wrote: > On 2017-11-09 08:07:57, Jose Fonseca wrote: > > On 09/11/17 13:19, Emil Velikov wrote: > > > On 9 November 2017 at 06:42, Jordan Justen > > > wrote: > > >> Signed-off-by: Jordan Justen > > > Currently zlib is a dependency for !WIndows platforms. > >

Re: [Mesa-dev] [Mesa-stable] [PATCH 17/21] intel/nir: Add a helper for getting the NoIndirect mask

2017-11-10 Thread Timothy Arceri
On 11/11/17 12:28, Andres Gomez wrote: Jason, this series of nominated commits landed without mentioning any specific stable queue. From what I'm seeing, they depend on 379b24a40d3 which didn't make it for 17.2 so I'm dropping the 3 of them for that queue: 7364f080f9a272323ed3491f278a1eed3eb9b

Re: [Mesa-dev] [Mesa-stable] [PATCH 17/21] intel/nir: Add a helper for getting the NoIndirect mask

2017-11-10 Thread Andres Gomez
Jason, this series of nominated commits landed without mentioning any specific stable queue. From what I'm seeing, they depend on 379b24a40d3 which didn't make it for 17.2 so I'm dropping the 3 of them for that queue: 7364f080f9a272323ed3491f278a1eed3eb9b1a7 (intel/nir: Add a helper for getting

Re: [Mesa-dev] [PATCH] st/program: fix compute shader nir references

2017-11-10 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 11/11/17 00:46, Rob Clark wrote: In case the IR is NIR, the driver takes reference to the nir_shader. Also, because there are no variants, we need to clone the shader, instead of sharing the reference with gl_program, which would result in a double free in _mesa_d

Re: [Mesa-dev] [PATCH 3/4] util/disk_cache: Make zlib support optional

2017-11-10 Thread Jordan Justen
On 2017-11-10 16:46:32, Matt Turner wrote: > On Fri, Nov 10, 2017 at 4:44 PM, Timothy Arceri wrote: > > On 11/11/17 08:49, Jordan Justen wrote: > >> > >> On 2017-11-10 13:15:10, Matt Turner wrote: > >>> > >>> Why? > >> > >> > >> For patch 4. Patch 4 can't happen unless zlib is optional because it'

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel/fs: Use a pure vertical stride for large register strides

2017-11-10 Thread Andres Gomez
On Fri, 2017-11-10 at 16:26 -0800, Jason Ekstrand wrote: > On Fri, Nov 10, 2017 at 4:12 PM, Andres Gomez > wrote: > > Jason, having this into account, I'll leave this patch out of 17.2 > > so > > far we don't have another one that fixes this regression (?) > > This patch doesn't regress anything,

[Mesa-dev] [PATCH 2/2] intel/tools: Fix program disassembly in aubinator_error_decode.

2017-11-10 Thread Kenneth Graunke
This indexing is bogus. idx_program is the offset of the next program. At this point, we've walked through the entire batch, and accumulated all the programs. So adding it again simply skips over 100% of the programs. --- src/intel/tools/aubinator_error_decode.c | 13 ++--- 1 file change

[Mesa-dev] [PATCH 1/2] intel/tools: Fix detection of enabled shader stages.

2017-11-10 Thread Kenneth Graunke
We renamed "Function Enable" to "Enable", which broke our detection of whether shaders are enabled or not. So, we'd see a bunch of HS/DS packets with program offsets of 0, and think that was a valid TCS/TES. Fixes: c032cae9ff77e (genxml: Rename "Function Enable" to "Enable".) --- src/intel/tools

Re: [Mesa-dev] [PATCH 3/4] util/disk_cache: Make zlib support optional

2017-11-10 Thread Matt Turner
On Fri, Nov 10, 2017 at 4:44 PM, Timothy Arceri wrote: > On 11/11/17 08:49, Jordan Justen wrote: >> >> On 2017-11-10 13:15:10, Matt Turner wrote: >>> >>> Why? >> >> >> For patch 4. Patch 4 can't happen unless zlib is optional because it's >> a pain to enable zlib on windows. >> >> No surprise, but

Re: [Mesa-dev] [PATCH 3/4] util/disk_cache: Make zlib support optional

2017-11-10 Thread Timothy Arceri
On 11/11/17 08:49, Jordan Justen wrote: On 2017-11-10 13:15:10, Matt Turner wrote: Why? For patch 4. Patch 4 can't happen unless zlib is optional because it's a pain to enable zlib on windows. No surprise, but the disk cache actually works without zlib. (Of course, Tim originally implemented

Re: [Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header implementations

2017-11-10 Thread Zhang, Boyuan
-Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Christian König Sent: November-09-17 12:19 PM To: Mark Thompson; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header implementations Am 09.11.20

Re: [Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header implementations

2017-11-10 Thread Zhang, Boyuan
From: Boyuan Zhang Implement encoding of sps, pps, and silce headers using the newly added h.264 header coding descriptors functions based on h.264 specs. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.h | 1 + src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c |

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel/fs: Use a pure vertical stride for large register strides

2017-11-10 Thread Jason Ekstrand
On Fri, Nov 10, 2017 at 4:12 PM, Andres Gomez wrote: > Jason, having this into account, I'll leave this patch out of 17.2 so > far we don't have another one that fixes this regression (?) > This patch doesn't regress anything, it just isn't sufficient to fix the bug on little-core. --Jason >

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel/fs: Use a pure vertical stride for large register strides

2017-11-10 Thread Andres Gomez
Jason, having this into account, I'll leave this patch out of 17.2 so far we don't have another one that fixes this regression (?) I noticed that the patch bisected by Mark is a different one so I'm not sure I'm understanding the status, though. Let me know what you think. On Thu, 2017-11-09 at

Re: [Mesa-dev] [PATCH 05/10] nir: Use well-known power-of-two test instead of util_bitscan

2017-11-10 Thread Matt Turner
On Fri, Nov 10, 2017 at 4:02 PM, Ian Romanick wrote: > On 11/10/2017 04:54 PM, Matt Turner wrote: >> On Fri, Nov 10, 2017 at 2:32 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> This prevents the next change from breaking the build, and I felt that >>> it was different enough from the res

[Mesa-dev] [PATCH 3/3] mesa/st: add missing copyright headers to memoryobjects files

2017-11-10 Thread Andres Rodriguez
Signed-off-by: Andres Rodriguez --- src/mesa/state_tracker/st_cb_memoryobjects.c | 24 src/mesa/state_tracker/st_cb_memoryobjects.h | 24 2 files changed, 48 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_memoryobjects.c b/src/mesa/stat

[Mesa-dev] [PATCH 2/3] mesa: minor tidy up for memory object error strings

2017-11-10 Thread Andres Rodriguez
Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/src/mesa/main/externalobjects.c b/src/mesa/main/externalobjects.c index e70280c..4e9f8f8 100644 --- a/src/mesa/main/externalobje

[Mesa-dev] [PATCH 1/3] broadcom/vc4: fix indentation in vc4_screen.c

2017-11-10 Thread Andres Rodriguez
Stumbled into this when adding a new PIPE_CAP. Signed-off-by: Andres Rodriguez --- src/gallium/drivers/vc4/vc4_screen.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/vc4/vc4_screen.c b/src/gallium/drivers/vc4/vc4_screen.c index 1a9eaad.

[Mesa-dev] [PATCH 0/3] Minor tidy ups

2017-11-10 Thread Andres Rodriguez
Split off some cleanup patches from my GL_EXT_semaphore series. There are no functional changes in this series. Andres Rodriguez (3): broadcom/vc4: fix indentation in vc4_screen.c mesa: minor tidy up for memory object error strings mesa/st: add missing copyright headers to memoryobjects fil

Re: [Mesa-dev] [PATCH 05/10] nir: Use well-known power-of-two test instead of util_bitscan

2017-11-10 Thread Ian Romanick
On 11/10/2017 04:54 PM, Matt Turner wrote: > On Fri, Nov 10, 2017 at 2:32 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> This prevents the next change from breaking the build, and I felt that >> it was different enough from the rest of that patch to stand on its own. >> >> Signed-off-by: Ian

Re: [Mesa-dev] [PATCH 02/13] i965: remove ARB_compute_shader extension override

2017-11-10 Thread Jordan Justen
On 2017-11-10 08:19:38, Emil Velikov wrote: > On 7 November 2017 at 11:54, Emil Velikov wrote: > > From: Emil Velikov > > > > Checking the override was useful in the early stages of developing the > > extension. > > > > Now that everything is wired, where possible, we can drop the check. > > Doin

[Mesa-dev] [ANNOUNCE] mesa 17.2.5

2017-11-10 Thread Andres Gomez
Mesa 17.2.5 is now available. In this release we have: In Mesa Core a GL error related to the ARB_ES3_1_compatibility spec noticed with the GFXBench 5 Aztec Ruins has been corrected. The GLSL compiler is not giving a linker error for mismatching uniform precision with GLSL ES 1.00 any more. Thi

Re: [Mesa-dev] [PATCH 05/10] nir: Use well-known power-of-two test instead of util_bitscan

2017-11-10 Thread Matt Turner
On Fri, Nov 10, 2017 at 2:32 PM, Ian Romanick wrote: > From: Ian Romanick > > This prevents the next change from breaking the build, and I felt that > it was different enough from the rest of that patch to stand on its own. > > Signed-off-by: Ian Romanick > --- > src/compiler/nir/nir_validate.c

Re: [Mesa-dev] [PATCH v2] configure.ac: Define HAVE_ZLIB if zlib is found

2017-11-10 Thread Emil Velikov
On 10 November 2017 at 22:18, Jordan Justen wrote: > v2: > * Keep zlib required for autotools & meson (Emil) > > Cc: Emil Velikov > Cc: Dylan Baker > Signed-off-by: Jordan Justen > --- > configure.ac | 8 +++- > meson.build | 6 +- > 2 files changed, 12 insertions(+), 2 deletions(-)

[Mesa-dev] [PATCH 10/10] spirv: Generate SPIR-V builder infrastructure

2017-11-10 Thread Ian Romanick
From: Ian Romanick v2: Don't try to automatically set SpvCapabilityGeometry or SpvCapabilityTessellation. --- src/compiler/Makefile.sources | 2 + src/compiler/Makefile.spirv.am| 4 + src/compiler/spirv/.gitignore | 1 + src/compiler/spirv/meson.build| 7 +

[Mesa-dev] [PATCH 08/10] spirv: Move SPIR-V building to Makefile.spirv.am and spirv/meson.build

2017-11-10 Thread Ian Romanick
From: Ian Romanick Future changes will add generated files used only from src/compiler/glsl. These can't be built from Makefile.nir.am, and we can't move all the rules from Makefile.nir.am to Makefile.spirv.am (and it would be silly anyway). v2: Do it for meson too. Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 09/10] spirv: Generate code to track SPIR-V capability dependencies

2017-11-10 Thread Ian Romanick
From: Ian Romanick v2: Clean ups. Remove some functions that never ended up being used. v3: After updating spirv.core.grammar.json, fix the handling of ShaderViewportMaskNV. See the comment around line 71 of spirv_capabilities_h.py. Signed-off-by: Ian Romanick --- src/compiler/Makefile.sour

[Mesa-dev] [PATCH 05/10] nir: Use well-known power-of-two test instead of util_bitscan

2017-11-10 Thread Ian Romanick
From: Ian Romanick This prevents the next change from breaking the build, and I felt that it was different enough from the rest of that patch to stand on its own. Signed-off-by: Ian Romanick --- src/compiler/nir/nir_validate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --

[Mesa-dev] [PATCH 07/10] compiler: All leaf Makefile.am should use +=

2017-11-10 Thread Ian Romanick
From: Ian Romanick This slightly simplifies later changes that add more Makefile.*.am files. Signed-off-by: Ian Romanick --- src/compiler/Makefile.am | 1 + src/compiler/Makefile.glsl.am | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/Makefile.am b/src/c

[Mesa-dev] [PATCH 02/10] i965: Don't request GLSL IR lowering of gl_VertexID

2017-11-10 Thread Ian Romanick
From: Ian Romanick Let the lowering in NIR handle it instead. This hurts one shader that occurs twice in shader-db (SynMark GSCloth) on IVB and HSW. No other shaders or platforms were affected. total cycles in shared programs: 253438422 -> 253438426 (0.00%) cycles in affected programs: 412 ->

[Mesa-dev] [PATCH 04/10] spirv: Add SubgroupBallotKHR capability to SubgroupSize and SubgroupLocalInvocationId

2017-11-10 Thread Ian Romanick
From: Ian Romanick The SPV_KHR_shader_ballot spec says: (Add the SubgroupBallotKHR capability to SubgroupSize.) (Add the SubgroupBallotKHR capability to SubgroupLocalInvocationId.) Yet the annotations are missing from the JSON. See also https://github.com/KhronosGroup/SPIRV-Headers/is

[Mesa-dev] [PATCH 06/10] util: Include bitscan.h directly

2017-11-10 Thread Ian Romanick
From: Ian Romanick Previously bitset.h would include u_math.h to get bitscan.h. u_math.h lives in src/gallium/auxiliary/util while both bitset.h and bitscan.h live in src/util. Having the one file directly include another file that lives in the same directory makes much more sense. As a side-e

[Mesa-dev] [PATCH 03/10] spirv: Import the latest 1.0.12 header and JSON from Khronos

2017-11-10 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/spirv/spirv.core.grammar.json | 417 - src/compiler/spirv/spirv.h | 56 ++-- 2 files changed, 201 insertions(+), 272 deletions(-) diff --git a/src/compiler/spirv/spirv.core.grammar.json

[Mesa-dev] [PATCH 01/10] i965: Silence "enumeral and non-enumeral type in conditional expression" warnings

2017-11-10 Thread Ian Romanick
From: Ian Romanick compiler/brw_inst.h: In function ‘brw_reg_type brw_inst_dst_type(const gen_device_info*, const brw_inst*)’: compiler/brw_inst.h:801:55: warning: enumeral and non-enumeral type in conditional expression [-Wextra] unsigned file = __builtin_strcmp("dst", #reg) == 0 ?

[Mesa-dev] [PATCH 00/10] The first of the real SPIR-V work

2017-11-10 Thread Ian Romanick
This is the first block of patches to enable generating SPIR-V from Mesa's GLSL compiler. The initial use of this is for testing GL_ARB_spirv, but it may eventually be useful in its own right. A lot more work will be necessary for that to happen, though. Most of the work is done, but there are s

[Mesa-dev] [Bug 102891] [radv] glitches on rpcs3 emulator (green zones)

2017-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102891 --- Comment #9 from jdr...@gmail.com --- Created attachment 135388 --> https://bugs.freedesktop.org/attachment.cgi?id=135388&action=edit new qrenderdoc capture I did an export RADV_DEBUG=zerovram before running qrenderdoc, but as I'm on mesa 1

Re: [Mesa-dev] [PATCH 2/2] anv/gen10: Enable float blend optimization

2017-11-10 Thread Anuj Phogat
On Fri, Nov 10, 2017 at 8:42 AM, Rafael Antognolli wrote: > On Thu, Nov 09, 2017 at 11:14:43AM -0800, Anuj Phogat wrote: >> On CNL this bit has been moved to CACHE_MODE_SS register. >> We already have this enabled in OpenGL driver. >> See Mesa commit 6c681b4cc1 >> >> Signed-off-by: Anuj Phogat >>

Re: [Mesa-dev] add util_queue_fence_wait_timeout checkin breaks centos6 build

2017-11-10 Thread Kyriazis, George
Hmm.. Looking at /usr/include/time.h on ubuntu, I see the following: #if (!defined __timespec_defined\ && ((defined _TIME_H \ && (defined __USE_POSIX199309 \

[Mesa-dev] [PATCH v2] configure.ac: Define HAVE_ZLIB if zlib is found

2017-11-10 Thread Jordan Justen
v2: * Keep zlib required for autotools & meson (Emil) Cc: Emil Velikov Cc: Dylan Baker Signed-off-by: Jordan Justen --- configure.ac | 8 +++- meson.build | 6 +- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 411c4f6b3e0..5db39e5a68

Re: [Mesa-dev] [PATCH] i965/gen10: Use the correct form of | for the RCPFE workaround

2017-11-10 Thread Anuj Phogat
On Fri, Nov 10, 2017 at 1:39 PM, Jason Ekstrand wrote: > Found by inspection > > Fixes: d3d0fe4572f62474b86ef3a68405046c68b54062 > Cc: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_pipe_control.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH 3/4] util/disk_cache: Make zlib support optional

2017-11-10 Thread Jordan Justen
On 2017-11-10 13:15:10, Matt Turner wrote: > Why? For patch 4. Patch 4 can't happen unless zlib is optional because it's a pain to enable zlib on windows. No surprise, but the disk cache actually works without zlib. (Of course, Tim originally implemented it without compression.) -Jordan

Re: [Mesa-dev] [PATCH] i965/gen10: Use the correct form of | for the RCPFE workaround

2017-11-10 Thread Rafael Antognolli
It seems I missed that one when reviewing before, thank you. Reviewed-by: Rafael Antognolli On Fri, Nov 10, 2017 at 01:39:22PM -0800, Jason Ekstrand wrote: > Found by inspection > > Fixes: d3d0fe4572f62474b86ef3a68405046c68b54062 > Cc: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_pipe_co

[Mesa-dev] [PATCH] i965/gen10: Use the correct form of | for the RCPFE workaround

2017-11-10 Thread Jason Ekstrand
Found by inspection Fixes: d3d0fe4572f62474b86ef3a68405046c68b54062 Cc: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_pipe_control.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_pipe_control.c b/src/mesa/drivers/dri/i965/brw_pipe_control.

[Mesa-dev] [PATCH] i965/gen10: Use the correct form of | for the RCPFE workaround

2017-11-10 Thread Jason Ekstrand
Found by inspection Cc: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_pipe_control.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_pipe_control.c b/src/mesa/drivers/dri/i965/brw_pipe_control.c index f5a9915..bae4ba7 100644 --- a/src/mesa/d

Re: [Mesa-dev] [PATCH 3/4] util/disk_cache: Make zlib support optional

2017-11-10 Thread Matt Turner
Why? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/5] Volatile and invariant LDS memory ops

2017-11-10 Thread Nicolai Hähnle
On 10.11.2017 19:24, Connor Abbott wrote: On Fri, Nov 10, 2017 at 1:19 PM, Marek Olšák wrote: On Fri, Nov 10, 2017 at 6:55 PM, Nicolai Hähnle wrote: On 10.11.2017 18:43, Marek Olšák wrote: On Fri, Nov 10, 2017 at 2:09 AM, Connor Abbott wrote: On Thu, Nov 9, 2017 at 7:17 PM, Marek Olšák

Re: [Mesa-dev] add util_queue_fence_wait_timeout checkin breaks centos6 build

2017-11-10 Thread Nicolai Hähnle
On 10.11.2017 19:20, Kyriazis, George wrote: Hello Nicolai, Your commit e3a8013 (util/u_queue: add util_queue_fence_wait_timeout), breaks the centos6 build. Specifically, I am getting: CC libmesautil_la-u_queue.lo ../../../src/util/u_queue.c: In function '_util_queue_fence_wait_timeout

Re: [Mesa-dev] [PATCH] st/dri: fix deadlock when waiting on android fences

2017-11-10 Thread Nicolai Hähnle
On 10.11.2017 19:10, Marek Olšák wrote: From: Marek Olšák Android fences can't be deferred, because st/dri calls fence_finish with ctx = NULL, so the driver can't flush u_threaded_context. Reviewed-by: Nicolai Hähnle --- src/gallium/include/state_tracker/st_api.h | 3 +-- src/gallium

Re: [Mesa-dev] [PATCH 1/4] configure.ac: Define HAVE_ZLIB if zlib is found

2017-11-10 Thread Jordan Justen
On 2017-11-10 11:38:08, Emil Velikov wrote: > On 10 November 2017 at 19:34, Emil Velikov wrote: > > On 10 November 2017 at 18:38, Dylan Baker wrote: > >> Quoting Jordan Justen (2017-11-10 10:24:36) > >>> Cc: Emil Velikov > >>> Cc: Dylan Baker > >>> Signed-off-by: Jordan Justen > >>> --- > >>>

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Make L3 configuration atom listen for TCS/TES program updates.

2017-11-10 Thread Francisco Jerez
Kenneth Graunke writes: > The L3 configuration code already considers the TCS and TES programs, > but failed to listen for TCS/TES program changes. > > This was somehow missing. > > Cc: mesa-sta...@lists.freedesktop.org Fixes: e9644cb1f96ccf7e155af09e90f6a7888f609a2d Reviewed-by: Francisco Jerez

Re: [Mesa-dev] [PATCH 5/5] meson: build gallium-xlib based glx

2017-11-10 Thread Eric Anholt
Dylan Baker writes: > [ Unknown signature status ] > Quoting Eric Anholt (2017-11-08 13:26:12) >> We shouldn't have to manually specify most of these deps, I think, since >> they should be transitively pulled in by the static libraries using >> them, right? It's fine either way, though. >> >> >

Re: [Mesa-dev] [PATCH 1/4] configure.ac: Define HAVE_ZLIB if zlib is found

2017-11-10 Thread Dylan Baker
Quoting Jordan Justen (2017-11-10 11:43:45) > On 2017-11-10 10:38:19, Dylan Baker wrote: > > Quoting Jordan Justen (2017-11-10 10:24:36) > > > Cc: Emil Velikov > > > Cc: Dylan Baker > > > Signed-off-by: Jordan Justen > > > --- > > > configure.ac | 6 +- > > > meson.build | 6 +- > > >

Re: [Mesa-dev] [PATCH 1/4] configure.ac: Define HAVE_ZLIB if zlib is found

2017-11-10 Thread Jordan Justen
On 2017-11-10 10:38:19, Dylan Baker wrote: > Quoting Jordan Justen (2017-11-10 10:24:36) > > Cc: Emil Velikov > > Cc: Dylan Baker > > Signed-off-by: Jordan Justen > > --- > > configure.ac | 6 +- > > meson.build | 6 +- > > 2 files changed, 10 insertions(+), 2 deletions(-) > > > > dif

Re: [Mesa-dev] [PATCH 1/4] configure.ac: Define HAVE_ZLIB if zlib is found

2017-11-10 Thread Emil Velikov
On 10 November 2017 at 19:34, Emil Velikov wrote: > On 10 November 2017 at 18:38, Dylan Baker wrote: >> Quoting Jordan Justen (2017-11-10 10:24:36) >>> Cc: Emil Velikov >>> Cc: Dylan Baker >>> Signed-off-by: Jordan Justen >>> --- >>> configure.ac | 6 +- >>> meson.build | 6 +- >>> 2

Re: [Mesa-dev] [PATCH 1/4] configure.ac: Define HAVE_ZLIB if zlib is found

2017-11-10 Thread Emil Velikov
On 10 November 2017 at 18:38, Dylan Baker wrote: > Quoting Jordan Justen (2017-11-10 10:24:36) >> Cc: Emil Velikov >> Cc: Dylan Baker >> Signed-off-by: Jordan Justen >> --- >> configure.ac | 6 +- >> meson.build | 6 +- >> 2 files changed, 10 insertions(+), 2 deletions(-) >> >> diff -

Re: [Mesa-dev] [PATCH 01/17] docs/specs: Add GL_MESA_program_binary_formats extension spec

2017-11-10 Thread Ian Romanick
Reviewed-by: Ian Romanick On November 10, 2017 12:17:38 PM Jordan Justen wrote: On 2017-11-10 08:43:37, Ian Romanick wrote: The one thing I would add is an issues section with a single issue about the decision to use a single enum for everything. How does this sound? diff --git a/docs

Re: [Mesa-dev] [PATCH] anv: don't crash when creating a huge image

2017-11-10 Thread Jason Ekstrand
On Fri, Nov 10, 2017 at 10:48 AM, Chad Versace wrote: > On Thu 09 Nov 2017, Jason Ekstrand wrote: > > On Thu, Nov 9, 2017 at 4:23 PM, Chad Versace <[1] > chadvers...@chromium.org> > > wrote: > > > > On Wed 08 Nov 2017, Jason Ekstrand wrote: > > > On Wed, Nov 8, 2017 at 1:34 AM, Samuel Igl

[Mesa-dev] [Bug 103412] gallium/wgl: Another fix to context creation without prior SetPixelFormat()

2017-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103412 --- Comment #1 from Brian Paul --- Thanks. Looks good AFAICT. I'll do a little reformatting and testing before pushing. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

Re: [Mesa-dev] [PATCH] gallium/xlib: remove GL_{MAJOR,MINOR,TINY}

2017-11-10 Thread Brian Paul
On 11/10/2017 11:08 AM, Emil Velikov wrote: On 10 November 2017 at 17:53, Dylan Baker wrote: These variables were removed from autotools in 2008 (sha: 80f68e1b6a0e5bd2da799c), but they have lived on here. The Scons build meanwhile doesn't set a patch/tiny version at all, just major and minor. T

Re: [Mesa-dev] [PATCH] anv: don't crash when creating a huge image

2017-11-10 Thread Chad Versace
On Thu 09 Nov 2017, Jason Ekstrand wrote: > On Thu, Nov 9, 2017 at 4:23 PM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Wed 08 Nov 2017, Jason Ekstrand wrote: > > On Wed, Nov 8, 2017 at 1:34 AM, Samuel Iglesias Gonsálvez <[1] > > [2]sigles...@igalia.com> wrote: > > >

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-10 Thread Jon Turney
On 10/11/2017 15:42, Nicolai Hähnle wrote: On 10.11.2017 14:00, Jon Turney wrote: On 09/11/2017 21:41, Nicolai Hähnle wrote: Sorry for the mess. I'm going to suggest that the fallback declaration of timespec_get() also needs to be provided for POSIX systems which don't have it. Not noticed

Re: [Mesa-dev] [PATCH 1/4] configure.ac: Define HAVE_ZLIB if zlib is found

2017-11-10 Thread Dylan Baker
Quoting Jordan Justen (2017-11-10 10:24:36) > Cc: Emil Velikov > Cc: Dylan Baker > Signed-off-by: Jordan Justen > --- > configure.ac | 6 +- > meson.build | 6 +- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 411c4f6b3e0..213c

[Mesa-dev] [Bug 103674] u_queue.c:173:7: error: implicit declaration of function 'timespec_get' is invalid in C99

2017-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103674 Bug ID: 103674 Summary: u_queue.c:173:7: error: implicit declaration of function 'timespec_get' is invalid in C99 Product: Mesa Version: git Hardware: x86-64 (AMD64)

[Mesa-dev] [Bug 103671] os_time.c:104:4: error: implicit declaration of function 'usleep' is invalid in C99

2017-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103671 Vinson Lee changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 103671] os_time.c:104:4: error: implicit declaration of function 'usleep' is invalid in C99

2017-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103671 Jon Turney changed: What|Removed |Added CC||jon.tur...@dronecode.org.uk --- Comment #1

[Mesa-dev] [PATCH 4/4] compiler: Fold shader_cache in with libglsl sources

2017-11-10 Thread Jordan Justen
It appears that we include the shader cache sources into libglsl regardless. The Meson build already does this. Signed-off-by: Jordan Justen --- src/compiler/Android.glsl.mk | 3 +-- src/compiler/Makefile.glsl.am | 3 +-- src/compiler/Makefile.sources | 6 ++ 3 files changed, 4 insertions(

[Mesa-dev] [PATCH 3/4] util/disk_cache: Make zlib support optional

2017-11-10 Thread Jordan Justen
Cc: Timothy Arceri Signed-off-by: Jordan Justen --- src/util/disk_cache.c | 129 ++ 1 file changed, 15 insertions(+), 114 deletions(-) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index fde6e2e0974..911ca8f9234 100644 --- a/src/util/

[Mesa-dev] [PATCH 2/4] util: Add u_zlib zlib wrappers

2017-11-10 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/util/Makefile.sources | 4 +- src/util/meson.build | 2 + src/util/u_zlib.c | 154 ++ src/util/u_zlib.h | 50 +++ 4 files changed, 209 insertions(+), 1 deletion(-) create mode 1

Re: [Mesa-dev] [PATCH 0/5] Volatile and invariant LDS memory ops

2017-11-10 Thread Connor Abbott
On Fri, Nov 10, 2017 at 1:19 PM, Marek Olšák wrote: > On Fri, Nov 10, 2017 at 6:55 PM, Nicolai Hähnle wrote: >> On 10.11.2017 18:43, Marek Olšák wrote: >>> >>> On Fri, Nov 10, 2017 at 2:09 AM, Connor Abbott >>> wrote: On Thu, Nov 9, 2017 at 7:17 PM, Marek Olšák wrote: > > On F

[Mesa-dev] [PATCH 1/4] configure.ac: Define HAVE_ZLIB if zlib is found

2017-11-10 Thread Jordan Justen
Cc: Emil Velikov Cc: Dylan Baker Signed-off-by: Jordan Justen --- configure.ac | 6 +- meson.build | 6 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 411c4f6b3e0..213cfe132fb 100644 --- a/configure.ac +++ b/configure.ac @@ -900,7 +

Re: [Mesa-dev] [PATCH] meson: don't us build_by_default for specific gallium drivers

2017-11-10 Thread Lionel Landwerlin
Fixes a build issue with gallium headers trying to include llvm ones (which I don't have installed). Thanks! Tested-by: Lionel Landwerlin On 10/11/17 17:23, Dylan Baker wrote: Using build_by_default : false is convenient for dependencies that can be pulled in by various diverse components of

[Mesa-dev] add util_queue_fence_wait_timeout checkin breaks centos6 build

2017-11-10 Thread Kyriazis, George
Hello Nicolai, Your commit e3a8013 (util/u_queue: add util_queue_fence_wait_timeout), breaks the centos6 build. Specifically, I am getting: CC libmesautil_la-u_queue.lo ../../../src/util/u_queue.c: In function '_util_queue_fence_wait_timeout': ../../../src/util/u_queue.c:173:7: error: imp

Re: [Mesa-dev] [PATCH 0/5] Volatile and invariant LDS memory ops

2017-11-10 Thread Marek Olšák
On Fri, Nov 10, 2017 at 6:55 PM, Nicolai Hähnle wrote: > On 10.11.2017 18:43, Marek Olšák wrote: >> >> On Fri, Nov 10, 2017 at 2:09 AM, Connor Abbott >> wrote: >>> >>> On Thu, Nov 9, 2017 at 7:17 PM, Marek Olšák wrote: On Fri, Nov 10, 2017 at 12:40 AM, Matt Arsenault wrote: >

Re: [Mesa-dev] [PATCH 01/17] docs/specs: Add GL_MESA_program_binary_formats extension spec

2017-11-10 Thread Jordan Justen
On 2017-11-10 08:43:37, Ian Romanick wrote: > > The one thing I would add is an issues section with a single issue about > the decision to use a single enum for everything. How does this sound? diff --git a/docs/specs/MESA_program_binary_formats.txt b/docs/specs/MESA_program_binary_formats.txt

[Mesa-dev] [PATCH] st/dri: fix deadlock when waiting on android fences

2017-11-10 Thread Marek Olšák
From: Marek Olšák Android fences can't be deferred, because st/dri calls fence_finish with ctx = NULL, so the driver can't flush u_threaded_context. --- src/gallium/include/state_tracker/st_api.h | 3 +-- src/gallium/state_trackers/dri/dri_helpers.c | 3 +-- src/mesa/state_tracker/st_manager.c

Re: [Mesa-dev] [PATCH 0/9] Fix shader_draw_parameters CTS tests

2017-11-10 Thread Neil Roberts
Just to note, I made some Piglit patches to verify this new behaviour too: https://patchwork.freedesktop.org/series/33626/ This might make testing a little easier if someone wants to implement the behaviour for other drivers too. - Neil Antia Puentes writes: > Hi, > > the series sets gl_BaseV

Re: [Mesa-dev] [PATCH] gallium/xlib: remove GL_{MAJOR,MINOR,TINY}

2017-11-10 Thread Emil Velikov
On 10 November 2017 at 17:53, Dylan Baker wrote: > These variables were removed from autotools in 2008 (sha: > 80f68e1b6a0e5bd2da799c), but they have lived on here. The Scons build > meanwhile doesn't set a patch/tiny version at all, just major and minor. > This patch removes the unused variables

Re: [Mesa-dev] [PATCH] meson: don't us build_by_default for specific gallium drivers

2017-11-10 Thread Dylan Baker
If fixed the typo in the subject locally. Quoting Dylan Baker (2017-11-10 09:23:37) > Using build_by_default : false is convenient for dependencies that can > be pulled in by various diverse components of the build system, the > gallium hardware/software drivers and state trackers do not fit that

Re: [Mesa-dev] [PATCH] gallium/xlib: remove GL_{MAJOR,MINOR,TINY}

2017-11-10 Thread Brian Paul
On 11/10/2017 10:53 AM, Dylan Baker wrote: These variables were removed from autotools in 2008 (sha: 80f68e1b6a0e5bd2da799c), but they have lived on here. The Scons build meanwhile doesn't set a patch/tiny version at all, just major and minor. This patch removes the unused variables and simply se

Re: [Mesa-dev] [PATCH 0/5] Volatile and invariant LDS memory ops

2017-11-10 Thread Nicolai Hähnle
On 10.11.2017 18:43, Marek Olšák wrote: On Fri, Nov 10, 2017 at 2:09 AM, Connor Abbott wrote: On Thu, Nov 9, 2017 at 7:17 PM, Marek Olšák wrote: On Fri, Nov 10, 2017 at 12:40 AM, Matt Arsenault wrote: On Nov 10, 2017, at 07:41, Marek Olšák wrote: Hi, This fixes the TCS gl_ClipDistance

[Mesa-dev] [PATCH] gallium/xlib: remove GL_{MAJOR,MINOR,TINY}

2017-11-10 Thread Dylan Baker
These variables were removed from autotools in 2008 (sha: 80f68e1b6a0e5bd2da799c), but they have lived on here. The Scons build meanwhile doesn't set a patch/tiny version at all, just major and minor. This patch removes the unused variables and simply sets the version, leaving patch/tiny as 0 since

[Mesa-dev] [PATCH 9/9] spirv: Lower BaseVertex to BASE_VERTEX_ID instead of BASE_VERTEX

2017-11-10 Thread Antia Puentes
From: Neil Roberts The base vertex in Vulkan is different from GL in that for non-indexed primitives the value is taken from the firstVertex parameter instead of being set to zero. This coincides with the new SYSTEM_VALUE_BASE_VERTEX_ID instead of BASE_VERTEX. --- src/compiler/spirv/vtn_variable

[Mesa-dev] [PATCH 8/9] i965: Let nir lower gl_VertexID instead of the linker

2017-11-10 Thread Antia Puentes
From: Neil Roberts --- src/mesa/drivers/dri/i965/brw_context.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 19d5a2e3503..01c8e8cb3cf 100644 --- a/src/mesa/drivers/dri/i965/brw_contex

[Mesa-dev] [PATCH 5/9] i965: gl_BaseVertex must be zero for non-indexed draw calls

2017-11-10 Thread Antia Puentes
- From the OpenGL 4.6 (11.1.3.9 Shader Inputs) specification: "gl_BaseVertex holds the integer value passed to the baseVertex parameter to the command that resulted in the current shader invocation. In the case where the command has no baseVertex parameter, the value of gl_BaseVertex is zero." -

[Mesa-dev] [PATCH 3/9] intel/compiler: Add a uses_basevertexid flag

2017-11-10 Thread Antia Puentes
From: Neil Roberts --- src/intel/compiler/brw_compiler.h | 1 + src/intel/compiler/brw_vec4.cpp | 4 2 files changed, 5 insertions(+) diff --git a/src/intel/compiler/brw_compiler.h b/src/intel/compiler/brw_compiler.h index df6ee018546..6b5b73a54f0 100644 --- a/src/intel/compiler/brw_com

[Mesa-dev] [PATCH 4/9] i965: emit basevertexid as a vertex element component

2017-11-10 Thread Antia Puentes
The new basevertexid will be emitted in the position previously occupied by gl_BaseVertex. This way we can keep pointing the indirect buffer for indirect draw calls. The gl_BaseVertex is now emited as part of the draw_id VERTEX_ELEMENT. Reviewed-by: Neil Roberts --- src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH 7/9] nir: Offset vertex_id by base_vertex_id instead of base_vertex

2017-11-10 Thread Antia Puentes
From: Neil Roberts base_vertex will be zero for non-indexed calls, but we need it to include the ‘first’ parameter. This is true for both GL and Vulkan. I think this patch will also affect freedreno and radeonsi. I believe if they are relying on this lowering then they are currently already brok

[Mesa-dev] [PATCH 1/9] compiler: Add new system value SYSTEM_VALUE_BASE_VERTEX_ID

2017-11-10 Thread Antia Puentes
This VS system value will contain the value passed as for indexed draw calls or the value passed as for non-indexed draw calls. It will be used to calculate the gl_VertexID as SYSTEM_VALUE_VERTEX_ID_ZERO_BASE plus SYSTEM_VALUE_BASE_VERTEX_ID. Note that the current calculation which uses SYSTEM_VA

[Mesa-dev] [PATCH 0/9] Fix shader_draw_parameters CTS tests

2017-11-10 Thread Antia Puentes
Hi, the series sets gl_BaseVertex to zero for gl*DrawArrays* in i965. Previously, its value was the value passed as in the non-indexed draw call. This was convinient because the gl_VertexID was calculated as gl_VertexIDBaseZero + gl_BaseVertex. However, as gl_BaseVertex must be zero for non-inde

[Mesa-dev] [PATCH 6/9] intel/compiler: implement the basevertex(id) load intrinsics

2017-11-10 Thread Antia Puentes
The gl_BaseVertex is in a new location now, and the new basevertexid occupies the old gl_BaseVertex place. Reviewed-by: Neil Roberts --- src/intel/compiler/brw_nir.c| 12 src/intel/compiler/brw_vec4.cpp | 14 -- 2 files changed, 16 insertions(+), 10 deletions(-) dif

[Mesa-dev] [PATCH 2/9] nir: Add SYSTEM_VALUE_BASE_VERTEX_ID instrinsics

2017-11-10 Thread Antia Puentes
Reviewed-by: Neil Roberts --- src/compiler/nir/nir.c | 4 src/compiler/nir/nir_gather_info.c | 1 + src/compiler/nir/nir_intrinsics.h | 1 + 3 files changed, 6 insertions(+) diff --git a/src/compiler/nir/nir.c b/src/compiler/nir/nir.c index 7380bf436a8..6f0477b0676 100644 --- a

  1   2   >