https://bugs.freedesktop.org/show_bug.cgi?id=101336
--- Comment #3 from Iago Toral ---
Link to patch:
https://lists.freedesktop.org/archives/mesa-dev/2017-June/158361.html
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.__
With commit f7741985be0234 the we have changed some preprocessor
error messages and warnings. Adapt related glcpp tests
expectations accoridngly.
---
src/compiler/glsl/glcpp/tests/120-undef-builtin.c.expected | 6 +++---
src/compiler/glsl/glcpp/tests/147-undef-builtin-allowed.c.expected |
On 06/08/2017 06:05 AM, Tomasz Figa wrote:
On Wed, Jun 7, 2017 at 5:36 AM, Chad Versace wrote:
More patches to break your formats... again ;)
The Android framework requires support for EGLConfigs with
HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORMAT_RGBA_. This prevents
Chrome OS from upd
https://bugs.freedesktop.org/show_bug.cgi?id=101336
--- Comment #2 from Iago Toral ---
Yes, my commit modified slightly the error messages, I'll send a patch with to
update the test to the new output. Thanks for letting me know.
--
You are receiving this mail because:
You are the QA Contact for
---
src/mesa/vbo/vbo_exec_array.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c
index 437d260..4f86d19 100644
--- a/src/mesa/vbo/vbo_exec_array.c
+++ b/src/mesa/vbo/vbo_exec_array.c
@@ -941,23 +941,3
argh, how did that get there ...
Reviewed-by: Tapani Pälli
On 06/08/2017 05:00 AM, Rob Herring wrote:
Commit 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to
src/vulkan/util") broke the Android build with the following error:
build/core/binary.mk:1427: error: external/mesa3d/src/vulkan/An
On Wed, Jun 7, 2017 at 9:15 PM, Michel Dänzer wrote:
> On 08/06/17 03:42 AM, Marek Olšák wrote:
>> On Wed, Jun 7, 2017 at 4:10 PM, Aaron Watry wrote:
>>> On Mon, Jun 5, 2017 at 3:07 PM, Marek Olšák wrote:
Can you make the change in radeon_drm_winsys.c instead?
>>>
>>> Something like th
Reviewed-by: Brian Paul
On 06/07/2017 05:39 PM, Timothy Arceri wrote:
The code comment which seems to have been added in cab974cf6c2db
(from year 2000) says:
"Set ctx->NewState to zero to avoid recursion if
Driver.UpdateState() has to call FLUSH_VERTICES(). (fixed?)"
As far as I can
From: Dave Airlie
We don't want vtx/tex instructions ending up in GDS sections.
Signed-off-by: Dave Airlie
---
src/gallium/drivers/r600/r600_asm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/r600/r600_asm.c
b/src/gallium/drivers/r600/r600_asm.c
From: Dave Airlie
This just makes sure we can see the index gpr in the asm dumps.
Signed-off-by: Dave Airlie
---
src/gallium/drivers/r600/r600_asm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/r600/r600_asm.c
b/src/gallium/drivers/r600/r600_asm.c
From: Dave Airlie
This adds support for the GDS operations needed to do atomic
counters.
Signed-off-by: Dave Airlie
---
src/gallium/drivers/r600/eg_asm.c | 15 ---
src/gallium/drivers/r600/r600_asm.c | 10 ++
src/gallium/drivers/r600/r600_asm.h | 4
3 files changed,
From: Dave Airlie
On evergreen we can route vertex fetches via the texture cache,
and this is required for some images support. So add support
to the asm builder for it.
Signed-off-by: Dave Airlie
---
src/gallium/drivers/r600/r600_asm.c | 20 ++--
src/gallium/drivers/r600/r600_
From: Dave Airlie
This was found during writing the images code, we need to
make sure we route the correct index register.
Signed-off-by: Dave Airlie
---
src/gallium/drivers/r600/r600_asm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/r600/r600_asm.c
These are just some minor prelim patches for the GL4.3 work, that
looked easy to split out.
Dave.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
From: Dave Airlie
This overhauls the copy prop and dead code passes to avoid
major CPU overhead in some corner cases trigged by the fp64 patches
v2: fix level not being updated correctly
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 123 +
1 file changed, 109 inse
On 08/06/17 12:04, Michel Dänzer wrote:
On 08/06/17 05:09 AM, Marek Olšák wrote:
From: Marek Olšák
If you want to keep it for your driver, please raise your hand.
The prefix will probably have to be added into the driver instead of here.
I cringe when I look at my long renderer string:
Gal
On Wed, Jun 7, 2017 at 5:36 AM, Chad Versace wrote:
> More patches to break your formats... again ;)
>
> The Android framework requires support for EGLConfigs with
> HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORMAT_RGBA_. This prevents
> Chrome OS from updating its Android drivers, because earl
On 08/06/17 03:42 AM, Marek Olšák wrote:
> On Wed, Jun 7, 2017 at 4:10 PM, Aaron Watry wrote:
>> On Mon, Jun 5, 2017 at 3:07 PM, Marek Olšák wrote:
>>>
>>> Can you make the change in radeon_drm_winsys.c instead?
>>
>> Something like the following?
>>
>> diff --git a/src/gallium/winsys/radeon/drm/
On 08/06/17 05:09 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> If you want to keep it for your driver, please raise your hand.
> The prefix will probably have to be added into the driver instead of here.
>
> I cringe when I look at my long renderer string:
> Gallium 0.4 on AMD Radeon R9 Fury
Commit 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to
src/vulkan/util") broke the Android build with the following error:
build/core/binary.mk:1427: error: external/mesa3d/src/vulkan/Android.mk:
libmesa_vulkan_util: Unused source files: util/vk_util.h).
Fixes: 621b3410f5f8 ("util/vulkan: M
https://bugs.freedesktop.org/show_bug.cgi?id=101338
Bug ID: 101338
Summary: Mesa software rendering draws incompletely on
Raspberry Pi
Product: Mesa
Version: unspecified
Hardware: Other
OS: All
S
On Tue 06 Jun 2017, Daniel Stone wrote:
> Hi Chad,
>
> On 6 June 2017 at 21:36, Chad Versace wrote:
> > @@ -254,8 +255,22 @@ create_mt_for_dri_image(struct brw_context *brw,
> > struct gl_context *ctx = &brw->ctx;
> > struct intel_mipmap_tree *mt;
> > uint32_t draw_x, draw_y;
> > +
The code comment which seems to have been added in cab974cf6c2db
(from year 2000) says:
"Set ctx->NewState to zero to avoid recursion if
Driver.UpdateState() has to call FLUSH_VERTICES(). (fixed?)"
As far as I can tell nothing in any of the UpdateState() calls
should cause it to be called
On 08/06/17 00:58, Brian Paul wrote:
On 06/07/2017 12:01 AM, Timothy Arceri wrote:
As far as I can tell this shouldn't do anything as we were just
passing a state of 0.
---
src/mesa/drivers/osmesa/osmesa.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/mesa/drivers/osmesa/osmesa.c
On June 7, 2017 3:22:33 PM Chad Versace wrote:
On Fri 26 May 2017, Jason Ekstrand wrote:
This patch series does a complete overhaul of the current resolve handling
framework inside the i916 OpenGL driver.
I've ran out of time to review the remainder of the series.
:-( Thanks for all the t
On Tue 06 Jun 2017, Dylan Baker wrote:
> Quoting Chad Versace (2017-06-06 15:11:18)
> > On Tue 06 Jun 2017, Dylan Baker wrote:
> > > Quoting Chad Versace (2017-06-06 13:36:55)
> > > > +write_preamble(stdout)
> > > > +write_func_mesa_format_fallback_rgbx_to_rgba(stdout, formats)
> > >
> >
On Fri 26 May 2017, Jason Ekstrand wrote:
> This patch series does a complete overhaul of the current resolve handling
> framework inside the i916 OpenGL driver.
I've ran out of time to review the remainder of the series. I believe
I skipped patches 24-30. You can add my acked-by to those patches
https://bugs.freedesktop.org/show_bug.cgi?id=101336
Vinson Lee changed:
What|Removed |Added
Keywords||bisected
CC|
On Wed, Jun 7, 2017 at 4:42 PM, Ilia Mirkin wrote:
> On Wed, Jun 7, 2017 at 4:34 PM, Marek Olšák wrote:
>> On Wed, Jun 7, 2017 at 10:28 PM, Ilia Mirkin wrote:
>>> On Wed, Jun 7, 2017 at 4:22 PM, Marek Olšák wrote:
On Wed, Jun 7, 2017 at 10:12 PM, Ilia Mirkin wrote:
> This creates stri
On Wed, Jun 7, 2017 at 4:34 PM, Marek Olšák wrote:
> On Wed, Jun 7, 2017 at 10:28 PM, Ilia Mirkin wrote:
>> On Wed, Jun 7, 2017 at 4:22 PM, Marek Olšák wrote:
>>> On Wed, Jun 7, 2017 at 10:12 PM, Ilia Mirkin wrote:
This creates string lifetime issues... should probably document that
t
https://bugs.freedesktop.org/show_bug.cgi?id=101336
Bug ID: 101336
Summary: glcpp-test.sh regression
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: All
Status: NEW
Keywords: regression
S
On Wed, Jun 7, 2017 at 10:28 PM, Ilia Mirkin wrote:
> On Wed, Jun 7, 2017 at 4:22 PM, Marek Olšák wrote:
>> On Wed, Jun 7, 2017 at 10:12 PM, Ilia Mirkin wrote:
>>> This creates string lifetime issues... should probably document that
>>> the pointer returned by get_vendor and get_name are suppose
On 06/07/2017 10:23 PM, Marek Olšák wrote:
On Wed, Jun 7, 2017 at 10:21 PM, Samuel Pitoiset
wrote:
You don't want to have a static verifier or something for correctness? :)
I don't know how to have a static verifier. The risk of breaking
something is high, but it should also be obvious (hop
On Wed, Jun 7, 2017 at 4:22 PM, Marek Olšák wrote:
> On Wed, Jun 7, 2017 at 10:12 PM, Ilia Mirkin wrote:
>> This creates string lifetime issues... should probably document that
>> the pointer returned by get_vendor and get_name are supposed to last
>> for the lifetime of the screen.
>
> Was the l
On Wed, Jun 7, 2017 at 10:22 PM, Samuel Pitoiset
wrote:
>
>
> On 06/07/2017 09:50 PM, Marek Olšák wrote:
>>
>> From: Marek Olšák
>>
>> ---
>> src/gallium/drivers/radeonsi/si_blit.c| 12 -
>> src/gallium/drivers/radeonsi/si_descriptors.c | 38
>> +--
>>
On Wed, Jun 7, 2017 at 10:21 PM, Samuel Pitoiset
wrote:
> You don't want to have a static verifier or something for correctness? :)
I don't know how to have a static verifier. The risk of breaking
something is high, but it should also be obvious (hopefully).
Marek
___
On Wed, Jun 7, 2017 at 10:12 PM, Ilia Mirkin wrote:
> This creates string lifetime issues... should probably document that
> the pointer returned by get_vendor and get_name are supposed to last
> for the lifetime of the screen.
Was the lifetime of the string not always guaranteed?
Most drivers u
On 06/07/2017 09:50 PM, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_blit.c| 12 -
src/gallium/drivers/radeonsi/si_descriptors.c | 38 +--
src/gallium/drivers/radeonsi/si_pipe.h| 6 ++---
3 files changed, 28 ins
You don't want to have a static verifier or something for correctness? :)
On 06/07/2017 09:50 PM, Marek Olšák wrote:
From: Marek Olšák
This and the previous commit decrease IB sizes and the number of
si_update_shaders invocations as follows:
IB size si_update_shaders calls
Yeah, this will help bindless a little bit because the winsys overhead
becomes high with a huge buffers list. Though, there is not a ton of
HTILE buffers.
A little comment on patch 4.
Patches 3-6 are:
Reviewed-by: Samuel Pitoiset
On 06/07/2017 09:50 PM, Marek Olšák wrote:
From: Marek Olšák
This creates string lifetime issues... should probably document that
the pointer returned by get_vendor and get_name are supposed to last
for the lifetime of the screen.
On Wed, Jun 7, 2017 at 4:09 PM, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/mesa/state_tracker/st_cb_strings.c | 4 +
From: Marek Olšák
If you want to keep it for your driver, please raise your hand.
The prefix will probably have to be added into the driver instead of here.
I cringe when I look at my long renderer string:
Gallium 0.4 on AMD Radeon R9 Fury Series (DRM 3.17.0 /
4.11.0-staging-01277-gab25a9e, L
From: Marek Olšák
---
src/mesa/state_tracker/st_cb_strings.c | 4 +---
src/mesa/state_tracker/st_context.h| 2 --
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/mesa/state_tracker/st_cb_strings.c
b/src/mesa/state_tracker/st_cb_strings.c
index 99d93a7..85fe5a7 100644
--- a
https://bugs.freedesktop.org/show_bug.cgi?id=101334
Bug ID: 101334
Summary: Any vulkan app seems to freeze the system
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Severit
I had noticed you don't have commit access probably, so I pushed the patch.
Marek
On Wed, Jun 7, 2017 at 2:07 AM, Marek Olšák wrote:
> Reviewed-by: Marek Olšák
>
> Marek
>
> On Wed, Jun 7, 2017 at 12:21 AM, Samuel Li wrote:
>> v2: Add a func pointer to radeon_winsys to support radeon later.
>>
From: Marek Olšák
Unused and radeonsi ignores it anyway.
---
src/gallium/auxiliary/vl/vl_winsys_dri3.c | 2 +-
src/gallium/state_trackers/omx/vid_dec.c | 2 +-
src/gallium/state_trackers/omx/vid_enc.c | 4 ++--
src/gallium/state_trackers/va/context.c | 2 +-
src/gallium/state_trackers/vdpau/
From: Marek Olšák
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101254
---
src/gallium/drivers/r600/r600_pipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/r600/r600_pipe.c
b/src/gallium/drivers/r600/r600_pipe.c
index 957431a..b938208 100644
From: Marek Olšák
---
src/gallium/drivers/r600/evergreen_state.c| 6 +--
src/gallium/drivers/r600/r600_blit.c | 2 +-
src/gallium/drivers/r600/r600_state.c | 6 +--
src/gallium/drivers/radeon/r600_pipe_common.h | 2 +-
src/gallium/drivers/radeon/r600_texture.c | 57 +
From: Marek Olšák
This and the previous commit decrease IB sizes and the number of
si_update_shaders invocations as follows:
IB size si_update_shaders calls
Borderlands 2 -10%-27%
Deus Ex: MD -5%-11%
Talos Principle -8%-30%
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_blit.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_blit.c
b/src/gallium/drivers/radeonsi/si_blit.c
index 20b08b6..e39ba62 100644
--- a/src/gallium/driv
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_blit.c| 12 -
src/gallium/drivers/radeonsi/si_descriptors.c | 38 +--
src/gallium/drivers/radeonsi/si_pipe.h| 6 ++---
3 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/src/galli
From: Marek Olšák
The workaround causes a massive performance decrease on 1-SE parts.
(Cape Verde, Hainan, Oland)
The performance regression is already part of 17.0 and 17.1.
v2: check tess_uses_prim_id
Cc: 17.0 17.1
---
src/gallium/drivers/radeonsi/si_pipe.h | 1 +
src/gallium/driver
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_descriptors.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c
b/src/gallium/drivers/radeonsi/si_descriptors.c
index 7a2b71d..6955b9d 100644
--- a/src/gallium/driver
Pushed, thanks!
Marek
On Wed, Jun 7, 2017 at 8:59 PM, Thomas Helland
wrote:
> 2017-06-06 12:38 GMT+02:00 Marek Olšák :
>> On Tue, Jun 6, 2017 at 12:07 PM, Thomas Helland
>> wrote:
>>> 2017-06-05 23:27 GMT+02:00 Marek Olšák :
For the series:
Reviewed-by: Marek Olšák
Mar
2017-06-06 12:38 GMT+02:00 Marek Olšák :
> On Tue, Jun 6, 2017 at 12:07 PM, Thomas Helland
> wrote:
>> 2017-06-05 23:27 GMT+02:00 Marek Olšák :
>>> For the series:
>>>
>>> Reviewed-by: Marek Olšák
>>>
>>> Marek
>>>
>>
>> As-is? Or with Eric's suggestions of splitting patch 6?
>> If it is OK as it
On 06/07/2017 02:34 PM, Nicolai Hähnle wrote:
On 06.06.2017 21:16, Samuel Pitoiset wrote:
I really like the idea. :-)
Seconded!
Though, I have two general comments:
1) I think it would be better to introduce some sort of compare helper
functions for the different state changes. Also, fo
On 06/07/2017 06:31 PM, Marek Olšák wrote:
On Mon, Jun 5, 2017 at 10:32 PM, Samuel Pitoiset
wrote:
On 06/05/2017 06:50 PM, Marek Olšák wrote:
From: Marek Olšák
so that LLVM IR looks like CSE has been run on it. It's also recommended
by the instruction combining pass.
This also fixes:
-
On Tue, Jun 6, 2017 at 4:51 PM, Kenneth Graunke wrote:
> On Tuesday, June 6, 2017 4:34:36 PM PDT Anuj Phogat wrote:
>> This patch is undoing the changes to way size computation
>> in broxton 2x6, made by below commit:
>>
>> Commit: 0d576fbfbe912cf3fb9ab594bb31eb58bccf2138
>> Author: Anuj Phoga
On Wed, Jun 7, 2017 at 4:10 PM, Aaron Watry wrote:
> On Mon, Jun 5, 2017 at 3:07 PM, Marek Olšák wrote:
>> Hi Aaron,
>>
>> Can you make the change in radeon_drm_winsys.c instead?
>
> Something like the following?
>
> diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c
> b/src/gallium/w
On Wed, Jun 7, 2017 at 2:34 PM, Nicolai Hähnle wrote:
> On 06.06.2017 21:16, Samuel Pitoiset wrote:
>>
>> I really like the idea. :-)
>
>
> Seconded!
>
>
>> Though, I have two general comments:
>>
>> 1) I think it would be better to introduce some sort of compare helper
>> functions for the differ
On Wed, Jun 7, 2017 at 8:16 PM, Nicolai Hähnle wrote:
> On 07.06.2017 19:32, Marek Olšák wrote:
>>
>> On Wed, Jun 7, 2017 at 1:29 PM, Nicolai Hähnle wrote:
>>>
>>> On 06.06.2017 11:34, Marek Olšák wrote:
On Tue, Jun 6, 2017 at 4:28 AM, Michel Dänzer
wrote:
>
>
> O
On 07.06.2017 19:32, Marek Olšák wrote:
On Wed, Jun 7, 2017 at 1:29 PM, Nicolai Hähnle wrote:
On 06.06.2017 11:34, Marek Olšák wrote:
On Tue, Jun 6, 2017 at 4:28 AM, Michel Dänzer wrote:
On 06/06/17 01:50 AM, Marek Olšák wrote:
From: Marek Olšák
radeonsi won't flush caches if set_frame
On Wed, Jun 7, 2017 at 2:09 PM, Nicolai Hähnle wrote:
> On 05.06.2017 18:50, Marek Olšák wrote:
>>
>> From: Marek Olšák
>>
>> ---
>> src/gallium/drivers/radeon/r600_pipe_common.h | 1 +
>> src/gallium/drivers/radeon/r600_texture.c | 1 +
>> src/gallium/drivers/radeonsi/si_state.c
On 07.06.2017 18:44, Marek Olšák wrote:
Ping
Ah, missed that since I saw you pushed patch #1 already. This one looks
good, too.
Reviewed-by: Nicolai Hähnle
On Sat, Jun 3, 2017 at 6:04 PM, Marek Olšák wrote:
From: Marek Olšák
Heaven LDS usage for LS+HS is below. The masks are "output
On Tue, Jun 6, 2017 at 11:26 PM, Chad Versace wrote:
> On Fri 26 May 2017, Jason Ekstrand wrote:
> > ---
> > src/mesa/drivers/dri/i965/brw_clear.c | 12 ++--
> > src/mesa/drivers/dri/i965/brw_context.c | 7 ---
> > src/mesa/drivers/dri/i965/brw_draw.c | 17 +++
On Wed, Jun 7, 2017 at 1:29 PM, Nicolai Hähnle wrote:
> On 06.06.2017 11:34, Marek Olšák wrote:
>>
>> On Tue, Jun 6, 2017 at 4:28 AM, Michel Dänzer wrote:
>>>
>>> On 06/06/17 01:50 AM, Marek Olšák wrote:
From: Marek Olšák
radeonsi won't flush caches if set_framebuffer_state d
Ping
On Sat, Jun 3, 2017 at 6:04 PM, Marek Olšák wrote:
> From: Marek Olšák
>
> Heaven LDS usage for LS+HS is below. The masks are "outputs_written"
> for LS and HS. Note that 32K is the maximum size.
>
> Before:
> heaven_x64: ls=1f1 tcs=1f1, lds=32K
> heaven_x64: ls=31 tcs=31, lds=24K
> h
On Mon, Jun 5, 2017 at 10:32 PM, Samuel Pitoiset
wrote:
>
>
> On 06/05/2017 06:50 PM, Marek Olšák wrote:
>>
>> From: Marek Olšák
>>
>> ---
>> src/gallium/drivers/radeonsi/si_pipe.h | 30
>> ++---
>> src/gallium/drivers/radeonsi/si_state_shaders.c | 6 ++---
>> 2
On Mon, Jun 5, 2017 at 10:32 PM, Samuel Pitoiset
wrote:
>
>
> On 06/05/2017 06:50 PM, Marek Olšák wrote:
>>
>> From: Marek Olšák
>>
>> so that LLVM IR looks like CSE has been run on it. It's also recommended
>> by the instruction combining pass.
>>
>> This also fixes:
>> - GL45-CTS.arrays_of_arra
For patches 32 - 36 and 38 - 48:
Reviewed-by: Marek Olšák
That means all patches from 25 up have been reviewed now, and only two need v3.
Marek
On Wed, Jun 7, 2017 at 5:14 PM, Marek Olšák wrote:
> For patch 37:
>
> Reviewed-by: Marek Olšák
>
> Patches 25 - 31 and 37 (gallium interface etc.)
On 07.06.2017 18:25, Nicolai Hähnle wrote:
On 30.05.2017 22:36, Samuel Pitoiset wrote:
v2: - rebased (is_bindless() -> contains_bindless())
- remove dead inst->bindless assignment
- add missing comment
Signed-off-by: Samuel Pitoiset
Reviewed-by: Marek Olšák (v1)
---
src/mesa/state
On 30.05.2017 22:36, Samuel Pitoiset wrote:
v2: - rebased (is_bindless() -> contains_bindless())
- remove dead inst->bindless assignment
- add missing comment
Signed-off-by: Samuel Pitoiset
Reviewed-by: Marek Olšák (v1)
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 75 ++
Patches 25, 26, and 28 - 32:
Reviewed-by: Nicolai Hähnle
On 30.05.2017 22:36, Samuel Pitoiset wrote:
v2: - rebased (is_bindless() -> contains_bindless())
- removed dead inst->bindless assignment
Signed-off-by: Samuel Pitoiset
Reviewed-by: Nicolai Hähnle (v1)
Reviewed-by: Marek Olšák
On 30.05.2017 22:35, Samuel Pitoiset wrote:
These helpers will be used for handling dynamic arrays of resident
texture/image handles.
Signed-off-by: Samuel Pitoiset
---
src/gallium/auxiliary/util/u_dynarray.h | 20
1 file changed, 20 insertions(+)
diff --git a/src/galli
This patch adds support for the EGL_KHR_partial_update extension for
android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update.
1 test not supported.
v2: add fallback for eglSetDamageRegionKHR (Tapani)
v3: The native_window_set_surface_damage call is available only from
Andro
On 30.05.2017 22:35, Samuel Pitoiset wrote:
This fixes a 64-bit vs 32-bit mismatch when setting an array
of bindless samplers. Also, we need to unconditionally set
size_mul to 2 when the underlying uniform is bindless.
Signed-off-by: Samuel Pitoiset
---
src/mesa/main/uniform_query.cpp | 29 ++
Patches 1, 2, and 6-8:
Reviewed-by: Nicolai Hähnle
On 30.05.2017 22:35, Samuel Pitoiset wrote:
The ARB_bindless_texture spec says:
"The error INVALID_OPERATION is generated by TexImage*, CopyTexImage*,
CompressedTexImage*, TexBuffer*, TexParameter*, as well as other
functions d
On 30.05.2017 22:35, Samuel Pitoiset wrote:
v2: - s/GLboolean/bool for HandleAllocated
- fix _mesa_has_ARB_shader_image_load_store() checks
- use u_vector for texture/image handles
- fix use of 64-bit handles on 32-bit systems
- some cleanups
Signed-off-by: Samuel Pitoiset
-
On Wed, Jun 07, 2017 at 11:18:53PM +0800, Chih-Wei Huang wrote:
> 2017-06-07 22:47 GMT+08:00 Jonathan Gray :
> > On Wed, Jun 07, 2017 at 10:30:49PM +0800, Chih-Wei Huang wrote:
> >> 2017-06-07 21:54 GMT+08:00 Jonathan Gray :
> >> > On Wed, Jun 07, 2017 at 02:45:15PM +0100, Emil Velikov wrote:
> >>
On Wed, Jun 7, 2017 at 7:29 AM, Samuel Pitoiset
wrote:
> To declare both errors and no errors GL prototypes.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/mesa/main/glheader.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/mesa/main/glheader.h b/src/mesa/main/glheader.h
> inde
2017-06-07 22:47 GMT+08:00 Jonathan Gray :
> On Wed, Jun 07, 2017 at 10:30:49PM +0800, Chih-Wei Huang wrote:
>> 2017-06-07 21:54 GMT+08:00 Jonathan Gray :
>> > On Wed, Jun 07, 2017 at 02:45:15PM +0100, Emil Velikov wrote:
>> >> On 6 June 2017 at 07:30, Chih-Wei Huang wrote:
>> >> >>> These are are
On 06/07/2017 05:14 PM, Marek Olšák wrote:
For patch 37:
Reviewed-by: Marek Olšák
Patches 25 - 31 and 37 (gallium interface etc.) can land now as far as
I'm concerned.
---
I sent comments on patches 49, 51, 52 (two comments), 53, 56 (just the
small cleanup), 58, 60.
With my comments appli
For patch 37:
Reviewed-by: Marek Olšák
Patches 25 - 31 and 37 (gallium interface etc.) can land now as far as
I'm concerned.
---
I sent comments on patches 49, 51, 52 (two comments), 53, 56 (just the
small cleanup), 58, 60.
With my comments applied, patches 49-51, 53-57, 59-64 are:
Reviewed-
For 6-8, Reviewed-by: Brian Paul
On 06/07/2017 12:02 AM, Timothy Arceri wrote:
Rather than calling it indirectly in each driver.
---
src/mesa/drivers/dri/i915/i915_context.c | 1 -
src/mesa/drivers/dri/i915/intel_context.c| 1 -
src/mesa/drivers/dri/i965/brw_context.c | 1 -
It would be great if you could put a comment on the new function
explaining what it's doing. Many readers would not know why
invalidating framebuffer state requires invalidating all that other state.
Thanks.
-Brian
On 06/07/2017 12:02 AM, Timothy Arceri wrote:
---
src/mesa/state_tracker/
On 06/07/2017 12:01 AM, Timothy Arceri wrote:
As far as I can tell this shouldn't do anything as we were just
passing a state of 0.
---
src/mesa/drivers/osmesa/osmesa.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/mesa/drivers/osmesa/osmesa.c b/src/mesa/drivers/osmesa/osmesa.c
inde
On Wed, Jun 7, 2017 at 4:47 PM, Samuel Pitoiset
wrote:
>
>
> On 06/07/2017 03:59 PM, Marek Olšák wrote:
>>
>> On Tue, May 30, 2017 at 10:36 PM, Samuel Pitoiset
>> wrote:
>>>
>>> When texture buffers are invalidated the addr in the resident
>>> descriptor has to be updated but we can't create a ne
On 06/07/2017 12:02 AM, Timothy Arceri wrote:
Here we make some assumptions about the AEcontext and set the
recalculate bools directly.
Some formating fixes are also made while we are here.
---
src/mesa/main/api_arrayelt.c | 6 ++
src/mesa/main/api_arrayelt.h | 1 +
src/mesa/vbo/vbo_ex
On Wed, Jun 07, 2017 at 10:30:49PM +0800, Chih-Wei Huang wrote:
> 2017-06-07 21:54 GMT+08:00 Jonathan Gray :
> > On Wed, Jun 07, 2017 at 02:45:15PM +0100, Emil Velikov wrote:
> >> On 6 June 2017 at 07:30, Chih-Wei Huang wrote:
> >> >>> These are are due to program_invocation_short_name/getprogname
On 06/07/2017 03:59 PM, Marek Olšák wrote:
On Tue, May 30, 2017 at 10:36 PM, Samuel Pitoiset
wrote:
When texture buffers are invalidated the addr in the resident
descriptor has to be updated but we can't create a new descriptor
because the resident handle has to be the same.
Instead, use the
2017-06-07 21:54 GMT+08:00 Jonathan Gray :
> On Wed, Jun 07, 2017 at 02:45:15PM +0100, Emil Velikov wrote:
>> On 6 June 2017 at 07:30, Chih-Wei Huang wrote:
>> >>> These are are due to program_invocation_short_name/getprogname. How
>> >>> about updating the file alike xmlconfig.c?
>> >>
>> >> Oh..
On Mon, Jun 5, 2017 at 3:07 PM, Marek Olšák wrote:
> Hi Aaron,
>
> Can you make the change in radeon_drm_winsys.c instead?
Something like the following?
diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c
b/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c
index a485615ae4..44948f49ef
On Tue, May 30, 2017 at 10:36 PM, Samuel Pitoiset
wrote:
> When texture buffers are invalidated the addr in the resident
> descriptor has to be updated but we can't create a new descriptor
> because the resident handle has to be the same.
>
> Instead, use the WRITE_DATA packet which allows to upda
On Wed, Jun 07, 2017 at 02:45:15PM +0100, Emil Velikov wrote:
> On 6 June 2017 at 07:30, Chih-Wei Huang wrote:
> > 2017-06-06 13:06 GMT+08:00 Chih-Wei Huang :
> >> 2017-06-05 21:04 GMT+08:00 Emil Velikov :
> >>> On 4 June 2017 at 04:31, Chih-Wei Huang wrote:
> Android bionic is derived from
On Tue, May 30, 2017 at 10:36 PM, Samuel Pitoiset
wrote:
> This implements the Gallium interface. Decompression of resident
> textures/images will follow in the next patches.
>
> v2: - fix a memleak related to util_copy_image_view()
> - remove "texture" parameter from create_texture_handle()
>
On Tue, May 30, 2017 at 10:36 PM, Samuel Pitoiset
wrote:
> Resident buffers have to be added to every new command stream.
> Though, this could be slightly improved when current shaders
> don't use any bindless textures/images but usually applications
> tend to use bindless for almost every draw ca
On 6 June 2017 at 07:30, Chih-Wei Huang wrote:
> 2017-06-06 13:06 GMT+08:00 Chih-Wei Huang :
>> 2017-06-05 21:04 GMT+08:00 Emil Velikov :
>>> On 4 June 2017 at 04:31, Chih-Wei Huang wrote:
Android bionic is derived from OpenBSD. So the logics of BSD
almost apply to Android as well.
For the series:
Reviewed-by: Nicolai Hähnle
On 06.06.2017 21:59, Samuel Pitoiset wrote:
Signed-off-by: Samuel Pitoiset
---
src/mesa/main/enable.c | 2 ++
src/mesa/state_tracker/st_context.c | 4 +---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main
Hi Chih-Wei,
On 6 June 2017 at 06:16, Chih-Wei Huang wrote:
> Making the code warning-free is the responsibility
> of the one who wrote the code instead of
> the one who builds the code.
>
if you look closer you'll see that particular warning will be
triggered at almost any point.
That is using
Signed-off-by: Samuel Pitoiset
---
src/mesa/main/blend.h | 22 ++-
src/mesa/main/blit.h| 38 ---
src/mesa/main/bufferobj.h | 148 -
src/mesa/main/compute.h | 31 +++--
src/mesa/main/copyimage.h | 20 ++
src/mesa
1 - 100 of 131 matches
Mail list logo
