On Tue 06 Jun 2017, Dylan Baker wrote: > Quoting Chad Versace (2017-06-06 15:11:18) > > On Tue 06 Jun 2017, Dylan Baker wrote: > > > Quoting Chad Versace (2017-06-06 13:36:55)
> > > > + write_preamble(stdout) > > > > + write_func_mesa_format_fallback_rgbx_to_rgba(stdout, formats) > > > > > > We really shouldn't write to stdout like this, it can cause all kinds of > > > breakages if there's ever a UTF-8 character (say ©) and the terminal > > > doesn't > > > have a unicode locale it'll fail, > > > > Ugh. I wasn't aware that Python's stdout was broken. Is Python's > > sys.stdout opened in "text" mode, and is that the cause of the > > brokenness? > > > > Does it still fail if stdout is redirected to a file? Because that's the > > only case that matters here. > > It's not python, it's the shell (I think). In this case it won't be a problem > since you don't have any non-ascii characters, but we've run into cases where > someone (like me) adds "Copyright © 3001 Mystery Science Theatre" and then > breaks some (but not many) systems. I know this because I added such a > copyright > and broke someone's system, and eventually we narrowed it down to the fact > that > this person didn't have a UTF-8 locale but I did, we ended up just removing > the > © character from the output to fix it. Ok, then it's not really a problem for build-system scripts. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
