Re: [Mesa-dev] [PATCH] Android: define PIPE_OS_BSD

2017-06-06 13:06 GMT+08:00 Chih-Wei Huang : > 2017-06-05 21:04 GMT+08:00 Emil Velikov : >> On 4 June 2017 at 04:31, Chih-Wei Huang wrote: >>> Android bionic is derived from OpenBSD. So the logics of BSD >>> almost apply to Android as well. >>> >> Having platform FOO define both PIPE_OS_BSD and PIP

Re: [Mesa-dev] [PATCH v14 15/36] i965: Improve same-buffer restriction for imports

On June 5, 2017 6:10:22 PM Varad Gautam wrote: Hi Daniel, On Mon, 2017-06-05 at 14:53 +0100, Daniel Stone wrote: Hi Varad, On 30 May 2017 at 12:53, Varad Gautam wrote: > > +   /* We only support all planes from the same bo. > +* brw_bo_gem_create_from_prime() should return the same poin

Re: [Mesa-dev] [PATCH 0/3] Fix missing initializer errors in generated tables

2017-06-05 3:57 GMT+08:00 Marek Olšák : > NAK. > > In C/C++, the initializer is used to clear the memory to 0s, thus, > adding 0s to the initializer is redundant and unnecessary. Empty > initializer {} is also commonly used instead of memset. Commonly used doesn't mean it's the right thing. Otherw

[Mesa-dev] [PATCH] glthread: remove extra _mesa_glthread_finish() from generated code

The other user of print_sync_dispatch() was ending up with code that looked like: _mesa_glthread_finish(ctx); _mesa_glthread_restore_dispatch(ctx); _mesa_glthread_finish(ctx); --- src/mapi/glapi/gen/gl_marshal.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] Android: use bionic pthread_barrier_* if possible

2017-06-05 21:15 GMT+08:00 Emil Velikov : > On 5 June 2017 at 09:27, Tapani Pälli wrote: >> that seems the case >> >> Acked-by: Tapani Pälli >> >> On 06/04/2017 07:53 AM, Chih-Wei Huang wrote: >>> >>> The pthread_barrier_* functions were introduced to bionic >>> since Nougat. >>> > ... and pushed

Re: [Mesa-dev] [PATCH 4/4] nir: add ARB_shader_ballot and ARB_shader_group_vote instructions

On Mon, Jun 5, 2017 at 6:37 PM, Connor Abbott wrote: > I pushed a v2 at > https://cgit.freedesktop.org/~cwabbott0/mesa/log/?h=nir-divergence-v2. > I'm not sure if I like this version better, though. I'll have to think > about it. In the meantime, feel free to take a look. > I've taken a skim thr

[Mesa-dev] [PATCH 2.5/4] configure: define HAVE_AMD_DRIVERS when the conditional is set

This will be used in the next commit to conditionally include amdgpu.h in ac_gpu_info.h Signed-off-by: Aaron Watry Cc: Jan Vesely Cc: Emil Velikov --- This worked earlier because I had an intermediate step where I had added a HAVE_AMD_DRIVERS define elsewhere and didn't git clean before testing

Re: [Mesa-dev] [PATCH 5/5] st/mesa: use texture_barrier before CopyPixels blits where src == dst

On 06/06/17 01:50 AM, Marek Olšák wrote: > From: Marek Olšák > > radeonsi won't flush caches if set_framebuffer_state doesn't change > anything. > --- > src/mesa/state_tracker/st_cb_drawpixels.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/mesa/state_tracker/st_cb_drawpix

Re: [Mesa-dev] [PATCH 4/4] nir: add ARB_shader_ballot and ARB_shader_group_vote instructions

I pushed a v2 at https://cgit.freedesktop.org/~cwabbott0/mesa/log/?h=nir-divergence-v2. I'm not sure if I like this version better, though. I'll have to think about it. In the meantime, feel free to take a look. On Mon, Jun 5, 2017 at 2:43 PM, Jason Ekstrand wrote: > On Mon, Jun 5, 2017 at 1:50 P

Re: [Mesa-dev] [PATCH v14 15/36] i965: Improve same-buffer restriction for imports

Hi Daniel, On Mon, 2017-06-05 at 14:53 +0100, Daniel Stone wrote: > Hi Varad, > > On 30 May 2017 at 12:53, Varad Gautam wrote: > > > > +   /* We only support all planes from the same bo. > > +* brw_bo_gem_create_from_prime() should return the same pointer for all > > +* fds received her

Re: [Mesa-dev] [PATCH] mapi: Enable assembly language API acceleration for PPC64LE (V2)

> On Jun 5, 2017, at 11:14 AM, Emil Velikov wrote: > > On 3 June 2017 at 00:37, Ben Crocker wrote: >> Implement assembly language API acceleration for PPC64LE, >> analogous to long-standing implementations for X86 and X86-64. >> >> See also similar implementation in libglvnd. >> >> Tested wi

Re: [Mesa-dev] [PATCH] intel/blorp: Set needs_(dst|src)_offset for Gen4 cubemaps

On Mon, Jun 5, 2017 at 5:22 PM, Ian Romanick wrote: > From: Jason Ekstrand > > We call convert_to_single_slice so they may end up with a non-trivial > offset that needs to be taken into account. > > v2 (idr): Also set needs_src_offset. Suggested by Jason. > > Fixes ES2-CTS.functional.texture.sp

Re: [Mesa-dev] [PATCH 03/10] i965: Perform HiZ flush/stall prior to HiZ resolves

Patches 1-3 should have been CC'd to stable. On Mon, Jun 5, 2017 at 5:55 PM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 39 +++--- > - > 1 file changed, 26 insertions(+), 13 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_blorp.

Re: [Mesa-dev] [PATCH 06/10] anv/blorp: Move the depth cache flush outside of BLORP

Reviewed-by: Jason Ekstrand On Mon, Jun 5, 2017 at 5:55 PM, Jason Ekstrand wrote: > From: Nanley Chery > > Signed-off-by: Nanley Chery > --- > src/intel/blorp/blorp_genX_exec.h | 8 > src/intel/vulkan/anv_blorp.c | 16 > 2 files changed, 16 insertions(+), 8 de

[Mesa-dev] [PATCH 10/10] i965: Use BLORP for all HiZ ops

BLORP has been capable of doing gen8-style HiZ ops for a while now. We might as well start using it. The one downside is that this may cause a bit more state emission since we still re-emit most things for BLORP. --- src/mesa/drivers/dri/i965/brw_blorp.c| 25 ++--- src/mesa/drivers/dri/

[Mesa-dev] [PATCH 08/10] i965: Move the post-HiZ-clear flush/stall to intel_hiz_exec

This also changes it to be predicated so we only do the flush/stall on clears and HiZ resolves. The docs only say it's needed for clears but empirical evidence says it's also needed for HiZ resolves. --- src/mesa/drivers/dri/i965/brw_blorp.c| 18 ++ src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH 04/10] i965/blorp: Inline gen6_blorp_exec

--- src/mesa/drivers/dri/i965/brw_blorp.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 097903e..7fd6760 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp.c +++

[Mesa-dev] [PATCH 01/10] i965/blorp: Take a layer range in intel_hiz_exec

--- src/mesa/drivers/dri/i965/brw_blorp.c | 13 - src/mesa/drivers/dri/i965/brw_blorp.h | 3 ++- src/mesa/drivers/dri/i965/brw_clear.c | 10 -- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 ++-- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 4 -

[Mesa-dev] [PATCH 09/10] blorp: Use FullSurfaceDepthandStencilClear for blorp_hiz_op

The blorp_hiz_op entrypoint always acts on a full subresource of a HiZ buffer so we can just set the flag unconditionally. --- src/intel/blorp/blorp.c | 1 + src/intel/blorp/blorp_genX_exec.h | 3 +++ src/intel/blorp/blorp_priv.h | 1 + 3 files changed, 5 insertions(+) diff --git a

[Mesa-dev] [PATCH 07/10] intel/blorp: Plumb through access to the workaround BO

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101283 --- src/intel/blorp/blorp_genX_exec.h | 9 +++-- src/intel/vulkan/genX_blorp_exec.c | 12 src/mesa/drivers/dri/i965/genX_blorp_exec.c | 13 + 3 files changed, 32 insertions(+), 2 deletion

[Mesa-dev] [PATCH 06/10] anv/blorp: Move the depth cache flush outside of BLORP

From: Nanley Chery Signed-off-by: Nanley Chery --- src/intel/blorp/blorp_genX_exec.h | 8 src/intel/vulkan/anv_blorp.c | 16 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/src/intel/blorp/blorp_genX_exec.h b/src/intel/blorp/blorp_genX_exec.h ind

[Mesa-dev] [PATCH 03/10] i965: Perform HiZ flush/stall prior to HiZ resolves

--- src/mesa/drivers/dri/i965/brw_blorp.c | 39 +++ 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 1e4c0de..097903e 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp

[Mesa-dev] [PATCH 05/10] intel/blorp: Refactor the HiZ op interface

This commit does a few things: 1) Now that BLORP can do HiZ ops on gen8+, drop the gen6 prefix. 2) Switch parameters to uint32_t to match the rest of blorp. 3) Take a range of layers and loop internally. --- src/intel/blorp/blorp.c | 104 ++ src/in

[Mesa-dev] [PATCH 02/10] i965: Move the pre-depth-clear flush/stalls to intel_hiz_exec

--- src/mesa/drivers/dri/i965/brw_blorp.c | 58 +++ src/mesa/drivers/dri/i965/brw_clear.c | 56 - 2 files changed, 58 insertions(+), 56 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_

Re: [Mesa-dev] [PATCH 03/30] intel/isl: Add a helper for determining if a color is 0/1

On Fri, Jun 2, 2017 at 1:09 PM, Chad Versace wrote: > On Fri 26 May 2017, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl.c | 19 +++ > > src/intel/isl/isl.h | 4 > > 2 files changed, 23 insertions(+) > > > > diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c > > in

[Mesa-dev] [PATCH] intel/blorp: Set needs_(dst|src)_offset for Gen4 cubemaps

From: Jason Ekstrand We call convert_to_single_slice so they may end up with a non-trivial offset that needs to be taken into account. v2 (idr): Also set needs_src_offset. Suggested by Jason. Fixes ES2-CTS.functional.texture.specification.basic_copyteximage2d.cube_rgba and ES2-CTS.functional.t

Re: [Mesa-dev] [PATCH] i965: Don't try to resolve CCS with MESA_FORMAT_NONE.

On Monday, June 5, 2017 2:03:45 AM PDT Tapani Pälli wrote: > FWIW this change fixes also regression on Android wallpaper since that > commit. I'm planning on dropping this patch, as it seems that commit 708664159e18487b6676fd5b4c33f52003f81d9e Author: Jason Ekstrand Date: Fri May 26 10:57:33

[Mesa-dev] [PATCH 10/14] radv: add IA_MULTI_VGT_PARAM support for GFX9.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 4 +++- src/amd/vulkan/radv_pipeline.c | 5 + src/amd/vulkan/si_cmd_buffer.c | 12 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/am

[Mesa-dev] [PATCH 14/14] radv: enable GFX9 on radv

From: Dave Airlie --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c index 94fd8b8..bce8dd2 100644 --- a/src/amd/vul

[Mesa-dev] [PATCH 13/14] radv: turn off geom/tess for gfx9.

From: Dave Airlie We don't support these yet, and it'll take a bit of work to do so. --- src/amd/vulkan/radv_device.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 5528bc5..1be92bc 100644 --- a/src/am

[Mesa-dev] [PATCH 07/14] radv: add texture descriptor/fmask/cmask support for GFX9

From: Dave Airlie This adds gfx9 support for the texture descriptor along with the fmask/cmask allocation routines. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_image.c | 189 1 file changed, 158 insertions(+), 31 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH 06/14] radv: add GFX9 to initialisation cmd buffer.

From: Dave Airlie This just adds support for initialising some GFX9 registers, and handles the different init for the VGT reuse reg. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 5 +-- src/amd/vulkan/si_cmd_buffer.c | 72 2 files

[Mesa-dev] [PATCH 01/14] radv: add some misc gfx9 pieces.

From: Dave Airlie This just adds the strings and includes the gfx9 register defs in some files that we need them in. Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_util.c| 3 +++ src/amd/vulkan/radv_cmd_buffer.c | 1 + src/amd/vulkan/radv_device.c | 6 ++ src/amd/vulkan/radv

[Mesa-dev] [PATCH 08/14] radv: add GFX9 cache flushing support.

From: Dave Airlie GFX9 needs to write event EOP to a fence buffer, allocate some space for this, and just write an ever increasing number to it, this isn't exactly what radeonsi does, but it seems to work. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 8 ++ src/amd/vulkan

[Mesa-dev] [PATCH 12/14] radv: misc GFX9 changes.

From: Dave Airlie These are just some register changes ported from radeonsi for gfx9. --- src/amd/vulkan/radv_cmd_buffer.c | 20 +++- src/amd/vulkan/radv_device.c | 4 src/amd/vulkan/radv_pipeline.c | 3 ++- 3 files changed, 21 insertions(+), 6 deletions(-) diff --g

[Mesa-dev] [PATCH 09/14] radv: add rb+ support for GFX9

From: Dave Airlie This adds some rb+ support, as on GFX9 we have to disable it as per radeonsi. --- src/amd/vulkan/radv_cmd_buffer.c | 7 +++ src/amd/vulkan/radv_device.c | 6 ++ src/amd/vulkan/radv_meta_clear.c | 5 + src/amd/vulkan/radv_private.h| 3 +++ 4 files changed, 21

[Mesa-dev] [PATCH 11/14] radv: add some GFX9 specific events.

From: Dave Airlie These are ported from radeonsi, don't know all the rules for when they should be inserted. --- src/amd/vulkan/radv_cmd_buffer.c | 16 1 file changed, 16 insertions(+) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 312694

[Mesa-dev] [PATCH 04/14] radv: add gfx9 cp dma support.

From: Dave Airlie This adds support to the CP dma code for GFX9, ported from radeonsi. Signed-off-by: Dave Airlie --- src/amd/vulkan/si_cmd_buffer.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd

[Mesa-dev] [PATCH 05/14] radv: don't setup raster_config on gfx9.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/vulkan/si_cmd_buffer.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c index 604a5e2..b848325 100644 --- a/src/amd/vulkan/s

[Mesa-dev] [PATCH 03/14] radv: add gfx9 depth/stencil surface support.

From: Dave Airlie This is ported from radeonsi. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 53 +--- src/amd/vulkan/radv_device.c | 34 +- src/amd/vulkan/radv_private.h| 2 ++ 3 files changed, 74 inserti

[Mesa-dev] radv: initial vega support

This is an initial port of the vega code from radeonsi to radv. It only support vertex/fragment shaders, tess/gs is going to take a fair bit of work, but we don't have many tess/gs workloads for radv yet, so it's not a major problem. I've tested this on one very remote card, so can't try anything

[Mesa-dev] [PATCH 02/14] radv: add GFX9 support for color surfaces.

From: Dave Airlie This is ported from radeonsi. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 53 src/amd/vulkan/radv_device.c | 30 ++- src/amd/vulkan/radv_private.h| 2 ++ 3 files changed, 69 insertions

Re: [Mesa-dev] [PATCH] radv: set offchip hs param like radeonsi.

Reviewed-by: Bas Nieuwenhuizen On Tue, Jun 6, 2017 at 12:37 AM, Dave Airlie wrote: > From: Dave Airlie > > radeonsi never uses 512 here anymore. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_device.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/

Re: [Mesa-dev] [PATCH v2 02/23] mesa: add KHR_no_error support for glVertexArrayVertexBuffers()

On Monday 05 June 2017, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > Reviewed-by: Timothy Arceri > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- > src/mesa/main/varray.c | 15 +++ > src/mesa/main/varray.h |

Re: [Mesa-dev] [PATCH v2 1/2] intel: gen-decoder: rework how we handle groups

Hi Lionel, I went through this patch more than once, but I think I understood what you did, and I think it highly simplifies the code, not necessarily in lines of code but at least the logic is way easier to follow. Just a minor nitpick below. On Wed, May 31, 2017 at 10:32:52AM +0100, Lionel Lan

[Mesa-dev] [PATCH] radv: set offchip hs param like radeonsi.

From: Dave Airlie radeonsi never uses 512 here anymore. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 6c30cde..d80d746 100644 --- a/src/amd/vul

Re: [Mesa-dev] [PATCH 1/4] automake: r600 should only depend on libamd_common if opencl is enabled

On Mon, Jun 5, 2017 at 5:31 PM, Jan Vesely wrote: > On Mon, 2017-06-05 at 15:31 -0500, Aaron Watry wrote: > > From: Jan Vesely > > > > Signed-off-by: Jan Vesely > > Reviewed-by: Aaron Watry > > I think Emil preferred v2, with comments and split android changes. > > Fair enough. I missed/forgo

Re: [Mesa-dev] [PATCH 1/4] automake: r600 should only depend on libamd_common if opencl is enabled

On Mon, 2017-06-05 at 15:31 -0500, Aaron Watry wrote: > From: Jan Vesely > > Signed-off-by: Jan Vesely > Reviewed-by: Aaron Watry I think Emil preferred v2, with comments and split android changes. Jan > --- > configure.ac| 3 ++- > src/gallium/drivers/r600/A

Re: [Mesa-dev] [PATCH 4/4] radeon: remove out of date LLVM_REVISION.txt

On Tue, Jun 6, 2017 at 12:16 AM, Aaron Watry wrote: > On Mon, Jun 5, 2017 at 3:53 PM, Marek Olšák wrote: >> >> Reviewed-by: Marek Olšák >> > Is that just for this patch, or the series? Only this patch. Thanks, Marek ___ mesa-dev mailing list mesa-dev

Re: [Mesa-dev] [PATCH v2 09/23] mesa: add 'no_error' parameter to blit_framebuffer()

On 06/06/2017 12:10 AM, Timothy Arceri wrote: Do we want to force inlining of blit_framebuffer()? Wrapping the error variant calls in blit_framebuffer_err() to avoid excess inlining? Mmh yeah, that might be too much to force inlining for both paths. I will update this one, thanks. On 06/0

Re: [Mesa-dev] [PATCH 4/4] radeon: remove out of date LLVM_REVISION.txt

On Mon, Jun 5, 2017 at 3:53 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Is that just for this patch, or the series? I've pushed this one for now, and I'll push the rest later tonight if you want me to. --Aaron > Would you please push this now, don't wait for other Rbs. > > Thanks

Re: [Mesa-dev] [PATCH v2 09/23] mesa: add 'no_error' parameter to blit_framebuffer()

Do we want to force inlining of blit_framebuffer()? Wrapping the error variant calls in blit_framebuffer_err() to avoid excess inlining? On 06/06/17 07:43, Samuel Pitoiset wrote: The whole GLES3 block has been moved before the buffer validation checks. Signed-off-by: Samuel Pitoiset --- src

Re: [Mesa-dev] [PATCH v2 21/23] mesa: make _mesa_texture_sub_image() static

Reviewed-by: Timothy Arceri On 06/06/17 07:44, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/teximage.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.

Re: [Mesa-dev] [PATCH v2 15/23] mesa: add KHR_no_error support for glBlitNamedFramebuffer()

14-15: Reviewed-by: Timothy Arceri On 06/06/17 07:44, Samuel Pitoiset wrote: v2: - rebased (make use of blit_named_framebuffer()) Signed-off-by: Samuel Pitoiset --- src/mesa/main/blit.c | 18 ++ src/mesa/main/blit.h | 9 + 2 files changed, 27 insertions(+) diff

[Mesa-dev] [PATCH v2 23/23] mesa: add KHR_no_error support for glTexSubImage*D()

Signed-off-by: Samuel Pitoiset Reviewed-by: Timothy Arceri --- src/mapi/glapi/gen/gl_API.xml | 6 +++--- src/mesa/main/teximage.c | 43 +++ src/mesa/main/teximage.h | 18 ++ 3 files changed, 64 insertions(+), 3 deletions(-) diff

[Mesa-dev] [PATCH v2 21/23] mesa: make _mesa_texture_sub_image() static

Signed-off-by: Samuel Pitoiset --- src/mesa/main/teximage.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 9285a96b68..b262e75b9d 100644 --- a/src/mesa/main/teximage.c +++ b/s

[Mesa-dev] [PATCH v2 19/23] mesa: add KHR_no_error support for glCopyImageSubData()

Signed-off-by: Samuel Pitoiset Reviewed-by: Timothy Arceri --- src/mapi/glapi/gen/ARB_copy_image.xml | 2 +- src/mesa/main/copyimage.c | 23 +++ src/mesa/main/copyimage.h | 7 +++ 3 files changed, 31 insertions(+), 1 deletion(-) diff --git a/src

[Mesa-dev] [PATCH v2 20/23] mesa: rename texsubimage() to texsubimage_err()

Signed-off-by: Samuel Pitoiset Reviewed-by: Timothy Arceri --- src/mesa/main/teximage.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index fed1dad262..9285a96b68 100644 --- a/src/mesa/

[Mesa-dev] [PATCH v2 22/23] mesa: add texsubimage() helper

v2: - rebased (_mesa_texture_sub_image() is now static) Signed-off-by: Samuel Pitoiset Reviewed-by: Timothy Arceri (v1) --- src/mesa/main/teximage.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index b262e75b9d..f4c1

[Mesa-dev] [PATCH v2 18/23] mesa: add copy_image_subdata() helper

v2: - move 'i' inside the for loop Signed-off-by: Samuel Pitoiset Reviewed-by: Timothy Arceri (v1) --- src/mesa/main/copyimage.c | 76 --- 1 file changed, 45 insertions(+), 31 deletions(-) diff --git a/src/mesa/main/copyimage.c b/src/mesa/main/copyim

[Mesa-dev] [PATCH v2 15/23] mesa: add KHR_no_error support for glBlitNamedFramebuffer()

v2: - rebased (make use of blit_named_framebuffer()) Signed-off-by: Samuel Pitoiset --- src/mesa/main/blit.c | 18 ++ src/mesa/main/blit.h | 9 + 2 files changed, 27 insertions(+) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index 46903b5181..e42eadf98d 1006

[Mesa-dev] [PATCH v2 17/23] mesa: add prepare_target() helper

Signed-off-by: Samuel Pitoiset Reviewed-by: Timothy Arceri --- src/mesa/main/copyimage.c | 24 1 file changed, 24 insertions(+) diff --git a/src/mesa/main/copyimage.c b/src/mesa/main/copyimage.c index 07c2359dda..6a74f7a1a8 100644 --- a/src/mesa/main/copyimage.c +++ b/s

[Mesa-dev] [PATCH v2 16/23] mesa: rename prepare_target() to prepare_target_err()

Signed-off-by: Samuel Pitoiset Reviewed-by: Timothy Arceri --- src/mesa/main/copyimage.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/src/mesa/main/copyimage.c b/src/mesa/main/copyimage.c index cf25159e88..07c2359dda 100644 --- a/src/me

[Mesa-dev] [PATCH v2 09/23] mesa: add 'no_error' parameter to blit_framebuffer()

The whole GLES3 block has been moved before the buffer validation checks. Signed-off-by: Samuel Pitoiset --- src/mesa/main/blit.c | 192 +-- 1 file changed, 95 insertions(+), 97 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c

[Mesa-dev] [PATCH v2 12/23] mesa: add validate_depth_buffer() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/blit.c | 72 +++- 1 file changed, 43 insertions(+), 29 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index ee48e4845b..e04f5d79b2 100644 --- a/src/mesa/main/blit.c +++ b/src/m

[Mesa-dev] [PATCH v2 11/23] mesa: add validate_stencil_buffer() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/blit.c | 81 ++-- 1 file changed, 47 insertions(+), 34 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index d2b662857c..ee48e4845b 100644 --- a/src/mesa/main/blit.c +++ b/src/m

[Mesa-dev] [PATCH v2 14/23] mesa: add blit_named_framebuffer() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/blit.c | 79 +--- 1 file changed, 51 insertions(+), 28 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index 609df63d20..46903b5181 100644 --- a/src/mesa/main/blit.c +++ b/src/m

[Mesa-dev] [PATCH v2 13/23] mesa: add KHR_no_error support for glBlitFramebuffer()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_framebuffer_object.xml | 2 +- src/mesa/main/blit.c | 15 +++ src/mesa/main/blit.h | 6 ++ 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/ge

[Mesa-dev] [PATCH v2 10/23] mesa: add validate_color_buffer() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/blit.c | 138 --- 1 file changed, 77 insertions(+), 61 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index 970c357335..d2b662857c 100644 --- a/src/mesa/main/blit.c +++ b/src/m

[Mesa-dev] [PATCH v2 03/23] mesa: add KHR_no_error support for glBindVertexBuffers()

Signed-off-by: Samuel Pitoiset Reviewed-by: Timothy Arceri --- src/mapi/glapi/gen/ARB_multi_bind.xml | 2 +- src/mesa/main/varray.c| 13 + src/mesa/main/varray.h| 5 + 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/

[Mesa-dev] [PATCH v2 07/23] mesa: add KHR_no_error support for glBindBuffer()

Signed-off-by: Samuel Pitoiset Reviewed-by: Timothy Arceri --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/bufferobj.c | 10 ++ src/mesa/main/bufferobj.h | 3 +++ 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/gla

[Mesa-dev] [PATCH v2 05/23] mesa: add KHR_no_error support for glInvalidateBufferSubData()

Signed-off-by: Samuel Pitoiset Reviewed-by: Timothy Arceri --- src/mapi/glapi/gen/ARB_invalidate_subdata.xml | 2 +- src/mesa/main/bufferobj.c | 10 ++ src/mesa/main/bufferobj.h | 5 + 3 files changed, 16 insertions(+), 1 deletion(-) diff --

[Mesa-dev] [PATCH v2 04/23] mesa: add invalidate_buffer_subdata() helper

v2: - s/inline/ALWAYS_INLINE/ Signed-off-by: Samuel Pitoiset Reviewed-by: Timothy Arceri (v1) --- src/mesa/main/bufferobj.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 9e656a4c98..4f3c640248 100

[Mesa-dev] [PATCH v2 08/23] mesa: make _mesa_blit_framebuffer() static

Signed-off-by: Samuel Pitoiset Reviewed-by: Timothy Arceri --- src/mesa/main/blit.c | 29 ++--- src/mesa/main/blit.h | 8 2 files changed, 14 insertions(+), 23 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index e739130f98..2c0300eab3 10

[Mesa-dev] [PATCH v2 06/23] mesa: add KHR_no_error support for glInvalidateBufferData()

Signed-off-by: Samuel Pitoiset Reviewed-by: Timothy Arceri --- src/mapi/glapi/gen/ARB_invalidate_subdata.xml | 2 +- src/mesa/main/bufferobj.c | 9 + src/mesa/main/bufferobj.h | 3 +++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/

[Mesa-dev] [PATCH v2 02/23] mesa: add KHR_no_error support for glVertexArrayVertexBuffers()

Signed-off-by: Samuel Pitoiset Reviewed-by: Timothy Arceri --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/varray.c | 15 +++ src/mesa/main/varray.h | 6 ++ 3 files changed, 22 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH v2 01/23] mesa: add vertex_array_vertex_buffers_err() helper

This also adds a 'no_error' parameter to vertex_array_vertex_buffer() to be used in a following patch. v2: - add a patch description Signed-off-by: Samuel Pitoiset Reviewed-by: Timothy Arceri (v1) --- src/mesa/main/varray.c | 108 - 1 file change

[Mesa-dev] [PATCH v2 00/23] mesa: Some more KHR_no_error support patches

Hi, Major changes from v2: - rework the blit framebuffer codepath - fix blit_framebuffer() when validation of buffers fail Initial cover letter can be found here: https://lists.freedesktop.org/archives/mesa-dev/2017-June/157553.html Please, review! Thanks. Samuel Pitoiset (23): mesa: add ve

Re: [Mesa-dev] [PATCH 4/4] nir: add ARB_shader_ballot and ARB_shader_group_vote instructions

On Mon, Jun 5, 2017 at 1:50 PM, Connor Abbott wrote: > On Mon, Jun 5, 2017 at 1:37 PM, Jason Ekstrand > wrote: > > I'm not sure how I feel about having these as ALU operations. ALU > > operations are generally pure functions (with the exception derivative) > that > > can be re-ordered at will.

Re: [Mesa-dev] [PATCH 3/3] mesa: make use of NewWindowRectangles driver flags

For the series: Reviewed-by: Marek Olšák Marek On Fri, Jun 2, 2017 at 2:31 PM, Samuel Pitoiset wrote: > Now, st_update_window_rectangles() won't be called when the > scissor is going to be updated. > > Signed-off-by: Samuel Pitoiset > --- > src/mesa/main/scissor.c | 4 +++- > src

Re: [Mesa-dev] [PATCH 1/3] mesa: remove call to Driver.Scissor() in _mesa_WindowRectanglesEXT()

I approve the patch. If no driver expects the callback, it shouldn't be called. The long term goal should be to get rid of all of these driver state callbacks (I've already removed a few dozens of them), but some classic drivers still rely on them and that's why mesa/main has to call them. Marek

Re: [Mesa-dev] [ANNOUNCE] mesa 17.1.2

There was a typo in the subject. I meant mesa 17.1.2 BR, J.A. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [ANNOUNCE] mesa 17.1.1

Mesa 17.1.2 is now available. In this release we have: Several fixes in the autotools' configure that improves handling of target platforms. Mesa receives a fix for a leaking in a surface. OMX has a couple of fixes when building in a X11-less setup. ANV driver receives several fixes, like add

Re: [Mesa-dev] [PATCH 3/3] mesa: only emit _NEW_MULTISAMPLE when min sample shading changes

For the series: Reviewed-by: Marek Olšák Marek On Fri, Jun 2, 2017 at 5:52 PM, Samuel Pitoiset wrote: > We usually check that given parameters are different before > updating the state. > > Signed-off-by: Samuel Pitoiset > --- > src/mesa/main/multisample.c | 9 ++--- > 1 file changed, 6

Re: [Mesa-dev] [PATCH 1/3] radv: refactor depth/stencil state setup

Series is Reviewed-by: Bas Nieuwenhuizen On Mon, Jun 5, 2017 at 3:12 AM, Dave Airlie wrote: > From: Dave Airlie > > In advance of GFX9 to reduce chances for regression, refactor > this code out so adding the GFX9 changes will be more obvious. > > Signed-off-by: Dave Airlie > --- > src/amd/vu

Re: [Mesa-dev] [PATCH 7/7] util: Add extern c to u_dynarray.h

For the series: Reviewed-by: Marek Olšák Marek On Sat, Jun 3, 2017 at 8:11 PM, Thomas Helland wrote: > --- > src/util/u_dynarray.h | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/util/u_dynarray.h b/src/util/u_dynarray.h > index ad3889a7c8..e9109ccd2d 100644 > --- a/src/

Re: [Mesa-dev] [PATCH] radv: split metadata struct into legacy/gfx9 parts.

Reviewed-by: Bas Nieuwenhuizen On Mon, Jun 5, 2017 at 2:47 AM, Dave Airlie wrote: > From: Dave Airlie > > This is just ported from radeonsi. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_image.c | 28 ++ > src/amd/vulkan/radv_radeon_winsys.h

Re: [Mesa-dev] [PATCH v2 49/64] radeonsi: add si_set_shader_image_desc() helper

On 06/05/2017 07:12 PM, Marek Olšák wrote: On Tue, May 30, 2017 at 10:36 PM, Samuel Pitoiset wrote: To share some common code between bound and bindless images. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 78 --- 1 file chang

Re: [Mesa-dev] [PATCH 4/4] radeon: remove out of date LLVM_REVISION.txt

Reviewed-by: Marek Olšák Would you please push this now, don't wait for other Rbs. Thanks, Marek On Mon, Jun 5, 2017 at 10:31 PM, Aaron Watry wrote: > From: Emil Velikov > > The file was introduced to track which LLVM revision was required, yet > that has quickly gone out of shape. > > It has

Re: [Mesa-dev] [PATCH 3/8] radeonsi: isolate real framebuffer changes from the decompression passes

On 06/05/2017 10:47 PM, Marek Olšák wrote: From: Samuel Pitoiset When a stencil buffer is part of the framebuffer state, it is decompressed but because it's bindless, all draw calls set stencil_dirty_level_mask to 1. v2: Marek - set the flags outside the loop - also clear and set

Re: [Mesa-dev] [PATCH 4/4] nir: add ARB_shader_ballot and ARB_shader_group_vote instructions

On Mon, Jun 5, 2017 at 1:37 PM, Jason Ekstrand wrote: > I'm not sure how I feel about having these as ALU operations. ALU > operations are generally pure functions (with the exception derivative) that > can be re-ordered at will. I don't really like breaking that. In fact, I'd > almost be incli

Re: [Mesa-dev] [PATCH] gallium/u_threaded: fixes for MSVC

Reviewed-by: Marek Olšák Marek On Mon, Jun 5, 2017 at 10:15 PM, Brian Paul wrote: > Replace some static assertions with runtime assertions. The static > asserts don't work/fail on MSVC, despite the offsets being multiples > of 16 (checked with softpipe). > > Use correct parameter types for a f

[Mesa-dev] [PATCH 3/8] radeonsi: isolate real framebuffer changes from the decompression passes

From: Samuel Pitoiset When a stencil buffer is part of the framebuffer state, it is decompressed but because it's bindless, all draw calls set stencil_dirty_level_mask to 1. v2: Marek - set the flags outside the loop - also clear and set framebuffer.do_update_surf_dirtiness there

Re: [Mesa-dev] [PATCH 3/8] radeonsi: isolate real framebuffer changes from the decompression passes

On 06/05/2017 06:50 PM, Marek Olšák wrote: From: Samuel Pitoiset When a stencil buffer is part of the framebuffer state, it is decompressed but because it's bindless, all draw calls set stencil_dirty_level_mask to 1. v2: Marek - set the flags outside the loop - also clear and set

Re: [Mesa-dev] [PATCH 4/4] nir: add ARB_shader_ballot and ARB_shader_group_vote instructions

I'm not sure how I feel about having these as ALU operations. ALU operations are generally pure functions (with the exception derivative) that can be re-ordered at will. I don't really like breaking that. In fact, I'd almost be inclined to make derivatives intrinsics and just special-case them i

[Mesa-dev] [AppVeyor] mesa 17.1 #4523 completed

Build mesa 4523 completed Commit 97f6404e50 by Juan A. Suarez Romero on 6/5/2017 8:27 PM: docs: add release notes for 17.1.2\n\nSigned-off-by: Juan A. Suarez Romero Configure your notification preferences

Re: [Mesa-dev] [PATCH 6/8] radeonsi: precompute some fields for PA_CL_VS_OUT_CNTL in si_shader_selector

On 06/05/2017 06:50 PM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_shader.h| 3 +++ src/gallium/drivers/radeonsi/si_state.c | 21 + src/gallium/drivers/radeonsi/si_s

Re: [Mesa-dev] [PATCH 2/8] radeonsi: do EarlyCSEMemSSA LLVM pass

On 06/05/2017 06:50 PM, Marek Olšák wrote: From: Marek Olšák so that LLVM IR looks like CSE has been run on it. It's also recommended by the instruction combining pass. This also fixes: - GL45-CTS.arrays_of_arrays_gl.InteractionFunctionCalls2 (crash) - piglit/spec/arb_shader_ballot/execution

Re: [Mesa-dev] [PATCH 5/8] radeonsi: add a new helper si_get_vs

On 06/05/2017 06:50 PM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.h | 30 ++--- src/gallium/drivers/radeonsi/si_state_shaders.c | 6 ++--- 2 files changed, 19 insertions(+), 17 deletions(-) diff --git a/src/gallium/drivers

Re: [Mesa-dev] [PATCH 1/8] radeonsi: remove 8 bytes from si_shader_key

Reviewed-by: Samuel Pitoiset On 06/05/2017 06:50 PM, Marek Olšák wrote: From: Marek Olšák We can use a union in si_shader_key::mono. --- src/gallium/drivers/radeonsi/si_shader.c| 14 +++--- src/gallium/drivers/radeonsi/si_shader.h| 9 ++--- src/gallium/drivers

  1   2   >