Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net>
On Mon, Jun 5, 2017 at 5:55 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote:
> From: Nanley Chery <nanley.g.ch...@intel.com>
>
> Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com>
> ---
> src/intel/blorp/blorp_genX_exec.h | 8 --------
> src/intel/vulkan/anv_blorp.c | 16 ++++++++++++++++
> 2 files changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/src/intel/blorp/blorp_genX_exec.h
> b/src/intel/blorp/blorp_genX_exec.h
> index a354cea..2276d7c 100644
> --- a/src/intel/blorp/blorp_genX_exec.h
> +++ b/src/intel/blorp/blorp_genX_exec.h
> @@ -1500,14 +1500,6 @@ blorp_emit_gen8_hiz_op(struct blorp_batch *batch,
> }
>
> blorp_emit(batch, GENX(3DSTATE_WM_HZ_OP), hzp);
> -
> - /* Perform depth clear specific flushing */
> - if (params->hiz_op == BLORP_HIZ_OP_DEPTH_CLEAR &&
> params->depth.enabled) {
> - blorp_emit(batch, GENX(PIPE_CONTROL), pc) {
> - pc.DepthStallEnable = true;
> - pc.DepthCacheFlushEnable = true;
> - }
> - }
> }
> #endif
>
> diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
> index d94a2f8..a869eeb 100644
> --- a/src/intel/vulkan/anv_blorp.c
> +++ b/src/intel/vulkan/anv_blorp.c
> @@ -1323,6 +1323,22 @@ anv_cmd_buffer_clear_subpass(struct anv_cmd_buffer
> *cmd_buffer)
> clear_depth, clear_stencil,
> clear_att.clearValue.
> depthStencil.stencil);
> +
> + /* From the SKL PRM, Depth Buffer Clear:
> + *
> + * Depth Buffer Clear Workaround
> + * Depth buffer clear pass using any of the methods (WM_STATE,
> + * 3DSTATE_WM or 3DSTATE_WM_HZ_OP) must be followed by a
> + * PIPE_CONTROL command with DEPTH_STALL bit and Depth FLUSH
> bits
> + * “set” before starting to render. DepthStall and DepthFlush
> are
> + * not needed between consecutive depth clear passes nor is it
> + * required if the depth-clear pass was done with
> “full_surf_clear”
> + * bit set in the 3DSTATE_WM_HZ_OP.
> + */
> + if (clear_depth) {
> + cmd_buffer->state.pending_pipe_bits |=
> + ANV_PIPE_DEPTH_CACHE_FLUSH_BIT |
> ANV_PIPE_DEPTH_STALL_BIT;
> + }
> }
> }
>
> --
> 2.5.0.400.gff86faf
>
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
