I will take a look to this one today.
Thanks for pointing it
On 18/04/16 00:47, Ilia Mirkin wrote:
> On Mon, Mar 28, 2016 at 2:50 PM, Alejandro Piñeiro
> wrote:
>> v2:
>> * Take into account out varyings too (Timothy Arceri)
>> * Fix style (Timothy Arceri)
>> * Use a new ast_expression varia
After the previous patch, this helper is only called in one place.
So, just fold it back in - there are a lot of parameters here and
not much code.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_vec4.cpp | 40 ++
src/mesa/drivers/dri/i965/brw_vec
We don't handle this properly - we'd have to perform the type conversion
before trying to convert the value to a VF.
While we could do that, it doesn't seem particularly useful - most
vector loads should be consistently typed (all float or all integer).
As a special case, we do allow type-convert
Previously, opt_vector_float() always interpreted MOV sources as
floating point, and always created a MOV with a F-type destination.
This meant that we could mess up sequences of integer loads, such as:
mov vgrf6.0.x:D, 0D
mov vgrf6.0.y:D, 1D
mov vgrf6.0.z:D, 2D
mov vgrf6.0.w:D, 3D
H
This reworks opt_vector_float() so that there's only one place that
flushes out any accumulated state and emits a VF.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_vec4.cpp | 63 +++---
1 file changed, 35 insertions(+), 28 deletions(-)
diff --git a
On Saturday, April 16, 2016 4:42:35 PM PDT Topi Pohjolainen wrote:
> Otherwise switch from blorp to compute failes. Note that this now
> follows the normal i965 upload logic found in gen7_upload_urb().
>
> Effectively vs_size changes from 2 to 1 and vs_start from 2 to 4.
>
> Signed-off-by: Topi P
On Saturday, April 16, 2016 4:42:34 PM PDT Topi Pohjolainen wrote:
> Signed-off-by: Topi Pohjolainen
> ---
> src/mesa/drivers/dri/i965/gen7_blorp.cpp | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/gen7_blorp.cpp b/src/mesa/drivers/
dri/i9
On Saturday, April 16, 2016 4:42:30 PM PDT Topi Pohjolainen wrote:
> Signed-off-by: Topi Pohjolainen
> ---
> src/mesa/drivers/dri/i965/gen8_misc_state.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/gen8_misc_state.c b/src/mesa/drivers/
dri/
Grazvydas Ignotas writes:
> On Sun, Apr 17, 2016 at 2:50 AM, Emil Velikov
> wrote:
>> On 16 April 2016 at 02:00, Grazvydas Ignotas wrote:
>>> This is mostly for variables that are only used in asserts and cause
>>> unused-but-set-variable warnings in release builds. Could just use
>>> UNUSED d
From: Dave Airlie
Currently the texture member functions take a texture unit
number, in order for TXQ to work we want to use a dynamic
value here, so we need to pass in an value reference.
This means we can't do the assert or add the llvm name.
For most normal users they still pass a constant v
From: Dave Airlie
This isn't currently that easy to expand, so fix it up
before expanding it later to include dynamic samplers.
Signed-off-by: Dave Airlie
---
src/gallium/auxiliary/draw/draw_llvm_sample.c | 22 ++-
src/gallium/auxiliary/gallivm/lp_bld_sample.h | 21 ---
src/gal
Hi guys,
Another in the line of things I thought would take a few hours, but
took a few more hours again.
This adds dynamic indexing of samplers to llvmpipe as required
for ARB_gpu_shader5.
The first two patches reorg some code (I've left some things commented
out for now that I'll remove later)
From: Dave Airlie
This is a first attempt at adding support for dynamic indexing
of samplers to llvmpipe. This is needed for ARB_gpu_shader5 support.
This uses the sampler function generator to generate functions
for all samplers, then uses if statements to pick which one to call.
This passes a
From: Dave Airlie
This adds support for indirect samplers to the texture size query.
Signed-off-by: Dave Airlie
---
src/gallium/auxiliary/gallivm/lp_bld_sample.h | 2 ++
src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c | 3 +++
src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 9 +++
On 17.04.2016 09:49, nico...@ndufresne.ca wrote:
> From: Nicolas Dufresne
>
> Sorry for the long delay breaking down this patch. I have now rebased
> on top recent mesa tree. First patch creates a new function to convert
> DRI2 format into PIPE format (to avoid more copy paste). The second fixes
On 16.04.2016 19:20, Marek Olšák wrote:
> On Sat, Apr 16, 2016 at 8:04 AM, Michel Dänzer wrote:
>> On 16.04.2016 14:51, Michel Dänzer wrote:
>>> On 16.04.2016 11:39, Tom Stellard wrote:
The ds_bpermute instruction allows threads to transfer data directly
to or from the vgprs of other thr
On Sun, Apr 17, 2016 at 2:50 AM, Emil Velikov wrote:
> On 16 April 2016 at 02:00, Grazvydas Ignotas wrote:
>> This is mostly for variables that are only used in asserts and cause
>> unused-but-set-variable warnings in release builds. Could just use
>> UNUSED directly, but MAYBE_UNUSED should be l
Ran into kernel hangup using R600 driver.
The question is - how can i get some debug infomation?
Kdump and netconsole with debug kernel param doesn't show me anything useful.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedeskt
Reviewed-by: Marek Olšák
Marek
On Sun, Apr 17, 2016 at 1:43 AM, Bas Nieuwenhuizen
wrote:
> For use by radeonsi.
>
> v2: Make sure that it works for all 64 bits set.
>
> Signed-off-by: Bas Nieuwenhuizen
> ---
> src/gallium/auxiliary/util/u_math.h | 14 ++
> 1 file changed, 14 inser
Reviewed-by: Marek Olšák
Marek
On Sun, Apr 17, 2016 at 1:43 AM, Bas Nieuwenhuizen
wrote:
> We can then upload only the dirty ones with the constant engine.
>
> Signed-off-by: Bas Nieuwenhuizen
> ---
> src/gallium/drivers/radeonsi/si_descriptors.c | 37
> ---
> src/gal
Am 18.04.2016 um 00:31 schrieb Emil Velikov:
> Hi gents,
>
> On 17 April 2016 at 10:06, Jose Fonseca wrote:
>> On 16/04/16 22:30, srol...@vmware.com wrote:
>>>
>>> From: Roland Scheidegger
>>>
>>> llvm 3.7 sometimes simply miscompiles vector selects.
>>
>>
>> Reviewed-by: Jose Fonseca
>>
> We w
Hi all,
Mesa 11.1.3 is now available.
This realease fixes crashes in VAAPI and EGL, squashes build problems in
Nine and Android, OpenMAX decoding uses the correct timestamping, GLSL no
longer crashes on Android and GLX has been update against latest version
of the EXT_create_context_es2_profile s
On Mon, Mar 28, 2016 at 2:50 PM, Alejandro Piñeiro wrote:
> v2:
> * Take into account out varyings too (Timothy Arceri)
> * Fix style (Timothy Arceri)
> * Use a new ast_expression variable, instead of an
>ast_expression::hir new parameter (Timothy Arceri)
>
> Bugzilla: https://bugs.freedesk
https://bugs.freedesktop.org/show_bug.cgi?id=94195
Emil Velikov changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On Mon, Apr 18, 2016 at 12:19 AM, Bas Nieuwenhuizen
wrote:
> On Mon, Apr 18, 2016 at 12:13 AM, Marek Olšák wrote:
>> On Sun, Apr 17, 2016 at 1:43 AM, Bas Nieuwenhuizen
>> wrote:
>>> v2: Use 32 byte alignment.
>>>
>>> Signed-off-by: Bas Nieuwenhuizen
>>> ---
>>> src/gallium/drivers/radeonsi/si_
Hi gents,
On 17 April 2016 at 10:06, Jose Fonseca wrote:
> On 16/04/16 22:30, srol...@vmware.com wrote:
>>
>> From: Roland Scheidegger
>>
>> llvm 3.7 sometimes simply miscompiles vector selects.
>
>
> Reviewed-by: Jose Fonseca
>
We want this for stable (11.1/11.2), correct ?
-Emil
From: Nicolai Hähnle
Turns out that this is needed after all to satisfy some strengthened
coherency tests. Depends on support in LLVM, see
http://reviews.llvm.org/D19203
---
Note that this patch applies on top of the compute shader series, otherwise
you'll get a trivial merge conflict.
src/gall
https://bugs.freedesktop.org/show_bug.cgi?id=94972
Roland Scheidegger changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Am 17.04.2016 um 11:06 schrieb Jose Fonseca:
> On 16/04/16 22:30, srol...@vmware.com wrote:
>> From: Roland Scheidegger
>>
>> llvm 3.7 sometimes simply miscompiles vector selects.
>
> Reviewed-by: Jose Fonseca
>
>> See https://bugs.freedesktop.org/show_bug.cgi?id=94972
>
> Great detective work
On Mon, Apr 18, 2016 at 12:08 AM, Bas Nieuwenhuizen
wrote:
> On Mon, Apr 18, 2016 at 12:04 AM, Marek Olšák wrote:
>> On Sun, Apr 17, 2016 at 1:43 AM, Bas Nieuwenhuizen
>> wrote:
>>> Based on work by Marek Olšák.
>>>
>>> v2: Add preamble IB.
>>>
>>> Leaves the load packet in the space calculation
On Mon, Apr 18, 2016 at 12:13 AM, Marek Olšák wrote:
> On Sun, Apr 17, 2016 at 1:43 AM, Bas Nieuwenhuizen
> wrote:
>> v2: Use 32 byte alignment.
>>
>> Signed-off-by: Bas Nieuwenhuizen
>> ---
>> src/gallium/drivers/radeonsi/si_descriptors.c | 30
>> +++
>> src/gallium/dr
On Sun, Apr 17, 2016 at 1:43 AM, Bas Nieuwenhuizen
wrote:
> v2: Use 32 byte alignment.
>
> Signed-off-by: Bas Nieuwenhuizen
> ---
> src/gallium/drivers/radeonsi/si_descriptors.c | 30
> +++
> src/gallium/drivers/radeonsi/si_state.h | 3 +++
> 2 files changed, 24 i
On Mon, Apr 18, 2016 at 12:04 AM, Marek Olšák wrote:
> On Sun, Apr 17, 2016 at 1:43 AM, Bas Nieuwenhuizen
> wrote:
>> Based on work by Marek Olšák.
>>
>> v2: Add preamble IB.
>>
>> Leaves the load packet in the space calculation as the
>> radeon winsys might not be able to support a premable.
>>
Reviewed-by: Marek Olšák
Marek
On Sun, Apr 17, 2016 at 1:43 AM, Bas Nieuwenhuizen
wrote:
> From: Marek Olšák
>
> v2: Use the correct IB to update request (Bas Nieuwenhuizen)
> v3: Add preamble IB. (Bas Nieuwenhuizen)
> ---
> src/gallium/drivers/radeon/radeon_winsys.h | 30 ++
> src/ga
Reviewed-by: Marek Olšák
Marek
On Sun, Apr 17, 2016 at 1:43 AM, Bas Nieuwenhuizen
wrote:
> Necessary to prevent performance regressions due to extra flushing.
>
> Probably should enlarge it even further when also updating
> uniforms through the CE, but this seems large enough for now.
>
> v2: A
On Sun, Apr 17, 2016 at 1:43 AM, Bas Nieuwenhuizen
wrote:
> Based on work by Marek Olšák.
>
> v2: Add preamble IB.
>
> Leaves the load packet in the space calculation as the
> radeon winsys might not be able to support a premable.
>
> The added space calculation may look expensive, but
> is conver
On Apr 17, 2016 1:56 PM, "Dave Airlie" wrote:
>
> From: Dave Airlie
>
> Pointed out by coverity.
>
> Signed-off-by: Dave Airlie
> ---
> src/compiler/nir/nir_builder.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/compiler/nir/nir_builder.h
b/src/compiler/nir/nir_b
From: Dave Airlie
Pointed out by coverity.
Signed-off-by: Dave Airlie
---
src/compiler/nir/nir_builder.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h
index 29b13fb..1425dba 100644
--- a/src/compiler/nir/nir_
On 17/04/16 20:21, Marek Olšák wrote:
On Sun, Apr 17, 2016 at 8:23 PM, Jose Fonseca wrote:
On 17/04/16 13:57, Marek Olšák wrote:
On Sun, Apr 17, 2016 at 11:12 AM, Jose Fonseca
wrote:
On 16/04/16 23:27, Roland Scheidegger wrote:
Am 16.04.2016 um 14:50 schrieb Marek Olšák:
From: Marek
On Sun, Apr 17, 2016 at 4:27 PM, Pierre Moreau wrote:
> On 04:17 PM - Apr 17 2016, Ilia Mirkin wrote:
>> On Sun, Apr 17, 2016 at 4:07 PM, Pierre Moreau wrote:
>> > Ping :-)
>> >
>> > On 10:56 PM - Mar 19 2016, Pierre Moreau wrote:
>> >> Generating a `cvt u32 $r0 u64 $r1d` or a `cvt u64 $r0d u32 $
On 04:17 PM - Apr 17 2016, Ilia Mirkin wrote:
> On Sun, Apr 17, 2016 at 4:07 PM, Pierre Moreau wrote:
> > Ping :-)
> >
> > On 10:56 PM - Mar 19 2016, Pierre Moreau wrote:
> >> Generating a `cvt u32 $r0 u64 $r1d` or a `cvt u64 $r0d u32 $r2` makes the
> >> GPU
> >> unhappy. Instead, manually handle
On Sun, Apr 17, 2016 at 4:07 PM, Pierre Moreau wrote:
> Ping :-)
>
> On 10:56 PM - Mar 19 2016, Pierre Moreau wrote:
>> Generating a `cvt u32 $r0 u64 $r1d` or a `cvt u64 $r0d u32 $r2` makes the GPU
>> unhappy. Instead, manually handle the conversion between 64-bit and 32-bit
>> values, and use `cv
Ping :-)
On 10:56 PM - Mar 19 2016, Pierre Moreau wrote:
> Generating a `cvt u32 $r0 u64 $r1d` or a `cvt u64 $r0d u32 $r2` makes the GPU
> unhappy. Instead, manually handle the conversion between 64-bit and 32-bit
> values, and use `cvt` to convert between the original target (resp. source)
> and
Reviewed-by: Marek Olšák
Marek
On Sat, Apr 16, 2016 at 8:06 PM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> ---
> We will soon claim GLES 3.1 support, which requires gl_HelperInvocation,
> so now is the time to do this.
>
> This depends on LLVM support: http://reviews.llvm.org/D19191
>
>
On Sun, Apr 17, 2016 at 8:23 PM, Jose Fonseca wrote:
> On 17/04/16 13:57, Marek Olšák wrote:
>>
>> On Sun, Apr 17, 2016 at 11:12 AM, Jose Fonseca
>> wrote:
>>>
>>> On 16/04/16 23:27, Roland Scheidegger wrote:
Am 16.04.2016 um 14:50 schrieb Marek Olšák:
>
>
> From: Marek
Return statements in conditional blocks were not having their
output varyings lowered correctly.
This patch fixes the following piglit tests:
/spec/glsl-1.10/execution/vs-float-main-return
/spec/glsl-1.10/execution/vs-vec2-main-return
/spec/glsl-1.10/execution/vs-vec3-main-return
Signed-off-by: L
Interesting, and thanks for poking at this issue. I've been thinking
about tuning IB sizes as well. I'd like for us to get this right, so I
wonder: What's your theory for _why_ your change helps?
See below. I think you discovered it yourself.
I'll be honest with you: Right now, I think your a
Hi all,
The first stable release for the 11.2 branch - Mesa 11.2.1 is now available.
It fixes crashes in VAAPI, some build problems in Nine has been addressed,
adds a drirc workaround for Warsow and resolves issues in the nouveau,
radeonsi and i965 drivers.
Brian Paul (2):
st/mesa: fix glReadBu
On 17/04/16 13:57, Marek Olšák wrote:
On Sun, Apr 17, 2016 at 11:12 AM, Jose Fonseca wrote:
On 16/04/16 23:27, Roland Scheidegger wrote:
Am 16.04.2016 um 14:50 schrieb Marek Olšák:
From: Marek Olšák
we should use MESA_SHADER_* everywhere, but we're not ready for that yet
---
I think th
This is nicer indeed. For the series:
Reviewed-by: Nicolai Hähnle
On 16.04.2016 07:50, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeon/r600_query.h | 43 ++---
1 file changed, 23 insertions(+), 20 deletions(-)
diff --git a/src/gallium/drive
Reviewed-by: Nicolai Hähnle
On 15.04.2016 19:13, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/auxiliary/util/u_math.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/util/u_math.h
b/src/gallium/auxiliary/util/u_math.h
index 0a82915..d983af
On 15.04.2016 12:50, Grigori Goronzy wrote:
apps that cause a lot of synchronization benefit from small IB
sizes. The current IB size is a bit on the large side for this class
of apps. On the other hand, if there isn't much synchronization going
on, increasing the IB size can slightly improve per
Looks good to me. Series is
Reviewed-by: Nicolai Hähnle
On 17.04.2016 11:11, Marek Olšák wrote:
I discovered these programming sequences in our closed driver.
Please review.
Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lis
On 17 April 2016 at 00:43, Bas Nieuwenhuizen wrote:
> Based on work by Marek Olšák.
>
> v2: Add preamble IB.
>
> Leaves the load packet in the space calculation as the
> radeon winsys might not be able to support a premable.
>
> The added space calculation may look expensive, but
> is converted to
From: Marek Olšák
It's only required on the compute ring. This matches the closed driver.
The compute flag is removed to prevent confusion and Bas's compute shader
patches remove it in the whole function.
---
src/gallium/drivers/radeonsi/si_state_draw.c | 26 --
1 file c
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_state_draw.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c
b/src/gallium/drivers/radeonsi/si_state_draw.c
index c9f56c6..3efaecc 100644
--- a/src/
From: Marek Olšák
This is typically used by the closed driver before SURFACE_SYNC.
---
src/gallium/drivers/radeonsi/si_state_draw.c | 10 +-
src/gallium/drivers/radeonsi/sid.h | 1 +
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_state_draw.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c
b/src/gallium/drivers/radeonsi/si_state_draw.c
index 86fb443..c9f56c6 100644
--- a/src/gallium/drivers/radeonsi/si_state_draw.c
From: Marek Olšák
Yes, that flag is really needed.
---
src/gallium/drivers/radeonsi/si_state_draw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c
b/src/gallium/drivers/radeonsi/si_state_draw.c
index 40cad50..8f4eba4 100644
---
From: Marek Olšák
I'm not sure about this. This will make the engines go idle, but the caches
will be unflushed. This should match app behavior without performance
counters, which can be a good thing.
---
src/gallium/drivers/radeonsi/si_perfcounter.c | 9 ++---
1 file changed, 6 insertions(+
From: Marek Olšák
---
src/gallium/drivers/radeon/r600_query.c | 4 ++--
src/gallium/drivers/radeon/r600d_common.h | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/radeon/r600_query.c
b/src/gallium/drivers/radeon/r600_query.c
index de6e37b..346238e 1006
I discovered these programming sequences in our closed driver.
Please review.
Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Hello
I would like to make a few comments about wiki pages such as
https://www.freedesktop.org/wiki/AccountRequests/
At first glance, the wiki page feels very old-school. That isn't a major
problem by itself, because retro-things can have their own distinct
quality. Unfortunately, I do not see th
On Sun, Apr 17, 2016 at 11:12 AM, Jose Fonseca wrote:
> On 16/04/16 23:27, Roland Scheidegger wrote:
>>
>> Am 16.04.2016 um 14:50 schrieb Marek Olšák:
>>>
>>> From: Marek Olšák
>>>
>>> we should use MESA_SHADER_* everywhere, but we're not ready for that yet
>>> ---
>>
>>
>> I think the idea initi
https://bugs.freedesktop.org/show_bug.cgi?id=94979
Bug ID: 94979
Summary: dolphin-emu rendering broken on gallium/SWR + crashing
often
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (All)
On Sun, Apr 17, 2016 at 1:22 AM, Emil Velikov wrote:
> On 16 April 2016 at 22:04, Marek Olšák wrote:
>> On Sat, Apr 16, 2016 at 9:40 PM, Rob Clark wrote:
>>> On Sat, Apr 16, 2016 at 8:50 AM, Marek Olšák wrote:
From: Marek Olšák
and remove number assignments which are consecutive
https://bugs.freedesktop.org/show_bug.cgi?id=94969
---
src/intel/vulkan/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am
index cba6671..5aedef8 100644
--- a/src/intel/vulkan/Makefile.am
+++ b/src/intel/vulka
On 16/04/16 22:51, Rob Clark wrote:
On Sat, Apr 16, 2016 at 5:49 PM, Rob Clark wrote:
On Sat, Apr 16, 2016 at 5:04 PM, Marek Olšák wrote:
On Sat, Apr 16, 2016 at 9:40 PM, Rob Clark wrote:
On Sat, Apr 16, 2016 at 8:50 AM, Marek Olšák wrote:
From: Marek Olšák
and remove number assignments
On 16/04/16 23:27, Roland Scheidegger wrote:
Am 16.04.2016 um 14:50 schrieb Marek Olšák:
From: Marek Olšák
we should use MESA_SHADER_* everywhere, but we're not ready for that yet
---
I think the idea initially was that tgsi is essentially self-contained:
you can parse the token stream witho
On 16/04/16 22:30, srol...@vmware.com wrote:
From: Roland Scheidegger
llvm 3.7 sometimes simply miscompiles vector selects.
Reviewed-by: Jose Fonseca
See https://bugs.freedesktop.org/show_bug.cgi?id=94972
Great detective work.
I think you should make a LLVM test case out of the IR on th
Both patches are:
Reviewed-by: Eduardo Lima Mitev
Thanks!
Eduardo
On 04/16/2016 09:26 PM, Juha-Pekka Heikkila wrote:
> These are just fixes for error paths.
>
> Juha-Pekka Heikkila (2):
> meta: Avoid random memory access on error
> meta: initialize values to avoid random behaviour on error
71 matches
Mail list logo
