From: Marek Olšák <marek.ol...@amd.com>

Yes, that flag is really needed.
---
 src/gallium/drivers/radeonsi/si_state_draw.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c 
b/src/gallium/drivers/radeonsi/si_state_draw.c
index 40cad50..8f4eba4 100644
--- a/src/gallium/drivers/radeonsi/si_state_draw.c
+++ b/src/gallium/drivers/radeonsi/si_state_draw.c
@@ -615,7 +615,7 @@ void si_emit_cache_flush(struct si_context *si_ctx, struct 
r600_atom *atom)
         * doesn't seem to work reliably. Since the bug doesn't affect
         * correctness (it only does more work than necessary) and
         * the performance impact is likely negligible, there is no plan
-        * to fix it.
+        * to add a workaround for it.
         */
 
        if (sctx->flags & SI_CONTEXT_INV_ICACHE)
@@ -628,7 +628,6 @@ void si_emit_cache_flush(struct si_context *si_ctx, struct 
r600_atom *atom)
        if (sctx->flags & SI_CONTEXT_INV_GLOBAL_L2) {
                cp_coher_cntl |= S_0085F0_TC_ACTION_ENA(1);
 
-               /* TODO: this might not be needed. */
                if (sctx->chip_class >= VI)
                        cp_coher_cntl |= S_0301F0_TC_WB_ACTION_ENA(1);
        }
-- 
2.5.0

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to