Re: [Mesa-dev] [PATCH 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-04 Thread Oded Gabbay
On Wed, Aug 5, 2015 at 9:36 AM, Christian Zigotzky wrote: > Hi Oded, > > Is the r600g driver ready for the Gallium3D infrastructure of big endian > hosts or did you only solve the wrong colors problem? > > Cheers, > > Christian > Hi Christian, I'm only working on software rendering at the moment

Re: [Mesa-dev] [PATCH v3 (part2) 08/56] glsl: add support for unsized arrays in shader storage blocks

2015-08-04 Thread Iago Toral
On Tue, 2015-08-04 at 14:08 -0700, Jordan Justen wrote: > On 2015-07-14 00:46:10, Iago Toral Quiroga wrote: > > From: Samuel Iglesias Gonsalvez > > > > They only can be defined in the last position of the shader > > storage blocks. > > > > When an unsized array is used in different shaders, it m

Re: [Mesa-dev] [PATCH 1/2] i965: Correct a mistake that always forced texture tiling.

2015-08-04 Thread Matt Turner
On Tue, Aug 4, 2015 at 11:18 PM, Matt Turner wrote: > Regression since commit 3a31876600, when tiling modes were moved into > layout_flags. > > The relevant enum values are > >MIPTREE_LAYOUT_ALLOC_YTILED = 1 << 5 >MIPTREE_LAYOUT_ALLOC_XTILED = 1 << 6 >MIPTREE_LAYOUT_ALLOC_ANY_TILED = M

Re: [Mesa-dev] ssbo, vec4, nir - Re: [PATCH v3 (part2) 00/56] ARB_shader_storage_buffer_object (mesa, i965)

2015-08-04 Thread Iago Toral
On Tue, 2015-08-04 at 17:54 -0700, Jason Ekstrand wrote: > On Tue, Aug 4, 2015 at 5:09 PM, Jordan Justen > wrote: > > I checked the extension spec, and it appears that like image > > load/store, ssbo is only required in fragment and compute stages. I > > don't think the ssbo support in vec4 is qu

[Mesa-dev] [PATCH 2/2] i965: Make MIPTREE_LAYOUT_ALLOC_ANY_TILED an enum value.

2015-08-04 Thread Matt Turner
--- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h index 89fdccb..540c655 100644 --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.

[Mesa-dev] [PATCH 1/2] i965: Correct a mistake that always forced texture tiling.

2015-08-04 Thread Matt Turner
Regression since commit 3a31876600, when tiling modes were moved into layout_flags. The relevant enum values are MIPTREE_LAYOUT_ALLOC_YTILED = 1 << 5 MIPTREE_LAYOUT_ALLOC_XTILED = 1 << 6 MIPTREE_LAYOUT_ALLOC_ANY_TILED = MIPTREE_LAYOUT_ALLOC_YTILED | MI

Re: [Mesa-dev] [PATCH 1/2] glsl: add variable mode check to build_stageref

2015-08-04 Thread Timothy Arceri
On Tue, 2015-08-04 at 21:20 +1000, Timothy Arceri wrote: > On Tue, 2015-08-04 at 08:24 +0300, Tapani Pälli wrote: > > > > On 08/04/2015 01:27 AM, Timothy Arceri wrote: > > > On Mon, 2015-08-03 at 23:16 +1000, Timothy Arceri wrote: > > > > On Mon, 2015-08-03 at 09:02 +0300, Tapani Pälli wrote: > >

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-04 Thread Jan Vesely
On Tue, 2015-08-04 at 22:40 +0200, Zoltan Gilian wrote: > There is no MDOperand in llvm 3.5. thanks, this fixes the build for me. jan > --- > src/gallium/state_trackers/clover/llvm/invocation.cpp | 19 > ++- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/s

[Mesa-dev] [PATCH 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-04 Thread Christian Zigotzky
Hi All, I know the false colors problems. Some Linux programs appear to be ABGR instead of RGBA, thus green becomes purple, red becomes light blue etc. I created a bug report on freedesktop.org. Bug report 72877: https://bugs.freedesktop.org/show_bug.cgi?id=72877 and http://lists.freedesktop

[Mesa-dev] help:read data out from Pixel buffer surface

2015-08-04 Thread InjuredWolf
background:having android apps run on X11 on base mesa OES lib: libgles1-mesa-dev libgles2-mesa-dev libosmesa6-dev what to do: render all surfaces to program memory. problems: 1) glMapBuffer returns NULL.OES_mapbuffer seemed not work. though the extension was available. 2) GL_READ_ONLY ,

[Mesa-dev] help:glGetString(GL_VERSION/GL_EXTENSIONS/GL_VENDER/DL_RENDERER) returns NULL

2015-08-04 Thread InjuredWolf
the original code worked because it was called after result = eglMakeCurrent(display, surface, surface, context); I wanted to use OSMesa. After I changed the call to OSMesaMakeCurrent.glGetString() returned NULL. Please advise. thanks h___

Re: [Mesa-dev] [PATCH 1/6] egl/x11: bail out if we cannot fetch the xcb connection

2015-08-04 Thread Eric Anholt
Emil Velikov writes: > Strictly speaking the xcb_connection_has_error() might be sufficient, > yet the documentation does not mention what will happen if NULL is fed > to the function. > > Keep things explicit, which will allow us to remove the dri2_dpy->conn > checking with the next commit. > >

Re: [Mesa-dev] [PATCH] glx: Fix __glXWireToEvent for BufferSwapComplete

2015-08-04 Thread Eric Anholt
Adam Jackson writes: > In the DRI2 path this event is magically synthesized from the > corresponding DRI2 event, but with Present, the server sends us the > event itself. The DRI2 path fills in the serial number, send_event, and > display fields of the XEvent struct that the app sees, but the Pre

Re: [Mesa-dev] Mesa (master): glsl: Add constuctors for the common cases of glsl_struct_field

2015-08-04 Thread Michel Dänzer
Hi Ian, On 04.08.2015 03:11, Ian Romanick wrote: > Module: Mesa > Branch: master > Commit: 7ac946e546bba440f87ce95ef022745201744f9c > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=7ac946e546bba440f87ce95ef022745201744f9c > > Author: Ian Romanick > Date: Thu Jul 30 06:00:56 2015

Re: [Mesa-dev] [PATCH 00/11] RadeonSI and Gallium HUD improvements

2015-08-04 Thread Michel Dänzer
On 03.08.2015 21:42, Marek Olšák wrote: > This improves the HUD for RadeonSI. The series is Reviewed-by: Michel Dänzer > Hopefully, an introductory message like this makes it easier for > Michel not to miss this. FWIW, I don't remember having missed any of your patches. Last week I was swampe

Re: [Mesa-dev] [PATCH] radeonsi: before storing tess levels, load them from LDS instead of temporary

2015-08-04 Thread Michel Dänzer
On 03.08.2015 21:43, Marek Olšák wrote: > From: Marek Olšák > > Also use only one store if stride <= 4. > All the fetches from and stores to temporaries can be removed now. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91461 Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer

Re: [Mesa-dev] [PATCH] winsys/radeon: loosen up the requirements for how much memory IBs can use

2015-08-04 Thread Michel Dänzer
On 03.08.2015 21:43, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_cs.c > b/src/gallium/winsys/radeon/drm/radeon_drm_

Re: [Mesa-dev] [PATCH] gallium/radeon: add a debug flag not to use write combining

2015-08-04 Thread Michel Dänzer
On 03.08.2015 21:36, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeon/r600_buffer_common.c | 6 -- > src/gallium/drivers/radeon/r600_pipe_common.c | 1 + > src/gallium/drivers/radeon/r600_pipe_common.h | 1 + > 3 files changed, 6 insertions(+), 2 deletions(

Re: [Mesa-dev] ssbo, vec4, nir - Re: [PATCH v3 (part2) 00/56] ARB_shader_storage_buffer_object (mesa, i965)

2015-08-04 Thread Jason Ekstrand
On Tue, Aug 4, 2015 at 5:09 PM, Jordan Justen wrote: > I checked the extension spec, and it appears that like image > load/store, ssbo is only required in fragment and compute stages. I > don't think the ssbo support in vec4 is quite as problematic as image > load/store, so I'm not sure this infor

[Mesa-dev] ssbo, vec4, nir - Re: [PATCH v3 (part2) 00/56] ARB_shader_storage_buffer_object (mesa, i965)

2015-08-04 Thread Jordan Justen
I checked the extension spec, and it appears that like image load/store, ssbo is only required in fragment and compute stages. I don't think the ssbo support in vec4 is quite as problematic as image load/store, so I'm not sure this information will prove useful. I did wonder what path we should ta

Re: [Mesa-dev] [PATCH 2/3] radeonsi: add support for FIJI (v4)

2015-08-04 Thread Edward O'Callaghan
LGTM Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Aug 4, 2015, at 03:51 AM, Alex Deucher wrote: > v2: incorporate comments from Marek > v3: add missing fiji case in winsys init > use tonga raster config (double check this) > v4: rebase on h

Re: [Mesa-dev] [PATCH 3/3] radeonsi: add fiji pci id

2015-08-04 Thread Edward O'Callaghan
LGTM Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Aug 4, 2015, at 03:51 AM, Alex Deucher wrote: > Reviewed-by: Marek Olšák > Reviewed-by: Christian König > Reviewed-by: David Zhang > Signed-off-by: Alex Deucher > --- > include/pci_ids/rade

Re: [Mesa-dev] [PATCH 1/3] addrlib: add support for Fiji (v2)

2015-08-04 Thread Edward O'Callaghan
LGTM Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Aug 4, 2015, at 03:51 AM, Alex Deucher wrote: > v2: fix tonga chip check > > Reviewed-by: Marek Olšák > Reviewed-by: Christian König > Reviewed-by: David Zhang > Signed-off-by: Alex Deucher

Re: [Mesa-dev] [PATCH] nir: Use a single bit for the dual-source blend index

2015-08-04 Thread Timothy Arceri
On Tue, 2015-08-04 at 18:15 -0400, Rob Clark wrote: > On Sun, Aug 2, 2015 at 1:04 AM, Timothy Arceri > wrote: > > The only values allowed are 0 and 1, and the value is checked before > > assigning. > > > > This is a copy of 8eeca7a56c that seems to have been made to the glsl > > ir type after it

Re: [Mesa-dev] [PATCH v3 (part2) 09/56] glsl: Add parser/compiler support for unsized array's length()

2015-08-04 Thread Jordan Justen
On 2015-08-04 15:12:06, Jordan Justen wrote: > On 2015-07-14 00:46:11, Iago Toral Quiroga wrote: > > From: Samuel Iglesias Gonsalvez > > > > It also creates unop and triop expressions to tell the driver to > > calculate the unsized array length. > > > > It is needed two expressions to do the cal

Re: [Mesa-dev] [PATCH v3 (part2) 10/56] glsl: Lower unsized array's length calculation expression

2015-08-04 Thread Jordan Justen
On 2015-07-14 00:46:12, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/glsl/lower_ubo_reference.cpp | 179 > +++ > 1 file changed, 179 insertions(+) > > diff --git a/src/glsl/lower_ubo_re

Re: [Mesa-dev] [PATCH] nir: Use a single bit for the dual-source blend index

2015-08-04 Thread Rob Clark
On Sun, Aug 2, 2015 at 1:04 AM, Timothy Arceri wrote: > The only values allowed are 0 and 1, and the value is checked before > assigning. > > This is a copy of 8eeca7a56c that seems to have been made to the glsl > ir type after it was copied for use in nir but before nir landed. > --- > src/glsl/

Re: [Mesa-dev] [PATCH v3 (part2) 09/56] glsl: Add parser/compiler support for unsized array's length()

2015-08-04 Thread Jordan Justen
On 2015-07-14 00:46:11, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > It also creates unop and triop expressions to tell the driver to > calculate the unsized array length. > > It is needed two expressions to do the calculation: "Two expressions are needed to do the calculatio

Re: [Mesa-dev] [PATCH 2/2] tgsi_to_nir: Convert to using VARYING_SLOT_* / FRAG_RESULT_*.

2015-08-04 Thread Rob Clark
On Tue, Aug 4, 2015 at 5:28 PM, Eric Anholt wrote: > This avoids exceeding the size of the .index bitfield since it got > truncated, and should make our NIR look more like the NIR that the rest of > the NIR developers are working on. > --- > The freedreno changes here are untested. > > src/galliu

[Mesa-dev] [PATCH 1/2] mesa: Move varying slots and FS output names to shader_enums.h

2015-08-04 Thread Eric Anholt
They're used by glsl_to_nir.cpp, and I want to use them in TGSI-to-NIR as well (our use of the var->index slot to store slot properties no longer works since it got truncated). The *_MAX defines are left in mtypes.h, because they depend on config.h. --- src/glsl/shader_enums.h | 98 +

[Mesa-dev] [PATCH 2/2] tgsi_to_nir: Convert to using VARYING_SLOT_* / FRAG_RESULT_*.

2015-08-04 Thread Eric Anholt
This avoids exceeding the size of the .index bitfield since it got truncated, and should make our NIR look more like the NIR that the rest of the NIR developers are working on. --- The freedreno changes here are untested. src/gallium/auxiliary/nir/tgsi_to_nir.c| 144 +++--

Re: [Mesa-dev] [PATCH v3 (part2) 08/56] glsl: add support for unsized arrays in shader storage blocks

2015-08-04 Thread Jordan Justen
On 2015-07-14 00:46:10, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > They only can be defined in the last position of the shader > storage blocks. > > When an unsized array is used in different shaders, it might be > converted in different sized arrays, avoid get a linker erro

[Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-04 Thread Zoltan Gilian
There is no MDOperand in llvm 3.5. --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp index

Re: [Mesa-dev] [PATCH v2 1/2] mesa: clear existing swizzle info before bitwise-OR

2015-08-04 Thread Oded Gabbay
On Tue, Aug 4, 2015 at 8:24 PM, Matt Turner wrote: > > On Tue, Aug 4, 2015 at 10:17 AM, Oded Gabbay wrote: > > This patch fixes a bug in big-endian treatment, where the previous > > swizzle info wasn't cleared before a new swizzle info was inserted into > > the format field using a bitwise-OR ope

[Mesa-dev] [PATCH v3 1/2] mesa: clear existing swizzle info before bitwise-OR

2015-08-04 Thread Oded Gabbay
This patch fixes a bug in big-endian treatment, where the previous swizzle info wasn't cleared before a new swizzle info was inserted into the format field using a bitwise-OR operation. v2: use MESA_ARRAY_FORMAT_SWIZZLE_*_MASK instead of numeric constants v3: align according to coding style Signe

Re: [Mesa-dev] [PATCH v2 00/78] i965: A new vec4 backend based on NIR

2015-08-04 Thread Jason Ekstrand
On Tue, Aug 4, 2015 at 2:42 AM, Antía Puentes wrote: > Hi! Jason, > > On lun, 2015-08-03 at 17:25 -0700, Jason Ekstrand wrote: >> On Mon, Aug 3, 2015 at 9:51 AM, Jason Ekstrand wrote: > >> > I also pushed a version to our CI system that switched the >> > INTEL_USE_NIR default to true and things l

Re: [Mesa-dev] [PATCH v4 (part2) 04/56] i965: set ARB_shader_storage_buffer_object related constant values

2015-08-04 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2015-07-22 23:42:55, Samuel Iglesias Gonsalvez wrote: > v2: > - Add tessellation shader constants assignment > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/mesa/drivers/dri/i965/brw_context.c | 12 > 1 file changed, 12 insertions(+) > > dif

Re: [Mesa-dev] [PATCH] glsl: Allow token pasting in ESSL

2015-08-04 Thread Ian Romanick
On 07/22/2015 07:52 PM, Ryan Houdek wrote: > All vendors I've tested allow token pasting in their ESSL shaders. > At least one application expects this to be supported > even though it is against spec. I'm not very excited about deviating from the spec. Do you know if the Khronos reference compil

[Mesa-dev] [PATCH 0/4] i965/cs: gl_WorkGroupID support

2015-08-04 Thread Jordan Justen
git://people.freedesktop.org/~jljusten/mesa i965-workgroup-id-v1 Allows piglit's tests/spec/arb_compute_shader/execution/basic-group-id-atomic.shader_test to pass. To test, I set MESA_GL_VERSION_OVERRIDE=4.3, MESA_GLSL_VERSION_OVERRIDE=430 and MESA_EXTENSION_OVERRIDE=GL_ARB_compute_shader. Jorda

[Mesa-dev] [PATCH 3/4] i965/cs: Initialize gl_WorkGroupID variable from payload

2015-08-04 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_cs.cpp | 19 +++ src/mesa/drivers/dri/i965/brw_fs.h | 1 + 2 files changed, 20 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_cs.cpp b/src/mesa/drivers/dri/i965/brw_cs.cpp index 3e68327..14c69a2 100644 -

[Mesa-dev] [PATCH 4/4] i965/nir: Support gl_WorkGroupID variable

2015-08-04 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 16 1 file changed, 16 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 711ace6..a0b20c4 100644 --- a/src/mesa/drivers/dri/i965/brw_fs

[Mesa-dev] [PATCH 2/4] nir: Add gl_WorkGroupID system variable

2015-08-04 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/glsl/nir/nir_intrinsics.h | 1 + src/glsl/nir/nir_lower_system_values.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/glsl/nir/nir_intrinsics.h b/src/glsl/nir/nir_intrinsics.h index 29b5e64..6987d42 100644 --- a/src/glsl/nir/nir_intrinsi

[Mesa-dev] [PATCH 1/4] glsl/cs: Add gl_WorkGroupID variable

2015-08-04 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/glsl/builtin_variables.cpp | 2 ++ src/glsl/shader_enums.h| 1 + 2 files changed, 3 insertions(+) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index b2936a5..8fa7b19 100644 --- a/src/glsl/builtin_variables.cpp +++ b/src

Re: [Mesa-dev] [PATCH v3 10/17] mesa: Add missing check of format and type in glTexSubImageXD on GLES 3.0

2015-08-04 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 08/04/2015 11:02 AM, Eduardo Lima Mitev wrote: > Argument validation for glTexSubImageXD is missing a check of format and type > against texture object's internal format when profile is OpenGL-ES 3.0+. > > This patch also groups together all format and

Re: [Mesa-dev] [PATCH v3 10/17] mesa: Add missing check of format and type in glTexSubImageXD on GLES 3.0

2015-08-04 Thread Brian Paul
On 08/04/2015 12:02 PM, Eduardo Lima Mitev wrote: Argument validation for glTexSubImageXD is missing a check of format and type against texture object's internal format when profile is OpenGL-ES 3.0+. This patch also groups together all format and type checks on GLES into a new function texture_

[Mesa-dev] [PATCH v3 10/17] mesa: Add missing check of format and type in glTexSubImageXD on GLES 3.0

2015-08-04 Thread Eduardo Lima Mitev
Argument validation for glTexSubImageXD is missing a check of format and type against texture object's internal format when profile is OpenGL-ES 3.0+. This patch also groups together all format and type checks on GLES into a new function texture_format_error_check_gles(), to factorize similar code

Re: [Mesa-dev] [PATCH] nir: Add a nir_lower_load_const_to_scalar() pass.

2015-08-04 Thread Matt Turner
On Mon, Aug 3, 2015 at 5:44 PM, Eric Anholt wrote: > This is useful to increase the CSE opportunities for a scalar backend. It > avoids regressions when dropping vc4's custom CSE implementation. > --- > src/glsl/Makefile.sources | 1 + > src/glsl/nir/nir.h

Re: [Mesa-dev] [PATCH v2 1/2] mesa: clear existing swizzle info before bitwise-OR

2015-08-04 Thread Matt Turner
On Tue, Aug 4, 2015 at 10:17 AM, Oded Gabbay wrote: > This patch fixes a bug in big-endian treatment, where the previous > swizzle info wasn't cleared before a new swizzle info was inserted into > the format field using a bitwise-OR operation. > > v2: use MESA_ARRAY_FORMAT_SWIZZLE_*_MASK instead o

[Mesa-dev] [PATCH v2 1/2] mesa: clear existing swizzle info before bitwise-OR

2015-08-04 Thread Oded Gabbay
This patch fixes a bug in big-endian treatment, where the previous swizzle info wasn't cleared before a new swizzle info was inserted into the format field using a bitwise-OR operation. v2: use MESA_ARRAY_FORMAT_SWIZZLE_*_MASK instead of numeric constants Signed-off-by: Oded Gabbay CC: "10.5 10.

Re: [Mesa-dev] [PATCH 1/2] mesa: clear existing swizzle info before bitwise-OR

2015-08-04 Thread Oded Gabbay
On Mon, Aug 3, 2015 at 6:29 PM, Emil Velikov wrote: > On 2 August 2015 at 11:37, Oded Gabbay wrote: > > This patch fixes a bug in big-endian handling, where the previous > > swizzle info wasn't cleared before a new swizzle info was inserted into > > the format field using a bitwise-OR operation.

[Mesa-dev] [Bug 91556] clSetKernelArg from OpenCL is erroring out incorrectly

2015-08-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91556 --- Comment #1 from Pavan Yalamanchili --- This was tested on Fedora 22 with AMD A10 5800K. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. __

Re: [Mesa-dev] [PATCH 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-04 Thread Oded Gabbay
On Mon, Aug 3, 2015 at 6:40 PM, Emil Velikov wrote: > Hi Oded, > > On 2 August 2015 at 11:37, Oded Gabbay wrote: > > This patch fixes a bug that is manifested in the read path of mesa when > > running on big-endian machines. The effects can be seen when running > > piglit sanity test and/or taki

[Mesa-dev] [Bug 91556] clSetKernelArg from OpenCL is erroring out incorrectly

2015-08-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91556 Pavan Yalamanchili changed: What|Removed |Added CC||cont...@pavanky.com -- You are rec

[Mesa-dev] [Bug 91556] clSetKernelArg from OpenCL is erroring out incorrectly

2015-08-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91556 Bug ID: 91556 Summary: clSetKernelArg from OpenCL is erroring out incorrectly Product: Mesa Version: 10.6 Hardware: Other OS: All Status: NEW Severity: no

Re: [Mesa-dev] [PATCH] clover: clEnqueue* should block when asked for

2015-08-04 Thread Tom Stellard
On Mon, Aug 03, 2015 at 12:53:32PM +0300, Francisco Jerez wrote: > EdB writes: > > > As a side effect, this fix clRetain/ReleaseEvent Piglit test > > --- > > src/gallium/state_trackers/clover/api/transfer.cpp | 29 > > -- > > 1 file changed, 27 insertions(+), 2 deletions(-)

Re: [Mesa-dev] [PATCH] gallium/radeon: always use the llvm. prefix in intrinsic names

2015-08-04 Thread Tom Stellard
On Mon, Aug 03, 2015 at 05:29:47PM +0900, Michel Dänzer wrote: > On 01.08.2015 00:35, Marek Olšák wrote: > > From: Marek Olšák > > [...] > > > @@ -1176,8 +1176,18 @@ static void emit_frac( > > struct lp_build_emit_data * emit_data) > > { > > LLVMBuilderRef builder = bld_base->ba

Re: [Mesa-dev] [PATCH 08/14] i965: Define and initialize image parameter structure.

2015-08-04 Thread Francisco Jerez
Francisco Jerez writes: > Ping. Some 10-20 other ARB_shader_image_load_store patches are blocking > on this patch I've been carrying around since I originally sent it for > review in Dec 2013. > Hint for reviewers: A quick comparison with "i965/fs: Import image memory offset calculation code."

Re: [Mesa-dev] [PATCH 09/20] glsl: add support for initialising sampler AoA

2015-08-04 Thread Timothy Arceri
On Tue, 2015-08-04 at 14:54 +0300, Tapani Pälli wrote: > Hi; > > I've tried to understand more about AoA to review the linker changes. > > Now I'm testing your patches (and taking currently closer look at 9/20). > Overall it looks fine, calling itself recursively for each array level. > However

Re: [Mesa-dev] [PATCH 2/2] i965: Fix brw_memory_barrier() for SKL.

2015-08-04 Thread Francisco Jerez
Francisco Jerez writes: > This works as-is on SKL, only the assertion needs to be relaxed. I'm going to push this straightforward series I sent back in May without review if there have been no complaints by the end of the week. > --- > src/mesa/drivers/dri/i965/brw_program.c | 2 +- > 1 file c

Re: [Mesa-dev] [PATCH 08/14] i965: Define and initialize image parameter structure.

2015-08-04 Thread Francisco Jerez
Ping. Some 10-20 other ARB_shader_image_load_store patches are blocking on this patch I've been carrying around since I originally sent it for review in Dec 2013. Francisco Jerez writes: > This will be used to pass image meta-data to the shader when we cannot > use typed surface reads and write

Re: [Mesa-dev] [PATCH v2 3/6] i965/vec4: Don't emit scratch reads for a spilled register we have just written

2015-08-04 Thread Francisco Jerez
Iago Toral writes: > On Thu, 2015-07-30 at 17:08 +0300, Francisco Jerez wrote: >> Iago Toral Quiroga writes: >> >> > When we have code such as this: >> > >> > mov vgrf1.0.x:F, vgrf2.:F >> > mov vgrf3.0.x:F, vgrf1.:F >> > ... >> > mov vgrf3.0.x:F, vgrf1.:F >> > >> > And vgrf1 is chos

Re: [Mesa-dev] [PATCH v2 3/6] i965/vec4: Don't emit scratch reads for a spilled register we have just written

2015-08-04 Thread Francisco Jerez
Iago Toral writes: > On Fri, 2015-07-31 at 13:12 +0300, Francisco Jerez wrote: >> Iago Toral writes: >> >> > On Thu, 2015-07-30 at 17:08 +0300, Francisco Jerez wrote: >> >> Iago Toral Quiroga writes: >> >> >> >> > When we have code such as this: >> >> > >> >> > mov vgrf1.0.x:F, vgrf2.:F >

[Mesa-dev] [PATCH v2 2/3] egl/x11: set EGL_BAD_NATIVE_(PIXMAP|WINDOW) for invalid pixmaps/windows

2015-08-04 Thread Frank Binns
Both eglCreatePixmapSurface and eglCreateWindowSurface were incorrectly setting the EGL error to be EGL_BAD_ALLOC when an invalid native drawable handle was being passed in. The EGL spec states the following for eglCreatePixmapSurface: "If pixmap is not a valid native pixmap handle, then a

[Mesa-dev] [PATCH v2 1/3] egl/x11: fix use of EGL_BAD_NATIVE_WINDOW

2015-08-04 Thread Frank Binns
Commit 4ed23fd590 introduced some calls to _eglError inappropriately passing it EGL_BAD_NATIVE_WINDOW. This was actually harmless in two of the cases as _eglError gets called later on with a more appropriate error code but (just to be safe) switch these to _eglLog calls instead. The final case is

[Mesa-dev] [PATCH v2 3/3] egl/x11: don't abort when creating a DRI2 drawable fails

2015-08-04 Thread Frank Binns
When calling either eglCreateWindowSurface or eglCreatePixmapSurface it was possible for an application to be aborted as a result of it failing to create a DRI2 drawable on the server. This could happen due to an application passing in an invalid native drawable handle, for example. v2: Handle the

Re: [Mesa-dev] [PATCH v2 10/17] mesa: Add missing check of format and type in glTexSubImageXD on GLES 3.0

2015-08-04 Thread Brian Paul
On 08/04/2015 05:07 AM, Eduardo Lima Mitev wrote: Argument validation for glTexSubImageXD is missing a check of format and type against texture object's internal format when profile is OpenGL-ES 3.0+. This patch also groups together all format and type checks into a single block of code for clar

Re: [Mesa-dev] [PATCH] glsl: default standalone compiler to 4.50

2015-08-04 Thread Timothy Arceri
On Tue, 2015-08-04 at 23:03 +1000, Timothy Arceri wrote: > On Fri, 2015-07-24 at 15:48 -0400, Ilia Mirkin wrote: > > Signed-off-by: Ilia Mirkin > > --- > > > > There seems to be a huge overlap between what initialize_context and > > initialize_context_to_defaults do, wasn't sure where to stick wh

Re: [Mesa-dev] [PATCH] glsl: default standalone compiler to 4.50

2015-08-04 Thread Timothy Arceri
On Fri, 2015-07-24 at 15:48 -0400, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > > There seems to be a huge overlap between what initialize_context and > initialize_context_to_defaults do, wasn't sure where to stick what. > > src/glsl/main.cpp | 26 +- > 1 file

Re: [Mesa-dev] [PATCH 09/20] glsl: add support for initialising sampler AoA

2015-08-04 Thread Tapani Pälli
Hi; I've tried to understand more about AoA to review the linker changes. Now I'm testing your patches (and taking currently closer look at 9/20). Overall it looks fine, calling itself recursively for each array level. However, with fs-initializer-const-index.shader_test it seems to set bindi

Re: [Mesa-dev] [PATCH] mesa: do not modify args when errors with GetProgramResourceName

2015-08-04 Thread Timothy Arceri
On Tue, 2015-08-04 at 11:32 +0300, Tapani Pälli wrote: > Original purpose of these lines was to be more friendly against > GUI tools using the extension. However conformance suite explicitly > checks that buffers are not modified in error conditions. > > Fixes: >ES31-CTS.program_interface_quer

Re: [Mesa-dev] [PATCH 1/2] glsl: add variable mode check to build_stageref

2015-08-04 Thread Timothy Arceri
On Tue, 2015-08-04 at 08:24 +0300, Tapani Pälli wrote: > > On 08/04/2015 01:27 AM, Timothy Arceri wrote: > > On Mon, 2015-08-03 at 23:16 +1000, Timothy Arceri wrote: > > > On Mon, 2015-08-03 at 09:02 +0300, Tapani Pälli wrote: > > > > Currently stage reference mask is built using the variable name

[Mesa-dev] [PATCH v2 10/17] mesa: Add missing check of format and type in glTexSubImageXD on GLES 3.0

2015-08-04 Thread Eduardo Lima Mitev
Argument validation for glTexSubImageXD is missing a check of format and type against texture object's internal format when profile is OpenGL-ES 3.0+. This patch also groups together all format and type checks into a single block of code for clarity. Fixes 2 dEQP tests: * dEQP-GLES3.functional.ne

Re: [Mesa-dev] [PATCH 1/2] nir: Add algebraic opt for no-op iand.

2015-08-04 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Mon, 2015-08-03 at 16:36 -0700, Eric Anholt wrote: > I lazily generated some of these in VC4 NIR lowering. > --- > src/glsl/nir/nir_opt_algebraic.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/glsl/nir/nir_opt_algebraic.py > b/src/glsl/nir/ni

[Mesa-dev] [PATCH v3 1/4] i965: Add a debug option for spilling everything in vec4 code

2015-08-04 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 +- src/mesa/drivers/dri/i965/brw_vec4.cpp| 2 +- src/mesa/drivers/dri/i965/intel_debug.c | 3 ++- src/mesa/drivers/dri/i965/intel_debug.h | 5 +++-- 4 files changed, 7 insertions(+), 5 deletions(-) diff --g

[Mesa-dev] [PATCH v3 3/4] i965/vec4: Fix indentation in vec4_visitor::evaluate_spill_costs

2015-08-04 Thread Iago Toral Quiroga
--- .../drivers/dri/i965/brw_vec4_reg_allocate.cpp | 24 +++--- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_reg_allocate.cpp b/src/mesa/drivers/dri/i965/brw_vec4_reg_allocate.cpp index cd89edd..617c988 100644 --- a/src/mes

[Mesa-dev] [PATCH v3 2/4] i965/vec4: do not predicate scratch writes for BRW_OPCODE_SEL instructions

2015-08-04 Thread Iago Toral Quiroga
The dst is always written, in this case the predicate is only used to select the value to write, so if we are spilling the dst we always want to write whatever value we selected to scratch. --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH v3 4/4] i965/vec4: Don't unspill the same register in consecutive instructions

2015-08-04 Thread Iago Toral Quiroga
If we have spilled/unspilled a register in the current instruction, avoid emitting unspills for the same register in the same instruction or consecutive instructions following the current one as long as they keep reading the spilled register. This should allow us to avoid emitting costy unspills th

[Mesa-dev] [PATCH v3 0/4] Improvements to the vec4 spilling code

2015-08-04 Thread Iago Toral Quiroga
Link to v1: http://lists.freedesktop.org/archives/mesa-dev/2015-July/089766.html Link to v2: http://lists.freedesktop.org/archives/mesa-dev/2015-July/089958.html Changes in v3 (Curro): - Move the caching logic to a separate helper function and reuse it in both spill_reg and evaluate_spill_c

Re: [Mesa-dev] [PATCH v2 3/6] i965/vec4: Don't emit scratch reads for a spilled register we have just written

2015-08-04 Thread Iago Toral
On Thu, 2015-07-30 at 17:08 +0300, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > When we have code such as this: > > > > mov vgrf1.0.x:F, vgrf2.:F > > mov vgrf3.0.x:F, vgrf1.:F > > ... > > mov vgrf3.0.x:F, vgrf1.:F > > > > And vgrf1 is chosen for spilling, we can emit this

Re: [Mesa-dev] [PATCH 3/3] egl/x11: don't abort when creating a DRI2 drawable fails

2015-08-04 Thread Frank Binns
On 03/08/15 13:33, Emil Velikov wrote: > On 31 July 2015 at 11:02, Frank Binns wrote: >> When calling either eglCreateWindowSurface or eglCreatePixmapSurface it >> was possible for an application to be aborted as a result of it failing >> to create a DRI2 drawable on the server. This could happen

Re: [Mesa-dev] [PATCH v2 00/78] i965: A new vec4 backend based on NIR

2015-08-04 Thread Antía Puentes
Hi! Jason, On lun, 2015-08-03 at 17:25 -0700, Jason Ekstrand wrote: > On Mon, Aug 3, 2015 at 9:51 AM, Jason Ekstrand wrote: > > I also pushed a version to our CI system that switched the > > INTEL_USE_NIR default to true and things look pretty good over-all. > > On ILK (gen5) and 965 (gen 4), th

Re: [Mesa-dev] [PATCH 2/3] egl/x11: set EGL_BAD_NATIVE_(PIXMAP|WINDOW) for invalid pixmaps/windows

2015-08-04 Thread Frank Binns
On 03/08/15 13:28, Emil Velikov wrote: > On 31 July 2015 at 11:02, Frank Binns wrote: >> Both eglCreatePixmapSurface and eglCreateWindowSurface were incorrectly >> setting the EGL error to be EGL_BAD_ALLOC when an invalid native drawable >> handle was being passed in. The EGL spec states the follo

Re: [Mesa-dev] [PATCH 1/3] egl/x11: fix use of EGL_BAD_NATIVE_WINDOW

2015-08-04 Thread Frank Binns
On 03/08/15 13:05, Emil Velikov wrote: > On 31 July 2015 at 13:34, Frank Binns wrote: >> On 31/07/15 12:53, Emil Velikov wrote: >>> On 31 July 2015 at 11:02, Frank Binns wrote: Commit 4ed23fd590 introduced some calls to _eglError inappropriately passing it EGL_BAD_NATIVE_WINDOW. This wa

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2015-08-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #44 from Heiko --- (In reply to Antoine Labour from comment #43) > I see, the XResizeWindow would cause a DRI2 Invalidate event on the server > side, and the XSync would make sure it's handled on the client before > anything else happ

[Mesa-dev] [PATCH] mesa: do not modify args when errors with GetProgramResourceName

2015-08-04 Thread Tapani Pälli
Original purpose of these lines was to be more friendly against GUI tools using the extension. However conformance suite explicitly checks that buffers are not modified in error conditions. Fixes: ES31-CTS.program_interface_query.buff-length Signed-off-by: Tapani Pälli --- src/mesa/main/prog

Re: [Mesa-dev] [PATCH 0/4] Implementation of glMemoryBarrierByRegion

2015-08-04 Thread marta . lofstedt
> This provides an i965 implementation of the > OpenGL ES 3.1 needed function, glMemoryBarrierByRegion. > > Marta Lofstedt (4): > gles/es3.1: Enable dispatch of glMemoryBarrierByRegion > mesa/es3.1: Add driver interface for glMemoryBarrierByRegion > mesa/es3.1: Implement the entry point of Me

[Mesa-dev] [PATCH v2] gles/es3.1: Implement glMemoryBarrierByRegion

2015-08-04 Thread Marta Lofstedt
From: Marta Lofstedt Signed-off-by: Marta Lofstedt --- src/mapi/glapi/gen/gl_API.xml | 4 src/mesa/main/shaderimage.c | 40 + src/mesa/main/shaderimage.h | 3 +++ src/mesa/main/tests/dispatch_sanity.cpp | 3 +-- 4 files c

[Mesa-dev] [PATCH v2] mesa: fix name returned for XFB varyings

2015-08-04 Thread Tapani Pälli
_mesa_get_program_resource_name has logic to append '[0]' in name if variable is an array, this should be skipped for XFB varyings that have array index already appended. v2: fix comment, change also GL_NAME_LENGTH query to match the behaviour Fixes: ES31-CTS.program_interface_query.transf

Re: [Mesa-dev] [PATCH 4/4] i965/es3.1: Implement glMemoryBarrierByRegion

2015-08-04 Thread Lofstedt, Marta
> -Original Message- > From: Matt Turner [mailto:matts...@gmail.com] > Sent: Monday, August 3, 2015 5:20 PM > To: Lofstedt, Marta > Cc: Ilia Mirkin; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH 4/4] i965/es3.1: Implement > glMemoryBarrierByRegion > > On Mon, Aug 3, 2015

Re: [Mesa-dev] [PATCH v2 3/6] i965/vec4: Don't emit scratch reads for a spilled register we have just written

2015-08-04 Thread Iago Toral
On Fri, 2015-07-31 at 13:12 +0300, Francisco Jerez wrote: > Iago Toral writes: > > > On Thu, 2015-07-30 at 17:08 +0300, Francisco Jerez wrote: > >> Iago Toral Quiroga writes: > >> > >> > When we have code such as this: > >> > > >> > mov vgrf1.0.x:F, vgrf2.:F > >> > mov vgrf3.0.x:F, vgrf1.xx