On Mon, 2015-07-20 at 10:56 -0700, Anuj Phogat wrote:
> On Mon, Jul 20, 2015 at 5:10 AM, Iago Toral wrote:
> > On Fri, 2015-06-19 at 13:40 -0700, Anuj Phogat wrote:
> >> On Tue, Jun 16, 2015 at 9:21 PM, Jason Ekstrand
> >> wrote:
> >> >
> >> > On Jun 16, 2015 11:15, "Anuj Phogat" wrote:
> >> >>
On Tue, Jul 21, 2015 at 1:19 AM, Dave Airlie wrote:
> @@ -366,18 +411,25 @@ _mesa_GetProgramResourceLocation(GLuint program, GLenum
> programInterface,
> case GL_PROGRAM_OUTPUT:
>break;
>
> + case GL_VERTEX_SUBROUTINE_UNIFORM:
> + case GL_FRAGMENT_SUBROUTINE_UNIFORM:
> + if (
I could be missing it, but does anything restrict the availability of
this define to core contexts? I believe you have comparable issues
elsewhere in the change (where you only look at the extension being
enabled vs also looking at the API).
On Tue, Jul 21, 2015 at 1:19 AM, Dave Airlie wrote:
> F
On Tue, Jul 21, 2015 at 1:19 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This handles converting the shader stages to the internal
> prefix along with the program resource interfaces.
>
> Reviewed-by: Chris Forbes
> Signed-off-by: Dave Airlie
> ---
> src/mesa/main/shaderobj.h | 84
> ++
You're adding this extension as core-only, so the functions should
only be accessible in core contexts. I believe that Ian added some
magical way to get the dispatch logic to handle this.
On Tue, Jul 21, 2015 at 1:19 AM, Dave Airlie wrote:
> From: Chris Forbes
>
> v2: fix output="true" and LENGT
From: Dave Airlie
since this touches drivers, only enable it on gallium
for now for drivers reporting GLSL 1.30 or above.
Signed-off-by: Dave Airlie
---
src/mesa/state_tracker/st_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/state_tracker/st_extensions.c
b/src/mesa
From: Dave Airlie
This fleshes out the APIs, using the program resource
APIs where they should match.
It also sets the default values to valid subroutines.
Signed-off-by: Dave Airlie
---
src/mesa/main/shaderapi.c | 450 +-
src/mesa/main/shaderapi.h
From: Dave Airlie
This fleshes out the ARB_program_query support for the
APIs that ARB_shader_subroutine introduces, leaving
some TODOs for later addition.
v2: reworked for lots of the ARB_program_interface_query
entry points and tests
Signed-off-by: Dave Airlie
---
src/mesa/main/program_reso
From: Dave Airlie
Add support for the subroutine uniform type ir->mesa.cpp
v1.1: add subroutine to int to switch
Signed-off-by: Dave Airlie
---
src/mesa/program/ir_to_mesa.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.
From: Dave Airlie
This adds the necessary storage for subroutine info to gl_shader.
v2: add comments, rename one member
Signed-off-by: Dave Airlie
---
src/mesa/main/mtypes.h | 28
1 file changed, 28 insertions(+)
diff --git a/src/mesa/main/mtypes.h b/src/mesa/main
From: Dave Airlie
Just add support for the subroutine type to the
glsl->tgsi convertor.
v1.1: add subroutine to int support.
Signed-off-by: Dave Airlie
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/state_tracker/st_
From: Chris Forbes
v2: [airlied]: merge version check update.
Reviewed-by: Tapani Pälli
Reviewed-by: Kenneth Graunke
Signed-off-by: Chris Forbes
Signed-off-by: Dave Airlie
---
src/mesa/main/extensions.c | 1 +
src/mesa/main/mtypes.h | 1 +
src/mesa/main/version.c| 2 +-
3 files chan
From: Dave Airlie
This adds linker support for subroutine uniforms, they
have some subtle differences from real uniforms, we also hide
them and they are given internal uniform names.
This also adds the subroutine locations and subroutine uniforms
to the program resource tracking for later use.
From: Dave Airlie
This handles converting the shader stages to the internal
prefix along with the program resource interfaces.
Reviewed-by: Chris Forbes
Signed-off-by: Dave Airlie
---
src/mesa/main/shaderobj.h | 84 +++
1 file changed, 84 insertions
From: Dave Airlie
This stops dead code from removing subroutines types,
we need these for the queries to work properly.
Signed-off-by: Dave Airlie
---
src/glsl/opt_dead_code.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/glsl/opt_dead_code.cpp b/src/glsl/opt_dead_code.cpp
index
From: Dave Airlie
This adds a ir_variable which contains the subroutine uniform
and an array rvalue for the deref of that uniform, these
are stored in the ir_call and lowered later.
Reviewed-by: Chris Forbes
Signed-off-by: Dave Airlie
---
src/glsl/ir.h | 21 -
1 file chang
From: Dave Airlie
This is the guts of the GLSL parser and AST support for
shader subroutines.
The code creates a subroutine type in the parser, and
uses that there to validate the identifiers. The parser
also distinguishes between subroutine types/function prototypes
/uniforms and subroutine def
From: Chris Forbes
Reviewed-by: Tapani Pälli
Reviewed-by: Kenneth Graunke
Signed-off-by: Chris Forbes
Signed-off-by: Dave Airlie
---
src/glsl/glcpp/glcpp-parse.y| 3 +++
src/glsl/glsl_parser_extras.cpp | 1 +
src/glsl/glsl_parser_extras.h | 2 ++
src/glsl/standalone_scaffol
From: Chris Forbes
Reviewed-by: Tapani Pälli
Reviewed-by: Kenneth Graunke
Signed-off-by: Chris Forbes
Signed-off-by: Dave Airlie
---
src/mesa/main/config.h | 6 ++
src/mesa/main/get.c | 1 +
src/mesa/main/get_hash_params.py | 4
src/mesa/main/tests
From: Chris Forbes
Reviewed-by: Tapani Pälli
Reviewed-by: Kenneth Graunke
Signed-off-by: Chris Forbes
Signed-off-by: Dave Airlie
---
src/mesa/main/shaderapi.c | 63 +++
src/mesa/main/shaderapi.h | 35 ++
2 files changed, 98
From: Dave Airlie
We need to store two sets of info into the ir_function,
if this is a function definition with a subroutine list
(subroutine_def) or if it a subroutine prototype.
v1.1: add some more documentation.
Reviewed-by: Chris Forbes
Signed-off-by: Dave Airlie
---
src/glsl/ir.cpp
So I revisited ARB_shader_subroutine again today, and noticed
it was lacking wrt ARB_explicit_uniform_location thanks to some
piglits from Igalia/Intel.
So I've added support for that, cleaned up some things,
like calculating the compatible shaders for a uniform at link
time, stopped the dead code
From: Dave Airlie
This type will be used to store the name of subroutine types
as in subroutine void myfunc(void);
will store myfunc into a subroutine type.
This is required to the parser can identify a subroutine
type in a uniform decleration as a valid type, and also for
looking up the type l
From: Chris Forbes
v2: fix output="true" and LENGTH typo
Reviewed-by: Tapani Pälli
Reviewed-by: Kenneth Graunke
Signed-off-by: Chris Forbes
Signed-off-by: Dave Airlie
---
src/mapi/glapi/gen/ARB_shader_subroutine.xml | 84
src/mapi/glapi/gen/Makefile.am
From: Chris Forbes
Reviewed-by: Tapani Pälli
Reviewed-by: Kenneth Graunke
Signed-off-by: Chris Forbes
Signed-off-by: Dave Airlie
---
src/glsl/glsl_lexer.ll | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/glsl_lexer.ll b/src/glsl/glsl_lexer.ll
index 845deeb..22055
From: Dave Airlie
This lowers the enhanced ir_call using the lookaside table
of subroutines into an if ladder. This initially was done
at the AST level but it caused some ordering issues so a separate
pass was required.
v2: clone return value derefs.
v2.1: update for subroutine->int convert.
v2.
Silence a release build warning.
st_glsl_to_tgsi.cpp: In function 'pipe_error st_translate_program(gl_context*,
uint, ureg_program*, glsl_to_tgsi_visitor*, const gl_program*, GLuint, const
GLuint*, const GLuint*, const ubyte*, const ubyte*, const GLuint*, const
GLuint*, GLuint, const GLuint*, c
On 21 July 2015 at 08:50, Marek Olšák wrote:
> If the extension is core only, we can rip out the checks, but the
> checks that test ctx->API == API_OPEGL_CORE should stay (if they are
> missing, they should be added).
>
I've reconsidered this, and I'm sticking with my original plan,
NIR and the i
On Tue, Jul 14, 2015 at 11:45 AM, Eric Anholt wrote:
> These are really useful hints to the compiler in the absence of link-time
> optimization, and I'm going to use them in VC4.
>
> I've made the const attribute be ATTRIBUTE_CONST unlike other function
> attributes, because we have other things i
Match the attributes currently checked in configure.ac.
Signed-off-by: Vinson Lee
---
scons/gallium.py | 5 +
1 file changed, 5 insertions(+)
diff --git a/scons/gallium.py b/scons/gallium.py
index 51b84d7..af30c09 100755
--- a/scons/gallium.py
+++ b/scons/gallium.py
@@ -380,11 +380,16 @@ de
https://bugs.freedesktop.org/show_bug.cgi?id=91254
--- Comment #7 from Jordan Justen ---
(In reply to Tomasz C. from comment #0)
> * config and/or log files etc.
> GLX Renderer: Mesa DRI Intel Ironlake Mobile GLX Version: 2.1 Mesa 10.6.0
>
> The problem is on Intel Core i5 M 450 - first generati
Am 21.07.2015 um 02:10 schrieb Ilia Mirkin:
> On Mon, Jul 20, 2015 at 7:53 PM, Roland Scheidegger
> wrote:
>> Am 20.07.2015 um 22:46 schrieb Ilia Mirkin:
>>> On Mon, Jul 20, 2015 at 3:53 PM, Brian Paul wrote:
On 07/20/2015 01:19 PM, Ilia Mirkin wrote:
> On Mon, Jul 20, 2015 at 2:44
Generated by running:
git grep -l INLINE src/gallium/ | xargs sed -i 's/\bINLINE\b/inline/g'
git grep -l INLINE src/mesa/state_tracker/ | xargs sed -i
's/\bINLINE\b/inline/g'
git checkout src/gallium/state_trackers/clover/Doxyfile
and manual edits to
src/gallium/include/pipe/p_compiler.h
src/gall
On Mon, Jul 20, 2015 at 7:53 PM, Roland Scheidegger wrote:
> Am 20.07.2015 um 22:46 schrieb Ilia Mirkin:
>> On Mon, Jul 20, 2015 at 3:53 PM, Brian Paul wrote:
>>> On 07/20/2015 01:19 PM, Ilia Mirkin wrote:
>>>
On Mon, Jul 20, 2015 at 2:44 PM, Ilia Mirkin wrote:
>
> Hi Brian,
>
>
Am 20.07.2015 um 22:46 schrieb Ilia Mirkin:
> On Mon, Jul 20, 2015 at 3:53 PM, Brian Paul wrote:
>> On 07/20/2015 01:19 PM, Ilia Mirkin wrote:
>>
>>> On Mon, Jul 20, 2015 at 2:44 PM, Ilia Mirkin wrote:
Hi Brian,
You marked off ARB_copy_image (and ARB_clear_texture) as in-progr
On Tue, Jul 14, 2015 at 3:08 PM, Thomas Helland
wrote:
> The deadline for GSoC is aproaching a bit faster than I'm
> comfortable with, so I need to get this out on the list
> for some review-action. It's not yet complete, but I think
> it's getting there. At least it should be possible to infer
>
Hi Emil,
I looked at the whole series, but didn't really feel qualified
to review the whole bunch. I've sent reviews on the patches
I felt I had a good take on. If you don't get anyone else to
review the remainder then shout out and I'll give it a shot.
- Thomas
2015-07-17 22:57 GMT+02:00 Emil V
If the extension is core only, we can rip out the checks, but the
checks that test ctx->API == API_OPEGL_CORE should stay (if they are
missing, they should be added).
Marek
On Thu, Jul 9, 2015 at 3:27 PM, Roland Scheidegger wrote:
> Should expose that only if hw has glsl 130 support?
>
> Roland
This patch is:
Reviewed-by: Thomas Helland
2015-07-10 19:49 GMT+02:00 Emil Velikov :
> Signed-off-by: Emil Velikov
> ---
> src/egl/drivers/dri2/platform_wayland.c | 26 +-
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/src/egl/drivers/dri2/platform
On Thu, Jul 9, 2015 at 9:17 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This fleshes out the ARB_program_query support for the
> APIs that ARB_shader_subroutine introduces, leaving
> some TODOs for later addition.
>
> Signed-off-by: Dave Airlie
> ---
> src/mesa/main/shader_query.cpp | 46
>
On Thu, Jul 9, 2015 at 9:17 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This adds linker support for subroutine uniforms, they
> have some subtle differences from real uniforms, we also hide
> them and they are given internal uniform names.
>
> This also adds the subroutine locations and subro
This looks a lot better.
The patch is:
Reviewed-by: Thomas Helland
2015-07-10 19:49 GMT+02:00 Emil Velikov :
> Move the code around rather than having it scattered. No functional
> change.
>
> Signed-off-by: Emil Velikov
> ---
> src/egl/drivers/dri2/egl_dri2.c | 210
> +++
2015-07-10 19:48 GMT+02:00 Emil Velikov :
> ... and update the documentation to reflect reality.
> null and gdi are gone, and surfaceless is a recent addition.
>
> Signed-off-by: Emil Velikov
> ---
> configure.ac | 3 ---
> docs/egl.html | 6 +++---
> 2 files changed, 3 insertions(+), 6 deletion
[resend without the patch to not anger the mailing list]
On Mon, Jul 20, 2015 at 5:25 PM, Ilia Mirkin wrote:
> In many places you end up changing comments where I think the full
> "boolean" word makes more sense. e.g.
>
> - /* Deal with AND 1.0 here since nv50 can't fold into boolean float */
>
On Monday, July 20, 2015 03:14:14 PM Iago Toral Quiroga wrote:
> We only consider a vgrf defined by a given block if the block writes to it
> unconditionally. So far we have been checking this by testing that the
> instruction is not predicated, however, in the case of BRW_OPCODE_SEL,
> the predica
On Mon, Jul 20, 2015 at 3:53 PM, Brian Paul wrote:
> On 07/20/2015 01:19 PM, Ilia Mirkin wrote:
>
>> On Mon, Jul 20, 2015 at 2:44 PM, Ilia Mirkin wrote:
>>>
>>> Hi Brian,
>>>
>>> You marked off ARB_copy_image (and ARB_clear_texture) as in-progress
>>> by VMware some months ago -- has there been a
On 20/07/15 18:35, Tom Stellard wrote:
All LLVM API calls that require an ostream object have been removed from
the disassemble() function, so we don't need to use this class to wrap
_debug_printf() we can just call this function directly.
---
src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 27
On Fri 17 Jul 2015, Emil Velikov wrote:
> On 17 July 2015 at 19:11, Ilia Mirkin wrote:
> > On Fri, Jul 17, 2015 at 2:11 PM, Eric Anholt wrote:
> >> Matt Turner writes:
> >>
> >>> On Fri, Jul 17, 2015 at 10:17 AM, Emil Velikov
> >>> wrote:
> Cc: Eric Anholt
> Signed-off-by: Emil Veli
Theoretically resource_copy_region should be the right function for
that. Both ARB_copy_image and d3d10 ResourceCopyRegion define this as
essentially the equivalent of memcpy.
I guess the difficulty is that GL's view classes are a bit different
compared to d3d10 typeless groups - d3d10 doesn't allo
On 07/20/2015 01:19 PM, Ilia Mirkin wrote:
On Mon, Jul 20, 2015 at 2:44 PM, Ilia Mirkin wrote:
Hi Brian,
You marked off ARB_copy_image (and ARB_clear_texture) as in-progress
by VMware some months ago -- has there been any movement on that? It
appears that Bioshock Infinite requires ARB_copy_im
On 07/20/2015 12:27 PM, Ian Romanick wrote:
Patches 1, 2, and 3 are
Reviewed-by: Ian Romanick
The other patches look correct too, but the whole series is
optimizations, so do you have any before / after performance data?
No, I don't. I happened across these while looking at apitraces of
Go
Am 20.07.2015 um 19:35 schrieb Tom Stellard:
> This fixes crashes in some piglit tests on radeonsi that use the draw
> module, and llvmpipe is likely completely broken without this on LLVM
> 3.8.
Yes, see https://llvm.org/bugs/show_bug.cgi?id=24172
>
> This is just a temporary solution. The cor
On Mon, Jul 20, 2015 at 2:44 PM, Ilia Mirkin wrote:
> Hi Brian,
>
> You marked off ARB_copy_image (and ARB_clear_texture) as in-progress
> by VMware some months ago -- has there been any movement on that? It
> appears that Bioshock Infinite requires ARB_copy_image so might be
> nice to get that ad
Brian Paul writes:
> ---
> src/mesa/main/light.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/main/light.c b/src/mesa/main/light.c
> index 4021dbe..f215c93 100644
> --- a/src/mesa/main/light.c
> +++ b/src/mesa/main/light.c
> @@ -44,14 +44,14 @@ _mesa_Sh
Brian Paul writes:
> ---
> src/mesa/swrast/s_texfilter.c | 56
> +--
> 1 file changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/src/mesa/swrast/s_texfilter.c b/src/mesa/swrast/s_texfilter.c
> index abc1727..cd6395f 100644
> --- a/src/mesa/swrast
Hi Brian,
You marked off ARB_copy_image (and ARB_clear_texture) as in-progress
by VMware some months ago -- has there been any movement on that? It
appears that Bioshock Infinite requires ARB_copy_image so might be
nice to get that added in.
The complication in implementing ARB_copy_image was tha
On 07/06/2015 03:33 AM, Chris Wilson wrote:
> Since we can distinguish when mapping between READ and WRITE, we can
> pass along the map mode to avoid stalls and flushes where possible.
>
> Signed-off-by: Chris Wilson
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 28
> ++---
On Mon, Jul 20, 2015 at 11:28 AM, Brian Paul wrote:
> ---
> src/mesa/swrast/s_texfilter.c | 56
> +--
> 1 file changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/src/mesa/swrast/s_texfilter.c b/src/mesa/swrast/s_texfilter.c
> index abc1727..cd6395
On 07/09/2015 01:12 PM, Emil Velikov wrote:
> On 9 July 2015 at 18:50, Ian Romanick wrote:
>> On 07/08/2015 10:07 AM, Emil Velikov wrote:
>>> Signed-off-by: Emil Velikov
>>> ---
>>> include/GL/internal/dri_interface.h | 11 ---
>>> 1 file changed, 11 deletions(-)
>>>
>>> diff --git a/inc
On 07/17/2015 05:48 PM, Brian Paul wrote:
> Skip memcpy() calls, etc. if the matrix is already the identity. Return
> true/false to indicate if we're really changing the matrix or not.
> ---
> src/mesa/math/m_matrix.c | 23 +++
> src/mesa/math/m_matrix.h | 2 +-
> 2 files cha
https://bugs.freedesktop.org/show_bug.cgi?id=83631
Ian Romanick changed:
What|Removed |Added
Status|NEW |NEEDINFO
--- Comment #9 from Ian Romanick
---
src/mesa/swrast/s_texfilter.c | 56 +--
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/src/mesa/swrast/s_texfilter.c b/src/mesa/swrast/s_texfilter.c
index abc1727..cd6395f 100644
--- a/src/mesa/swrast/s_texfilter.c
+++ b/src/mesa/swrast/
Patches 1, 2, and 3 are
Reviewed-by: Ian Romanick
The other patches look correct too, but the whole series is
optimizations, so do you have any before / after performance data?
On 07/17/2015 05:48 PM, Brian Paul wrote:
> If the new mode matches the current mode, there can be no error.
> ---
>
On Fri, Jul 17, 2015 at 5:48 PM, Brian Paul wrote:
> Google Earth often calls glLoadMatrixf() with an identity matrix instead
> of glLoadIdentity() to set the modelview and texture matrices. In many
> cases, the matrix is already the identity so the calls are redundant.
>
> By being a bit smarter
On Mon, Jul 20, 2015 at 5:10 AM, Iago Toral wrote:
> On Fri, 2015-06-19 at 13:40 -0700, Anuj Phogat wrote:
>> On Tue, Jun 16, 2015 at 9:21 PM, Jason Ekstrand wrote:
>> >
>> > On Jun 16, 2015 11:15, "Anuj Phogat" wrote:
>> >>
>> >> Without this patch, piglit test fbo_integer_readpixels_sint_uint
This fixes crashes in some piglit tests on radeonsi that use the draw
module, and llvmpipe is likely completely broken without this on LLVM
3.8.
This is just a temporary solution. The correct solution will require
creating a TargetMachine during gallivm initialization and pulling the
DataLayout f
Its only use is to implement a custom version of LLVMDumpValue
on some Windows and embedded platforms.
---
src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
b/src/gallium/auxiliary/gallivm/lp_bld_deb
All LLVM API calls that require an ostream object have been removed from
the disassemble() function, so we don't need to use this class to wrap
_debug_printf() we can just call this function directly.
---
src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 27 +-
1 file change
On 18/07/15 16:02, samuel.pitoiset wrote:
>
>
> On 17/07/2015 23:08, Ilia Mirkin wrote:
>> On Fri, Jul 17, 2015 at 5:02 PM, Emil Velikov
>> wrote:
>>> On 16/07/15 22:39, Samuel Pitoiset wrote:
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/nouveau/codegen/nv50_ir.h
On Mon, Jul 20, 2015 at 03:35:26PM +0200, Iago Toral wrote:
> Hi,
> On Thu, 2015-07-16 at 08:15 -0700, Jason Ekstrand wrote:
> >
> > On Jul 15, 2015 11:20 PM, "Iago Toral" wrote:
> > >
> > > On Wed, 2015-07-15 at 11:02 -0700, Connor Abbott wrote:
> > > > On Wed, Jul 15, 2015 at 7:49 AM, Iago Tora
Hi,
On 20 July 2015 at 17:40, Emil Velikov wrote:
> On 18 July 2015 at 23:13, Jonathan Gray wrote:
>> $(RM) is set to 'rm -f' by GNU make, this is not true of other versions
>> of make and RM is not one of the macros required by POSIX.
>>
> Slightly unfortunate but I think we can live with it. W
On Sat, Jul 18, 2015 at 1:24 AM, Chris Wilson wrote:
> On Fri, Jul 17, 2015 at 05:12:54PM -0700, Anuj Phogat wrote:
>> On Mon, Jul 6, 2015 at 3:33 AM, Chris Wilson
>> wrote:
>> > + do {
>> > + /* The pitch given to the GPU must be DWORD aligned, and
>> > + * we want width to match p
https://bugs.freedesktop.org/show_bug.cgi?id=83631
--- Comment #8 from Emil Velikov ---
With all due respect guys, should one take a closer look and remove the need
for GL_GLEXT_LEGACY and its friends GL_GLEXT_PROTOTYPES/GLX_GLXEXT_PROTOTYPES.
Iirc those were added as a workaround for ABI non-co
On 18 July 2015 at 23:13, Jonathan Gray wrote:
> $(RM) is set to 'rm -f' by GNU make, this is not true of other versions
> of make and RM is not one of the macros required by POSIX.
>
Slightly unfortunate but I think we can live with it. Would like to
see if Matt/other have objections against this
https://bugs.freedesktop.org/show_bug.cgi?id=91387
--- Comment #1 from Brian Paul ---
Can you debug this a bit to see where this is happening and what the texture
target is?
I don't see how this would directly lead to a segfault in Mesa. After the
error message we select the null_sample_func()
v2: Add CS support.
---
src/mesa/drivers/dri/i965/brw_cs.cpp | 3 ++-
src/mesa/drivers/dri/i965/brw_gs.c | 1 +
src/mesa/drivers/dri/i965/brw_vs.c | 3 ++-
src/mesa/drivers/dri/i965/brw_wm.c | 3 ++-
4 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw
v2: Add CS support. Move the image_params array back to
brw_stage_prog_data.
---
src/mesa/drivers/dri/i965/brw_context.h | 10 +++-
src/mesa/drivers/dri/i965/brw_gs_surface_state.c | 25
src/mesa/drivers/dri/i965/brw_state.h| 4 ++
src/mesa/drivers/dri/i965/brw_
This will be used to pass image meta-data to the shader when we cannot
use typed surface reads and writes. All entries except surface_idx
and size are otherwise unused and will get eliminated by the uniform
packing pass. size will be used for bounds checking with some image
formats and will be us
On 07/17/2015 02:14 PM, Emil Velikov wrote:
On 17 July 2015 at 20:22, Brian Paul wrote:
Can you elaborate in the commit message why this is being done or why the
HAVE_SYS_TYPES_H definition is not needed? That saves me time having to
research the issue myself.
I'm not sure I can elaborate mo
Looks OK to me. Thanks for doing this.
Reviewed-by: Brian Paul
On 07/18/2015 02:36 AM, Kenneth Graunke wrote:
Generated by sed; no manual changes.
Signed-off-by: Kenneth Graunke
---
We talked about doing this back in 2013, but the patches never
quite materialized. Here's the obvious sed j
Francisco Jerez writes:
> This seems rather silly and would lead to memory corruption if the
> size of a VGRF was allowed to be zero.
> ---
> src/mesa/drivers/dri/i965/brw_fs.cpp | 10 +++---
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.
This seems rather silly and would lead to memory corruption if the
size of a VGRF was allowed to be zero.
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs
Reviewed-by: Samuel Pitoiset
On 07/20/2015 09:26 AM, Ilia Mirkin wrote:
Make the assumption that there's a 1:1 TIC <-> TSC connection, and
increase min/max lod by the relevant texture's base level. Also if
there's no mipfilter, we have to enable it while forcing min/max lod to
the base level.
Hi,
On Thu, 2015-07-16 at 08:15 -0700, Jason Ekstrand wrote:
>
> On Jul 15, 2015 11:20 PM, "Iago Toral" wrote:
> >
> > On Wed, 2015-07-15 at 11:02 -0700, Connor Abbott wrote:
> > > On Wed, Jul 15, 2015 at 7:49 AM, Iago Toral
> wrote:
> > > > Hi,
> > > >
> > > > when we sent the patches for the n
Iago Toral Quiroga writes:
> We only consider a vgrf defined by a given block if the block writes to it
> unconditionally. So far we have been checking this by testing that the
> instruction is not predicated, however, in the case of BRW_OPCODE_SEL,
> the predication is used to select the value t
We only consider a vgrf defined by a given block if the block writes to it
unconditionally. So far we have been checking this by testing that the
instruction is not predicated, however, in the case of BRW_OPCODE_SEL,
the predication is used to select the value to write, not to decide if
the write i
On Fri, 2015-06-19 at 13:40 -0700, Anuj Phogat wrote:
> On Tue, Jun 16, 2015 at 9:21 PM, Jason Ekstrand wrote:
> >
> > On Jun 16, 2015 11:15, "Anuj Phogat" wrote:
> >>
> >> Without this patch, piglit test fbo_integer_readpixels_sint_uint fails,
> >> when
> >> forced to use the meta pbo path.
> >>
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> Cc:
> ---
> src/mesa/main/readpix.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c
> index caa2648..a9416ef 100644
> --- a/src/mesa/main/readpix.c
>
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> This utility function is used in a later patch.
>
> Signed-off-by: Anuj Phogat
> Cc:
> ---
> src/mesa/main/readpix.c | 32 ++--
> src/mesa/main/readpix.h | 4
> 2 files changed, 22 insertions(+), 14 deleti
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> This utility function is utilized in a later patch.
>
> Signed-off-by: Anuj Phogat
> Cc:
> ---
> Jenkins showed no piglit regressions with this series.
>
> src/mesa/main/readpix.c | 14 --
> src/mesa/main/readpix.h | 6 ++
On Fri, 2015-07-17 at 10:36 -0700, Anuj Phogat wrote:
> Iago, Jason: Patches 2 and 5 in this series depend on patches 1 and 4
> respectively, Since you guys reviewed 2 and 5, would you also like to
> review 1, 4 and/or other patches in this series?
>
> Thanks
> -Anuj
Sure, I'll have a look at the
Make the assumption that there's a 1:1 TIC <-> TSC connection, and
increase min/max lod by the relevant texture's base level. Also if
there's no mipfilter, we have to enable it while forcing min/max lod to
the base level.
This fixes many, but not all, tex-miplevel-selection tests on G80.
Signed-o
92 matches
Mail list logo
