Re: [Mesa-dev] [PATCH 03/14] mesa: Fix conditions to test signed, unsigned integer format

On Thu, 2015-06-18 at 09:19 -0700, Anuj Phogat wrote: > On Thu, Jun 18, 2015 at 7:09 AM, Iago Toral wrote: > > On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: > >> Signed-off-by: Anuj Phogat > >> Cc: > >> --- > >> src/mesa/main/readpix.c | 2 ++ > >> 1 file changed, 2 insertions(+) > >> >

Re: [Mesa-dev] [PATCH] docs: update developer info

On Friday, June 19, 2015 01:14:07 PM Timothy Arceri wrote: > Just link directly to the piglit repo the old link has outdated information. > > Add note about updating patchwork when sending patch revisions. > --- > docs/devinfo.html | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) >

Re: [Mesa-dev] [PATCH] docs: update developer info

On Thu, Jun 18, 2015 at 8:14 PM, Timothy Arceri wrote: > Just link directly to the piglit repo the old link has outdated information. > > Add note about updating patchwork when sending patch revisions. > --- > docs/devinfo.html | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > di

Re: [Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

On 06/17/2015 10:53 PM, Julien Isorce wrote: > From: Jon TURNEY > > On darwin, GLhandleARB is defined as a void *, not the unsigned int it is on > linux. > > For the moment, apply a cast to supress the warning > > Possibly this is safe, as for the mesa software renderer the shader program > han

[Mesa-dev] [PATCH] docs: update developer info

Just link directly to the piglit repo the old link has outdated information. Add note about updating patchwork when sending patch revisions. --- docs/devinfo.html | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/devinfo.html b/docs/devinfo.html index 0da18b9..6779ab

Re: [Mesa-dev] [PATCH] mesa_tags: dri/common no longer exists

Sorry, ignore this. I had script fail. Real patch coming up. On Thu, Jun 18, 2015 at 06:44:35PM -0700, Ben Widawsky wrote: > --- > scripts/tags/mesa_tags.sh | 4 > 1 file changed, 4 deletions(-) > > diff --git a/scripts/tags/mesa_tags.sh b/scripts/tags/mesa_tags.sh > index 4404b92..c8e2098

[Mesa-dev] [PATCH] i965/gen8: Use HALIGN_16 for single sample mcs buffers

The original code meant to do this, but was only checking num_samples == 1 to figure out if a surface was fast clear capable. However, we can allocate single sample miptrees with num_samples == 0 (when it's an internally created buffer). This fixes a bunch of the piglit tests on gen8. Other gens s

[Mesa-dev] [PATCH] mesa_tags: dri/common no longer exists

--- scripts/tags/mesa_tags.sh | 4 1 file changed, 4 deletions(-) diff --git a/scripts/tags/mesa_tags.sh b/scripts/tags/mesa_tags.sh index 4404b92..c8e2098 100755 --- a/scripts/tags/mesa_tags.sh +++ b/scripts/tags/mesa_tags.sh @@ -3,13 +3,9 @@ rm cscope.* rm tags git ls-files src/mesa/dri

Re: [Mesa-dev] [PATCH 1/2] i965/gen9: Implement Push Constant Buffer workaround

On Wed, Jun 3, 2015 at 9:35 PM, Ben Widawsky wrote: > This implements a workaround (exact excerpt as a comment in the code). The > docs > specify [clearly, after you struggle for a while] that the offset isn't > relative > to state base. This actually makes sense. > > Buffer #0 is meant to be us

[Mesa-dev] [PATCH 16/17] i965/fs_generator: Use inst->exec_size for determining hardware reg widths

--- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp index 8eb3ace..2b66acf 100644 --- a/src/mesa/drivers/dri/i965/brw_f

[Mesa-dev] [PATCH 15/17] i965/fs: Use exec_size instead of dst.width for computing component size

There are a variety of places where we use dst.width / 8 to compute the size of a single logical channel. Instead, we should be using exec_size. --- src/mesa/drivers/dri/i965/brw_fs.cpp| 6 +++--- src/mesa/drivers/dri/i965/brw_fs_cse.cpp| 2 +- src/mesa/drivers

[Mesa-dev] [PATCH 10/17] i965/fs: Use exec_size for determining regs read/written and partial writes

--- src/mesa/drivers/dri/i965/brw_fs.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 61235d7..cff27e7 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++ b/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 13/17] i965/fs: Use the builder dispatch width instead of dst.width for pull constants

--- src/mesa/drivers/dri/i965/brw_fs.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index d9b7f75..b889432 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++ b/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 07/17] i965/fs: Move offset() and half() to the fs_builder

We want to move these into the builder so that they know the current builder's dispatch width. This will be needed by a later commit. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 52 ++ src/mesa/drivers/dri/i965/brw_fs_builder.h | 46 + src/mesa/drivers/dri/i965/brw_fs_c

[Mesa-dev] [PATCH 11/17] i965/fs_builder: Use the dispatch width for setting exec sizes

Previously we used dst.width but the two *should* be the same. --- src/mesa/drivers/dri/i965/brw_fs_builder.h | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_builder.h b/src/mesa/drivers/dri/i965/brw_fs_builder.h index 74f

[Mesa-dev] [PATCH 06/17] i965/blorp: Explicitly set execution sizes for new'd instructions

This doesn't affect instructions allocated using the builder. --- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp index c1

[Mesa-dev] [PATCH 17/17] i965/fs: Remove the width field from fs_reg

As of now, the width field is no longer used for anything. The width field "seemed like a good idea at the time" but is actually entirely redundant with the instruction's execution size. Initially, it gave us the ability to easily set the instructions execution size based entirely on register wid

[Mesa-dev] [PATCH 14/17] i965/fs_builder: Use dispatch_width instead of reg.width for offset and half

--- src/mesa/drivers/dri/i965/brw_fs_builder.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_builder.h b/src/mesa/drivers/dri/i965/brw_fs_builder.h index 7d3c8ab..58519d7 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_builder.h +++ b/s

[Mesa-dev] [PATCH 12/17] i965/fs: Remove exec_size guessing from fs_inst::init()

Now that all of the non-explicit constructors are gone, we don't need to guess anymore. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 22 -- 1 file changed, 22 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index cff27e7..d9

[Mesa-dev] [PATCH 09/17] i965/fs: Remove fs_inst constructors that don't take an explicit exec_size

--- src/mesa/drivers/dri/i965/brw_fs.cpp | 30 ++ src/mesa/drivers/dri/i965/brw_fs_builder.h | 2 +- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 6 -- src/mesa/drivers/dri/i965/brw_ir_fs.h | 9 + 4 files changed, 8 insertions(+), 39 deletions(

[Mesa-dev] [PATCH 08/17] i965/fs: Make better use of the builder in shader_time

Previously, we were just depending on register widths to ensure that various things were exec_size of 1 etc. Now, we do so explicitly using the builder. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri

[Mesa-dev] [PATCH 03/17] i965/fs: Report the right value in fs_inst::regs_read() for PIXEL_X/Y

--- src/mesa/drivers/dri/i965/brw_fs.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index ce56657..4f98d63 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp @@ -76

[Mesa-dev] [PATCH 01/17] i965/fs: Use a switch statement in fs_inst::regs_read()

This makes things a little simpler, more efficient, and quite a bit more readable. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 45 ++-- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH 02/17] i965/fs: Fix fs_inst::regs_read() for uniform pull constant loads

Previously, fs_inst::regs_read() fell back to depending on the register width for the second source. This isn't really correct since it isn't a SIMD8 value at all, but a SIMD4x2 value. This commit changes it to explicitly be always one register. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 6 +

[Mesa-dev] [PATCH 05/17] i965/fs: Set the builder group for emitting FB-write stencil/AA alpha

--- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp index b00825e..8a43ec8 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp +++ b/s

[Mesa-dev] [PATCH 04/17] i965/fs: Explicitly set the exec_size on the add(32) in interpolation setup

Soon we will start using the builder to explicitly set all the execution sizes. We could make a 32-wide builder, but the builder asserts that we never grow it which is usually a reasonable assumption. Sinc this one instruction is a bit of an odd-ball, we just set the exec_size explicitly. --- sr

Re: [Mesa-dev] [PATCH 3/4] i965/gen9: Don't use encrypted MOCS

On Wednesday, June 17, 2015 03:50:13 PM Ben Widawsky wrote: > On gen9+ MOCS is an index into a table. It is 7 bits, and AFAICT, bit 0 is for > doing encrypted reads. > > I don't recall how I decided to do this for BXT. I don't know this patch was > ever needed, since it seems nothing is broken tod

Re: [Mesa-dev] [PATCH v2] glsl: guard gl_NumSamples enablement on ARB_sample_shading

On Thu, Jun 18, 2015 at 4:08 PM, Ilia Mirkin wrote: > gl_NumSamples should only be enabled when ARB_sample_shading is enabled. > > Signed-off-by: Ilia Mirkin > --- > src/glsl/builtin_variables.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/builtin_variabl

[Mesa-dev] [Bug 91020] Mesa's demo / tools won't compile since EGL changes

https://bugs.freedesktop.org/show_bug.cgi?id=91020 --- Comment #3 from Mike Lothian --- Created attachment 116585 --> https://bugs.freedesktop.org/attachment.cgi?id=116585&action=edit Buid log without EGL -- You are receiving this mail because: You are the QA Contact for the bug. You are the

[Mesa-dev] [Bug 91020] Mesa's demo / tools won't compile since EGL changes

https://bugs.freedesktop.org/show_bug.cgi?id=91020 Mike Lothian changed: What|Removed |Added Attachment #116585|Buid log without EGL|Build log without EGL description|

[Mesa-dev] [Bug 91020] Mesa's demo / tools won't compile since EGL changes

https://bugs.freedesktop.org/show_bug.cgi?id=91020 Mike Lothian changed: What|Removed |Added CC||m...@fireburn.co.uk --- Comment #2 from M

Re: [Mesa-dev] [PATCH] i965: Add missing braces around if-statement.

On Thursday, June 18, 2015 04:28:25 PM Ben Widawsky wrote: > > On Thu, Jun 18, 2015 at 04:19:36PM -0700, Matt Turner wrote: > > Fixes a performance problem caused by commit b639ed2f. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90895 > > Ken spotted this in review. > /me hides

Re: [Mesa-dev] [PATCH 5/5] osx: fix asm support on darwin

On 18 June 2015 at 19:46, Emil Velikov wrote: > On 18 June 2015 at 06:53, Julien Isorce wrote: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90908 > > Signed-off-by: Julien Isorce > > --- > > configure.ac | 2 +- > > src/mesa/x86-64/xform4.S | 53 > +++

Re: [Mesa-dev] New stable-branch 10.5 candidate pushed

We should also pull in Chris' 3-patch drawbuffers series if it applies: http://lists.freedesktop.org/archives/mesa-dev/2015-June/085851.html On Thu, Jun 18, 2015 at 11:30 AM, Emil Velikov wrote: > Hello list, > > The candidate for the Mesa 10.5.8 is now available. Currently we have: > - 11 queu

Re: [Mesa-dev] [PATCH] i965: Add missing braces around if-statement.

On Thu, Jun 18, 2015 at 04:19:36PM -0700, Matt Turner wrote: > Fixes a performance problem caused by commit b639ed2f. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90895 Ken spotted this in review. /me hides Reviewed-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/brw_meta_fa

Re: [Mesa-dev] [PATCH] i965: Add missing braces around if-statement.

Wow... Reviewed-by: Jason Ekstrand On Thu, Jun 18, 2015 at 4:19 PM, Matt Turner wrote: > Fixes a performance problem caused by commit b639ed2f. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90895 > --- > src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 3 ++- > 1 file changed, 2 i

Re: [Mesa-dev] [PATCH] i965: Add missing braces around if-statement.

Oh, how silly :) Reviewed-by: Chris Forbes - Chris On Fri, Jun 19, 2015 at 11:19 AM, Matt Turner wrote: > Fixes a performance problem caused by commit b639ed2f. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90895 > --- > src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 3 ++- >

Re: [Mesa-dev] [PATCH 4/5] egl: use unix defines on osx with clang

On 18 June 2015 at 19:33, Emil Velikov wrote: > On 18 June 2015 at 19:29, Emil Velikov wrote: > Sorry about that. Unintentionally hit send ;-\ > > > On 18 June 2015 at 06:53, Julien Isorce wrote: > >> CC egl_dri2.lo > >> include/EGL/eglplatform.h:135:2: > >> error: "Platform not recogni

[Mesa-dev] [PATCH] i965: Add missing braces around if-statement.

Fixes a performance problem caused by commit b639ed2f. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90895 --- src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c b/src/mesa

Re: [Mesa-dev] [PATCH 3/5] egl/dri2: load libglapi.0.dylib on osx

On 18 June 2015 at 19:29, Emil Velikov wrote: > On 18 June 2015 at 06:53, Julien Isorce wrote: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90903 > > Signed-off-by: Julien Isorce > > --- > > src/egl/drivers/dri2/egl_dri2.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff

[Mesa-dev] [Bug 90903] egl_dri2.c:dri2_load fails to load libglapi on osx

https://bugs.freedesktop.org/show_bug.cgi?id=90903 --- Comment #1 from Julien Isorce --- Created attachment 116583 --> https://bugs.freedesktop.org/attachment.cgi?id=116583&action=edit es2gears_x11 and es2_info with llvmpipe on osx Running gears with egl/gles2/x11 with llvmpipe software driver

[Mesa-dev] [PATCH v2] glsl: guard gl_NumSamples enablement on ARB_sample_shading

gl_NumSamples should only be enabled when ARB_sample_shading is enabled. Signed-off-by: Ilia Mirkin --- src/glsl/builtin_variables.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index c52b252..a765d35 1006

Re: [Mesa-dev] [PATCH] glsl: move gl_NumSamples enablement with other ARB_sample_shading vars

Hmmm actually looking at the GLSL 4.50 doc, it looks like it just has a list of all uniforms available in one place, unlike the ARB_sample_shading spec which says it should go into fs only. From ARB_sample_shading: Add the following prototype to the list of built-in uniforms accessible

Re: [Mesa-dev] [PATCH 2/5] applegl: Provide requirements of _SET_DrawBuffers

Sorry for removing the XXX line. Original message is here: https://bugs.freedesktop.org/attachment.cgi?id=115539 At the time src/glx/apple/apple_glapi.c has been developed this patch was not needed I guess so I wonder which change made the regression. Cheers Julien On 18 June 2015 at 19:23, Emil

[Mesa-dev] [PATCH] glsl: move gl_NumSamples enablement with other ARB_sample_shading vars

gl_NumSamples should only be enabled when ARB_sample_shading is enabled, and only in the fragment shader. Move to the generate_fs_special_vars function, next to the other ARB_sample_shading-provided variables. Signed-off-by: Ilia Mirkin --- src/glsl/builtin_variables.cpp | 2 +- 1 file changed,

Re: [Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

Hi Emil, Do you mean adding the cast only if __APPLE__ is defined ? Actually when reading comment #2 we should get the build error for src/mesa/main/uniform_query.cpp too but it is not the case anymore. So with git blame I can see that the build error has been fixed by commit d96ed5c0 for the fil

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

On Thu, Jun 18, 2015 at 2:34 PM, Connor Abbott wrote: > On Thu, Jun 18, 2015 at 11:19 AM, Rob Clark wrote: >> On Thu, Jun 18, 2015 at 1:27 PM, Connor Abbott wrote: >>> On Thu, Jun 18, 2015 at 9:42 AM, Rob Clark wrote: On Thu, Jun 18, 2015 at 11:01 AM, Connor Abbott wrote: (

Re: [Mesa-dev] [PATCH] EGL: Add pbuffer support for drm platform

On 18 June 2015 at 17:11, Liu, Ying2 wrote: > Hi, Chad, > > Thank you so much for reviewing my patch. I am in vacation and sabbatical > right now. I will talk with our customer about your suggestion. I will fix > the patch when I come back. > Enjoy your sabbatical Ying ! As you come back, pleas

Re: [Mesa-dev] [PATCH 0/4] CLOEXEC fix-ups

On 17 June 2015 at 17:28, Derek Foreman wrote: > This series catches a couple of places where we forget to set CLOEXEC on > file descriptors, and makes a helper function for the necessarily ugly > way we have to open fds to make sure CLOEXEC is set. > > Derek Foreman (4): > egl/drm: Duplicate fd

Re: [Mesa-dev] [PATCH 5/5] osx: fix asm support on darwin

On 18 June 2015 at 06:53, Julien Isorce wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90908 > Signed-off-by: Julien Isorce > --- > configure.ac | 2 +- > src/mesa/x86-64/xform4.S | 53 > +--- > src/mesa/x86/assyntax.h |

Re: [Mesa-dev] [RFC v2 14/15] i965: refactor miptree alignment calculation code

The next revision will be all code refactoring. I moved the spec references into the new top-level function intel_get_texture_alignment_unit because some of the alignment calculations occurring in the top-level function reference the spec. Since the intel_vertical_texture_alignment_unit and intel_h

Re: [Mesa-dev] [PATCH v2 23/82] glsl: Do not do CSE for expressions involving SSBO loads

On 2015-06-17 22:57:27, Iago Toral wrote: > On Wed, 2015-06-17 at 17:20 -0700, Jordan Justen wrote: > > I wanted to question whether this was required, based on this text > > from the extension spec: > > > > "The ability to write to buffer objects creates the potential for > > multiple independen

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

On Thu, Jun 18, 2015 at 11:19 AM, Rob Clark wrote: > On Thu, Jun 18, 2015 at 1:27 PM, Connor Abbott wrote: >> On Thu, Jun 18, 2015 at 9:42 AM, Rob Clark wrote: >>> On Thu, Jun 18, 2015 at 11:01 AM, Connor Abbott wrote: >>> (really I want phi's for variables too.. the way I turn arrays into

Re: [Mesa-dev] [PATCH 4/5] egl: use unix defines on osx with clang

On 18 June 2015 at 19:29, Emil Velikov wrote: Sorry about that. Unintentionally hit send ;-\ > On 18 June 2015 at 06:53, Julien Isorce wrote: >> CC egl_dri2.lo >> include/EGL/eglplatform.h:135:2: >> error: "Platform not recognized" >> include/EGL/eglplatform.h:140:9: >> error: unknown

Re: [Mesa-dev] [PATCH 4/5] egl: use unix defines on osx with clang

On 18 June 2015 at 06:53, Julien Isorce wrote: > CC egl_dri2.lo > include/EGL/eglplatform.h:135:2: > error: "Platform not recognized" > include/EGL/eglplatform.h:140:9: > error: unknown type name 'EGLNativeDisplayType' > typedef EGLNativeDisplayType NativeDisplayType; > > Bugzilla: https

Re: [Mesa-dev] [PATCH 3/5] egl/dri2: load libglapi.0.dylib on osx

On 18 June 2015 at 06:53, Julien Isorce wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90903 > Signed-off-by: Julien Isorce > --- > src/egl/drivers/dri2/egl_dri2.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/e

Re: [Mesa-dev] [PATCH 2/5] applegl: Provide requirements of _SET_DrawBuffers

On 18 June 2015 at 06:53, Julien Isorce wrote: > From: Jon TURNEY > > _SET_DrawBuffers requires driDispatchRemapTable, > so we need to link with libmesa for remap.c. > libmesa requires the C++ linker. > > Also need to arrange to call _mesa_init_remap_table() > to initialize the remap table. > > B

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

On Thu, Jun 18, 2015 at 1:27 PM, Connor Abbott wrote: > On Thu, Jun 18, 2015 at 9:42 AM, Rob Clark wrote: >> On Thu, Jun 18, 2015 at 11:01 AM, Connor Abbott wrote: >> (really I want phi's for variables too.. the way I turn arrays into >> fanin/collect fanout/split works on the backend f

Re: [Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

On 18 June 2015 at 06:53, Julien Isorce wrote: > From: Jon TURNEY > > On darwin, GLhandleARB is defined as a void *, not the unsigned int it is on > linux. > > For the moment, apply a cast to supress the warning > > Possibly this is safe, as for the mesa software renderer the shader program > han

Re: [Mesa-dev] [PATCH] configure.ac: rename LLVM_VERSION_PATCH to avoid conflict with llvm-config.h

On 18 June 2015 at 13:32, Marek Olšák wrote: > We'll need to check the patch version for tessellation and amdgpu. > Did not see that one. Thanks ! -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listin

[Mesa-dev] [Bug 91020] Mesa's demo / tools won't compile since EGL changes

https://bugs.freedesktop.org/show_bug.cgi?id=91020 --- Comment #1 from Emil Velikov --- Mesa commit 7a58262e58d removed all the EGL_MESA_screen_surface definitions as it was never implemented (according to it). Seems like mesa-demos doesn't have the necessary compile guards. Something like the f

[Mesa-dev] New stable-branch 10.5 candidate pushed

Hello list, The candidate for the Mesa 10.5.8 is now available. Currently we have: - 11 queued - 10 nominated (outstanding) - and 0 rejected (obsolete) patches The present queue consist of a few nouveau and i965 patches, along with couple libEGL hit bug fixes and a build fix for people using l

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

On Thu, Jun 18, 2015 at 9:42 AM, Rob Clark wrote: > On Thu, Jun 18, 2015 at 11:01 AM, Connor Abbott wrote: > (really I want phi's for variables too.. the way I turn arrays into > fanin/collect fanout/split works on the backend for dealing with > arrays in ssa form (other than making

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

On Thu, Jun 18, 2015 at 12:42 PM, Rob Clark wrote: > On Thu, Jun 18, 2015 at 11:01 AM, Connor Abbott wrote: > (really I want phi's for variables too.. the way I turn arrays into > fanin/collect fanout/split works on the backend for dealing with > arrays in ssa form (other than making

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

On Thu, Jun 18, 2015 at 11:01 AM, Connor Abbott wrote: (really I want phi's for variables too.. the way I turn arrays into fanin/collect fanout/split works on the backend for dealing with arrays in ssa form (other than making instruction graph large) but the way I go from nir

Re: [Mesa-dev] [PATCH 03/14] mesa: Fix conditions to test signed, unsigned integer format

On Thu, Jun 18, 2015 at 7:09 AM, Iago Toral wrote: > On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: >> Signed-off-by: Anuj Phogat >> Cc: >> --- >> src/mesa/main/readpix.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c >> in

Re: [Mesa-dev] [PATCH] EGL: Add pbuffer support for drm platform

Hi, Chad, Thank you so much for reviewing my patch. I am in vacation and sabbatical right now. I will talk with our customer about your suggestion. I will fix the patch when I come back. Ying -Original Message- From: Versace, Chad Sent: Thursday, June 18, 2015 7:34 AM To: Liu, Ying2 C

Re: [Mesa-dev] [PATCH] llvmpipe: Truncate the binned constants to max const buffer size.

Am 18.06.2015 um 16:52 schrieb Jose Fonseca: > Tested with Ilia Mirkin's gzdoom.trace and > "arb_uniform_buffer_object-maxuniformblocksize fsexceed" piglit test > without my earlier fix to fail linkage when UBO exceeds > GL_MAX_UNIFORM_BLOCK_SIZE. > --- > src/gallium/auxiliary/gallivm/lp_bld_limit

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

On Thu, Jun 18, 2015 at 4:48 AM, Rob Clark wrote: > On Thu, Jun 18, 2015 at 1:23 AM, Connor Abbott wrote: >> On Wed, Jun 17, 2015 at 12:02 PM, Rob Clark wrote: >>> On Wed, Jun 17, 2015 at 2:27 PM, Connor Abbott wrote: So, as is, this patch isn't quite correct. When I originally wrote

[Mesa-dev] [PATCH] llvmpipe: Truncate the binned constants to max const buffer size.

Tested with Ilia Mirkin's gzdoom.trace and "arb_uniform_buffer_object-maxuniformblocksize fsexceed" piglit test without my earlier fix to fail linkage when UBO exceeds GL_MAX_UNIFORM_BLOCK_SIZE. --- src/gallium/auxiliary/gallivm/lp_bld_limits.h | 6 +- src/gallium/drivers/llvmpipe/lp_setup.c

Re: [Mesa-dev] [PATCH] EGL: Add pbuffer support for drm platform

On Thu 11 Jun 2015, Ying Liu wrote: > Add pbuffer support for drm platform, because some customers are still using > this feature. > > Signed-off-by: Ying Liu > --- > src/egl/drivers/dri2/egl_dri2.c | 2 +- > src/egl/drivers/dri2/platform_drm.c | 18 ++ > 2 files changed, 1

Re: [Mesa-dev] [PATCH 03/14] mesa: Fix conditions to test signed, unsigned integer format

On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > Cc: > --- > src/mesa/main/readpix.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c > index caa2648..a9416ef 100644 > --- a/src/mesa/main/readpix.c >

Re: [Mesa-dev] [PATCH] configure.ac: rename LLVM_VERSION_PATCH to avoid conflict with llvm-config.h

We'll need to check the patch version for tessellation and amdgpu. Marek On Thu, Jun 18, 2015 at 2:22 PM, Emil Velikov wrote: > On 16 June 2015 at 20:18, Tom Stellard wrote: >> On Tue, Jun 16, 2015 at 08:07:57PM +0100, Emil Velikov wrote: >>> On 13 June 2015 at 19:16, Marek Olšák wrote: >>> >

Re: [Mesa-dev] [PATCH 02/14] meta: Fix transfer operations check in meta pbo path for readpixels

On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: > Without this patch, arb_color_buffer_float-readpixels test fails, when > forced to use meta pbo path. > > Signed-off-by: Anuj Phogat > Cc: > --- > src/mesa/drivers/common/meta_tex_subimage.c | 10 ++ > 1 file changed, 6 insertions(

Re: [Mesa-dev] [PATCH] configure.ac: rename LLVM_VERSION_PATCH to avoid conflict with llvm-config.h

On 16 June 2015 at 20:18, Tom Stellard wrote: > On Tue, Jun 16, 2015 at 08:07:57PM +0100, Emil Velikov wrote: >> On 13 June 2015 at 19:16, Marek Olšák wrote: >> > From: Marek Olšák >> > >> > --- >> > configure.ac | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/

Re: [Mesa-dev] [PATCH 5/6] mesa: don't rebind constant buffers after every state change if GS is active

Strange I was under the impression that there are apps that make use of GS, albeit not too many. On the perf side - I was thinking about the hardware (i.e. regardless if the driver does extra state-tracking or not) - would there be the optimisation mentioned, would there be a "stall" in the pipeli

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl/x11: Remove duplicate call to dri2_x11_add_configs_for_visuals

Hi Boyan, On 13 June 2015 at 08:33, Boyan Ding wrote: > The call to dri2_x11_add_configs_for_visuals (previously > dri2_add_configs_for_visuals) was moved downwards in commit f8c5b8a1, > but appeared again in its original position after its rename in > d019cd81. Remove it. > I believe you're bang

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl/x11: Set version of swrastLoader to 2

On 16 June 2015 at 16:39, Ian Romanick wrote: > Gak... I thought we fixed all of those. :( > Ops seems like I've missed it. Good news is that this is the last one :-) > Reviewed-by: Ian Romanick > > On 06/15/2015 08:08 PM, Boyan Ding wrote: >> which it actually implements instead of the newest v

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

On Thu, Jun 18, 2015 at 1:23 AM, Connor Abbott wrote: > On Wed, Jun 17, 2015 at 12:02 PM, Rob Clark wrote: >> On Wed, Jun 17, 2015 at 2:27 PM, Connor Abbott wrote: >>> So, as is, this patch isn't quite correct. When I originally wrote >>> NIR, the idea was that the size of each instruction would

[Mesa-dev] [PATCH] clover: Implement image attribute getters

Image attributes are passed to the kernel as hidden parameters after the image attribute itself. An llvm pass replaces the getter builtins to the appropriate parameters. --- src/gallium/state_trackers/clover/core/kernel.cpp | 26 +++ src/gallium/state_trackers/clover/core/kernel.hpp | 13 ++-

Re: [Mesa-dev] [PATCH] mesa: add GL_PROGRAM_PIPELINE support in KHR_debug calls

On Wed, 2015-06-17 at 23:02 -0400, Ilia Mirkin wrote: > This was apparently missed when KHR_debug or ARB_sso support was added. SSO was still missing when I added KHR_debug, but this should have been picked up by the object label piglit test I wrote. However the test was broken, it failed to fail

[Mesa-dev] [Bug 91020] Mesa's demo / tools won't compile since EGL changes

https://bugs.freedesktop.org/show_bug.cgi?id=91020 Bug ID: 91020 Summary: Mesa's demo / tools won't compile since EGL changes Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal