[Mesa-dev] [Bug 89773] "builtin_functions.cpp", line 3218: Error: INFINITY is not defined.

https://bugs.freedesktop.org/show_bug.cgi?id=89773 Bug ID: 89773 Summary: "builtin_functions.cpp", line 3218: Error: INFINITY is not defined. Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: All

Re: [Mesa-dev] [PATCH] i965/skl: Don't use the PMA depth stall workaround

On Wednesday, March 25, 2015 04:52:46 PM Ben Widawsky wrote: > The PMA depth stall must be enabled (optimization turned off) under certain > circumstances on gen8. This was supposedly fixed for Gen9, which means we do not > need to check, or toggle the state. The hardware is supposed to enable the

[Mesa-dev] New stable-branch 10.5 candidate pushed

Hello list, The candidate for the Mesa 10.5.2 is now available. The current patch queue is as follows: - 18 queued - 5 nominated (outstanding) - and 2 rejected (obsolete) patches This release addresses a couple of glsl bugs affecting all the drivers, squashes bugs in the libGL and glapi librar

Re: [Mesa-dev] [PATCH v2 6/6] i965/nir: Use NIR for ARB_vertex_program support on Gen8+.

On Mar 25, 2015 7:43 PM, "Connor Abbott" wrote: > > On Wed, Mar 25, 2015 at 7:21 PM, Kenneth Graunke wrote: > > Everything is already in place; we simply have to take the scalar code > > generation path. This gives us SIMD8 VS programs, instead of SIMD4x2. > > > > v2: Rebase on the patch that dr

[Mesa-dev] [PATCH] r600g/sb: Update last_cf for loops

CF_END could end up emitted in the middle of a shader on cayman when there was a loop at the very end. Fixes glsl-1.50-geometry-end-primitive and ext_transform_feedback-geometry-shaders-basic piglit tests. Signed-off-by: Glenn Kennard --- Bug exposed by [PATCH] r600g/sb: Enable SB for geometry s

Re: [Mesa-dev] [PATCH] st_glsl_to_tgsi: only do mov copy propagation on temps (v2)

On Wed, Mar 25, 2015 at 7:53 PM, Dave Airlie wrote: > From: Dave Airlie > > Don't propagate ARRAYs > > This should fix: > https://bugs.freedesktop.org/show_bug.cgi?id=89759 > > v2: just specify arrays so we get input propagation > Signed-off-by: Dave Airlie > Cc: mesa-sta...@lists.freedesktop.or

Re: [Mesa-dev] [PATCH 05/11] i965/inst: Add notify and gateway_subfuncid fields

On Sun, Mar 22, 2015 at 06:49:15PM -0700, Jordan Justen wrote: > These fields will be used when emitting a send for the barrier function. > > Reference: IVB PRM Volume 4, Part 2, Section 1.1.1 Message Descriptor > > Signed-off-by: Jordan Justen > Reviewed-by: Chris Forbes > --- > src/mesa/driv

Re: [Mesa-dev] [PATCH v2 1/6] nir: Add nir_builder helpers for creating load_const intrinsics.

Except for one comment on patch 6, patches 1-2 and 4-6 are Reviewed-by: Connor Abbott I don't know enough about Mesa IR to fully review patch 3, although on a quick read-through I couldn't find anything to improve. On Wed, Mar 25, 2015 at 7:21 PM, Kenneth Graunke wrote: > Both prog->nir and tg

Re: [Mesa-dev] [PATCH v2 6/6] i965/nir: Use NIR for ARB_vertex_program support on Gen8+.

On Wed, Mar 25, 2015 at 7:21 PM, Kenneth Graunke wrote: > Everything is already in place; we simply have to take the scalar code > generation path. This gives us SIMD8 VS programs, instead of SIMD4x2. > > v2: Rebase on the patch that drops brw->gen >= 8. > > Signed-off-by: Kenneth Graunke > Revi

Re: [Mesa-dev] [PATCH v2] egl/dri2: Fix GCC maybe-uninitialized warning.

On Wed, Mar 25, 2015 at 8:31 PM, Matt Turner wrote: > On Wed, Mar 25, 2015 at 4:15 PM, Jan Vesely wrote: >> On Wed, 2015-03-25 at 18:55 -0400, Ilia Mirkin wrote: >>> On Wed, Mar 25, 2015 at 6:51 PM, Jan Vesely wrote: >>> > On Fri, 2015-03-06 at 23:54 -0800, Vinson Lee wrote: >>> >> egl_dri2.c: I

Re: [Mesa-dev] [PATCH v2] egl/dri2: Fix GCC maybe-uninitialized warning.

On Wed, Mar 25, 2015 at 4:15 PM, Jan Vesely wrote: > On Wed, 2015-03-25 at 18:55 -0400, Ilia Mirkin wrote: >> On Wed, Mar 25, 2015 at 6:51 PM, Jan Vesely wrote: >> > On Fri, 2015-03-06 at 23:54 -0800, Vinson Lee wrote: >> >> egl_dri2.c: In function ‘dri2_bind_tex_image’: >> >> egl_dri2.c:1240:4:

Re: [Mesa-dev] [PATCH v2 1/6] nir: Add nir_builder helpers for creating load_const intrinsics.

Kenneth Graunke writes: > Both prog->nir and tgsi->nir will want to use these. > > Signed-off-by: Kenneth Graunke Patches 1, 2, 4 are: Reviewed-by: Eric Anholt and the changes in 3 all sound good. signature.asc Description: PGP signature ___ mesa

[Mesa-dev] [PATCH] st_glsl_to_tgsi: only do mov copy propagation on temps (v2)

From: Dave Airlie Don't propagate ARRAYs This should fix: https://bugs.freedesktop.org/show_bug.cgi?id=89759 v2: just specify arrays so we get input propagation Signed-off-by: Dave Airlie Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 + 1 file change

[Mesa-dev] [PATCH] i965/skl: Don't use the PMA depth stall workaround

The PMA depth stall must be enabled (optimization turned off) under certain circumstances on gen8. This was supposedly fixed for Gen9, which means we do not need to check, or toggle the state. The hardware is supposed to enable the hardware optimization by default, unlike BDW, so we also don't need

Re: [Mesa-dev] [PATCH] st_glsl_to_tgsi: only do mov copy propogation on temps

On Wednesday, March 25, 2015 07:33:43 PM Ilia Mirkin wrote: > On Wed, Mar 25, 2015 at 7:18 PM, Dave Airlie wrote: > > From: Dave Airlie > > > > Don't propoate ARRAY > > > > This should fix: > > https://bugs.freedesktop.org/show_bug.cgi?id=89759 > > > > Signed-off-by: Dave Airlie > > Cc: mesa-sta

Re: [Mesa-dev] [PATCH 6/6] i965: Allow Y-tiled allocations for large surfaces

On Mon, Mar 23, 2015 at 02:52:50PM +, Neil Roberts wrote: > Sorry for the delay in replying to this. > > Ben Widawsky writes: > > >> > +static inline uint32_t > >> > +intel_miptree_blit_height(struct intel_mipmap_tree *mt) > >> > +{ > >> > + switch (mt->target) { > >> > + case GL_TEXTURE

Re: [Mesa-dev] [PATCH] st_glsl_to_tgsi: only do mov copy propogation on temps

On Wed, Mar 25, 2015 at 7:18 PM, Dave Airlie wrote: > From: Dave Airlie > > Don't propoate ARRAY > > This should fix: > https://bugs.freedesktop.org/show_bug.cgi?id=89759 > > Signed-off-by: Dave Airlie > Cc: mesa-sta...@lists.freedesktop.org Note that this disables propagating IN[] reads as wel

[Mesa-dev] [PATCH v2 6/6] i965/nir: Use NIR for ARB_vertex_program support on Gen8+.

Everything is already in place; we simply have to take the scalar code generation path. This gives us SIMD8 VS programs, instead of SIMD4x2. v2: Rebase on the patch that drops brw->gen >= 8. Signed-off-by: Kenneth Graunke Reviewed-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_vec4.cpp |

[Mesa-dev] [PATCH v2 2/6] nir: Add builder helpers for MOVs with ALU sources and swizzling MOVs.

These will be useful for prog->nir and tgsi->nir. Signed-off-by: Kenneth Graunke --- src/glsl/nir/nir_builder.h | 44 1 file changed, 44 insertions(+) diff --git a/src/glsl/nir/nir_builder.h b/src/glsl/nir/nir_builder.h index fe6cb37..cdd413e 100644

[Mesa-dev] [PATCH v2 5/6] i965/fs: Add ARB_fragment_program support to the NIR backend.

Use prog_to_nir where we would normally call glsl_to_nir, handle program parameter lists, and skip a few things that don't exist. Using NIR generates much better shader code than Mesa IR, since we get real optimizations, as opposed to prog_optimize: total instructions in shared programs: 314007 -

[Mesa-dev] [PATCH v2 4/6] nir: Lower subtraction to add with negation when !lower_negate.

prog->nir will generate fsub opcodes, but i965 doesn't implement them. We may as well lower them at the NIR level, since it's trivial to do. Suggested by Connor Abbott. Signed-off-by: Kenneth Graunke --- src/glsl/nir/nir_opt_algebraic.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src

[Mesa-dev] [PATCH v2 1/6] nir: Add nir_builder helpers for creating load_const intrinsics.

Both prog->nir and tgsi->nir will want to use these. Signed-off-by: Kenneth Graunke --- src/glsl/nir/nir_builder.h | 35 +++ 1 file changed, 35 insertions(+) diff --git a/src/glsl/nir/nir_builder.h b/src/glsl/nir/nir_builder.h index 7c4f7fd..fe6cb37 100644 --- a/

[Mesa-dev] [PATCH v2 3/6] nir: Implement a Mesa IR -> NIR translator.

Shamelessly ripped off from Eric Anholt's tgsi_to_nir pass. This is not built on SCons, like the rest of NIR. v2: - Delete redundant c->s, c->impl, and c->cf_node_list pointers (Ken) - Use nir_builder directly instead of ptn_compile in more places (Ken) - Drop 'struct' keyword in front of nir_bui

[Mesa-dev] [PATCH] st_glsl_to_tgsi: only do mov copy propogation on temps

From: Dave Airlie Don't propoate ARRAY This should fix: https://bugs.freedesktop.org/show_bug.cgi?id=89759 Signed-off-by: Dave Airlie Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker

Re: [Mesa-dev] [PATCH 3/6] i965: Create and use #defines for blitter constraints

On Mon, Mar 23, 2015 at 02:18:30PM +, Neil Roberts wrote: > Ben Widawsky writes: > > > diff --git a/src/mesa/drivers/dri/i965/intel_blit.h > > b/src/mesa/drivers/dri/i965/intel_blit.h > > index f563939..531d329 100644 > > --- a/src/mesa/drivers/dri/i965/intel_blit.h > > +++ b/src/mesa/driver

Re: [Mesa-dev] [PATCH v2] egl/dri2: Fix GCC maybe-uninitialized warning.

On Wed, 2015-03-25 at 18:55 -0400, Ilia Mirkin wrote: > On Wed, Mar 25, 2015 at 6:51 PM, Jan Vesely wrote: > > On Fri, 2015-03-06 at 23:54 -0800, Vinson Lee wrote: > >> egl_dri2.c: In function ‘dri2_bind_tex_image’: > >> egl_dri2.c:1240:4: warning: ‘format’ may be used uninitialized in this > >>

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #39 from Ilia Mirkin --- (In reply to Dan Sebald from comment #38) > I can experiment with some of the C "next nearest number" routines and get a > feeling for the ULP. Thanks. FWIW I think you're going way overboard with this. BTW,

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #38 from Dan Sebald --- 0.1 tolerance is rather large (I'm guessing that applies to normalized numbers). In this case the discrepancy doesn't come close to that big. I looked up ARB_shader_precision and I'm seeing tolerance on the o

Re: [Mesa-dev] [PATCH v2] egl/dri2: Fix GCC maybe-uninitialized warning.

On Wed, Mar 25, 2015 at 6:51 PM, Jan Vesely wrote: > On Fri, 2015-03-06 at 23:54 -0800, Vinson Lee wrote: >> egl_dri2.c: In function ‘dri2_bind_tex_image’: >> egl_dri2.c:1240:4: warning: ‘format’ may be used uninitialized in this >> function [-Wmaybe-uninitialized] >> (*dri2_dpy->tex_buffer->

Re: [Mesa-dev] [PATCH v2] egl/dri2: Fix GCC maybe-uninitialized warning.

On Fri, 2015-03-06 at 23:54 -0800, Vinson Lee wrote: > egl_dri2.c: In function ‘dri2_bind_tex_image’: > egl_dri2.c:1240:4: warning: ‘format’ may be used uninitialized in this > function [-Wmaybe-uninitialized] > (*dri2_dpy->tex_buffer->setTexBuffer2)(dri2_ctx->dri_context, > ^ > > Suggest

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #37 from Ilia Mirkin --- (In reply to Dan Sebald from comment #36) > What is the general thought regarding floating point numerical issues and > the OpenGL formulas? In early GLSL versions, floating point accuracy was supposed to be

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #36 from Dan Sebald --- What is the general thought regarding floating point numerical issues and the OpenGL formulas? The reason the swrast-legacy driver is failing one the Piglit pixelzoom tests is that this computation: c1 =

Re: [Mesa-dev] [PATCH v2] egl/dri2: Fix GCC maybe-uninitialized warning.

This was never pushed, so Reviewed-by: Mark Janes Vinson Lee writes: > egl_dri2.c: In function ‘dri2_bind_tex_image’: > egl_dri2.c:1240:4: warning: ‘format’ may be used uninitialized in this > function [-Wmaybe-uninitialized] > (*dri2_dpy->tex_buffer->setTexBuffer2)(dri2_ctx->dri_context,

Re: [Mesa-dev] [PATCH 6/6] i965/nir: Use NIR for ARB_vertex_program support on Gen8+.

On Tuesday, March 24, 2015 11:51:53 PM Jordan Justen wrote: > On 2015-03-23 17:38:00, Kenneth Graunke wrote: > > Everything is already in place; we simply have to take the scalar code > > generation path. This gives us SIMD8 VS programs, instead of SIMD4x2. > > > > Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH v2] i965/fs: in MAD optimizations, switch last argument to be immediate

On 16 March 2015 at 08:19, Kenneth Graunke wrote: > On Monday, March 16, 2015 10:08:08 AM Tapani Pälli wrote: >> Commit bb33a31 introduced optimizations that transform cases of MAD >> in to simpler forms but it did not take in to account that src[0] >> can not be immediate and did not report progr

Re: [Mesa-dev] [Freedreno] [Mesa-stable] [PATCH 2/2] freedreno/a3xx: fix 3d texture layout

On Wed, Mar 25, 2015 at 5:59 PM, Emil Velikov wrote: > On 15 March 2015 at 23:18, Ilia Mirkin wrote: >> The SZ2 field contains the layer size of a lower miplevel. It only >> contains 4 bits, which limits the maximum layer size it can describe. In >> situations where the next miplevel would be too

[Mesa-dev] [PATCH] nv50/ir: take postFactor into account when doing peephole optimizations

Multiply operations can have a post-factor on them, which other ops don't support. Only perform the peephole optimizations when there is no post-factor involved. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89758 Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_i

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] freedreno/a3xx: fix 3d texture layout

On 15 March 2015 at 23:18, Ilia Mirkin wrote: > The SZ2 field contains the layer size of a lower miplevel. It only > contains 4 bits, which limits the maximum layer size it can describe. In > situations where the next miplevel would be too big, the hardware > appears to keep minifying the size unt

Re: [Mesa-dev] [PATCH] nir: Add optional lowering of flrp.

Reviewed-by: Connor Abbott We should probably use this for Gen4-5 too. On Wed, Mar 25, 2015 at 5:11 PM, Eric Anholt wrote: > --- > > I missed this one when I was doing my other lowering bits. I don't > have ffma, and I certainly don't have flrp. > > src/gallium/drivers/vc4/vc4_program.c | 1 +

Re: [Mesa-dev] [PATCH 0/9] NIR: Several optimization patches

On Mon, Mar 23, 2015 at 8:13 PM, Jason Ekstrand wrote: > There is one notable place where this hurts us. There are three shaders in > Kerbal Space Program that now spill. However, this does not seem to be the > fault of NIR. See patch 8 for more details. I've got an optimization that brings th

Re: [Mesa-dev] [PATCH] nir: Add optional lowering of flrp.

On Wed, Mar 25, 2015 at 2:11 PM, Eric Anholt wrote: > --- > > I missed this one when I was doing my other lowering bits. I don't > have ffma, and I certainly don't have flrp. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedeskto

[Mesa-dev] [PATCH] nir: Add optional lowering of flrp.

--- I missed this one when I was doing my other lowering bits. I don't have ffma, and I certainly don't have flrp. src/gallium/drivers/vc4/vc4_program.c | 1 + src/glsl/nir/nir.h| 1 + src/glsl/nir/nir_opt_algebraic.py | 1 + 3 files changed, 3 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

On Wed, Mar 25, 2015 at 4:44 PM, Tom Stellard wrote: > On Wed, Mar 25, 2015 at 04:35:03PM -0400, Ilia Mirkin wrote: >> On Wed, Mar 25, 2015 at 4:27 PM, Dave Airlie wrote: >> > On 26 March 2015 at 06:07, Ilia Mirkin wrote: >> >> So what do you do when someone goes to shadertoy.com which on >>

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

On Wed, Mar 25, 2015 at 04:35:03PM -0400, Ilia Mirkin wrote: > On Wed, Mar 25, 2015 at 4:27 PM, Dave Airlie wrote: > > On 26 March 2015 at 06:07, Ilia Mirkin wrote: > >> So what do you do when someone goes to shadertoy.com which on > >> average uses 1000 temps? > > > > Fall over in a heap, li

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

On Wed, Mar 25, 2015 at 4:27 PM, Dave Airlie wrote: > On 26 March 2015 at 06:07, Ilia Mirkin wrote: >> So what do you do when someone goes to shadertoy.com which on >> average uses 1000 temps? > > Fall over in a heap, like every other driver on shadertoy, nouveau (nv50/nvc0) tends to do pret

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

On 26 March 2015 at 06:07, Ilia Mirkin wrote: > So what do you do when someone goes to shadertoy.com which on > average uses 1000 temps? Fall over in a heap, like every other driver on shadertoy, This would be raelly bad for r600g in its present state, since it doesn't go TGSI->SB yet, and t

[Mesa-dev] [PATCH] docs: note that classic osmesa/libEGL no longer builds with scons

Plus nuke final note of osmesa from README.WIN32 Signed-off-by: Emil Velikov --- docs/README.WIN32 | 4 docs/relnotes/10.6.0.html | 2 ++ 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/docs/README.WIN32 b/docs/README.WIN32 index e0e5b9b..94e1d6f 100644 --- a/docs/REA

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

So what do you do when someone goes to shadertoy.com which on average uses 1000 temps? On Wed, Mar 25, 2015 at 3:21 PM, Brian Paul wrote: > The problem is, our binary shader interface only supports 32 temps at this > time. We sometimes bump into that limit as-is. > > -Brian > > > On 03/25/20

Re: [Mesa-dev] [PATCH 4/8] scons: Don't build osmesa.

On 25/03/15 19:35, Emil Velikov wrote: On 25/03/15 15:21, Jose Fonseca wrote: On 25/03/15 14:53, Emil Velikov wrote: On 24 March 2015 at 21:16, Jose Fonseca wrote: There doesn't seem much interest on osmesa on Windows, particularly classic osmesa. If there is indeed interest in osmesa on Win

[Mesa-dev] [PATCH 2/2 v2] mesa: Add missing check of format and type in glTexSubImageXD on GLES 3.0

Argument validation for glTexSubImageXD is missing a check of format and type against texture object's internal format when profile is OpenGL-ES 3.0+. This patch also groups together all format and type checks into a single block of code for clarity. Fixes 2 dEQP tests: * dEQP-GLES3.functional.ne

[Mesa-dev] [PATCH 1/2 v2] mesa: Validate target before resolving tex obj in glTex(ture)SubImageXD

Currently, glTexSubImageXD attempt to resolve the texture object (by calling _mesa_get_current_tex_object()) before validating the given target. However, that method explicitly states that target must have been validated before calling it, so it never returns a user error. The target validation oc

Re: [Mesa-dev] [PATCH 4/8] scons: Don't build osmesa.

On 25/03/15 15:21, Jose Fonseca wrote: > On 25/03/15 14:53, Emil Velikov wrote: >> On 24 March 2015 at 21:16, Jose Fonseca wrote: >>> There doesn't seem much interest on osmesa on Windows, particularly >>> classic osmesa. >>> >>> If there is indeed interest in osmesa on Windows, we should instead

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

The problem is, our binary shader interface only supports 32 temps at this time. We sometimes bump into that limit as-is. -Brian On 03/25/2015 01:04 PM, Ilia Mirkin wrote: Yes, more temp registers and more instructions. But presumably the backend has an optimization pass that is at least as g

Re: [Mesa-dev] [PATCH] clover: Update the wait_count of the correct event when chaining events

Tom Stellard writes: > Cc: 10.5 10.4 > --- > src/gallium/state_trackers/clover/core/event.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/state_trackers/clover/core/event.cpp > b/src/gallium/state_trackers/clover/core/event.cpp > index 58de888..9d78b48

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

Yes, more temp registers and more instructions. But presumably the backend has an optimization pass that is at least as good as this one (hopefully better!). Is that not the case for vmware? On Wed, Mar 25, 2015 at 2:59 PM, Brian Paul wrote: > Will removing this pass have much effect on the numbe

[Mesa-dev] [PATCH] gallivm: use llvm function calls for texturing instead of inlining

From: Roland Scheidegger There are issues with inlining everything, most notably llvm will use much more memory (and be slower) when compiling. Ideally we'd probably use functions for shader functions too but texture sampling usually is responsible for quite some IR (it can easily reach 80% of to

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

Will removing this pass have much effect on the number of temp regs used? It looks like more instructions may be emitted w/out this pass. We're kind of sensitive to that in the VMware driver. -Brian On 03/25/2015 12:16 PM, Marek Olšák wrote: Reviewed-by: Marek Olšák I might need to wait fo

[Mesa-dev] [PATCH] clover: Update the wait_count of the correct event when chaining events

Cc: 10.5 10.4 --- src/gallium/state_trackers/clover/core/event.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/core/event.cpp b/src/gallium/state_trackers/clover/core/event.cpp index 58de888..9d78b48 100644 --- a/src/gallium/state_tracker

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

On Wed, Mar 25, 2015 at 2:16 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > I might need to wait for other people's opinion too. I guess technically a2xx backend might suffer.. not even really sure about that, but meh. We can probably eventually do tgsi->nir->optimize->tgsi if it was tha

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

Reviewed-by: Marek Olšák I might need to wait for other people's opinion too. Marek On Wed, Mar 25, 2015 at 6:34 PM, Ilia Mirkin wrote: > It's buggy and unnecessary in the presence of optimizing backends. The > only backend that will suffer is nv30, but... meh. > > Bugzilla: https://bugs.freed

[Mesa-dev] [Bug 89759] WebGL OGL ES GLSL conformance test with mesa drivers fails

https://bugs.freedesktop.org/show_bug.cgi?id=89759 --- Comment #5 from Ilia Mirkin --- FTR, the issue is that before the copy prop we have DCL TEMP[1..4], ARRAY(1), LOCAL DCL TEMP[5..8], ARRAY(2), LOCAL DCL TEMP[9..12], ARRAY(3), LOCAL DCL TEMP[13..16], ARRAY(4), LOCAL DCL TEMP[17..20], ARRAY(5)

[Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

It's buggy and unnecessary in the presence of optimizing backends. The only backend that will suffer is nv30, but... meh. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89759 Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 199 - 1

Re: [Mesa-dev] [PATCH] i965/fs: Combine tex/fb_write operations (opt)

On Mon, Feb 23, 2015 at 10:02:26AM -0800, Matt Turner wrote: > On Sun, Feb 22, 2015 at 3:06 PM, Ben Widawsky wrote: > > On Sun, Feb 08, 2015 at 02:48:02PM -0800, Matt Turner wrote: > >> On Sun, Feb 8, 2015 at 1:59 PM, Ben Widawsky > >> wrote: > >> > + /* The LOAD_PAYLOAD helper seems like the o

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

https://bugs.freedesktop.org/show_bug.cgi?id=89586 Dan Sebald changed: What|Removed |Added Attachment #114591|0 |1 is obsolete|

Re: [Mesa-dev] [PATCH] mesa/state_tracker: Fix draw-pixel-with-texture piglit test.

Minor nit-picks below. On 03/23/2015 11:38 PM, Matthew Dawson wrote: When glDrawPixels was used with an external texture, the pixels passed in were sampled instead of the texture. Change gallium to instead move the user texture to a new sampler below the glDrawPixels samplers and use the textu

Re: [Mesa-dev] [PATCH 1/6] nir: Add glsl_float_type() wrapper.

I finally git a chance to look through this. I think Eric, Connor, and Jordan have probably provided enough commentary so I don't have much to add. FWIW the series looks good to me pending the other comments. Can't say I read every line though. --Jason

Re: [Mesa-dev] [PATCH 1/3] dri3_glx.c: Pass NULL DRI drawables into driver for None GLX drawables

Hi Xiong Zhang, On 25 March 2015 at 08:05, Xiong Zhang wrote: > GLX_ARB_create_context spec says: > If either or are not a valid GLX drawable, a GLXBadDrawable > error is generated, unless and are both None and the OpenGL > version supported by is 3.0 or greater. > > So when both and are No

[Mesa-dev] [PATCH 2/2] gallivm: use llvm function calls for texturing instead of inlining

From: Roland Scheidegger There are issues with inlining everything, most notably llvm will use much more memory (and be slower) when compiling. Ideally we'd probably use functions for shader functions too but texture sampling usually is responsible for quite some IR (it can easily reach 80% of to

[Mesa-dev] [PATCH 1/2] gallivm: pass jit_context pointer through to sampling

From: Roland Scheidegger The callbacks used for getting the dynamic texture/sampler state were using the jit_context from the generated jit function. This works just fine, however that way it's impossible to generate separate functions for texture sampling, as will be done in the next commit. Hen

Re: [Mesa-dev] [PATCH] r600g/sb: Enable SB for geometry shaders

On Wed, 25 Mar 2015 14:26:40 +0100, Marc Dietrich wrote: Am Dienstag, 24. März 2015, 20:05:46 schrieb Glenn Kennard: On Tue, 24 Mar 2015 17:21:35 +0100, Dieter Nützel wrote: > Am 20.03.2015 14:13, schrieb Glenn Kennard: >> Add SV_GEOMETRY_EMIT special variable type to track the >> implicit d

[Mesa-dev] [Bug 89759] WebGL OGL ES GLSL conformance test with mesa drivers fails

https://bugs.freedesktop.org/show_bug.cgi?id=89759 --- Comment #4 from Ilia Mirkin --- Looks like the st/mesa copy propagation pass fails... commenting out v->copy_propagate(); makes the original shader work. Probably not the right forum, but why do we bother with the tgsi optimizations? All th

Re: [Mesa-dev] [PATCH 1/3] mesa: Improve validation of target, format and type of glTexSubImage[2, 3]D

With your modifications in this patch, the target is already validated by the time you get to this function, so it should be fine to move mesa select tex image up above the format and type checks. On Mar 24, 2015 11:44 PM, "Eduardo Lima Mitev" wrote: > On 03/25/2015 12:02 AM, Laura Ekstrand wrote

[Mesa-dev] [Bug 89754] vertexAttrib fails WebGL Conformance test with mesa drivers

https://bugs.freedesktop.org/show_bug.cgi?id=89754 Matthew Dawson changed: What|Removed |Added CC||matt...@mjdsystems.ca -- You are recei

Re: [Mesa-dev] [PATCH 4/8] scons: Don't build osmesa.

On 25/03/15 14:53, Emil Velikov wrote: On 24 March 2015 at 21:16, Jose Fonseca wrote: There doesn't seem much interest on osmesa on Windows, particularly classic osmesa. If there is indeed interest in osmesa on Windows, we should instead integrate src/gallium/targets/osmesa into SCons. Afaic

[Mesa-dev] [Bug 89759] WebGL OGL ES GLSL conformance test with mesa drivers fails

https://bugs.freedesktop.org/show_bug.cgi?id=89759 --- Comment #3 from Ilia Mirkin --- Created attachment 114617 --> https://bugs.freedesktop.org/attachment.cgi?id=114617&action=edit shader test Confirmed that it's the a[1] += 1.0; line causing the trouble. If I comment it out, I get the

Re: [Mesa-dev] [PATCH 2/6] nir: Implement a Mesa IR -> NIR translator.

On 24 March 2015 at 22:18, Kenneth Graunke wrote: > On Tuesday, March 24, 2015 08:52:01 PM Emil Velikov wrote: >> Hi Ken, >> >> On 24/03/15 00:37, Kenneth Graunke wrote: >> > Shamelessly ripped off from Eric Anholt's tgsi_to_nir pass. >> > >> > Not compiled on SCons, like the rest of NIR. >> > >>

Re: [Mesa-dev] [PATCH 4/8] scons: Don't build osmesa.

On 24 March 2015 at 21:16, Jose Fonseca wrote: > There doesn't seem much interest on osmesa on Windows, particularly classic > osmesa. > > If there is indeed interest in osmesa on Windows, we should instead > integrate src/gallium/targets/osmesa into SCons. Afaict the Octave people still use it.

Re: [Mesa-dev] [PATCH 2/8] scons: Don't build egl on Windows.

On 24 March 2015 at 21:16, Jose Fonseca wrote: > Useless, as there are no drivers for it. Hi Jose, Just a question - I was under the impression that one could use it with softpipe/llvmpipe's dri module. Although not sure if there are (m)any benefits of doing so. -Emil ___

[Mesa-dev] [Bug 89759] WebGL OGL ES GLSL conformance test with mesa drivers fails

https://bugs.freedesktop.org/show_bug.cgi?id=89759 --- Comment #2 from Ilia Mirkin --- Connor just confirmed that these pass on i965, so most likely a st/mesa issue. [Which doesn't have its own component.] -- You are receiving this mail because: You are the QA Contact for the bug. You are the a

[Mesa-dev] [Bug 89759] WebGL OGL ES GLSL conformance test with mesa drivers fails

https://bugs.freedesktop.org/show_bug.cgi?id=89759 Ilia Mirkin changed: What|Removed |Added Component|Drivers/DRI/nouveau |Mesa core Assignee|nouveau@lists

Re: [Mesa-dev] [PATCH] r600g/sb: Enable SB for geometry shaders

Am Dienstag, 24. März 2015, 20:05:46 schrieb Glenn Kennard: > On Tue, 24 Mar 2015 17:21:35 +0100, Dieter Nützel > > wrote: > > Am 20.03.2015 14:13, schrieb Glenn Kennard: > >> Add SV_GEOMETRY_EMIT special variable type to track the > >> implicit dependencies between CUT/EMIT_VERTEX/MEM_RING > >>

Re: [Mesa-dev] [PATCH 07/23] ir_to_mesa: Add support for ir_triop_csel

Took a moment to understand how this works but I think it does. Reviewed-by: Juha-Pekka Heikkila /Juha-Pekka On 20.03.2015 22:58, Ian Romanick wrote: > From: Ian Romanick > > The only drivers that use this path are i915 and swrast. Both of these > support the CMP opcode. This is untested, b

Re: [Mesa-dev] [PATCH 18.4/23] glsl: Constify ir_instruction::equals

Ian Romanick writes: > From: Ian Romanick > > v2: Don't be lazy. Constify the as_foo functions and use those instead > of ugly casts. Suggested by Curro. > > Signed-off-by: Ian Romanick > Cc: Francisco Jerez Thanks, this is much better: Reviewed-by: Francisco Jerez > --- > src/glsl/ir.h

Re: [Mesa-dev] [PATCH 18.3/23] glsl: Constify the as_foo functions

Ian Romanick writes: > From: Ian Romanick > > Now that they're all implemented using macros, this is trivial. > > Signed-off-by: Ian Romanick > Cc: Francisco Jerez > --- > src/glsl/ir.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/src/glsl/ir.h b/src/glsl/ir.h > index

Re: [Mesa-dev] [PATCH 18.2/23] glsl: Implement remaining as_foo functions with macros

Ian Romanick writes: > From: Ian Romanick > > The downcast functions for non-leaf classes were previously implemented > "by hand." Now they are implemented using macros based on the is_foo > functions added in the previous patch. > > Signed-off-by: Ian Romanick > Cc: Francisco Jerez Reviewed

Re: [Mesa-dev] [PATCH 18.1/23] glsl: Add is_rvalue, is_dereference, and is_jump methods

Ian Romanick writes: > On 03/24/2015 02:14 PM, Matt Turner wrote: >> On Tue, Mar 24, 2015 at 11:25 AM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> These functions deteremine when an IR node is one of the non-leaf >>> classes. >>> >>> Signed-off-by: Ian Romanick >>> Cc: Francisco Jerez

Re: [Mesa-dev] [PATCH 0/7] clover: add clLinkProgram

Ping Le 2014-12-14 11:31, EdB a écrit : Hello, This serie add the neccesary bits needed for clLinkProgram. Patches from 1 to 2 are llvm/invocation.cpp little reorganisation. Patches 3 to 5 rework our clCompileProgram implementation. Patch 6 is for returning clover smart ptr to the API side. Pat

[Mesa-dev] [PATCH] i965: Add XRGB8888 format to intel_screen_make_configs

Some application, such as drm backend of weston, uses XRGB config as default. i965 doesn't provide this format, but before commit 65c8965d, the drm platform of EGL takes ARGB as XRGB. Now that commit 65c8965d makes EGL recognize format correctly so weston won't start because it can't fi

[Mesa-dev] [Bug 81680] [r600g] Firefox crashes with hardware acceleration turned on

https://bugs.freedesktop.org/show_bug.cgi?id=81680 Michel Dänzer changed: What|Removed |Added CC||kami...@gmail.com --- Comment #47 from M

Re: [Mesa-dev] Building Mesa for Windows using Visual Studio

See http://www.mesa3d.org/install.html or docs/install.html from Mesa tree. If you want to build with llvmpipe support, you'll also need to read and follow http://www.mesa3d.org/llvmpipe.html I'm also experimenting on automated Windows builds with AppVeyor. You can see the build log

Re: [Mesa-dev] [PATCH v4 16/17] main: Added entry points for NamedRenderbufferStorage/Multisample

On 25/03/15 01:27, Laura Ekstrand wrote: Looks good to me. Reviewed-by: Laura Ekstrand > Thanks, I pushed the whole series. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/lis

[Mesa-dev] [PATCH 1/3] dri3_glx.c: Pass NULL DRI drawables into driver for None GLX drawables

GLX_ARB_create_context spec says: If either or are not a valid GLX drawable, a GLXBadDrawable error is generated, unless and are both None and the OpenGL version supported by is 3.0 or greater. So when both and are None, it could pass NULL drawable into driver instead of returing GLXBadDraw

[Mesa-dev] [PATCH 2/3] driX_glx.c: Draw and read must be either all non-zero or all zero

Signed-off-by: Xiong Zhang --- src/glx/dri2_glx.c | 5 + src/glx/dri3_glx.c | 5 + src/glx/dri_glx.c | 5 + src/glx/drisw_glx.c | 5 + 4 files changed, 20 insertions(+) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index 462d560..f980f82 100644 --- a/src/glx/dri2_glx.c

[Mesa-dev] [PATCH 3/3] glx: Distinguish the macro value for Success and GLXBadContext

The return value for glx_context->vtable->bind may be Success or GLXBadContext, but the macro value for both Success and GLXBadContext are 0, so the caller can't identify the return value between them. Signed-off-by: Xiong Zhang --- src/glx/applegl_glx.c | 12 +++- src/glx/dri2_glx.c

Re: [Mesa-dev] [PATCH 1/6] nir: Add glsl_float_type() wrapper.

On 2015-03-23 17:37:55, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/glsl/nir/nir_types.cpp | 6 ++ > src/glsl/nir/nir_types.h | 1 + > 2 files changed, 7 insertions(+) > > Patches also available in the `nir-arb` branch of ~kwg/mesa. Nice results. With minor commen