Re: [Mesa-dev] [PATCH 6/6] i965/nir: Use NIR for ARB_vertex_program support on Gen8+.

[Kenneth Graunke]

On Tuesday, March 24, 2015 11:51:53 PM Jordan Justen wrote:
> On 2015-03-23 17:38:00, Kenneth Graunke wrote:
> > Everything is already in place; we simply have to take the scalar code
> > generation path.  This gives us SIMD8 VS programs, instead of SIMD4x2.
> > 
> > Signed-off-by: Kenneth Graunke <kenn...@whitecape.org>
> > ---
> >  src/mesa/drivers/dri/i965/brw_vec4.cpp | 14 ++++++++++----
> >  1 file changed, 10 insertions(+), 4 deletions(-)
> > 
> > diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp 
b/src/mesa/drivers/dri/i965/brw_vec4.cpp
> > index 918519c..21de1af 100644
> > --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp
> > +++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp
> > @@ -1823,7 +1823,7 @@ brw_vs_emit(struct brw_context *brw,
> >     if (unlikely(INTEL_DEBUG & DEBUG_VS))
> >        brw_dump_ir("vertex", prog, &shader->base, &c->vp->program.Base);
> >  
> > -   if (prog && brw->gen >= 8 && brw->scalar_vs) {
> > +   if (brw->gen >= 8 && brw->scalar_vs && (prog || 
getenv("INTEL_USE_NIR"))) {
> 
> We should be able to leave out the brw->gen >= 8 check, right?
> 
> -Jordan

Yup - that's never been necessary.  I made a separate patch to delete
that (prior to this one), and went ahead and put your Reviewed-by on it.

signature.asc
Description: This is a digitally signed message part.

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev