Re: [Mesa-dev] [PATCH 1/2] mesa/main: Make get_hash.c values constant.

2014-06-06 Thread Ian Romanick
On 06/06/2014 05:13 PM, Carl Worth wrote: > Ian Romanick writes: >> Series is >> >> Reviewed-by: Ian Romanick >> Cc: "10.1 10.2" > > This hunk: > > + /* ARB_vertex_array_bgra */ > + case GL_COLOR_ARRAY_SIZE: > + array = &ctx->Array.VAO->VertexAttrib[VERT_ATTRIB_COLOR0]; > + v

Re: [Mesa-dev] [Piglit] [PATCH piglit] Test using glTexSubImage2D with packed depth-stencil textures

2014-06-06 Thread Ian Romanick
On 06/06/2014 02:53 AM, Tapani Pälli wrote: > > with 2 small things (mentioned below) fixed; > > Reviewed-by: Tapani Pälli > > > On 06/05/2014 03:57 PM, Neil Roberts wrote: >> This adds a test for updating a sub-region of a texture created with >> the GL_EXT_packed_depth_stencil extension. Cur

[Mesa-dev] Mesa 10.2.1 release

2014-06-06 Thread Ian Romanick
Mesa 10.2.1 has been released! Mesa 10.2.1 is an emergency release to fix a build failure added to 10.2 between 10.2-rc5 and the final release. There are no other code changes. Sorry for the commotion. :( The tag in the GIT repository for Mesa 10.2.1 is 'mesa-10.2.1'. I have verified that the

[Mesa-dev] [PATCH] intel: Fix initial MakeCurrent for drawables of multi screens

2014-06-06 Thread Xiong Zhang
This patch fix a regression caused by commit 11baad35. Multi screens share one context. When the first screen call intel_prepare_render(), it will set ctx->ViewportInitialized to true, so the following screens don't have chance to call intel _prepare_render(). If all screens run following gl comma

[Mesa-dev] [Bug 54372] GLX_INTEL_swap_event crashes driver when swapping window buffers

2014-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54372 --- Comment #10 from danm...@gmail.com --- Regarding your request for info about my system, X server etc: I have tested my application with over 40 GPUs, and 7 host systems. The full matrix is just a distraction. In good news the radeon r300 dri

[Mesa-dev] [Bug 54372] GLX_INTEL_swap_event crashes driver when swapping window buffers

2014-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54372 --- Comment #9 from danm...@gmail.com --- Attached is a backtrace from the crash with the 10.1.4 glx libs. The same patch attached here still fixes the crash. It would take me days to produce a small test program for you. My program is quite com

[Mesa-dev] [Bug 54372] GLX_INTEL_swap_event crashes driver when swapping window buffers

2014-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54372 --- Comment #8 from danm...@gmail.com --- Created attachment 100587 --> https://bugs.freedesktop.org/attachment.cgi?id=100587&action=edit Edited backtrace of glx crash -- You are receiving this mail because: You are the QA Contact for the bug.

Re: [Mesa-dev] [PATCH] radeonsi: Fix build error introduced in 5ab9a9c

2014-06-06 Thread Laurent Carlier
Le vendredi 6 juin 2014, 22:11:43 Ian Romanick a écrit : > From: Ian Romanick > > While resolving conflicts in cherry picking commit d226191, I > accidentally introduced some garbage. Because radeonsi isn't built by > default, the problem went unnoticed by me. > > Signed-off-by: Ian Romanick >

[Mesa-dev] [PATCH] radeonsi: Fix build error introduced in 5ab9a9c

2014-06-06 Thread Ian Romanick
From: Ian Romanick While resolving conflicts in cherry picking commit d226191, I accidentally introduced some garbage. Because radeonsi isn't built by default, the problem went unnoticed by me. Signed-off-by: Ian Romanick Reported-by: Laurent Carlier --- Laurent, can you verify that this fix

Re: [Mesa-dev] Mesa 10.2 release

2014-06-06 Thread Ian Romanick
On 06/06/2014 09:52 PM, Laurent Carlier wrote: > Le vendredi 6 juin 2014 21:38:23, vous avez écrit : >> On 06/06/2014 09:35 PM, Laurent Carlier wrote: >>> Le vendredi 6 juin 2014, 21:20:12 Ian Romanick a écrit : Mesa 10.2 has been released! Mesa 10.2 is a feature release that includes man

Re: [Mesa-dev] Mesa 10.2 release

2014-06-06 Thread Laurent Carlier
Le vendredi 6 juin 2014 21:38:23, vous avez écrit : > On 06/06/2014 09:35 PM, Laurent Carlier wrote: > > Le vendredi 6 juin 2014, 21:20:12 Ian Romanick a écrit : > >> Mesa 10.2 has been released! Mesa 10.2 is a feature release that > >> includes many updates and enhancements. The full list is avail

Re: [Mesa-dev] Mesa 10.2 release

2014-06-06 Thread Laurent Carlier
Le vendredi 6 juin 2014, 21:38:23 Ian Romanick a écrit : > On 06/06/2014 09:35 PM, Laurent Carlier wrote: > > Le vendredi 6 juin 2014, 21:20:12 Ian Romanick a écrit : > >> Mesa 10.2 has been released! Mesa 10.2 is a feature release that > >> includes many updates and enhancements. The full list is

Re: [Mesa-dev] [PATCH 04/15] glsl: Add preprocessor error condition for #else directive

2014-06-06 Thread Ian Romanick
I thought Matt already fixed this bug. commit 060e69679925f171cfcc2a5f84fab1d833a7e804 Author: Matt Turner Date: Tue Nov 6 10:59:30 2012 -0800 glcpp: Reject garbage after #else and #endif tokens Previously we were accepting garbage after #else and #endif tokens when the previo

Re: [Mesa-dev] [PATCH 05/15] mesa: Fix error condition for valid texture targets in glTexStorage* functions

2014-06-06 Thread Matt Turner
On Fri, Jun 6, 2014 at 9:30 PM, Ian Romanick wrote: > On 06/06/2014 09:13 PM, Matt Turner wrote: >> On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: >>> Fixes gles3 Khronos CTS test: texture_storage_texture_targets >>> >>> Cc: >>> Signed-off-by: Anuj Phogat >>> --- >>> src/mesa/main/texstora

Re: [Mesa-dev] Mesa 10.2 release

2014-06-06 Thread Ian Romanick
On 06/06/2014 09:35 PM, Laurent Carlier wrote: > Le vendredi 6 juin 2014, 21:20:12 Ian Romanick a écrit : >> Mesa 10.2 has been released! Mesa 10.2 is a feature release that >> includes many updates and enhancements. The full list is available in >> the release notes file in docs/relnotes/10.2.html

Re: [Mesa-dev] Mesa 10.2 release

2014-06-06 Thread Laurent Carlier
Le vendredi 6 juin 2014, 21:20:12 Ian Romanick a écrit : > Mesa 10.2 has been released! Mesa 10.2 is a feature release that > includes many updates and enhancements. The full list is available in > the release notes file in docs/relnotes/10.2.html. > It fails to build here: make[3]: Leaving direc

Re: [Mesa-dev] [PATCH 01/15] glsl: Add __FILE__ and __LINE__ as built-in macros

2014-06-06 Thread Ian Romanick
On 06/06/2014 09:03 PM, Matt Turner wrote: > On Fri, Jun 6, 2014 at 4:56 PM, Anuj Phogat wrote: >> A compile error will be generated for redefinition of these macros. >> >> Cc: >> Signed-off-by: Anuj Phogat >> --- >> src/glsl/glcpp/glcpp-parse.y | 2 ++ >> 1 file changed, 2 insertions(+) >> >>

Re: [Mesa-dev] [PATCH 05/15] mesa: Fix error condition for valid texture targets in glTexStorage* functions

2014-06-06 Thread Ian Romanick
On 06/06/2014 09:13 PM, Matt Turner wrote: > On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: >> Fixes gles3 Khronos CTS test: texture_storage_texture_targets >> >> Cc: >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/main/texstorage.c | 7 +++ >> 1 file changed, 7 insertions(+) >> >> dif

[Mesa-dev] Mesa 10.2 release

2014-06-06 Thread Ian Romanick
Mesa 10.2 has been released! Mesa 10.2 is a feature release that includes many updates and enhancements. The full list is available in the release notes file in docs/relnotes/10.2.html. The tag in the GIT repository for Mesa 10.2 is 'mesa-10.2'. I have verified that the tag is in the correct plac

Re: [Mesa-dev] [PATCH 05/15] mesa: Fix error condition for valid texture targets in glTexStorage* functions

2014-06-06 Thread Matt Turner
On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: > Fixes gles3 Khronos CTS test: texture_storage_texture_targets > > Cc: > Signed-off-by: Anuj Phogat > --- > src/mesa/main/texstorage.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/t

Re: [Mesa-dev] [PATCH 01/15] glsl: Add __FILE__ and __LINE__ as built-in macros

2014-06-06 Thread Matt Turner
On Fri, Jun 6, 2014 at 4:56 PM, Anuj Phogat wrote: > A compile error will be generated for redefinition of these macros. > > Cc: > Signed-off-by: Anuj Phogat > --- > src/glsl/glcpp/glcpp-parse.y | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/g

Re: [Mesa-dev] [PATCH] glapi: Add KHR_debug functions to check_table test

2014-06-06 Thread Timothy Arceri
Bump. Just going through some uncommitted stuff, not too concerned about this personally but would be good to get a reviewed by so I can push before its forgotten about forever. On Fri, 2014-04-04 at 22:08 +1100, Timothy Arceri wrote: > Signed-off-by: Timothy Arceri > --- > src/mapi/glapi/test

[Mesa-dev] Mesa 10.1.5

2014-06-06 Thread Carl Worth
Mesa 10.1.5 has been released. Mesa 10.1.5 is a bug fix release which fixes bugs fixed since the 10.1.4 release, (see below for a list of changes). The tag in the git repository for Mesa 10.1.5 is 'mesa-10.1.5'. Mesa 10.1.5 is available for download at ftp://freedesktop.org/pub/mesa/10.1.5/ SHA-

Re: [Mesa-dev] [PATCH] mesa: Fix substitution of large shaders

2014-06-06 Thread Brian Paul
Reviewed-by: Brian Paul Do you need someone to commit/push this for you? -Brian On 06/06/2014 12:04 PM, Cody Northrop wrote: Whoops, yes, you're right. ftell() of SEEK_END and strlen() are returning the same value, which does not include the terminating zero. Updated patch below. We use th

Re: [Mesa-dev] Mesa (master): r600g, radeonsi: don' t use hardware MSAA resolve if dst is fast-cleared

2014-06-06 Thread Ian Romanick
This patch didn't apply cleanly to 10.2. It appears that 0423513c also hits some code in this area. I picked d2261918 over, but should 0423513c also get picked? On 06/03/2014 04:33 AM, Marek Olšák wrote: > Module: Mesa > Branch: master > Commit: d2261918202697febed0de18f66416e273001088 > URL:

Re: [Mesa-dev] [PATCH 10/15] mesa: Don't allow snorm internal formats in glCopyTexImage*() in GLES3

2014-06-06 Thread Marek Olšák
Since this seems to be a GLES-only limitation, the patch should use _mesa_is_gles3 or _mesa_is_gles. Marek On Sat, Jun 7, 2014 at 1:57 AM, Anuj Phogat wrote: > Fixes few failures in gles3 Khronos CTS test: packed_pixels > > Cc: "10.2" > Signed-off-by: Anuj Phogat > --- > src/mesa/main/teximag

[Mesa-dev] [PATCH 13/15] mesa: Add gles3 error condition for GL_RGBA10_A2 buffer format in glCopyTexImage*()

2014-06-06 Thread Anuj Phogat
Fixes many failures in gles3 Khronos CTS test: packed_pixels Khronos bug# 9807 Cc: Signed-off-by: Anuj Phogat Signed-off-by: Anuj Phogat --- src/mesa/main/teximage.c | 45 - 1 file changed, 28 insertions(+), 17 deletions(-) diff --git a/src/mesa/ma

[Mesa-dev] [PATCH 11/15] mesa: Add a helper function _mesa_is_enum_format_unsized()

2014-06-06 Thread Anuj Phogat
Function is utilized by next patch in the series. Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/glformats.c | 18 ++ src/mesa/main/glformats.h | 3 +++ 2 files changed, 21 insertions(+) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index 05a3842..b95ece

[Mesa-dev] [PATCH 06/15] mesa: Turn target_can_be_compressed() in to a utility function

2014-06-06 Thread Anuj Phogat
Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/glformats.h | 3 +++ src/mesa/main/teximage.c | 12 ++-- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/glformats.h b/src/mesa/main/glformats.h index af10899..5c3b2e3 100644 --- a/src/mesa/main/glformats.h +

[Mesa-dev] [PATCH 10/15] mesa: Don't allow snorm internal formats in glCopyTexImage*() in GLES3

2014-06-06 Thread Anuj Phogat
Fixes few failures in gles3 Khronos CTS test: packed_pixels Cc: "10.2" Signed-off-by: Anuj Phogat --- src/mesa/main/teximage.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 03ebbd8..6474dba 100644 --- a/src/mesa/main/t

[Mesa-dev] [PATCH 09/15] mesa: Add utility function mesa_is_enum_format_snorm()

2014-06-06 Thread Anuj Phogat
Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/glformats.c | 37 + src/mesa/main/glformats.h | 3 +++ 2 files changed, 40 insertions(+) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index 9bb341c..05a3842 100644 --- a/src/mesa/main/glf

[Mesa-dev] [PATCH 02/15] glsl: Do not allow undefining the built-in macros

2014-06-06 Thread Anuj Phogat
Fixes piglit tests in spec/glsl-es-3.00/compile: undef-__FILE__.vert undef-GL_ES.vert undef-__LINE__.vert undef-__VERSION__.vert Also, fixes Khronos GLES3 CTS tests: undefine_invalid_object_1_vertex undefine_invalid_object_1_fragment undefine_invalid_object_2_vertex undefine_invalid_object_2_fragm

[Mesa-dev] [PATCH 05/15] mesa: Fix error condition for valid texture targets in glTexStorage* functions

2014-06-06 Thread Anuj Phogat
Fixes gles3 Khronos CTS test: texture_storage_texture_targets Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/texstorage.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/texstorage.c index 86c8f3c..44b5374 100644 --- a/src/mesa/main/texsto

[Mesa-dev] [PATCH 00/15] Fix mesa bugs identified by Khronos GLES3 conformance tests

2014-06-06 Thread Anuj Phogat
Patches in this series fix few preprocessor bugs and GLES3 error conditions. This series is also available on 'review' branch at: https://github.com/aphogat/mesa.git Anuj Phogat (15): glsl: Add __FILE__ and __LINE__ as built-in macros glsl: Do not allow undefining the built-in macros glsl:

[Mesa-dev] [PATCH 12/15] mesa: Add a gles3 error condition for sized internalformat in glCopyTexImage*()

2014-06-06 Thread Anuj Phogat
Fixes many failures in gles3 Khronos CTS test: packed_pixels Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/teximage.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 6474dba..c926a2f 10

[Mesa-dev] [PATCH 04/15] glsl: Add preprocessor error condition for #else directive

2014-06-06 Thread Anuj Phogat
Fixes gles3 Khronos CTS tests: tokens_after_else_vertex tokens_after_else_fragment Cc: Signed-off-by: Anuj Phogat --- src/glsl/glcpp/glcpp-lex.l | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/glcpp/glcpp-lex.l b/src/glsl/glcpp/glcpp-lex.l index 188e454..393db81 100644 --- a/sr

[Mesa-dev] [PATCH 03/15] glsl: Fix preprocessor error condition for macro redefinition

2014-06-06 Thread Anuj Phogat
This patch specifically fixes redefinition condition for white space changes. #define and #undef functionality in GLSL follows the standard for C++ preprocessors for macro definitions. >From https://gcc.gnu.org/onlinedocs/cpp/Undefining-and-Redefining-Macros.html: These definitions are effectivel

Re: [Mesa-dev] [PATCH 1/2] mesa/main: Make get_hash.c values constant.

2014-06-06 Thread Carl Worth
Ian Romanick writes: > Series is > > Reviewed-by: Ian Romanick > Cc: "10.1 10.2" This hunk: + /* ARB_vertex_array_bgra */ + case GL_COLOR_ARRAY_SIZE: + array = &ctx->Array.VAO->VertexAttrib[VERT_ATTRIB_COLOR0]; + v->value_int = array->Format == GL_BGRA ? GL_BGRA : array->Size

[Mesa-dev] [PATCH 15/15] mesa: Add gles3 condition for normalized internal formats in glCopyTexImage*()

2014-06-06 Thread Anuj Phogat
Fixes many failures in gles3 Khronos CTS test: packed_pixels Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/teximage.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 11b8439..a09d994 100644 --- a/src/mesa/main/tex

[Mesa-dev] [PATCH 07/15] mesa: Add error condition for using compressed internalformat in glTexStorage3D()

2014-06-06 Thread Anuj Phogat
Fixes gles3 Khronos CTS test: texture_storage_texture_internal_formats Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/texstorage.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/texstorage.c index 44b5374..897d589 100644 ---

[Mesa-dev] [PATCH 01/15] glsl: Add __FILE__ and __LINE__ as built-in macros

2014-06-06 Thread Anuj Phogat
A compile error will be generated for redefinition of these macros. Cc: Signed-off-by: Anuj Phogat --- src/glsl/glcpp/glcpp-parse.y | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index 9887583..2ddc8b9 100644 --- a/src/glsl/glcp

[Mesa-dev] [PATCH 08/15] mesa: Fix condition for using compressed internalformat in glCompressedTexImage3D()

2014-06-06 Thread Anuj Phogat
Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/teximage.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index b8627a3..03ebbd8 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -2262,7 +2262

[Mesa-dev] [PATCH 14/15] mesa: Add utility function _mesa_is_enum_format_unorm()

2014-06-06 Thread Anuj Phogat
Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/glformats.c | 67 +++ src/mesa/main/glformats.h | 3 +++ 2 files changed, 70 insertions(+) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index b95ecea..8107757 100644 --- a/src/mes

Re: [Mesa-dev] [Mesa-stable] [PATCH] Check for NULL native_window into eglCreateWindowSurface()

2014-06-06 Thread Carl Worth
Sinclair Yeh writes: > This fix adds a check and sets EGL_BAD_NATIVE_WINDOW > > Cc: "10.1 10.2" From what I can tell, the function being modified by this patch doesn't actually exist in 10.1, so I'm passing on this patch for the 10.1 branch. -Carl -- carl.d.wo...@intel.com pgpww6vHRSf1G.pgp

[Mesa-dev] [PATCH] mesa/main: Prevent sefgault on glGetIntegerv(GL_ATOMIC_COUNTER_BUFFER_BINDING).

2014-06-06 Thread jfonseca
From: José Fonseca A recent ApiTrace change, that tries to dump more buffer state causes Mesa from my distro (10.1.4) to segfaults here. I haven't actually confirm this fixes it (I can't repro on master), but it seems a good idea to be defensive here anyway. Cc: "10.1 10.2" --- src/mesa/main/

Re: [Mesa-dev] [PATCH 1/2] radeonsi: implement ARB_texture_gather and Gather functions from GLSL 4.00

2014-06-06 Thread Marek Olšák
All offsets are six-bit signed integers on SI packed into one dword. They are set in the same way no matter what the instruction is. All SAMPLE and GATHER4 instructions, i.e. those which take floating-point coordinates, support offsets. Only the IMAGE_LOAD instructions (texelFetch) don't support i

Re: [Mesa-dev] [Nouveau] [PATCH 1/3] gk110/ir: emit texbar the same way that the blob does

2014-06-06 Thread Ben Skeggs
On Sat, Jun 7, 2014 at 5:43 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > Cc: "10.2" For the series: Reviewed-by: Ben Skeggs > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers

Re: [Mesa-dev] [PATCH 1/2] radeonsi: implement ARB_texture_gather and Gather functions from GLSL 4.00

2014-06-06 Thread Ilia Mirkin
On Fri, Jun 6, 2014 at 5:58 PM, Marek Olšák wrote: > diff --git a/src/gallium/drivers/radeonsi/si_pipe.c > b/src/gallium/drivers/radeonsi/si_pipe.c > index 4b96f20..a3e1846 100644 > --- a/src/gallium/drivers/radeonsi/si_pipe.c > +++ b/src/gallium/drivers/radeonsi/si_pipe.c > @@ -294,11 +297,12 @@

[Mesa-dev] [PATCH 1/2] radeonsi: implement ARB_texture_gather and Gather functions from GLSL 4.00

2014-06-06 Thread Marek Olšák
From: Marek Olšák All ARB_texture_gather and gather-related ARB_gpu_shader5 piglit tests pass. --- docs/GL3.txt | 2 +- docs/relnotes/10.3.html | 1 + src/gallium/drivers/radeonsi/si_pipe.c | 12 ++- src/gallium/drivers/radeonsi/si_shader.c | 1

[Mesa-dev] [PATCH 2/2] radeonsi: cosmetic changes in si_shader.c

2014-06-06 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index d7e588d..a7ca35b 100644 --- a/src/galliu

[Mesa-dev] [PATCH] R600/SI: add Gather4 intrinsics

2014-06-06 Thread Marek Olšák
From: Marek Olšák This adds a new type of intrinsic and SDNode: SampleRaw. All fields of the MIMG opcodes are exposed and can be set by Mesa, even DMASK. All GATHER4 variants are added and there are a lot of them. DMASK was repurposed for GATHER4, so all passes which modify DMASK are disabled by

[Mesa-dev] Texture object locking

2014-06-06 Thread Jason Ekstrand
Hello all, Kristian and I were looking at this today, and there seems to be a substantial race in the way that we are doing texture locking. In particular, we usually do the following: Lock the hashmap Find the texture object Unlock the hashmap Lock the texture object Do Stuff Unlock the texture

[Mesa-dev] [PATCH 2/3] gk110: add in forgotten code for gk110 isa

2014-06-06 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin Cc: "10.2" --- Pretty sure this was the cause of all the "invalid opcode" errors on like 20% of the piglit tests. Any time the 3d blit path was used, this would trigger. src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 13 + 1 file changed, 13 insertions

[Mesa-dev] [PATCH 1/3] gk110/ir: emit texbar the same way that the blob does

2014-06-06 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin Cc: "10.2" --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp index

[Mesa-dev] [PATCH 3/3] nvc0: don't bother trying to set up compute for gk110+

2014-06-06 Thread Ilia Mirkin
The nouveau fw currently prints a bunch of errors. No point in seeing those all the time, esp since compute doesn't really work in the first place. Signed-off-by: Ilia Mirkin Cc: "10.2" --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-

Re: [Mesa-dev] [PATCH] mesa: Fix substitution of large shaders

2014-06-06 Thread Cody Northrop
Whoops, yes, you're right. ftell() of SEEK_END and strlen() are returning the same value, which does not include the terminating zero. Updated patch below. We use this quite a bit, much faster than editing large apitrace files Thanks, -C Signed-off-by: Cody Northrop --- src/mesa/main/shade

Re: [Mesa-dev] [PATCH 1/8] add megadriver_stub_FILES

2014-06-06 Thread Emil Velikov
Hi Adrian, I seem to recall seeing this patch although it seems like it never got pushed. Note sure how the Android development process goes but imho these should be safe to go in stable. Cc: "10.1 10.2" Reviewed-by: Emil Velikov Let me know if you need someone to push these for you. In your

Re: [Mesa-dev] [PATCH 2/3] radeon/compute: Implement PIPE_COMPUTE_CAP_MAX_COMPUTE_UNITS

2014-06-06 Thread Alex Deucher
On Thu, Jun 5, 2014 at 2:39 PM, Bruno Jimenez wrote: > On Tue, 2014-06-03 at 08:55 -0400, Alex Deucher wrote: >> On Mon, Jun 2, 2014 at 7:34 PM, Bruno Jimenez wrote: >> > On Mon, 2014-06-02 at 16:16 -0400, Alex Deucher wrote: >> >> On Sat, May 31, 2014 at 7:13 AM, Bruno Jimenez >> >> wrote: >>

[Mesa-dev] [Bug 79688] [dri3] Latest git breaks PRIME Offloading to Nouveau GPU

2014-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79688 Jan Vesely changed: What|Removed |Added CC||jano.ves...@gmail.com -- You are receiving

Re: [Mesa-dev] [PATCH 1/8] add megadriver_stub_FILES

2014-06-06 Thread Juha-Pekka Heikkila
This set 1..8 Reviewed-by: Juha-Pekka Heikkila On 06.06.2014 12:16, Adrian Negreanu wrote: > From: Adrian Negreanu > > So that android part can also use $(megadriver_stub_FILES) > > Signed-off-by: Adrian Negreanu > --- > src/mesa/drivers/dri/common/Makefile.am | 2 +- > src/mesa/driver

[Mesa-dev] [Bug 79688] [dri3] Latest git breaks PRIME Offloading to Nouveau GPU

2014-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79688 Frederic Romagne changed: What|Removed |Added CC||frederic.roma...@gmail.com -- You ar

[Mesa-dev] [Bug 54372] GLX_INTEL_swap_event crashes driver when swapping window buffers

2014-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54372 --- Comment #7 from Tapani Pälli --- Also please include some information on your setup, which version of X server, Mesa and so on. -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [Bug 54372] GLX_INTEL_swap_event crashes driver when swapping window buffers

2014-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54372 --- Comment #6 from Tapani Pälli --- Do you have some small test app to trigger this bug? I haven't worked on GLX code but it would help to understand the problem better. In Piglit test suite there is a test "./tests/glx/glx-swap-event.c" that c

Re: [Mesa-dev] [PATCH piglit] Test using glTexSubImage2D with packed depth-stencil textures

2014-06-06 Thread Tapani Pälli
with 2 small things (mentioned below) fixed; Reviewed-by: Tapani Pälli On 06/05/2014 03:57 PM, Neil Roberts wrote: > This adds a test for updating a sub-region of a texture created with > the GL_EXT_packed_depth_stencil extension. Currently this seems to > trigger a bug on the i965 driver. > -

[Mesa-dev] [PATCH 1/8] add megadriver_stub_FILES

2014-06-06 Thread Adrian Negreanu
From: Adrian Negreanu So that android part can also use $(megadriver_stub_FILES) Signed-off-by: Adrian Negreanu --- src/mesa/drivers/dri/common/Makefile.am | 2 +- src/mesa/drivers/dri/common/Makefile.sources | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/

[Mesa-dev] [PATCH 8/8] android, dricore: undefined reference to _mesa_streaming_load_memcpy

2014-06-06 Thread Adrian Negreanu
From: Adrian Negreanu _mesa_streaming_load_memcpy is defined in main/streaming-load-memcpy.c I'm adding it to the dricore lib Signed-off-by: Adrian Negreanu --- src/mesa/Android.libmesa_dricore.mk | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/Android.libmesa_dricore.mk b/s

[Mesa-dev] [PATCH 4/8] android: add src/gallium/auxiliary as include path for libmesa_dricore

2014-06-06 Thread Adrian Negreanu
From: Adrian Negreanu This fixes: In file included from /home/adrian/workspace/mesa/mesa-master.git/src/mesa/vbo/vbo_exec_api.c:445:0: /home/adrian/workspace/mesa/mesa-master.git/src/mesa/vbo/vbo_attrib_tmp.h:28:38: fatal error: util/u_format_r11g11b10f.h: No such file or directory Signed-off-by

[Mesa-dev] [PATCH 5/8] android, egl: add correct drm include for libmesa_egl_dri2

2014-06-06 Thread Adrian Negreanu
From: Adrian Negreanu Fixes: src/egl/drivers/dri2/platform_android.c:38: include/GL/internal/dri_interface.h:51:17: fatal error: drm.h: No such file or directory Signed-off-by: Adrian Negreanu --- src/egl/drivers/dri2/Android.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/src/e

[Mesa-dev] [PATCH 3/8] android: add libloader to libGLES_mesa and libmesa_egl_dri2

2014-06-06 Thread Adrian Negreanu
From: Adrian Negreanu This fixes src/egl/drivers/dri2/platform_android.c:664: error: undefined reference to 'loader_set_logger' src/egl/drivers/dri2/platform_android.c:678: error: undefined reference to 'loader_get_driver_for_fd' Signed-off-by: Adrian Negreanu --- src/egl/drivers/dri2/An

[Mesa-dev] [PATCH 2/8] android: adapt to the megadriver mechanism

2014-06-06 Thread Adrian Negreanu
From: Adrian Negreanu Fixes linker error: ld: .../libmesa_dri_common_intermediates/libmesa_dri_common.a(dri_util.o): in function globalDriverAPI:dri_util.c(.data.rel+0x0): error: undefined reference to 'driDriverAPI' As an example, you can see that mesa_dri_drivers also uses common/l

[Mesa-dev] [PATCH 7/8] android, mesa_gen_matypes: pull in timespec POSIX definition

2014-06-06 Thread Adrian Negreanu
From: Adrian Negreanu This fixes: include/c11/threads_posix.h: In function 'cnd_timedwait': include/c11/threads_posix.h:140:21: error: storage size of 'abs_time' isn't known Signed-off-by: Adrian Negreanu --- src/mesa/Android.libmesa_glsl_utils.mk | 1 + src/mesa/Android.mesa_gen_matypes.

[Mesa-dev] [PATCH 6/8] android, egl: typo dri2_fallback_pixmap_surface -> dri2_fallback_create_pixmap_surface

2014-06-06 Thread Adrian Negreanu
From: Adrian Negreanu I used commit bc8b07a6 as reference, and only the droid_display_vtbl had this issue. This fixes: src/egl/drivers/dri2/platform_android.c:641:29: error: 'dri2_fallback_pixmap_surface' undeclared here (not in a function) Signed-off-by: Adrian Negreanu --- src/egl/driver

[Mesa-dev] [Bug 79662] [DRI3 all Bisected] Many webglc cases fail

2014-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79662 Chris Wilson changed: What|Removed |Added Assignee|ch...@chris-wilson.co.uk|mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 2/2] i965: Drop the remaining default predication whacking.

2014-06-06 Thread Jordan Justen
On Fri, Jun 6, 2014 at 12:23 AM, Kenneth Graunke wrote: > With my earlier cleaning in place, nothing relies on the instruction What about referencing the commits if they are in a single series? Series Reviewed-by: Jordan Justen > emitters for IF/WHILE/JMPI disabling predication. Drop it in fa

[Mesa-dev] [PATCH 2/2] i965: Drop the remaining default predication whacking.

2014-06-06 Thread Kenneth Graunke
With my earlier cleaning in place, nothing relies on the instruction emitters for IF/WHILE/JMPI disabling predication. Drop it in favor of making callers do the right thing explicitly. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_clip_tri.c | 1 + src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH 1/2] i965/sf: Use brw_set_default_predicate_control().

2014-06-06 Thread Kenneth Graunke
This is a bit tidier than poking at p->current directly. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_sf_emit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Piglit tested on Crestline and Haswell - no regressions. I diffed assembly for two Piglit runs on Crestli