[Mesa-dev] [PATCH] i965: Fix a few base addresses on Broadwell.

2014-04-26 Thread Kenneth Graunke
We intended to set these 64-bit addresses to 0, and set the enable bit. But, I accidentally placed the DWord with the high bits first, when it should have been second. This generally worked out, by luck - presumably General State Base Address is initially zero, and ends up remaining that way in ou

[Mesa-dev] [PATCH 0/6] Initial no-op implementation of `precise`

2014-04-26 Thread Chris Forbes
This series adds compiler support for the `precise` qualifier from ARB_gpu_shader5. The precise flag is propagated as far as the GLSL IR, but nothing further is done beyond that point. This was suggested by Ian as an acceptable initial approach until we have tesselation shaders (where possible geo

[Mesa-dev] [PATCH 4/6] glsl: Disallow `precise` redeclarations of vars from outer scopes

2014-04-26 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/glsl/ast_to_hir.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index e7e862b..e71a287 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -3108,6 +3108,15 @@ ast_declarator_li

[Mesa-dev] [PATCH 1/6] glsl: remove outdated comment, move sample to correct block

2014-04-26 Thread Chris Forbes
--- src/glsl/glsl_parser.yy | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index 2d0e7be..2f666a2 100644 --- a/src/glsl/glsl_parser.yy +++ b/src/glsl/glsl_parser.yy @@ -128,7 +128,7 @@ static bool match_layout_qualifier(c

[Mesa-dev] [PATCH 3/6] glsl: Add support for `precise` redeclarations

2014-04-26 Thread Chris Forbes
This works like glsl-1.20+'s invariant redeclarations, but with fewer restrictions, since `precise` is allowed on pretty much anything. Signed-off-by: Chris Forbes --- src/glsl/ast.h | 10 -- src/glsl/ast_to_hir.cpp | 27 +++ src/glsl/glsl

[Mesa-dev] [PATCH 2/6] glsl: add support for `precise` in type_qualifier

2014-04-26 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/glsl/ast.h | 1 + src/glsl/ast_to_hir.cpp | 12 src/glsl/glsl_lexer.ll | 3 +++ src/glsl/glsl_parser.yy | 39 +++ src/glsl/ir.h | 1 + 5 files changed, 48 insertions(+), 8 deletions(-) dif

[Mesa-dev] [PATCH 5/6] glsl: Allow `precise` as a parameter qualifier

2014-04-26 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/glsl/glsl_parser.yy | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index ff34ba5..838789f 100644 --- a/src/glsl/glsl_parser.yy +++ b/src/glsl/glsl_parser.yy @@ -931,14 +931,22

[Mesa-dev] [PATCH 6/6] docs: Update `precise` qualifier status in GL3.txt

2014-04-26 Thread Chris Forbes
Signed-off-by: Chris Forbes --- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index b8557bf..d9d8c03 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -101,7 +101,7 @@ GL 4.0: GL_ARB_draw_buffers_blendDONE

Re: [Mesa-dev] [PATCH] docs: add ARB_sample_shading to GL3, update relnotes

2014-04-26 Thread Ian Romanick
On 04/26/2014 09:43 AM, Ilia Mirkin wrote: > relnotes weren't updated this whole time, so I went through all the GL3 > changes and picked out the nouveau ones since 10.1. > > Signed-off-by: Ilia Mirkin Reviewed-by: Ian Romanick > --- > > I've never updated relnotes before -- not sure if this

Re: [Mesa-dev] [PATCH] egl: Add GetSyncValuesCHROMIUM extension.

2014-04-26 Thread Ian Romanick
On 04/22/2014 12:19 PM, Sarah Sharp wrote: > On Sat, Apr 19, 2014 at 12:34:37PM -0700, Stéphane Marchesin wrote: >> On Fri, Apr 18, 2014 at 3:37 PM, Sarah Sharp >> wrote: >> >>> Chromium defined a new GL extension (that isn't registered with Khronos). >>> >> >> This here is the problem IMO. I'll se

Re: [Mesa-dev] [PATCH] egl: Add GetSyncValuesCHROMIUM extension.

2014-04-26 Thread Ian Romanick
On 04/19/2014 10:23 AM, Chad Versace wrote: > On Fri, Apr 18, 2014 at 05:30:02PM -0700, Ian Romanick wrote: >> On 04/18/2014 05:07 PM, Jamey Sharp wrote: >>> On Fri, Apr 18, 2014 at 4:49 PM, Ian Romanick wrote: On 04/18/2014 03:37 PM, Sarah Sharp wrote: > >> If you use the unchecked >>> vari

Re: [Mesa-dev] [PATCH 11/19] glsl: Track explicitly set location independent from the actual location

2014-04-26 Thread Ian Romanick
On 04/20/2014 04:53 PM, Eric Anholt wrote: > Ian Romanick writes: > >> On 04/11/2014 04:35 PM, Eric Anholt wrote: >>> Ian Romanick writes: >>> From: Ian Romanick Almost all of the time the location set by layout(location=...) is the location that will be used for the variabl

[Mesa-dev] [PATCH v4 0/1] clover: Add clEnqueue{Marker, Barrier}WithWaitList

2014-04-26 Thread EdB
Changes according to Francisco Jerez's latest comments I omit CL1.2 headers changes, there are too big and can be grab on Khronos website EdB (1): clover: Add clEnqueue{Marker,Barrier}WithWaitList src/gallium/state_trackers/clover/api/dispatch.cpp | 4 +- src/gallium/state_trackers/clover/ap

[Mesa-dev] [PATCH 1/1] clover: Add clEnqueue{Marker, Barrier}WithWaitList

2014-04-26 Thread EdB
--- src/gallium/state_trackers/clover/api/dispatch.cpp | 4 +- src/gallium/state_trackers/clover/api/event.cpp| 46 +++--- 2 files changed, 43 insertions(+), 7 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/dispatch.cpp b/src/gallium/state_trackers/clover/ap

[Mesa-dev] [PATCH] docs: add ARB_sample_shading to GL3, update relnotes

2014-04-26 Thread Ilia Mirkin
relnotes weren't updated this whole time, so I went through all the GL3 changes and picked out the nouveau ones since 10.1. Signed-off-by: Ilia Mirkin --- I've never updated relnotes before -- not sure if this is the right way to do it, or if there's some sort of filter on which extensions make

[Mesa-dev] [PATCH v2 2/6] mesa/st: implement new bit manipulation opcodes

2014-04-26 Thread Ilia Mirkin
Also pipe through [IU]MUL_HI, MAD, and lower ldexp. This provides coverage of all new ARB_gpu_shader5 functions except uaddCarry, usubBorrow and interpolateAt*. Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 73 +++--- 1 file changed, 56 inser

[Mesa-dev] [PATCH v2 3/6] gallium/util: add helpers for bitfield manipulation

2014-04-26 Thread Ilia Mirkin
Add bitwise reversing and signed MSB helpers for software implementation of the new TGSI opcodes. Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/util/u_math.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/gallium/auxiliary/util/u_math.h b/src/gal

[Mesa-dev] [PATCH v2 5/6] nvc0/ir: add support for new bitfield manipulation opcodes

2014-04-26 Thread Ilia Mirkin
This adds support for: IBFE, UBFE, BFI, LSB, IMSB, UMSB, BREV, POPC Which are all required for ARB_gs5 support. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 2 + .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 35 .../drivers/nouveau/co

[Mesa-dev] [PATCH v2 4/6] tgsi: add tgsi_exec support for new bit manipulation opcodes

2014-04-26 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 172 + 1 file changed, 172 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec.c index 55da60a..9be1d13 100644 --- a/src/gallium/auxiliary

[Mesa-dev] [PATCH v2 0/6] gallium: add new opcodes needed for ARB_gs5

2014-04-26 Thread Ilia Mirkin
v1 -> v2: - improved docs and comments - nvc0 support for new opcodes - split out math helpers into separate commit I'm pretty sure I addressed all the feedback in the earlier series. Let me know if I missed anything. Ilia Mirkin (6): gallium: add new opcodes for ARB_gs5 bit manipulation sup

[Mesa-dev] [PATCH v2 1/6] gallium: add new opcodes for ARB_gs5 bit manipulation support

2014-04-26 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_info.c | 8 src/gallium/docs/source/tgsi.rst | 75 ++ src/gallium/include/pipe/p_shader_tokens.h | 11 - 3 files changed, 93 insertions(+), 1 deletion(-) diff --git a/src/gallium/au

[Mesa-dev] [PATCH v2 6/6] nvc0/ir: add support for MUL_HI tgsi opcodes

2014-04-26 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp index 0

[Mesa-dev] [Bug 77502] libOpenVG contains no vg Symbols

2014-04-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77502 --- Comment #16 from dagg --- *** Bug 77917 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev

[Mesa-dev] [Bug 77917] VG/openvg.h defines non existent functions

2014-04-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77917 dagg changed: What|Removed |Added Resolution|FIXED |DUPLICATE --- Comment #2 from dagg --- you are c

[Mesa-dev] [Bug 77917] VG/openvg.h defines non existent functions

2014-04-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77917 dagg changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] R600/SI: allow 4 more input SGPRs to a shader

2014-04-26 Thread Christian König
Ah! Didn't took streamout into account, than that makes indeed sense. On the other hand every SGPR load at shader start means quite a penalty, so we should try to avoid loading so many of them. We sooner or later probably need a more dynamical allocation for them. Christian. Am 26.04.2014 1

[Mesa-dev] [PATCH v3 3/5] gallium: Implement DRIimageExtension.duplicateImage

2014-04-26 Thread John Kåre Alsaker
--- src/gallium/include/state_tracker/st_api.h | 1 + src/gallium/state_trackers/dri/common/dri_screen.c | 1 + src/gallium/state_trackers/dri/common/dri_screen.h | 1 + src/gallium/state_trackers/dri/drm/dri2.c | 42 -- src/mesa/state_tracker/st_manager.c

[Mesa-dev] [PATCH v3 4/5] i965: Implement DRIimageExtension.duplicateImage

2014-04-26 Thread John Kåre Alsaker
--- src/mesa/drivers/dri/i965/intel_screen.c | 46 ++-- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 8cb1260..bfa93c6 100644 --- a/src/mesa/drivers/dri/i965/inte

[Mesa-dev] [PATCH v3 2/5] dri: Add another duplicateImage to DRIimageExtension

2014-04-26 Thread John Kåre Alsaker
duplicateImage will allow you to create a linear or sRGB view into a DRIimage you have access to. This is useful because compositors may want a specific view which doesn't correspond to the one used by applications. --- include/GL/internal/dri_interface.h | 20 +++- 1 file changed,

[Mesa-dev] [PATCH v3 5/5] egl: Add MESA_image_sRGB extension.

2014-04-26 Thread John Kåre Alsaker
This gives applications access to use DRIimage.duplicateImage to create sRGB and linear views from EGL images. --- include/EGL/eglmesaext.h| 7 ++ src/egl/drivers/dri2/egl_dri2.c | 201 +++- src/egl/drivers/dri2/egl_dri2.h | 11 +- src

[Mesa-dev] [PATCH v3 1/5] Add MESA_image_sRGB spec.

2014-04-26 Thread John Kåre Alsaker
--- docs/specs/MESA_image_sRGB.spec | 155 1 file changed, 155 insertions(+) create mode 100644 docs/specs/MESA_image_sRGB.spec diff --git a/docs/specs/MESA_image_sRGB.spec b/docs/specs/MESA_image_sRGB.spec new file mode 100644 index 000..7b29e7e ---

Re: [Mesa-dev] [PATCH] R600/SI: allow 4 more input SGPRs to a shader

2014-04-26 Thread Marek Olšák
No, the user SGPRs are within the limit, but there are other SGPRs loaded by the hardware. For example, streamout needs up to 6 SGPRs but none of them are "user". This patch is actually correct, because it allows 16 user SGPRs and 6 non-user SGPRs. Marek On Sat, Apr 26, 2014 at 4:06 PM, Christian

Re: [Mesa-dev] [PATCH] R600/SI: allow 4 more input SGPRs to a shader

2014-04-26 Thread Christian König
That won't work correctly, the hardware can only load a maximum of 16 user SGPRs at shader initialization. If we need more we need to pass the data through an extra buffer or something like that. Christian. Am 26.04.2014 15:37, schrieb Marek Olšák: Sorry, the subject should say "5 more input

Re: [Mesa-dev] [PATCH 2/2] clover: Add clEnqueue{Marker, Barrier}WithWaitList

2014-04-26 Thread EdB
On Saturday, April 26, 2014 12:05:25 PM Francisco Jerez wrote: > EdB writes: > > Looks OK to me, some nitpicks related to the coding style below. > > > --- > > > > src/gallium/state_trackers/clover/api/dispatch.cpp | 4 +- > > src/gallium/state_trackers/clover/api/event.cpp| 48 > > +

Re: [Mesa-dev] [PATCH] R600/SI: allow 4 more input SGPRs to a shader

2014-04-26 Thread Marek Olšák
Sorry, the subject should say "5 more input SGPRs". Marek On Sat, Apr 26, 2014 at 3:36 PM, Marek Olšák wrote: > From: Marek Olšák > > Mesa needs one more SGPR, let's add 5 then, because it's a recurring issue. > > This is silly. Why cannot Mesa specify the calling convention? > Now I have to br

[Mesa-dev] [PATCH] R600/SI: allow 4 more input SGPRs to a shader

2014-04-26 Thread Marek Olšák
From: Marek Olšák Mesa needs one more SGPR, let's add 5 then, because it's a recurring issue. This is silly. Why cannot Mesa specify the calling convention? Now I have to break transform feedback to support ARB_draw_indirect until this patch is released. Or I'll have to wait until the release an

Re: [Mesa-dev] [PATCHES 0/9] Draw Indirect and Cube Map Arrays for RadeonSI

2014-04-26 Thread Marek Olšák
BTW, there is also softpipe and llvmpipe support for ARB_draw_indirect, but please note that Mesa advertises the extension for the core profile only. Marek On Sat, Apr 26, 2014 at 3:27 PM, Marek Olšák wrote: > Hi everyone, > > This series adds support for ARB_texture_cube_map_array and ARB_draw_

[Mesa-dev] [PATCH 6/9] st/mesa: add support for indirect drawing

2014-04-26 Thread Marek Olšák
From: Christoph Bumiller --- src/mesa/state_tracker/st_cb_bufferobjects.c | 3 +++ src/mesa/state_tracker/st_draw.c | 11 ++- src/mesa/state_tracker/st_extensions.c | 3 ++- 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_b

[Mesa-dev] [PATCH 7/9] radeonsi: use an SGPR instead of VGT_INDX_OFFSET

2014-04-26 Thread Marek Olšák
From: Marek Olšák The draw indirect packets cannot set VGT_INDX_OFFSET, they can only set user data SGPRs. This is the only way to support start/index_bias with indirect drawing. This breaks transform feedback with 4 buffers, because the calling convention doesn't allow so many input SGPRs. ---

[Mesa-dev] [PATCH 8/9] radeonsi: don't add info->start to the index buffer offset

2014-04-26 Thread Marek Olšák
From: Marek Olšák info->start will be invalid once info->indirect isn't NULL, so it shouldn't be added to ib.offset. --- src/gallium/drivers/radeonsi/si_state_draw.c | 36 +++- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si

[Mesa-dev] [PATCH 2/9] radeonsi: implement ARB_texture_cube_map_array

2014-04-26 Thread Marek Olšák
From: Marek Olšák No LLVM changes needed. --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- src/gallium/drivers/radeonsi/si_shader.c | 47 +--- src/gallium/drivers/radeonsi/si_state.c | 4 ++- 3 files changed, 47 insertions(+), 6 deletions(-) diff --git a/src/g

[Mesa-dev] [PATCH 9/9] radeonsi: implement ARB_draw_indirect

2014-04-26 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_commands.c | 53 src/gallium/drivers/radeonsi/si_pipe.c | 1 + src/gallium/drivers/radeonsi/si_state.h | 7 +++ src/gallium/drivers/radeonsi/si_state_draw.c | 73 ++-- src/gallium/dr

[Mesa-dev] [PATCH 3/9] gallium: add PIPE_BIND_COMMAND_ARGS_BUFFER

2014-04-26 Thread Marek Olšák
From: Christoph Bumiller Intended for use with GL_ARB_draw_indirect's DRAW_INDIRECT_BUFFER target or for D3D11_RESOURCE_MISC_DRAWINDIRECT_ARGS. --- src/gallium/docs/source/screen.rst | 3 +++ src/gallium/include/pipe/p_defines.h | 1 + 2 files changed, 4 insertions(+) diff --git a/src/gallium

[Mesa-dev] [PATCH 1/9] configure.ac: radeonsi requires EGL_DRM and GBM

2014-04-26 Thread Marek Olšák
From: Marek Olšák --- configure.ac | 14 ++ 1 file changed, 14 insertions(+) diff --git a/configure.ac b/configure.ac index c71fa26..b2ea8ca 100644 --- a/configure.ac +++ b/configure.ac @@ -1738,6 +1738,19 @@ gallium_require_drm_loader() { fi } +require_egl_drm() { +case

[Mesa-dev] [PATCH 5/9] gallium/u_vbuf: get draw info from an indirect buffer if there's any

2014-04-26 Thread Marek Olšák
From: Marek Olšák This is required for fallbacks to work with ARB_draw_indirect. --- src/gallium/auxiliary/util/u_vbuf.c | 116 ++-- 1 file changed, 72 insertions(+), 44 deletions(-) diff --git a/src/gallium/auxiliary/util/u_vbuf.c b/src/gallium/auxiliary/util/u

[Mesa-dev] [PATCHES 0/9] Draw Indirect and Cube Map Arrays for RadeonSI

2014-04-26 Thread Marek Olšák
Hi everyone, This series adds support for ARB_texture_cube_map_array and ARB_draw_indirect to the radeonsi driver. There is also Gallium infrastructure support for ARB_draw_indirect. As usual, the first patch is unrelated to the rest of the series. ;) Please review. Christoph Bumiller (3):

[Mesa-dev] [PATCH 4/9] gallium: add facilities for indirect drawing

2014-04-26 Thread Marek Olšák
From: Christoph Bumiller v2: Added comments to util_draw_indirect, clarified and fixed map size. Removed unlikely(). --- src/gallium/auxiliary/util/u_draw.c | 43 src/gallium/auxiliary/util/u_draw.h | 8 + src/gallium/auxiliary/util/u_dump_

Re: [Mesa-dev] [PATCH v3 0/2] clover: Add clEnqueue{Marker, Barrier}WithWaitList

2014-04-26 Thread EdB
On Saturday, April 26, 2014 01:43:23 PM Francisco Jerez wrote: > EdB writes: > > changed according to Francisco Jerez's comments > > > > (v2 won't compil, sorry about that) > > > > EdB (2): > > clover: Update opencl headers to version 1.2 > > It doesn't look like PATCH 1/2 is going to make it

Re: [Mesa-dev] [PATCH v3 0/2] clover: Add clEnqueue{Marker, Barrier}WithWaitList

2014-04-26 Thread Francisco Jerez
EdB writes: > changed according to Francisco Jerez's comments > > (v2 won't compil, sorry about that) > > EdB (2): > clover: Update opencl headers to version 1.2 It doesn't look like PATCH 1/2 is going to make it through, I've checked them in myself to a branch here [1]. Thanks. [1] http://c

Re: [Mesa-dev] [PATCH 2/2] clover: Add clEnqueue{Marker, Barrier}WithWaitList

2014-04-26 Thread Francisco Jerez
EdB writes: Looks OK to me, some nitpicks related to the coding style below. > --- > src/gallium/state_trackers/clover/api/dispatch.cpp | 4 +- > src/gallium/state_trackers/clover/api/event.cpp| 48 > ++ > 2 files changed, 42 insertions(+), 10 deletions(-) > > diff --g