[Mesa-dev] [Bug 75355] brw_fs.h:135:37: error: invalid conversion from 'unsigned int' to 'brw_reg_type' [-fpermissive]

2014-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75355 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 75355] brw_fs.h:135:37: error: invalid conversion from 'unsigned int' to 'brw_reg_type' [-fpermissive]

2014-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75355 Vinson Lee changed: What|Removed |Added CC||kenn...@whitecape.org, |

[Mesa-dev] [Bug 75355] New: brw_fs.h:135:37: error: invalid conversion from 'unsigned int' to 'brw_reg_type' [-fpermissive]

2014-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75355 Priority: medium Bug ID: 75355 Keywords: regression Assignee: mesa-dev@lists.freedesktop.org Summary: brw_fs.h:135:37: error: invalid conversion from 'unsigned int' to 'brw_r

Re: [Mesa-dev] [PATCH] meta: Use a #define for the vector type to avoid %svec4 everywhere.

2014-02-21 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 22/25] gallium/nouveau: handle query_renderer caps

2014-02-21 Thread Ilia Mirkin
On Fri, Feb 21, 2014 at 10:04 PM, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > > IMHO we could easily rip out all the common stuff wrt PIPE_CAPs > handling and move it to nouveau, rather than duplicating it in > each driver. > > I believe that can be done as a follow up patch. Easy

Re: [Mesa-dev] [PATCH 07/25] dri/nouveau: add GLX_MESA_query_renderer support

2014-02-21 Thread Ilia Mirkin
On Fri, Feb 21, 2014 at 10:03 PM, Emil Velikov wrote: > v2: nv04-2x cards support upto opengl 1.3. nv1x only has 1.2, iirc. i'll re-check. why does it matter though? version is computed based on extension availability... > v3: Include correct headers. > > Signed-off-by: Emil Velikov > --- > sr

[Mesa-dev] [PATCH] i965: Validate (and resolve) all the bound textures.

2014-02-21 Thread Chris Forbes
BRW_MAX_TEX_UNIT is the static limit on the number of textures we support per-stage, not in total. Core's `Unit` array is sized by MAX_COMBINED_TEXTURE_IMAGE_UNITS, which is significantly larger, and across the various shader stages, up to ctx->Const.MaxCombinedTextureImageUnits elements of it may

Re: [Mesa-dev] [PATCH V2 04/22] i965: refactor format munging for separate stencil

2014-02-21 Thread Chris Forbes
They do -- you can create views of any format that is legal for TexStorage*. Each of the formats not listed in the table in the ARB_texture_view spec has its own equivalence class, so no casting is possible. This is still useful if you want to restrict levels or layers, or vary texture parameters.

Re: [Mesa-dev] [PATCH] i965: Don't try to use the hardware blitter for multisampled miptrees.

2014-02-21 Thread Paul Berry
On 21 February 2014 19:15, Kenneth Graunke wrote: > The blitter is completely ignorant of MSAA buffer layouts, so any > attempt to use BLT paths with MSAA buffers is likely to break > spectacularly. > > In most cases, BLORP handles MSAA blits, so we never hit this bug. > Until recently, it also w

[Mesa-dev] [Bug 75347] xlib.c:35:42: fatal error: state_tracker/xlib_sw_winsys.h: No such file or directory

2014-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75347 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 75347] New: xlib.c:35:42: fatal error: state_tracker/xlib_sw_winsys.h: No such file or directory

2014-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75347 Priority: medium Bug ID: 75347 Keywords: regression CC: emil.l.veli...@gmail.com, ja...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: xlib.c:35:42: fatal error:

Re: [Mesa-dev] [PATCH 19/25] gallium/i915: handle query_renderer caps

2014-02-21 Thread Stéphane Marchesin
On Fri, Feb 21, 2014 at 7:04 PM, Emil Velikov wrote: > Implementation is a verbatim copy from the classic driver. > > This introduces a driver dependency on libdrm-intel, as the winsys does not > cache the aperture size of the device. > Usually if you have to add calls into libdrm, you add them t

[Mesa-dev] [PATCH] i965: Don't try to use the hardware blitter for multisampled miptrees.

2014-02-21 Thread Kenneth Graunke
The blitter is completely ignorant of MSAA buffer layouts, so any attempt to use BLT paths with MSAA buffers is likely to break spectacularly. In most cases, BLORP handles MSAA blits, so we never hit this bug. Until recently, it also wasn't worth fixing, since Meta couldn't handle MSAA either, so

[Mesa-dev] [PATCH] meta: Use a #define for the vector type to avoid %svec4 everywhere.

2014-02-21 Thread Kenneth Graunke
By adding "#define gvec4 %svec4" to the top of our fragment shader, we can write generic code without needing to specialize it to vec4, ivec4, or uvec4 via asprintf. This also makes the INT and UNSIGNED_INT merge function code identical, so I combined those two cases. It's not a big savings, but

Re: [Mesa-dev] [PATCH V2 04/22] i965: refactor format munging for separate stencil

2014-02-21 Thread Eric Anholt
Chris Forbes writes: > We will need this for munging the view's format. But texture views don't allow internalformats involving depth or stencil (or ETC in the next commit), right? pgpO1mRYJ0lhW.pgp Description: PGP signature ___ mesa-dev mailing lis

[Mesa-dev] [PATCH 24/25] gallium/softpipe/llvmpipe: handle query_renderer caps

2014-02-21 Thread Emil Velikov
Both drivers report 0x as vendor/device id, and the maximum amount of system memory as video memory. We might want to reconsider the latter. Cc: Brian Paul Signed-off-by: Emil Velikov --- src/gallium/drivers/llvmpipe/lp_screen.c | 25 + src/gallium/drivers/softpi

[Mesa-dev] [PATCH 12/25] dri/i9*5: correctly calculate the amount of system memory

2014-02-21 Thread Emil Velikov
The variable name states megabytes, while we calculate the amount in kilobytes. Correct this by dividing with the correct amount. Cc: "10.0 10.1" Cc: Ian Romanick Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i915/intel_screen.c | 2 +- src/mesa/drivers/dri/i965/intel_screen.c | 2 +- 2

[Mesa-dev] [PATCH 02/25] glx/dri2: use mapping table for dri2_convert_glx_query_renderer_attribs()

2014-02-21 Thread Emil Velikov
Signed-off-by: Emil Velikov --- Might seem like a bikeshed but it makes the code a lot more readable IMHO. Could be squashed in the following commit depending on how people feel with the idea of using a mapping table. -Emil src/glx/dri2_query_renderer.c | 54 ++

[Mesa-dev] [PATCH 11/25] dri/swrast: add GLX_MESA_query_renderer support

2014-02-21 Thread Emil Velikov
Cc: Brian Paul Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/swrast/swrast.c | 82 +++- 1 file changed, 80 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/swrast/swrast.c b/src/mesa/drivers/dri/swrast/swrast.c index 071192c..8830ce4 100644

[Mesa-dev] [PATCH 16/25] st/dri: cap the reported max_gl*version against the ones supported by core mesa

2014-02-21 Thread Emil Velikov
XXX: Squash with previous patch XXX: Add similar treatment to classic mesa Signed-off-by: Emil Velikov --- src/gallium/state_trackers/dri/common/dri_screen.c | 16 src/mesa/main/config.h | 9 + 2 files changed, 17 insertions(+), 8 deletions(-

[Mesa-dev] [PATCH 25/25] st/dri/drm: Add __DRI2rendererQueryExtension support

2014-02-21 Thread Emil Velikov
From: Dave Airlie The final step to get GLX_MESA_query_renderer working with hardware gallium drivers. v2: (Emil) - Split out the nouveau changes - Move code to common/dri_query_renderer, so that we can reuse it for both dri2 and sw based drivers. Signed-off-by: Emil Velikov --- .../state_t

[Mesa-dev] [PATCH 06/25] dri/nouveau: create nouveau_{vendor, get_renderer}_string helpers

2014-02-21 Thread Emil Velikov
The functions will be reused by GLX_MESA_query_renderer. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/nouveau/nouveau_driver.c | 24 src/mesa/drivers/dri/nouveau/nouveau_driver.h | 5 + 2 files changed, 21 insertions(+), 8 deletions(-) diff --git a/src/mesa

[Mesa-dev] [PATCH 14/25] gallium/drivers: add default values for PIPE_CAP_MAX_GL_*_VERSION

2014-02-21 Thread Emil Velikov
Based on the current return value of glGetString(GL_VERSION) Signed-off-by: Emil Velikov --- src/gallium/drivers/freedreno/freedreno_screen.c | 11 ++- src/gallium/drivers/i915/i915_screen.c | 9 + src/gallium/drivers/ilo/ilo_screen.c | 9 + src/ga

[Mesa-dev] [PATCH 21/25] gallium/r300/r600/radeonsi: handle query_renderer caps

2014-02-21 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/drivers/r300/r300_screen.c | 12 src/gallium/drivers/r600/r600_pipe.c | 12 src/gallium/drivers/radeonsi/si_pipe.c | 12 3 files changed, 36 insertions(+) diff --git a/src/gallium/drivers/r300/r300_screen.c b/s

[Mesa-dev] [PATCH 09/25] dri/radeon: create radeon{Vendor, GetRenderer}String helpers

2014-02-21 Thread Emil Velikov
To be used by the upcomming GLX_MESA_query_renderer implementation. Signed-off-by: Emil Velikov --- .../drivers/dri/radeon/radeon_common_context.c | 50 +- .../drivers/dri/radeon/radeon_common_context.h | 4 ++ src/mesa/drivers/dri/radeon/radeon_screen.h| 2

[Mesa-dev] [PATCH 01/25] glx/drisw: Move private structure declarations to a header file

2014-02-21 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/glx/drisw_glx.c | 41 + src/glx/drisw_priv.h | 64 2 files changed, 65 insertions(+), 40 deletions(-) create mode 100644 src/glx/drisw_priv.h diff --git a/src/glx/drisw_glx.

[Mesa-dev] [PATCH 04/25] glx/drisw: add support for DRI2rendererQueryExtension

2014-02-21 Thread Emil Velikov
The extension is used by GLX_MESA_query_renderer, which can be provided for by hardware and software drivers. Signed-off-by: Emil Velikov --- src/glx/drisw_glx.c | 58 +++- src/glx/drisw_priv.h | 1 + 2 files changed, 54 insertions(+), 5 deletion

[Mesa-dev] [PATCH 08/25] dri/radeon: don't print TCL status on glGetString(GL_RENDERER)

2014-02-21 Thread Emil Velikov
Printing the TCL involves that context is available at the time of query. The GLX_MESA_query_renderer states that glGetString(GL_RENDERER) and glXQueryRendererStringMESA(GLX_RENDERER_DEVICE_ID_MESA) will have the same format, thus removing the context dependenicy will help us achieve that. Signed-

[Mesa-dev] [PATCH 22/25] gallium/nouveau: handle query_renderer caps

2014-02-21 Thread Emil Velikov
Signed-off-by: Emil Velikov --- IMHO we could easily rip out all the common stuff wrt PIPE_CAPs handling and move it to nouveau, rather than duplicating it in each driver. I believe that can be done as a follow up patch. -Emil src/gallium/drivers/nouveau/nv30/nv30_screen.c | 25 ++

[Mesa-dev] [PATCH 05/25] glx/dri3: add support for DRI2rendererQueryExtension

2014-02-21 Thread Emil Velikov
The extension is used to implement GLX_MESA_query_renderer. Currently untested, due to lack of dri3 enabled drivers. Signed-off-by: Emil Velikov --- src/glx/dri3_glx.c | 55 - src/glx/dri3_priv.h | 1 + 2 files changed, 51 insertions(+), 5 de

[Mesa-dev] [PATCH 03/25] glx: move dri2_convert_glx_query_renderer_attribs into a common place

2014-02-21 Thread Emil Velikov
This way we can reuse it for drisw and dri3. Squash a couple minor whitespace fixes while we're here. Signed-off-by: Emil Velikov --- src/glx/dri2_query_renderer.c | 34 +- src/glx/dri_common.c | 40 src/glx/dri_co

[Mesa-dev] [PATCH 07/25] dri/nouveau: add GLX_MESA_query_renderer support

2014-02-21 Thread Emil Velikov
v2: nv04-2x cards support upto opengl 1.3. v3: Include correct headers. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/nouveau/nouveau_screen.c | 83 ++- 1 file changed, 82 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/nouveau/nouveau_screen.c b/s

[Mesa-dev] [PATCH 13/25] gallium: Introduce max_gl*version pipe-caps

2014-02-21 Thread Emil Velikov
According to the GLX_MESA_query_renderer spec each driver should be able to report the version of each GL api they support before creating a context. Currently both classic mesa and gallium evaluate the version post context creation and while the classic drivers set the max_gl*version according to

[Mesa-dev] [PATCH 10/25] dri/radeon: add GLX_MESA_query_renderer support

2014-02-21 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/radeon/radeon_screen.c | 77 + 1 file changed, 77 insertions(+) diff --git a/src/mesa/drivers/dri/radeon/radeon_screen.c b/src/mesa/drivers/dri/radeon/radeon_screen.c index 57e866e..8ad9d12 100644 --- a/src/mesa/dr

[Mesa-dev] [PATCH 19/25] gallium/i915: handle query_renderer caps

2014-02-21 Thread Emil Velikov
Implementation is a verbatim copy from the classic driver. This introduces a driver dependency on libdrm-intel, as the winsys does not cache the aperture size of the device. Cc: Stephane Marchesin Signed-off-by: Emil Velikov --- NOTE: This _will_ fail on i915/sw due to the lack of fd on the pa

[Mesa-dev] [PATCH 23/25] gallium/svga: handle query_rendered caps

2014-02-21 Thread Emil Velikov
All the values returned are currently hardcoded. One could use some heuristics to determine the amount of video memory if a callback to the host is not available. Do we what to advertise the driver as hardware accelerated ? Cc: Brian Paul Cc: José Fonseca Signed-off-by: Emil Velikov --- Hello

[Mesa-dev] [PATCH 17/25] gallium: add GLX_MESA_query_renderer caps

2014-02-21 Thread Emil Velikov
Namely vendor/device id, accelerated and UMA, which will be used to describe the underlying renderer. Signed-off-by: Emil Velikov --- src/gallium/docs/source/screen.rst | 8 src/gallium/include/pipe/p_defines.h | 5 + 2 files changed, 13 insertions(+) diff --git a/src/gallium/doc

[Mesa-dev] [PATCH 18/25] gallium/freedreno: handle query_renderer caps

2014-02-21 Thread Emil Velikov
Provide the real vendor and hardcode the device id as 0x as the devices currently using freedreno are non-pci. The device features UMA. Cc: Rob Clark Signed-off-by: Emil Velikov --- Hi Rob, Can you please take a look at the memory side of this patch. I'm pretty sure I've got it wrong.

[Mesa-dev] [PATCH 15/25] st/dri: set max_gl*version based on the value supported by the driver

2014-02-21 Thread Emil Velikov
Avoid setting generic gallium max_gl*version values, but use driver provided ones instead. Signed-off-by: Emil Velikov --- Marek stated that drivers may abuse this and report version that are not supported/handled by core mesa. The following patch adds a way of capping the driver values, thus re

[Mesa-dev] [PATCH 20/25] gallium/ilo: handle query_renderer caps

2014-02-21 Thread Emil Velikov
Implementation is a verbatim copy from the classic driver. This introduces a driver dependency on libdrm-intel, as the winsys does not cache the aperture size of the device. This implemetation duplicates the fd from intel_winsys to intel_winsys_info and ultimatelly to ilo_dev_info, due to the des

[Mesa-dev] [PATCH 00/25] GLX_MESA_query_renderer to all ;-)

2014-02-21 Thread Emil Velikov
As the name suggests this series adds support for the above extension to every driver that mesa provides, standing as equal to the classic i915 and i965. Summary of the series PATCH 01-05: Factor out common glx loader code, and then add support for __DRI2rendererQueryExtension to drisw and dri3.

Re: [Mesa-dev] [PATCH] meta: Eliminate samplers[] array in favor of using vec4_prefix.

2014-02-21 Thread Eric Anholt
Kenneth Graunke writes: > We don't need an array mapping the shader index to "sampler2DMS", > "isampler2DMS", and so on. We can simply do "%ssampler2DMS" and pass in > vec4_prefix, which is "", "i", or "u". > > This eliminates the use of C99 array initializers and should fix the > MSVC build. >

[Mesa-dev] Mesa 10.1 release candidate 2

2014-02-21 Thread Ian Romanick
Mesa 10.1 release candidate 2 is now available for testing. The current plan of record is to have the 10.2 release one week from today on Friday, February 28th. The tag in the GIT repository for Mesa 10.1-rc2 is 'mesa-10.1-rc2'. Mesa 10.1 release candidate 1 is available for download at ftp:/

[Mesa-dev] [PATCH] meta: Eliminate samplers[] array in favor of using vec4_prefix.

2014-02-21 Thread Kenneth Graunke
We don't need an array mapping the shader index to "sampler2DMS", "isampler2DMS", and so on. We can simply do "%ssampler2DMS" and pass in vec4_prefix, which is "", "i", or "u". This eliminates the use of C99 array initializers and should fix the MSVC build. Cc: Vinson Lee Cc: Eric Anholt Bugzi

Re: [Mesa-dev] [PATCH 00/10] Klocwork related pathes

2014-02-21 Thread Ian Romanick
On 02/21/2014 05:47 AM, Juha-Pekka Heikkilä wrote: On Mon, Feb 17, 2014 at 11:03 PM, Ian Romanick wrote: On 02/17/2014 08:21 AM, Juha-Pekka Heikkila wrote: Resend of the earlier glx patches with the issue pointed out by Petri fixed. Patch number five is a bit special. hash_table_insert() and

Re: [Mesa-dev] [PATCH 1/8] meta: Set some object labels on our meta shaders.

2014-02-21 Thread Ian Romanick
I really like using the object label in logging. Series is Reviewed-by: Ian Romanick On 02/21/2014 11:32 AM, Eric Anholt wrote: --- src/mesa/drivers/common/meta.c | 6 ++ src/mesa/drivers/common/meta_blit.c | 8 2 files changed, 14 insertions(+) diff --git a/src/mesa/dr

Re: [Mesa-dev] [PATCH 0/3] dri3: Add GLX_EXT_buffer_age support

2014-02-21 Thread Adel Gadllah
Am 21.02.2014 23:47, schrieb Ian Romanick: On 02/20/2014 02:15 AM, Adel Gadllah wrote: Hi, OK here are updated patches based on the review comments. The first one simply updates the glxext.h header even though that turned out to not be required for this but it doesn't hurt doing it anyway. The

[Mesa-dev] [PATCH] glx: Add test for GLX_EXT_buffer_age

2014-02-21 Thread Adel Gadllah
Add a test case for the GLX_EXT_buffer_age extension. --- tests/all.py| 1 + tests/glx/CMakeLists.gl.txt | 1 + tests/glx/glx-buffer-age.c | 115 3 files changed, 117 insertions(+) create mode 100644 tests/glx/glx-buffer-age.c dif

Re: [Mesa-dev] [PATCH V2 00/22] ARB_texture_view support for i965

2014-02-21 Thread Ian Romanick
On 02/21/2014 12:48 PM, Chris Forbes wrote: This series adds support for texture views on i965. I think it's fairly complete, but have probably still missed some things. It would be great if someone at Intel can run the relevant parts of oglconform against this. Big changes from V1: * Level/lay

[Mesa-dev] [Bug 75344] meta_blit.c(97) : error C2059: syntax error : '['

2014-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75344 Kenneth Graunke changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev@l

Re: [Mesa-dev] [PATCH V2 08/22] i965: Add _Format to intel_texobj.

2014-02-21 Thread Ian Romanick
On 02/21/2014 12:48 PM, Chris Forbes wrote: This is the actual mesa_format to use. In non-view cases this is always the same as the mt's format. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/intel_tex.c | 8 src/mesa/drivers/dri/i965/intel_tex_obj.h | 5 +++

[Mesa-dev] [Bug 75344] New: meta_blit.c(97) : error C2059: syntax error : '['

2014-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75344 Priority: medium Bug ID: 75344 Keywords: regression CC: e...@anholt.net, kenn...@whitecape.org Assignee: mesa-dev@lists.freedesktop.org Summary: meta_blit.c(97) : error C2059: sy

Re: [Mesa-dev] [PATCH 1/3] st/mesa: use MIN2 macro in favour of custom _min function

2014-02-21 Thread Emil Velikov
On 22/02/14 00:34, Ian Romanick wrote: > On 02/21/2014 03:15 PM, Marek Olšák wrote: >> The main reason _min exists is that it evaluates each parameter once, >> while MIN2 evaluates each parameter twice, so in this case, MIN2 calls >> the get_param function twice, which may not be desirable. The sam

Re: [Mesa-dev] [PATCH 1/3] st/mesa: use MIN2 macro in favour of custom _min function

2014-02-21 Thread Ian Romanick
On 02/21/2014 03:15 PM, Marek Olšák wrote: The main reason _min exists is that it evaluates each parameter once, while MIN2 evaluates each parameter twice, so in this case, MIN2 calls the get_param function twice, which may not be desirable. The same for the other macros. There is a GCC extensi

Re: [Mesa-dev] [PATCH V2 06/22] i965: Skip texture validation for immutable-format textures.

2014-02-21 Thread Eric Anholt
Chris Forbes writes: > We're about to start sharing miptrees in texture views, and I'd rather > not teach this validation code about nonzero MinLevel or MinLayer when > views are guaranteed complete [and all levels resident in the base > miptree]. > > The only thing we have to do is set up our _M

Re: [Mesa-dev] [PATCH] i965: Delete the fabulous target_to_target() function.

2014-02-21 Thread Eric Anholt
Kenneth Graunke writes: > gl_texture_object's Target field is never a cube face enumeration, so > target_to_target is just the identity function. Aptly named, at least. > > I verified this by putting an assert(!"ZOMG, CUBES!") in the cube face > case, and running Piglit. Nothing ever hit it. B

Re: [Mesa-dev] [PATCH 02/19] i965: Mark brw_reg_type and register_file enums as PACKED.

2014-02-21 Thread Matt Turner
On Fri, Feb 21, 2014 at 3:48 PM, Kenneth Graunke wrote: > On 02/21/2014 02:43 PM, Matt Turner wrote: >> On Fri, Feb 21, 2014 at 2:25 PM, Kenneth Graunke >> wrote: >>> Generally, I only use PACKED when something -relies- on a particular >>> memory layout. Is it really worth second guessing the c

Re: [Mesa-dev] [PATCH 02/19] i965: Mark brw_reg_type and register_file enums as PACKED.

2014-02-21 Thread Kenneth Graunke
On 02/21/2014 02:43 PM, Matt Turner wrote: > On Fri, Feb 21, 2014 at 2:25 PM, Kenneth Graunke > wrote: >> Generally, I only use PACKED when something -relies- on a particular >> memory layout. Is it really worth second guessing the compiler here? >> Presumably it had a reason for choosing a larg

Re: [Mesa-dev] [PATCH] i965/fs: Drop the emit(fs_inst) overload.

2014-02-21 Thread Matt Turner
Reviewed-by: Matt Turner I'll replace 13/19 with *this* patch. :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965/fs: Drop the emit(fs_inst) overload.

2014-02-21 Thread Kenneth Graunke
Using this emit function implicitly creates three copies, which is pointlessly inefficient. 1. Code creates the original instruction. 2. Calling emit(fs_inst) copies it into the function. 3. It then allocates a new fs_inst and copies it into that. The second could be eliminated by changing the si

Re: [Mesa-dev] [PATCH] i965/fs: Make fs_reg's type an enum for better debugging.

2014-02-21 Thread Matt Turner
Wait, this isn't the patch you meant to send! :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] st/mesa: use MIN2 macro in favour of custom _min function

2014-02-21 Thread Marek Olšák
The main reason _min exists is that it evaluates each parameter once, while MIN2 evaluates each parameter twice, so in this case, MIN2 calls the get_param function twice, which may not be desirable. The same for the other macros. Marek On Fri, Feb 21, 2014 at 11:59 PM, Emil Velikov wrote: > Sign

Re: [Mesa-dev] [PATCH 10/19] i965/fs: Drop redundant zero assignments in fs_inst::init().

2014-02-21 Thread Matt Turner
On Fri, Feb 21, 2014 at 1:44 PM, Kenneth Graunke wrote: > On 02/20/2014 01:41 PM, Matt Turner wrote: >> Unfortunately the compiler isn't able to recognize that assigning >> reg_undef is just zeroing the fs_reg, which was already done by the >> above memset. >> --- >> src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH 3/3] st/mesa: use CLAMP macro in favour of custom _clamp function

2014-02-21 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/mesa/state_tracker/st_extensions.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 879b954..c36e221 100644 --- a/src/mesa/state_tracker/s

[Mesa-dev] [PATCH 2/3] st/mesa: use MAX2 macro in favour of custom _maxf function

2014-02-21 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/mesa/state_tracker/st_extensions.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index a909b71..879b954 100644 --- a/src/mesa/state_tracker/s

[Mesa-dev] [PATCH 1/3] st/mesa: use MIN2 macro in favour of custom _min function

2014-02-21 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/mesa/state_tracker/st_extensions.c | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index e43e7b4..a909b71 100644 --- a/src/mesa/st

[Mesa-dev] [Bug 75098] OpenGL ES2 with fbdev - link error

2014-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75098 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 75126] configure: error: classic DRI driver 'yes' does not exist

2014-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75126 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] i965/fs: Make fs_reg's type an enum for better debugging.

2014-02-21 Thread Matt Turner
With your R-b, I'll replace 13/19 with this. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/3] dri3: Add GLX_EXT_buffer_age support

2014-02-21 Thread Ian Romanick
On 02/20/2014 02:15 AM, Adel Gadllah wrote: Hi, OK here are updated patches based on the review comments. The first one simply updates the glxext.h header even though that turned out to not be required for this but it doesn't hurt doing it anyway. The second one refactors glx_pbuffer based on t

Re: [Mesa-dev] [PATCH] configure: use default dri drivers whenever opengl and dri are enabled

2014-02-21 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 02/19] i965: Mark brw_reg_type and register_file enums as PACKED.

2014-02-21 Thread Matt Turner
On Fri, Feb 21, 2014 at 2:25 PM, Kenneth Graunke wrote: > Generally, I only use PACKED when something -relies- on a particular > memory layout. Is it really worth second guessing the compiler here? > Presumably it had a reason for choosing a larger size other than sheer > stupidity... We're not

[Mesa-dev] [PATCH] configure: use default dri drivers whenever opengl and dri are enabled

2014-02-21 Thread Emil Velikov
Commit ee55500c22a(configure: cleanup classic dri drivers handling) cleaned up the logic handling autodetection of dri drivers, but missed the case when one can explicitly disable dri, and still request opengl. Fixes build issues for the following ./autogen.sh --disable-dri --with-gallium-drivers=

Re: [Mesa-dev] [PATCH] i965: Fix S8 and X8 reversal in brw_depthbuffer_format refactor.

2014-02-21 Thread Ian Romanick
On 02/21/2014 12:23 AM, Kenneth Graunke wrote: In commit 09d9a8913e8c28fc4c1c60d7da85a2f093786894, I accidentally botched the X8 and S8 cases. (I wrote this patch before realizing that X8 and S8 had been swapped in the big MESA_FORMAT rename, and apparently didn't rebase it properly after fixing

Re: [Mesa-dev] [PATCH] i965: Delete the fabulous target_to_target() function.

2014-02-21 Thread Jordan Justen
Reviewed-by: Jordan Justen On Fri, Feb 21, 2014 at 2:00 PM, Kenneth Graunke wrote: > gl_texture_object's Target field is never a cube face enumeration, so > target_to_target is just the identity function. Aptly named, at least. > > I verified this by putting an assert(!"ZOMG, CUBES!") in the cu

Re: [Mesa-dev] [PATCH 02/19] i965: Mark brw_reg_type and register_file enums as PACKED.

2014-02-21 Thread Kenneth Graunke
On 02/20/2014 01:41 PM, Matt Turner wrote: > Will now take a byte, rather than four. > --- > src/mesa/drivers/dri/i965/brw_reg.h| 3 ++- > src/mesa/drivers/dri/i965/brw_shader.h | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_reg.h >

[Mesa-dev] [PATCH] i965/fs: Make fs_reg's type an enum for better debugging.

2014-02-21 Thread Kenneth Graunke
From: Matt Turner Since the enum is marked as packed, it'll still take only one byte. --- src/mesa/drivers/dri/i965/brw_fs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) This is a proposed replacement for Matt's patch 13/19, and also obsoletes part of patch 14/19. diff --git a/s

Re: [Mesa-dev] [PATCH 05/19] i965/fs: Reorder fs_reg for better packing.

2014-02-21 Thread Kenneth Graunke
On 02/20/2014 01:41 PM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_fs.h | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletions(-) Depending whether you decide to keep packing enums or not, you may want to reorder this. Patches 1, 3-7, 8 with the bool:

Re: [Mesa-dev] EXTERNAL: Re: Radeon r600_ring_test/evergreen_resume errors

2014-02-21 Thread Tom Stellard
On Fri, Feb 21, 2014 at 09:48:50PM +, Dorrington, Albert wrote: > > -Original Message- > > From: Tom Stellard [mailto:t...@stellard.net] > > Subject: Re: [Mesa-dev] EXTERNAL: Re: Radeon > > r600_ring_test/evergreen_resume errors > > > > On Fri, Feb 21, 2014 at 05:53:02PM +, Dorring

Re: [Mesa-dev] [PATCH 08/19] i965/fs: Use a bitfield for fs_inst's bool fields.

2014-02-21 Thread Matt Turner
On Fri, Feb 21, 2014 at 1:50 PM, Philipp Klaus Krause wrote: > Using uint8_t as a bitfield type is non-portable. AFAIK, only int > singed int, unsigned int and bool are mandatory bit-field types in the > C standard. Why not just use > > bool saturate:1; > > and so on? That sounds good. Will do. _

[Mesa-dev] [PATCH] i965: Delete the fabulous target_to_target() function.

2014-02-21 Thread Kenneth Graunke
gl_texture_object's Target field is never a cube face enumeration, so target_to_target is just the identity function. Aptly named, at least. I verified this by putting an assert(!"ZOMG, CUBES!") in the cube face case, and running Piglit. Nothing ever hit it. Beyond that, I inspected the code in

Re: [Mesa-dev] [PATCH 08/19] i965/fs: Use a bitfield for fs_inst's bool fields.

2014-02-21 Thread Philipp Klaus Krause
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 20.02.2014 22:41, schrieb Matt Turner: > --- src/mesa/drivers/dri/i965/brw_fs.h | 14 +++--- 1 file > changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.h > b/src/mesa/drivers/dri/i965/brw_fs.h index b

Re: [Mesa-dev] EXTERNAL: Re: Radeon r600_ring_test/evergreen_resume errors

2014-02-21 Thread Dorrington, Albert
> -Original Message- > From: Tom Stellard [mailto:t...@stellard.net] > Subject: Re: [Mesa-dev] EXTERNAL: Re: Radeon > r600_ring_test/evergreen_resume errors > > On Fri, Feb 21, 2014 at 05:53:02PM +, Dorrington, Albert wrote: > > > -Original Message- > > > From: Alex Deucher [ma

Re: [Mesa-dev] [PATCH 08/19] i965/fs: Use a bitfield for fs_inst's bool fields.

2014-02-21 Thread Matt Turner
On Fri, Feb 21, 2014 at 1:40 PM, Kenneth Graunke wrote: > Please just do: > >unsigned eot:1; For #include struct a { unsigned a:1; unsigned b:1; unsigned c:1; }; struct b { uint8_t a:1; uint8_t b:1; uint8_t c:1; }; void f(struct a a, struct b b) {} pahole says: struct a { unsigned int

Re: [Mesa-dev] [PATCH 10/19] i965/fs: Drop redundant zero assignments in fs_inst::init().

2014-02-21 Thread Kenneth Graunke
On 02/20/2014 01:41 PM, Matt Turner wrote: > Unfortunately the compiler isn't able to recognize that assigning > reg_undef is just zeroing the fs_reg, which was already done by the > above memset. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 6 -- > 1 file changed, 6 deletions(-) > > diff -

Re: [Mesa-dev] [PATCH 08/19] i965/fs: Use a bitfield for fs_inst's bool fields.

2014-02-21 Thread Kenneth Graunke
On 02/20/2014 01:41 PM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_fs.h | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.h > b/src/mesa/drivers/dri/i965/brw_fs.h > index b4e69ba..a1f33e7 100644 > --- a/src/mesa

[Mesa-dev] [Bug 75226] Dark rendering of War for the Overworld

2014-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75226 --- Comment #11 from Fredrik Höglund --- Created attachment 94535 --> https://bugs.freedesktop.org/attachment.cgi?id=94535&action=edit Add support for sRGB render targets in r600g r600g will need this patch however. -- You are receiving this

[Mesa-dev] [Bug 75226] Dark rendering of War for the Overworld

2014-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75226 --- Comment #10 from Fredrik Höglund --- Comment on attachment 94530 --> https://bugs.freedesktop.org/attachment.cgi?id=94530 assume sRGB by default Review of attachment 94530: -

Re: [Mesa-dev] [PATCH] i965: Fix S8 and X8 reversal in brw_depthbuffer_format refactor.

2014-02-21 Thread Jordan Justen
Reviewed-by: Jordan Justen On Fri, Feb 21, 2014 at 12:23 AM, Kenneth Graunke wrote: > In commit 09d9a8913e8c28fc4c1c60d7da85a2f093786894, I accidentally > botched the X8 and S8 cases. (I wrote this patch before realizing that > X8 and S8 had been swapped in the big MESA_FORMAT rename, and appar

Re: [Mesa-dev] [PATCH 1/8] meta: Set some object labels on our meta shaders.

2014-02-21 Thread Kenneth Graunke
On 02/21/2014 11:32 AM, Eric Anholt wrote: > --- > src/mesa/drivers/common/meta.c | 6 ++ > src/mesa/drivers/common/meta_blit.c | 8 > 2 files changed, 14 insertions(+) This series is: Reviewed-by: Kenneth Graunke There are a couple more instances of printf in the main compile

Re: [Mesa-dev] [PATCH 8/8] i965: Move the remaining driver debug over to stderr.

2014-02-21 Thread Matt Turner
On Fri, Feb 21, 2014 at 11:32 AM, Eric Anholt wrote: > --- > src/mesa/drivers/dri/i965/brw_context.c | 4 ++-- > src/mesa/drivers/dri/i965/brw_curbe.c | 26 > +++ > src/mesa/drivers/dri/i965/brw_draw_upload.c | 8 +++ > src/mesa/drivers/dri/i

[Mesa-dev] [PATCH 7/8] i965: Move compiler debugging output to stderr.

2014-02-21 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 4 +- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp| 4 +- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 6 +- src/mesa/drivers/dri/i965/brw_cfg.cpp | 16 +-- src/mesa/drivers/dri/i965/brw_clip.c

[Mesa-dev] [PATCH 3/8] i965: Use the object label when available for INTEL_DEBUG=vs, gs, fs output.

2014-02-21 Thread Eric Anholt
Note that this requires updated run.py in shader_db. --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp| 3 ++- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 4 +++- src/mesa/drivers/dri/i965/gen8_fs_generator.cpp | 3 ++- src/mesa/drivers/dri/i965/gen8_vec4_generator.cpp | 4 +++- 4 f

[Mesa-dev] [PATCH 8/8] i965: Move the remaining driver debug over to stderr.

2014-02-21 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/brw_context.c | 4 ++-- src/mesa/drivers/dri/i965/brw_curbe.c | 26 +++ src/mesa/drivers/dri/i965/brw_draw_upload.c | 8 +++ src/mesa/drivers/dri/i965/brw_eu_compact.c| 8 +++ src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 4/8] intel: Remove some dead code I noticed in intel_screen.c.

2014-02-21 Thread Eric Anholt
It was present in the initial i915tex import. --- src/mesa/drivers/dri/i915/intel_screen.c | 4 src/mesa/drivers/dri/i965/intel_screen.c | 4 2 files changed, 8 deletions(-) diff --git a/src/mesa/drivers/dri/i915/intel_screen.c b/src/mesa/drivers/dri/i915/intel_screen.c index 296df16..

[Mesa-dev] [PATCH 6/8] glsl: Add a file argument to the IR printer.

2014-02-21 Thread Eric Anholt
While we want to be able to print to stdout for glsl_compiler, for debugging drivers we want to be able to dump to stderr because that's where other driver debug (like LIBGL_DEBUG) tends to go, and because some apps actually close stdout to shut up their own messages (such as the X Server, or NWN).

[Mesa-dev] [PATCH 1/8] meta: Set some object labels on our meta shaders.

2014-02-21 Thread Eric Anholt
--- src/mesa/drivers/common/meta.c | 6 ++ src/mesa/drivers/common/meta_blit.c | 8 2 files changed, 14 insertions(+) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 2dec2c3..d415e61 100644 --- a/src/mesa/drivers/common/meta.c +++ b/src/mesa/dr

[Mesa-dev] [PATCH 5/8] i965: Refactor debug dumping of GLSL IR.

2014-02-21 Thread Eric Anholt
This was only going to get worse when tesselation shows up, and was causing too much extra duplication in my stderr changes coming up. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 13 ++--- src/mesa/drivers/dri/i965/brw_program.c | 18 ++ src/mesa/drive

[Mesa-dev] [PATCH 2/8] i965: Use the object label when available for shader_time output.

2014-02-21 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/brw_program.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_program.c b/src/mesa/drivers/dri/i965/brw_program.c index 58a7e81..2145d7b 100644 --- a/src/mesa/drivers/dri/i965/brw_program.c +++ b/src/mes

[Mesa-dev] [Bug 75336] New: Don't provide inline definitions of functions available in MSVS 2013's standard library

2014-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75336 Priority: medium Bug ID: 75336 Assignee: mesa-dev@lists.freedesktop.org Summary: Don't provide inline definitions of functions available in MSVS 2013's standard library Sever

  1   2   >