Kenneth Graunke <kenn...@whitecape.org> writes:

> We don't need an array mapping the shader index to "sampler2DMS",
> "isampler2DMS", and so on.  We can simply do "%ssampler2DMS" and pass in
> vec4_prefix, which is "", "i", or "u".
>
> This eliminates the use of C99 array initializers and should fix the
> MSVC build.
>
> Cc: Vinson Lee <v...@freedesktop.org>
> Cc: Eric Anholt <e...@anholt.net>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75344
> Signed-off-by: Kenneth Graunke <kenn...@whitecape.org>

I was just thinking about this array today, and the thing we'll need to
add at some point is sampler2DMSArray to handle MSAA blits from that (do
we even have tests for blits with texture_multisample arrays?), but we
could do that with just a one-off check on the target and appending
"Array".

Reviewed-by: Eric Anholt <e...@anholt.net>

Attachment: pgpnRpxZ8Fe5w.pgp
Description: PGP signature

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to