On 02/20/2014 02:15 AM, Adel Gadllah wrote:
Hi,
OK here are updated patches based on the review comments. The first one simply
updates the glxext.h header even though that turned out to not be required
for this but it doesn't hurt doing it anyway.
The second one refactors glx_pbuffer based on the review comments
from Ian (assuming I got what he meant).
Finally the third patch adds glx_ext_buffer_age support to dri3.
Series is
Reviewed-by: Ian Romanick <ian.d.roman...@intel.com>
Patches 1 & 2 should be able to land right away.
For the implementation of GLX_EXT_buffer_age... do we have any test
cases? Does Robert perhaps have something around that we could put in
piglit? We don't generaly land new features without any tests. I would
have mentioned this before, but I didn't notice that there weren't any
tests.
It shouldn't be too hard to make some rendering tests that clear the
window to a different color each frame. After calling SwapBuffers,
query the age and check that the color matches the expected value.
Adel Gadllah (3):
glx: Update glxext.h to revision 25407
glx_pbuffer: Refactor GetDrawableAttribute
dri3: Add GLX_EXT_buffer_age support
include/GL/glxext.h | 32 +++++++++++++++++++++++++++++---
src/glx/dri2_glx.c | 1 +
src/glx/dri3_glx.c | 18 ++++++++++++++++++
src/glx/dri3_priv.h | 2 ++
src/glx/glx_pbuffer.c | 19 ++++++++++++++-----
src/glx/glxclient.h | 1 +
src/glx/glxextensions.c | 1 +
src/glx/glxextensions.h | 1 +
8 files changed, 67 insertions(+), 8 deletions(-)
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
