[Mesa-dev] [PATCH] Break instead of loop all paths once dri driver is gotten successfully

Originally it will continue all paths. The next search will overwrite previous result even if the previous is successful. In some case it will cause error. Signed-off-by: Quanxian Wang Reviewed-By: Gong, Zhigang --- src/egl/drivers/dri2/egl_dri2.c | 3 +++ src/gbm/backends/dri/gbm_dri.c | 5 ++

[Mesa-dev] [PATCH] radeonsi: Only scan pixel shaders for TGSI_PROPERTY_FS_COLOR0_WRITES_ALL_CBUFS

From: Michel Dänzer It's not relevant for other shader types. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_state.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_stat

Re: [Mesa-dev] [PATCH] mesa: Fix build to properly check for supported compiler flags

On Tue, Dec 17, 2013 at 7:15 AM, Lauri Kasanen wrote: > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=72708 Make this "Bugzilla: ..." > It seems to me that the Intel code that uses this SSE4.1 function > is still buggy, as it has no runtime check - would it not crash > if built on a SSE4-c

Re: [Mesa-dev] [PATCH V2 10/10] i965/Gen7: Allow CMS layout for multisample textures

On Sat, Nov 30, 2013 at 3:30 PM, Chris Forbes wrote: > Now that all the pieces are in place, this should provide > a nice performance boost for apps using multisample textures. > > Signed-off-by: Chris Forbes > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 18 +- > 1 file

Re: [Mesa-dev] [PATCH] llvmpipe: fix possible constant buffer overflow

Am 19.12.2013 01:16, schrieb Zack Rusin: > It's possible to bind a smaller buffer as a constant buffer, than > what the shader actually uses/requires. This could cause nasty > crashes. This patch adds the architecture to pass the maximum > allowable constant buffer index to the jit so let it make >

[Mesa-dev] [PATCH] llvmpipe: fix possible constant buffer overflow

It's possible to bind a smaller buffer as a constant buffer, than what the shader actually uses/requires. This could cause nasty crashes. This patch adds the architecture to pass the maximum allowable constant buffer index to the jit so let it make sure that the constant buffer indices are always w

Re: [Mesa-dev] [PATCH 1/2] mesa: Add gl_formats to cover all GLUser provided format/type combinations

On 12/18/2013 12:23 PM, Mark Mueller wrote: On Wed, Dec 18, 2013 at 7:36 AM, Brian Paul mailto:bri...@vmware.com>> wrote: On 12/17/2013 07:50 PM, Mark Mueller wrote: On Tue, Dec 17, 2013 at 12:19 PM, Mark Mueller mailto:markkmuel...@gmail.com>

[Mesa-dev] [PATCH 1/1] R600: Allow ftrunc

v2: Add ftrunc->TRUNC pattern instead of replacing int_AMDGPU_trunc v3: move ftrunc pattern next to TRUNC definition, it's available since R600 Signed-off-by: Jan Vesely --- lib/Target/R600/AMDGPUISelLowering.cpp | 2 ++ lib/Target/R600/R600Instructions.td| 3 +++ 2 files changed, 5 insertio

Re: [Mesa-dev] [PATCH] i965: Fix 3DSTATE_PUSH_CONSTANT_ALLOC_PS packet creation.

On 18 December 2013 13:03, Kenneth Graunke wrote: > When adding geometry shader support, we accidentally reversed the size > and offset parameters. > > Signed-off-by: Kenneth Graunke > Cc: Paul Berry > Cc: mesa-sta...@lists.freedesktop.org > --- > src/mesa/drivers/dri/i965/gen7_urb.c | 2 +- >

[Mesa-dev] [PATCH] i965: Fix 3DSTATE_PUSH_CONSTANT_ALLOC_PS packet creation.

When adding geometry shader support, we accidentally reversed the size and offset parameters. Signed-off-by: Kenneth Graunke Cc: Paul Berry Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/gen7_urb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa

Re: [Mesa-dev] [PATCH v2 1/1] R600: Allow ftrunc

On Wed, Dec 18, 2013 at 03:41:09PM -0500, Jan Vesely wrote: > v2: Add ftrunc->TRUNC pattern instead of replacing int_AMDGPU_trunc > > Signed-off-by: Jan Vesely > --- > lib/Target/R600/AMDGPUISelLowering.cpp | 2 ++ > lib/Target/R600/R600Instructions.td| 2 ++ > 2 files changed, 4 insertions(

[Mesa-dev] [PATCH v2 1/1] R600: Allow ftrunc

v2: Add ftrunc->TRUNC pattern instead of replacing int_AMDGPU_trunc Signed-off-by: Jan Vesely --- lib/Target/R600/AMDGPUISelLowering.cpp | 2 ++ lib/Target/R600/R600Instructions.td| 2 ++ 2 files changed, 4 insertions(+) diff --git a/lib/Target/R600/AMDGPUISelLowering.cpp b/lib/Target/R600

Re: [Mesa-dev] [PATCH 1/2] mesa: Add gl_formats to cover all GLUser provided format/type combinations

Towards this end, I'd like to start by adding UNORM, or UINT, where applicable, to all of the MESA_FORMATs listed in the "basic hardware formats" section. Are there any objections? Mark On Wed, Dec 18, 2013 at 2:16 AM, Marek Olšák wrote: > See Gallium PIPE_FORMATs. They all have consistent nam

Re: [Mesa-dev] [PATCH 1/2] mesa: Add gl_formats to cover all GLUser provided format/type combinations

On Wed, Dec 18, 2013 at 7:36 AM, Brian Paul wrote: > On 12/17/2013 07:50 PM, Mark Mueller wrote: > >> >> >> >> On Tue, Dec 17, 2013 at 12:19 PM, Mark Mueller > > wrote: >> >> >> >> >> On Sat, Nov 23, 2013 at 4:10 PM, Marek Olšák > >

Re: [Mesa-dev] [PATCH] i965: fold offset into coord for textureOffset(gsampler2DRect)

On 12/18/2013 01:04 AM, Chris Forbes wrote: > The hardware is broken with nonzero texel offsets and unnormalized > coordinates; instead of doing correct offsetting, we get garbage. > > This just extends the existing workaround for ir_txf and > ir_tg4+gsampler2DRect to also consider ir_tex+gsampler

Re: [Mesa-dev] [PATCH] winsys/radeon: remove superfluous distinction of cases

On Wed, Dec 18, 2013 at 1:11 PM, Niels Ole Salscheider wrote: > Signed-off-by: Niels Ole Salscheider Reviewed-by: Alex Deucher > --- > src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 20 +--- > 1 file changed, 5 insertions(+), 15 deletions(-) > > diff --git a/src/gallium/winsy

[Mesa-dev] [PATCH] winsys/radeon: remove superfluous distinction of cases

Signed-off-by: Niels Ole Salscheider --- src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_cs.c b/src/gallium/winsys/radeon/drm/radeon_drm_cs.c index acb12b2..d8ad297 10

Re: [Mesa-dev] [PATCH 1/3] glx: add missing null check in dri2_bind_tex_image

On 12/18/2013 06:58 AM, Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila --- src/glx/dri2_glx.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index 309c1e7..ae807ee 100644 --- a/src/glx/dri2_glx.c +++ b/src/glx

Re: [Mesa-dev] [PATCH 2/3] glx: Fix two identical null check errors in driSet/GetInterval

On 12/18/2013 06:58 AM, Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila --- src/glx/dri_glx.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/src/glx/dri_glx.c b/src/glx/dri_glx.c index 0b89e3e..91cccac 100644 --- a/src/glx/dri_glx.c +

Re: [Mesa-dev] [PATCH 1/2] mesa: Add gl_formats to cover all GLUser provided format/type combinations

On 12/17/2013 07:50 PM, Mark Mueller wrote: On Tue, Dec 17, 2013 at 12:19 PM, Mark Mueller mailto:markkmuel...@gmail.com>> wrote: On Sat, Nov 23, 2013 at 4:10 PM, Marek Olšák mailto:mar...@gmail.com>> wrote: On Sat, Nov 23, 2013 at 10:23 PM, Mark Mueller mailto:markkmu

[Mesa-dev] [Bug 72281] [bisected] Eufloria HD crash on start

https://bugs.freedesktop.org/show_bug.cgi?id=72281 --- Comment #2 from Pavel Ondračka --- (In reply to comment #1) > (In reply to comment #0) > ... > #8 0x4e9899ee in cgGLLoadProgram () from > /usr/local/games/EufloriaHD/lib/libCgGL.so > #9 0x081e85f8 in Coal::Shader::LoadBinary(char const*) ()

Re: [Mesa-dev] [PATCH v2 1/1] clover: Add parameter checks to clCreateBuffer.

Jan Vesely writes: > v2: use fewer if statements and functional tricks instead of single-use > method, > suggested by Francisco Jerez > squash two small patches into one > > Signed-off-by: Jan Vesely > --- > Hi, > > this is v2 of the first two patches incorporating Francisco's comments,

Re: [Mesa-dev] [PATCH v3 19/23] glsl: Add image built-in function generator.

On 18 December 2013 07:14, Francisco Jerez wrote: > Paul Berry writes: > >[...] > > This is definitely an improvement, thanks. I still think there are some > > minor tweaks that would reduce duplication of information, though: > > > > - Precompute the value (glsl ? IMAGE_FUNCTION_EMIT_STUB : 0)

Re: [Mesa-dev] [PATCH] st_glsl_to_tgsi: add support for prim id fragment shader input

On 12/18/2013 01:01 AM, Dave Airlie wrote: From: Dave Airlie For GLSL 1.50 we can get frag shaders with primitive id as an input, add support to the translator for this. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_program.c | 5 + 1 file changed, 5 insertions(+) diff --gi

Re: [Mesa-dev] [PATCH v3 19/23] glsl: Add image built-in function generator.

Paul Berry writes: >[...] > This is definitely an improvement, thanks. I still think there are some > minor tweaks that would reduce duplication of information, though: > > - Precompute the value (glsl ? IMAGE_FUNCTION_EMIT_STUB : 0) rather than > duplicating it at each add_image_function call si

Re: [Mesa-dev] [PATCH] radeonsi: Since we're not using HiS, use more buffer space for HiZ.

You're right. I think stencil compression is always enabled just like depth compression. HTILE is only for HiZ and HiS. I'm not sure if we need HTILE for fast clear. Marek On Wed, Dec 18, 2013 at 3:29 PM, Andreas Hartmetz wrote: > If I don't send a new patch this week you can assume that I've dr

[Mesa-dev] [Bug 72281] [bisected] Eufloria HD crash on start

https://bugs.freedesktop.org/show_bug.cgi?id=72281 Eero Tamminen changed: What|Removed |Added CC||eero.t.tammi...@intel.com --- Comment #1

Re: [Mesa-dev] [PATCH] radeonsi: Since we're not using HiS, use more buffer space for HiZ.

If I don't send a new patch this week you can assume that I've dropped the ball. I am planning to do something soon though... Your finding from the documentation needs a little context, I was confused at first. When I made this patch, it looked like stencil compression was off via DB_RENDER_OVERRID

[Mesa-dev] [PATCH 3/3] Mesa: add asserts in load_texunit_bumpmap

In load_texunit_bumpmap tc_array is asserted so lets assert rot_mat_0 and rot_mat_1 also which are coming from same path. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/ff_fragment_shader.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/

[Mesa-dev] [PATCH 2/3] glx: Fix two identical null check errors in driSet/GetInterval

Signed-off-by: Juha-Pekka Heikkila --- src/glx/dri_glx.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/src/glx/dri_glx.c b/src/glx/dri_glx.c index 0b89e3e..91cccac 100644 --- a/src/glx/dri_glx.c +++ b/src/glx/dri_glx.c @@ -747,13 +747,16 @@ static int

[Mesa-dev] [PATCH 1/3] glx: add missing null check in dri2_bind_tex_image

Signed-off-by: Juha-Pekka Heikkila --- src/glx/dri2_glx.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index 309c1e7..ae807ee 100644 --- a/src/glx/dri2_glx.c +++ b/src/glx/dri2_glx.c @@ -991,10 +991,14 @@ dri2_bind_tex_image(D

Re: [Mesa-dev] [PATCH 1/9] st/mesa: always prefer pipe->clear over clear_with_quad

I still would like to have this for color and combined depth-stencil clears. If either attachment can use pipe->clear, let's use it. I think the only disagreement is over what should happen if there is a partial stencil write mask. The following cases are still okay, aren't they? 1) pipe->clear(C

Re: [Mesa-dev] [PATCH] radeonsi: set CB_DISABLE if the color mask is 0

Not really. r600g does the same thing. I pretty much ported this from r600g, but I also checked the docs to be sure. Marek On Wed, Dec 18, 2013 at 1:25 PM, Sylvain BERTRAND wrote: > On Tue, Dec 17, 2013 at 06:33:12PM +0100, Marek Olšák wrote: >> I don't think so. > > I bet it's being readied for

Re: [Mesa-dev] [PATCH] radeonsi: set CB_DISABLE if the color mask is 0

On Tue, Dec 17, 2013 at 06:33:12PM +0100, Marek Olšák wrote: > I don't think so. I bet it's being readied for mantle publication :) -- Sylvain ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-d

Re: [Mesa-dev] [PATCH 1/9] st/mesa: always prefer pipe->clear over clear_with_quad

If this is such a corner case, that's not worth the diligence, then I think it might be better to drop the change. If it was just software rendering (llvmpipe) I wouldn't mind, as bottlenecks are elsewhere anyway. My concern is more of principle here: I'm assuming there is other hardware we ca

Re: [Mesa-dev] [PATCH 1/2] mesa: Add gl_formats to cover all GLUser provided format/type combinations

See Gallium PIPE_FORMATs. They all have consistent names. The translation between Mesa and Gallium formats takes place in st_format.c. I'm inclined to rename all Mesa formats to match the Gallium names. Marek On Wed, Dec 18, 2013 at 3:50 AM, Mark Mueller wrote: > > > > On Tue, Dec 17, 2013 at 12

Re: [Mesa-dev] [PATCH] i965: fold offset into coord for textureOffset(gsampler2DRect)

Erk, ignore the stray 'to 0' in the commit message; editor fail :) On Wed, Dec 18, 2013 at 10:04 PM, Chris Forbes wrote: > The hardware is broken with nonzero texel offsets and unnormalized > coordinates; instead of doing correct offsetting, we get garbage. > > This just extends the existing work

[Mesa-dev] [PATCH] i965: fold offset into coord for textureOffset(gsampler2DRect)

The hardware is broken with nonzero texel offsets and unnormalized coordinates; instead of doing correct offsetting, we get garbage. This just extends the existing workaround for ir_txf and ir_tg4+gsampler2DRect to also consider ir_tex+gsampler2DRect. Fixes broken rendering in 'tesseract' when 'm

[Mesa-dev] [PATCH] st_glsl_to_tgsi: add support for prim id fragment shader input

From: Dave Airlie For GLSL 1.50 we can get frag shaders with primitive id as an input, add support to the translator for this. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_program.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/state_tracker/st_program.c b/src/