On 12/03/2013 09:48 PM, Brian Paul wrote:
On 11/26/2013 10:59 PM, Siavash Eliasi wrote:
---
src/mesa/main/imports.c| 7 +--
src/mesa/math/m_matrix.c | 13 +
src/mesa/program/prog_parameter.c | 3 +--
src/mesa/state_tracker/st_cb_texture.c
Revision 2:
- Avoiding compile error on MSVC and possible warnings on other compilers.
- Added comment regards passing NULL pointer being safe.
---
src/mesa/main/imports.c| 14 +-
src/mesa/math/m_matrix.c | 13 +
src/mesa/program/prog_parameter
On Fre, 2013-11-29 at 18:55 +0100, Marek Olšák wrote:
> This series moves the r600_buffer.c files from both drivers to the shared
> directory gallium/drivers/radeon, and implements what's missing for radeonsi
> to make sharing the code possible.
>
> This improves Valve's Team Fortress 2 performa
From: Michel Dänzer
Signed-off-by: Michel Dänzer
---
src/gallium/drivers/radeonsi/radeonsi_pipe.c | 1 -
src/gallium/drivers/radeonsi/radeonsi_shader.c | 5 +
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/radeonsi_pipe.c
b/src/gallium/drivers/
On Fre, 2013-11-29 at 19:08 +0100, Marek Olšák wrote:
> From: Marek Olšák
>
> If we assume that all buffers allocated by the DDX are scanout, a new flag
> that says "this is not scanout" has to be added to support the non-scanout
> buffers and maintain backward compatibility.
>
> This fixes bad
On Mon, Dec 2, 2013 at 10:40 AM, Matt Turner wrote:
> Previously we made the basic block following an ENDIF instruction a
> successor of the basic blocks ending with IF and ELSE. The PRM says that
> IF and ELSE instructions jump *to* the ENDIF, rather than over it.
>
> This should be immaterial to
On Die, 2013-12-03 at 21:33 +0100, Andreas Hartmetz wrote:
>
> diff --git a/src/gallium/drivers/radeonsi/si_state.c
> b/src/gallium/drivers/radeonsi/si_state.c
> index 24c9cf3..7b1a6df 100644
> --- a/src/gallium/drivers/radeonsi/si_state.c
> +++ b/src/gallium/drivers/radeonsi/si_state.c
> @@ -184
On 12/03/2013 01:24 PM, Juha-Pekka Heikkilä wrote:
> On Tue, Dec 3, 2013 at 6:42 PM, Brian Paul wrote:
>> On 12/02/2013 02:39 AM, Juha-Pekka Heikkila wrote:
>>>
>>> Check if any of the callocs fail and report it with _mesa_error
>>> if needed.
>>>
>>> Signed-off-by: Juha-Pekka Heikkila
>>> ---
>>
On Tue, Dec 3, 2013 at 4:28 PM, Brian Paul wrote:
> On 12/03/2013 02:56 PM, Courtney Goeltzenleuchter wrote:
>
>> Hi Brian,
>>
>> I've made all the recommended changes.
>>
>> I also added one, a test that the Driver.TextureView != NULL before
>> calling. This lets me test the non DD functionality
On 12/03/2013 02:56 PM, Courtney Goeltzenleuchter wrote:
Hi Brian,
I've made all the recommended changes.
I also added one, a test that the Driver.TextureView != NULL before
calling. This lets me test the non DD functionality with the
MESA_EXTENSION_OVERRIDE=+GL_ARB_texture_view
I've also reba
Kenneth Graunke writes:
> I missed this in the boolean -> enum conversion. C cheerfully casts
> false -> 0 -> UNKNOWN_RING. On Gen4-5, this causes the render ring
> prelude hook to get called in the middle of the batch, which is crazy.
>
> BRW_BATCH_STRUCT is not used on Gen6+.
>
> Fixes regres
On Tue, Dec 3, 2013 at 5:59 PM, Matt Turner wrote:
> On Tue, Dec 3, 2013 at 2:56 PM, Alex Deucher wrote:
>> On Tue, Dec 3, 2013 at 3:33 PM, Andreas Hartmetz wrote:
>>> Reduce scope of variables and divide the code more clearly into
>>> sections dealing with one thing.
>>> ---
>>> src/gallium/dr
On Tue, Dec 3, 2013 at 3:33 PM, Andreas Hartmetz wrote:
> ---
> src/gallium/drivers/radeon/r600_texture.c | 84
> +--
> 1 file changed, 68 insertions(+), 16 deletions(-)
>
> diff --git a/src/gallium/drivers/radeon/r600_texture.c
> b/src/gallium/drivers/radeon/r600_te
On Tue, Dec 3, 2013 at 2:56 PM, Alex Deucher wrote:
> On Tue, Dec 3, 2013 at 3:33 PM, Andreas Hartmetz wrote:
>> Reduce scope of variables and divide the code more clearly into
>> sections dealing with one thing.
>> ---
>> src/gallium/drivers/radeonsi/si_state.c | 38
>> +++-
On Tue, Dec 3, 2013 at 3:33 PM, Andreas Hartmetz wrote:
> ---
> src/gallium/drivers/radeonsi/si_state.c | 28 +++-
> 1 file changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_state.c
> b/src/gallium/drivers/radeonsi/si_state.c
> inde
On Tue, Dec 3, 2013 at 3:33 PM, Andreas Hartmetz wrote:
> Reduce scope of variables and divide the code more clearly into
> sections dealing with one thing.
> ---
> src/gallium/drivers/radeonsi/si_state.c | 38
> +++--
> 1 file changed, 22 insertions(+), 16 deletions(
Carl Worth writes:
> When a branch is pushed to the master git repo, a git hook will
> automatically search for the patch in the database, and if it is
> found,
...
At least, that was my intention.
I had a couple of permissions problem with the git hook, so it hasn't
actually been active. I fix
https://bugs.freedesktop.org/show_bug.cgi?id=72230
--- Comment #4 from Patrick Steinhardt ---
Would it be possible to provide updated tarballs including this fix?
--
You are receiving this mail because:
You are the assignee for the bug.
___
mesa-dev m
https://bugs.freedesktop.org/show_bug.cgi?id=72230
Emil Velikov changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On Tue, Dec 3, 2013 at 6:42 PM, Brian Paul wrote:
> On 12/02/2013 02:39 AM, Juha-Pekka Heikkila wrote:
>>
>> Check if any of the callocs fail and report it with _mesa_error
>> if needed.
>>
>> Signed-off-by: Juha-Pekka Heikkila
>> ---
>> src/mesa/main/attrib.c | 34 +
On 3 December 2013 13:12, Chad Versace wrote:
> The BSpec states that the aligment for the non-msrt clear rectangle must
> be doubled; the BSpec does not restricit the workaround to specific
> hardware.
>
> Commit 9a1a67b applied the workaround to Haswell GT3. Commit 8b659ce
> expanded the worka
The BSpec states that the aligment for the non-msrt clear rectangle must
be doubled; the BSpec does not restricit the workaround to specific
hardware.
Commit 9a1a67b applied the workaround to Haswell GT3. Commit 8b659ce
expanded the workaround to all Haswell variants. This commit expands it
to al
On Tue, Dec 3, 2013 at 6:51 PM, Ian Romanick wrote:
> On 12/02/2013 01:39 AM, Juha-Pekka Heikkila wrote:
>> Check if any of the callocs fail and report it with _mesa_error
>> if needed.
>>
>> Signed-off-by: Juha-Pekka Heikkila
>> ---
>> src/mesa/main/attrib.c | 106
>> ++
I like the idea. I haven't really looked at the code, so...
Acked-by: Ian Romanick
But there is one comment below...
On 12/03/2013 09:58 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/xdemos/glxinfo.c | 43 ++-
> 1 file changed, 30 insertion
This adds HyperZ support, without fast clear for now.
I got a lot of help from Marek with this.
There seem to be no piglit regressions; about 60 very basic GL1.0 tests
were skipped in my test run for some reason - they looked very
unrelated. There was no change in other tests.
It does seem to make
---
src/gallium/drivers/radeon/r600_texture.c | 84 +--
1 file changed, 68 insertions(+), 16 deletions(-)
diff --git a/src/gallium/drivers/radeon/r600_texture.c
b/src/gallium/drivers/radeon/r600_texture.c
index 70f21bd..c91fbce 100644
--- a/src/gallium/drivers/radeon/
This should make the differences and similarities between color and
depth buffer handling more clear.
---
src/gallium/drivers/r600/evergreen_state.c| 10 ++---
src/gallium/drivers/r600/r600_blit.c | 6 +--
src/gallium/drivers/r600/r600_state.c | 10 ++---
src/gallium/drivers/
Reduce scope of variables and divide the code more clearly into
sections dealing with one thing.
---
src/gallium/drivers/radeonsi/si_state.c | 38 +++--
1 file changed, 22 insertions(+), 16 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/galliu
---
src/gallium/drivers/radeonsi/si_state.c | 28 +++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/gallium/drivers/radeonsi/si_state.c
index 24c9cf3..7b1a6df 100644
--- a/src/gallium/drivers/radeonsi/si_state.
On Tue, Dec 3, 2013 at 6:39 PM, Brian Paul wrote:
> On 12/02/2013 02:39 AM, Juha-Pekka Heikkila wrote:
>>
>> Signed-off-by: Juha-Pekka Heikkila
>> ---
>> src/glx/clientattrib.c | 5 +
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/src/glx/clientattrib.c b/src/glx/clientattrib.c
>> i
https://bugs.freedesktop.org/show_bug.cgi?id=72281
Priority: medium
Bug ID: 72281
Keywords: regression
CC: e...@anholt.net
Assignee: mesa-dev@lists.freedesktop.org
Summary: [bisected] Eufloria HD crash on start
Severity
Thanks! These are:
Reviewed-by: Eric Anholt
pgpNXhaJ5J1l2.pgp
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Siavash Eliasi writes:
> Hello, this is V2 series of patches to accomplish *Enable
> ARB_map_buffer_alignment in all drivers* newbie project suggested by
> Ian Romanick.
I think there's a piece missing to this, which is this bit of spec text:
"If no error occurs, the pointer value returned
On 12/03/2013 08:43 AM, Ian Romanick wrote:
> Can we please hold off on this? I'm in the process of getting the GLSL
> spec updated to match what people actually ship. We've always taken the
> approach of following the spec, and if the spec doesn't match reality,
> fix the spec. I've done this a
The BSpec states that for IVB, VLVT, and HSW, the aligment for the
non-msrt clear rectangle must be doubled. Commit 9a1a67b applied the
workaround to Haswell GT3. Commit 8b659ce expanded the workaround to
all Haswell variants. This commit expands it to all Gen7 hardware, as
required by the BSpec.
On 11/26/2013 10:59 PM, Siavash Eliasi wrote:
---
src/mesa/main/imports.c| 7 +--
src/mesa/math/m_matrix.c | 13 +
src/mesa/program/prog_parameter.c | 3 +--
src/mesa/state_tracker/st_cb_texture.c | 6 ++
src/mesa/swrast/s_texture.c
Francisco Jerez writes:
> Petri Latvala writes:
>[...]
>> Not saying it kosher either way though, calling assignment operator in a
>> constructor is iffy :P. The proper way is selecting the correct base
>> class constructor to call.
>>
Again, that probably belongs to a separate clean-up commit
On 12/03/2013 10:58 AM, Marek Olšák wrote:
From: Marek Olšák
---
src/xdemos/glxinfo.c | 43 ++-
1 file changed, 30 insertions(+), 13 deletions(-)
diff --git a/src/xdemos/glxinfo.c b/src/xdemos/glxinfo.c
index c9edc6a..a008ea8 100644
--- a/src/xdemos/g
From: Marek Olšák
---
src/xdemos/glxinfo.c | 43 ++-
1 file changed, 30 insertions(+), 13 deletions(-)
diff --git a/src/xdemos/glxinfo.c b/src/xdemos/glxinfo.c
index c9edc6a..a008ea8 100644
--- a/src/xdemos/glxinfo.c
+++ b/src/xdemos/glxinfo.c
@@ -760,7 +
This looks pretty good. Just a bunch of nitpicks below.
On 11/25/2013 05:49 PM, Courtney Goeltzenleuchter wrote:
Add Mesa TextureView logic.
Incorporate feedback on ARB_texture_view:
- Add S3TC VIEW_CLASSes to compatibility table
- Use existing _mesa_get_tex_image
- Clean up error strings
- Us
On 11/25/2013 05:47 PM, Courtney Goeltzenleuchter wrote:
Refactor to make next_mipmap_level_size defined in mipmap.c a
_mesa_ helper function that can then be used by texture_view
Signed-off-by: Courtney Goeltzenleuchter
---
src/mesa/main/mipmap.c | 8
src/mesa/main/mipmap.h
On 12/02/2013 09:55 PM, Tapani Pälli wrote:
On 12/02/2013 11:06 PM, Chad Versace wrote:
On 12/01/2013 01:53 AM, Tapani Pälli wrote:
Commit a594cec broke EGL X11 backend by adding dependency between
X11 and DRM backends requiring HAVE_EGL_PLATFORM_DRM defined for X11.
This patch fixes the issue
On 11/26/2013 04:54 PM, Ian Romanick wrote:
From: Ian Romanick
glext.h has had all the necessary bits for years.
Signed-off-by: Ian Romanick
---
include/GL/gl.h | 33 -
1 file changed, 33 deletions(-)
For the series:
Reviewed-by: Brian Paul
On 12/02/2013 01:39 AM, Juha-Pekka Heikkila wrote:
> Check if any of the callocs fail and report it with _mesa_error
> if needed.
>
> Signed-off-by: Juha-Pekka Heikkila
> ---
> src/mesa/main/attrib.c | 106
> -
> 1 file changed, 104 insertions(+),
On 12/02/2013 07:30 AM, Juha-Pekka Heikkila wrote:
Signed-off-by: Juha-Pekka Heikkila
---
src/glx/dri2_glx.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c
index 3b33312..bfeebed 100644
--- a/src/glx/dri2_glx.c
+++ b/src/glx/dri2_glx.c
@@ -676,
On 12/02/2013 01:39 AM, Juha-Pekka Heikkila wrote:
> Check if any of the callocs fail and report it with _mesa_error
> if needed.
>
> Signed-off-by: Juha-Pekka Heikkila
> ---
> src/mesa/main/attrib.c | 34 ++
> 1 file changed, 30 insertions(+), 4 deletions(-)
>
>
On 12/02/2013 02:39 AM, Juha-Pekka Heikkila wrote:
Check if any of the callocs fail and report it with _mesa_error
if needed.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/attrib.c | 106 -
1 file changed, 104 insertions(+), 2 deletions(
Can we please hold off on this? I'm in the process of getting the GLSL
spec updated to match what people actually ship. We've always taken the
approach of following the spec, and if the spec doesn't match reality,
fix the spec. I've done this about a dozen times over the last 3 years,
and I don'
On 12/02/2013 02:39 AM, Juha-Pekka Heikkila wrote:
Check if any of the callocs fail and report it with _mesa_error
if needed.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/attrib.c | 34 ++
1 file changed, 30 insertions(+), 4 deletions(-)
diff --git a/
On 12/02/2013 02:39 AM, Juha-Pekka Heikkila wrote:
Signed-off-by: Juha-Pekka Heikkila
---
src/glx/clientattrib.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/glx/clientattrib.c b/src/glx/clientattrib.c
index 1b306ea..a26906f 100644
--- a/src/glx/clientattrib.c
+++ b/src/glx/cl
On 12/03/2013 05:47 AM, Kevin Rogovin wrote:
Allow for GLSL shaders to have #extension directive
anywhere in source file; during preprocessor, #extension
directives are saved to a list rather than being added
to the pre-processed string. That list is played back
before parsing of pre-processed te
On Thu, Nov 28, 2013 at 11:41:06AM -0800, Paul Berry wrote:
> This function is about to get more complex.
> ---
> src/glsl/loop_analysis.cpp | 91
> +-
> src/glsl/loop_analysis.h | 4 ++
> 2 files changed, 70 insertions(+), 25 deletions(-)
>
> diff
Ping? Can anyone review this, please?
Grigori
On 27.11.2013 00:15, Grigori Goronzy wrote:
---
src/glsl/glsl_types.cpp | 61 +++--
src/glsl/glsl_types.h | 7 ++
2 files changed, 41 insertions(+), 27 deletions(-)
diff --git a/src/glsl/glsl_t
Add an additional bit flag, GLSL_EXTENSION_STRICT for
gl_context#Shader#Flags to require that #extension
directives must come before variable or function
declarations. The flag is set to on if MESA_GLSL has
the option extension_strict_ordering in it.
---
src/glsl/glsl_parser_extras.cpp | 7
Allow for GLSL shaders to have #extension directive
anywhere in source file; during preprocessor, #extension
directives are saved to a list rather than being added
to the pre-processed string. That list is played back
before parsing of pre-processed text takes place.
---
src/glsl/Makefile.sour
Hi,
Thankyou for the beans on ralloc. I will send out a patch sequence shortly
that:
1) fixes the formatting issues (spaces, comments, etc)
2) uses ralloc in glcpp_extras.c
Best Regards
- Kevin Rogovin
From: Kenneth Graunke [kenn...@whitecape.org]
Hi,
> Yeah...there's a point where you switch from the old code to the new
> code, and most bugs would probably bisect to that. In this case, I
> think that's fairly unavoidable.
>
> However, splitting it up into multiple patches would definitely make it
> a lot easier to review.
So, is it requ
On 12/03/2013 12:00 AM, Kevin Rogovin wrote:
[snip]
> diff --git a/src/glsl/glcpp/glcpp_extras.c b/src/glsl/glcpp/glcpp_extras.c
> new file mode 100644
> index 000..1672f9f
> --- /dev/null
> +++ b/src/glsl/glcpp/glcpp_extras.c
> @@ -0,0 +1,126 @@
> +#include
> +#include
> +#include "glcpp_ext
On 12/03/2013 01:00 AM, Rogovin, Kevin wrote:
> Hi,
>
> I appreciate the feedback, however I am having difficulty in figuring out a
> -good- way to break up the first patch. The basic beans is that all of it's
> parts are needed together for it to even make sense. To be precise, the
> changes
Petri Latvala writes:
> On 12/02/2013 10:36 PM, Francisco Jerez wrote:
>> Would you prefer 'this->operator=(reg);'?
>>
>> I just remembered... The reason this wouldn't work is that it would
>> trigger an implicit conversion from 'backend_reg' to 'fs_reg', causing
>> infinite recursion into the f
Hi,
I appreciate the feedback, however I am having difficulty in figuring out a
-good- way to break up the first patch. The basic beans is that all of it's
parts are needed together for it to even make sense. To be precise, the changes
consist of:
1) implementation of linked list of #extensi
On 12/03/2013 12:00 AM, Kevin Rogovin wrote:
> Allow for GLSL shaders to have #extension directive
> anywhere in source file; during preprocessor, #extension
> directives are saved to a list rather than being added
> to the pre-processed string. That list is played back
> before parsing of pre-pro
Add an additional bit flag, GLSL_EXTENSION_STRICT for
gl_context#Shader#Flags to require that #extension
directives must come before variable of function
declarations. The flag is set to on if MESA_GLSL has
the option extension_strict_ordering in it.
---
src/glsl/glsl_parser_extras.cpp | 6 +++-
Allow for GLSL shaders to have #extension directive
anywhere in source file; during preprocessor, #extension
directives are saved to a list rather than being added
to the pre-processed string. That list is played back
before parsing of pre-processed text takes place.
---
src/glsl/Makefile.sour
64 matches
Mail list logo
