Re: [Mesa-dev] [PATCH 5/8] dri/common: Add functions mapping MESA_FORMAT_* <-> __DRI_IMAGE_FORMAT_*

2013-11-04 Thread Keith Packard
Jordan Justen writes: > After patch 6, this will add SARGB8, right? So, maybe add this to the > commit message, or separate out adding SARGB8 into a separate commit? I added the SARGB8 define in patch 4; is there some other separation you think would be warranted? Oh, just so everyone knows --

[Mesa-dev] [PATCH] i965/gen7: Emit workaround flush when changing GS enable state.

2013-11-04 Thread Paul Berry
--- src/mesa/drivers/dri/i965/brw_context.h | 44 +++ src/mesa/drivers/dri/i965/gen7_blorp.cpp | 8 + src/mesa/drivers/dri/i965/gen7_gs_state.c | 18 +++ src/mesa/drivers/dri/i965/gen7_urb.c | 24 ++- src/mesa/drivers/dri/i96

Re: [Mesa-dev] [PATCH 5/8] dri/common: Add functions mapping MESA_FORMAT_* <-> __DRI_IMAGE_FORMAT_*

2013-11-04 Thread Jordan Justen
On Mon, Nov 4, 2013 at 6:23 PM, Keith Packard wrote: > The __DRI_IMAGE_FORMAT codes are used by the image extension, drivers need to > be able to translate between them. Instead of duplicating this translation in > each driver, create a shared version. > > Signed-off-by: Keith Packard > --- > sr

Re: [Mesa-dev] [PATCH 3/3] radeon / r200: Don't pass unused parameters to radeon_viewport

2013-11-04 Thread Jordan Justen
Series Reviewed-by: Jordan Justen On Fri, Nov 1, 2013 at 12:44 PM, Ian Romanick wrote: > From: Ian Romanick > > The x, y, width, and height parameters aren't used by radeon_viewport, > so don't pass them. This should make future changes to the > dd_function_table::Viewport interface a little e

Re: [Mesa-dev] [PATCH 2/2] i965: Use unreachable to silence a compiler warning.

2013-11-04 Thread Francisco Jerez
Matt Turner writes: > --- > src/mesa/drivers/dri/i965/brw_reg.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_reg.h > b/src/mesa/drivers/dri/i965/brw_reg.h > index e9cf892..bfc99e1 100644 > --- a/src/mesa/drivers/dri/i965/brw_reg.h > +++ b/src/mesa/drive

Re: [Mesa-dev] [PATCH] i965: Fix context initialization after 2f896627175384fd5

2013-11-04 Thread Matt Turner
On Mon, Nov 4, 2013 at 3:50 PM, Eric Anholt wrote: > You can't return stack-initialized values and expect anything good to > happen. > --- > src/mesa/drivers/dri/i965/brw_context.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_cont

Re: [Mesa-dev] [PATCH] i965: Let driconf clamp_max_samples affect context version

2013-11-04 Thread Eric Anholt
Chad Versace writes: > Commit 2f89662 added the driconf option 'clamp_max_samples'. In that > commit, the option did not alter the context version. > > Specifically, Mesa constructed a GL 3.0 context for Baytrail even if > clamp_max_samples=0, which clamps GL_MAX_SAMPLES to 0. This violates the

[Mesa-dev] [PATCH] mesa: Remove last BEOS checks

2013-11-04 Thread Alexander von Gluck IV
* Goodbye BeOS, we hardly knew thee * As BeOS was gcc2 only, there was little chance of this being useful. * Doesn't effect Haiku in any meaningful way --- include/GL/gl.h |8 scons/gallium.py |2 -- 2 files changed, 10 deletions(-) diff --git a/include/GL/gl.h b/include/GL/gl

[Mesa-dev] [PATCH] i965: Let driconf clamp_max_samples affect context version

2013-11-04 Thread Chad Versace
Commit 2f89662 added the driconf option 'clamp_max_samples'. In that commit, the option did not alter the context version. Specifically, Mesa constructed a GL 3.0 context for Baytrail even if clamp_max_samples=0, which clamps GL_MAX_SAMPLES to 0. This violates the GL 3.0 spec, which requires GL_M

Re: [Mesa-dev] [PATCH 3/5] mesa: remove __QUICKDRAW__ tests

2013-11-04 Thread Alexander von Gluck IV
On Mon, Nov 4, 2013 at 6:48 PM, Brian Paul wrote: --- include/GL/gl.h |2 +- include/GL/osmesa.h |5 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/include/GL/gl.h b/include/GL/gl.h index 0efa6ef..31a2813 100644 --- a/include/GL/gl.h +++ b/include/GL/gl.h @@ -69

Re: [Mesa-dev] [PATCH 1/5] mesa: remove Alpha CPU checks

2013-11-04 Thread Matt Turner
On Mon, Nov 4, 2013 at 5:04 PM, Matt Turner wrote: > On Mon, Nov 4, 2013 at 4:48 PM, Brian Paul wrote: >> --- >> src/mesa/main/compiler.h |7 +-- >> 1 file changed, 1 insertion(+), 6 deletions(-) >> >> diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h >> index 61ce5db..275

Re: [Mesa-dev] [PATCH 1/5] mesa: remove Alpha CPU checks

2013-11-04 Thread Matt Turner
On Mon, Nov 4, 2013 at 4:48 PM, Brian Paul wrote: > --- > src/mesa/main/compiler.h |7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h > index 61ce5db..2752ca8 100644 > --- a/src/mesa/main/compiler.h > +++ b/src/mes

Re: [Mesa-dev] [PATCH] target/haiku-softpipe: Fix viewport issues

2013-11-04 Thread Brian Paul
On 11/04/2013 12:05 PM, Alexander von Gluck IV wrote: * Call mesa viewport call on winndow resize * Add initial postprocessing code * Pass hgl_context to private statetracker as it is more useful than GalliumContext * Use Lock and Unlock functions to standardize GalliumContext locking * Cre

[Mesa-dev] [PATCH 5/5] mesa: remove OPENSTEP stuff

2013-11-04 Thread Brian Paul
--- include/GL/gl.h |6 +- src/mesa/main/compiler.h |2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/include/GL/gl.h b/include/GL/gl.h index 1d21df7..d0710ba 100644 --- a/include/GL/gl.h +++ b/include/GL/gl.h @@ -40,15 +40,11 @@ #include /* to get so

[Mesa-dev] [PATCH 3/5] mesa: remove __QUICKDRAW__ tests

2013-11-04 Thread Brian Paul
--- include/GL/gl.h |2 +- include/GL/osmesa.h |5 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/include/GL/gl.h b/include/GL/gl.h index 0efa6ef..31a2813 100644 --- a/include/GL/gl.h +++ b/include/GL/gl.h @@ -69,7 +69,7 @@ # define GLAPIENTRY #endif /* WIN32 &&

[Mesa-dev] [PATCH 1/5] mesa: remove Alpha CPU checks

2013-11-04 Thread Brian Paul
--- src/mesa/main/compiler.h |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h index 61ce5db..2752ca8 100644 --- a/src/mesa/main/compiler.h +++ b/src/mesa/main/compiler.h @@ -36,11 +36,7 @@ #include #include -#if

[Mesa-dev] [PATCH 2/5] mesa: remove WGLAPI macro

2013-11-04 Thread Brian Paul
WGLAPI was defined in glheader.h but wasn't used anywhere. --- src/mesa/main/glheader.h | 16 1 file changed, 16 deletions(-) diff --git a/src/mesa/main/glheader.h b/src/mesa/main/glheader.h index e027218..7f7f9a3 100644 --- a/src/mesa/main/glheader.h +++ b/src/mesa/main/glhead

[Mesa-dev] [PATCH 4/5] mesa: remove macintosh preprocessor stuff

2013-11-04 Thread Brian Paul
IIRC, this is MacOS 9.x stuff. --- include/GL/gl.h|7 --- src/mesa/math/m_clip_tmp.h | 12 ++-- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/include/GL/gl.h b/include/GL/gl.h index 31a2813..1d21df7 100644 --- a/include/GL/gl.h +++ b/include/GL/gl.h

Re: [Mesa-dev] [PATCH 1/2] mesa: Add unreachable macro.

2013-11-04 Thread Brian Paul
On 11/04/2013 05:43 PM, Matt Turner wrote: --- src/mesa/main/compiler.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h index 61ce5db..6a25bf5 100644 --- a/src/mesa/main/compiler.h +++ b/src/mesa/main/compiler.h @@ -252,6

Re: [Mesa-dev] [PATCH] i965: Fix context initialization after 2f896627175384fd5

2013-11-04 Thread Chad Versace
On 11/04/2013 03:50 PM, Eric Anholt wrote: You can't return stack-initialized values and expect anything good to happen. --- src/mesa/drivers/dri/i965/brw_context.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/

[Mesa-dev] [PATCH 2/2] i965: Use unreachable to silence a compiler warning.

2013-11-04 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_reg.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_reg.h b/src/mesa/drivers/dri/i965/brw_reg.h index e9cf892..bfc99e1 100644 --- a/src/mesa/drivers/dri/i965/brw_reg.h +++ b/src/mesa/drivers/dri/i965/brw_reg.h @@ -299,6 +299,7

[Mesa-dev] [PATCH 1/2] mesa: Add unreachable macro.

2013-11-04 Thread Matt Turner
--- src/mesa/main/compiler.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h index 61ce5db..6a25bf5 100644 --- a/src/mesa/main/compiler.h +++ b/src/mesa/main/compiler.h @@ -252,6 +252,21 @@ static INLINE GLuint CPU_TO_LE32(GL

[Mesa-dev] [PATCH 1/2] mesa: Clean up use of top_srcdir/top_builddir.

2013-11-04 Thread Matt Turner
--- src/mesa/Makefile.am | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/src/mesa/Makefile.am b/src/mesa/Makefile.am index f86caee..6ce31d2 100644 --- a/src/mesa/Makefile.am +++ b/src/mesa/Makefile.am @@ -85,8 +85,7 @@ if HAVE_GALLIUM noinst_LTLIBRARIES += lib

[Mesa-dev] [PATCH 2/2] mesa: Build program as part of libmesa.

2013-11-04 Thread Matt Turner
--- Makefile.am | 2 +- configure.ac | 1 - src/mesa/Makefile.am | 24 +++ src/mesa/program/Makefile.am | 45 4 files changed, 17 insertions(+), 55 deletions(-) delete mode 100644 src/mesa/

[Mesa-dev] [PATCH] i965: Fix 'SIMD16 only' dispatch of fragment shader in case of sample shading

2013-11-04 Thread Anuj Phogat
This patch make changes to correctly set up the Dispatch GRF Start Register in case of 'SIMD16 only' FS dispatch. This fixes an issue of incorrect rendering on dolphin emulator with GL_SAMPLE_SHADING enabled. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/gen6_wm_state.c | 19

[Mesa-dev] [PATCH] i965: Fix context initialization after 2f896627175384fd5

2013-11-04 Thread Eric Anholt
You can't return stack-initialized values and expect anything good to happen. --- src/mesa/drivers/dri/i965/brw_context.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 13569ad..9

Re: [Mesa-dev] [PATCH 05/11] mesa: Add ARB_vertex_attrib_binding

2013-11-04 Thread Fredrik Höglund
On Monday 04 November 2013, Ian Romanick wrote: > On 10/28/2013 03:33 PM, Fredrik Höglund wrote: > > update_array() and update_array_format() are changed to update the new > > attrib and binding states, and the client arrays become derived state. > > I don't think we should enable the extension un

Re: [Mesa-dev] [PATCH] i965/gen7: workaround alpha blending problems with CMS MSAA buffers.

2013-11-04 Thread Paul Berry
On 4 November 2013 14:44, Chris Forbes wrote: > Is this broken the same way on all of IVB|HSW|BYT? > Good question. I'd tested IVB and HSW but not BYT. I've now tested all three and the bug is present on all three platforms. > > On Tue, Nov 5, 2013 at 11:24 AM, Paul Berry > wrote: > > i965/

Re: [Mesa-dev] [PATCH 09/11] mesa: Add Get* support for ARB_vertex_attrib_binding

2013-11-04 Thread Fredrik Höglund
On Monday 04 November 2013, Ian Romanick wrote: > On 10/28/2013 03:33 PM, Fredrik Höglund wrote: > > This needs some extension checks somewhere. I've added a check for ARB_instanced_arrays in the VERTEX_BINDING_DIVISOR case. I didn't add checks for ARB_vertex_attrib_binding since the intent is t

Re: [Mesa-dev] [PATCH] i965/gen7: workaround alpha blending problems with CMS MSAA buffers.

2013-11-04 Thread Chris Forbes
Is this broken the same way on all of IVB|HSW|BYT? On Tue, Nov 5, 2013 at 11:24 AM, Paul Berry wrote: > i965/gen7 hardware doesn't perform alpha blending correctly when > compressed (CMS) multisampled buffers are in use. Therefore, we need > to detect when alpha blending is used on a compressed

[Mesa-dev] [PATCH] i965/gen7: workaround alpha blending problems with CMS MSAA buffers.

2013-11-04 Thread Paul Berry
i965/gen7 hardware doesn't perform alpha blending correctly when compressed (CMS) multisampled buffers are in use. Therefore, we need to detect when alpha blending is used on a compressed multisampled buffer, and convert the buffer to uncompressed (UMS) layout. Once a given buffer has been conver

Re: [Mesa-dev] [PATCH] target/haiku-softpipe: Fix viewport issues

2013-11-04 Thread Alexander von Gluck IV
On Mon, Nov 4, 2013 at 1:05 PM, Alexander von Gluck IV wrote: * Call mesa viewport call on winndow resize * Add initial postprocessing code * Pass hgl_context to private statetracker as it is more useful than GalliumContext * Use Lock and Unlock functions to standardize GalliumContext lockin

Re: [Mesa-dev] [PATCH 5/5] mesa: Fix bug about "what if we didn't find the VBO"?

2013-11-04 Thread Ian Romanick
On 11/01/2013 12:01 PM, Fredrik Höglund wrote: > On Thursday 31 October 2013, Eric Anholt wrote: >> There was some spec text, and what there isn't text for we have obvious >> intended behavior from other buffer object bindings. > > The first revision of the specification didn't say anything about

Re: [Mesa-dev] [PATCH 00/11] Implement GL_ARB_vertex_attrib_binding

2013-11-04 Thread Ian Romanick
Patches 1, 3, 4, 6, 7, 8, and 10 are Reviewed-by: Ian Romanick I sent trivial comments for patch 2. I sent comments for patches 5 and 9. On 10/28/2013 03:33 PM, Fredrik Höglund wrote: > This extension decouples the vertex attributes from the vertex buffer > bindings, making it possible to chan

Re: [Mesa-dev] [PATCH 05/11] mesa: Add ARB_vertex_attrib_binding

2013-11-04 Thread Ian Romanick
On 10/28/2013 03:33 PM, Fredrik Höglund wrote: > update_array() and update_array_format() are changed to update the new > attrib and binding states, and the client arrays become derived state. I don't think we should enable the extension until after the other patches. Otherwise people can encount

Re: [Mesa-dev] [PATCH 09/11] mesa: Add Get* support for ARB_vertex_attrib_binding

2013-11-04 Thread Ian Romanick
On 10/28/2013 03:33 PM, Fredrik Höglund wrote: This needs some extension checks somewhere. > --- > src/mesa/main/get.c | 24 > src/mesa/main/get_hash_params.py |3 +++ > src/mesa/main/varray.c |9 + > 3 files changed, 36 insertion

Re: [Mesa-dev] [PATCH 02/11] mesa: Split out the format code from update_array()

2013-11-04 Thread Ian Romanick
On 10/28/2013 03:33 PM, Fredrik Höglund wrote: > Split out the code for updating the array format into a new function > called update_array_format(). This function will be called by both > update_array() and the new glVertexAttrib*Format() entry points in > ARB_vertex_attrib_binding. Other than th

Re: [Mesa-dev] [PATCH 5/6] dri3: Add DRI3 support to GLX, DRI common and Intel driver

2013-11-04 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/03/2013 02:35 PM, Keith Packard wrote: > Kristian Høgsberg writes: > >> I sent a reply to the sourceforge addresses in the original >> emails, but I didn't see it show up in the archives. Trying >> again with the freedesktop addresses. > > (s

Re: [Mesa-dev] Automake/subdir-object/makefile.sources cleanups

2013-11-04 Thread Ian Romanick
On 11/02/2013 12:00 PM, Emil Velikov wrote: > Hello list, > > Here is a follow up patchset to the Makefile.sources, targeting the following > * move source files lists to Makefile.sources (symmetry and reuse accross > build systems) > * creates symlinks and enables subdir-objects (preparation as t

Re: [Mesa-dev] [PATCH 17/37] targets/vdpau: symlink vl_winsys_{dri, xsp}.c for each target

2013-11-04 Thread Emil Velikov
On 02/11/13 19:17, Christian König wrote: > Am 02.11.2013 20:00, schrieb Emil Velikov: >> Make automake's subdir-objects work. >> >> Signed-off-by: Emil Velikov > > You can drop this and patch 18, I have a patch in the pipeline to > entirely remove vl_winsys_xsp.c. > > Just waiting for Mareks pa

[Mesa-dev] [Bug 71110] xorg_driver.c:1030:2: error: too many arguments to function ‘DamageUnregister’

2013-11-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71110 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] i965: Combine gen6_clip_state.c and gen7_clip_state.c.

2013-11-04 Thread Eric Anholt
Kenneth Graunke writes: > The changes between Gen6-7 are minimal, and can easily be solved with > an extra generation check. This cuts a lot of duplicated code. > > It also helps prevent even more duplication for Broadwell. > > Signed-off-by: Kenneth Graunke Reviewed-by: Eric Anholt pgplRje

Re: [Mesa-dev] [PATCH 3/5] i965/fs: New peephole optimization to generate SEL.

2013-11-04 Thread Matt Turner
On Mon, Nov 4, 2013 at 11:30 AM, Paul Berry wrote: > On 4 November 2013 11:23, Matt Turner wrote: >> >> On Mon, Nov 4, 2013 at 10:57 AM, Paul Berry >> wrote: >> > On 4 November 2013 10:31, Eric Anholt wrote: >> >> >> >> Matt Turner writes: >> >> > diff --git a/src/mesa/drivers/dri/i965/brw_fs_

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

2013-11-04 Thread Brian Paul
On 11/04/2013 11:43 AM, Ian Romanick wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/01/2013 04:12 PM, Francisco Jerez wrote: Ian Romanick writes: On 11/01/2013 02:04 PM, Courtney Goeltzenleuchter wrote: [...] More often, the dd_function_table functions allow core Mesa to signal

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

2013-11-04 Thread Marek Olšák
Hi Ian, Gallium uses the following interface: void (*set_scissor_states)( struct pipe_context *, unsigned start_slot, unsigned num_scissors, const struct pipe_scissor_state * ); void (*set_viewport

Re: [Mesa-dev] [PATCH 3/5] i965/fs: New peephole optimization to generate SEL.

2013-11-04 Thread Paul Berry
On 4 November 2013 11:23, Matt Turner wrote: > On Mon, Nov 4, 2013 at 10:57 AM, Paul Berry > wrote: > > On 4 November 2013 10:31, Eric Anholt wrote: > >> > >> Matt Turner writes: > >> > diff --git a/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp > >> > b/src/mesa/drivers/dri/i965/brw_fs_sel

Re: [Mesa-dev] [PATCH 3/5] i965/fs: New peephole optimization to generate SEL.

2013-11-04 Thread Matt Turner
On Mon, Nov 4, 2013 at 10:57 AM, Paul Berry wrote: > On 4 November 2013 10:31, Eric Anholt wrote: >> >> Matt Turner writes: >> > diff --git a/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp >> > b/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp >> > new file mode 100644 >> > index 000..9

Re: [Mesa-dev] [PATCH 2/4] mesa: remove BUILD_FOR_SNAP bits

2013-11-04 Thread Eric Anholt
These are: Reviewed-by: Eric Anholt pgp77HPIuZ_o5.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] util/u_format: take normalized flag in consideration in util_format_is_rgba8_variant

2013-11-04 Thread Jose Fonseca
- Original Message - > Am 04.11.2013 18:21, schrieb jfons...@vmware.com: > > From: José Fonseca > > > > Just happened to notice it was missing while looking at it. > > --- > > src/gallium/auxiliary/util/u_format.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/src/ga

[Mesa-dev] [PATCH] target/haiku-softpipe: Fix viewport issues

2013-11-04 Thread Alexander von Gluck IV
* Call mesa viewport call on winndow resize * Add initial postprocessing code * Pass hgl_context to private statetracker as it is more useful than GalliumContext * Use Lock and Unlock functions to standardize GalliumContext locking * Create texture resources in texture validation --- .../targe

Re: [Mesa-dev] [PATCH 00/11] ARB_draw_indirect support for i965

2013-11-04 Thread Ian Romanick
On 11/04/2013 01:09 AM, Chris Forbes wrote: > This series adds support for ARB_[multi_]draw_indirect on IVB and later. > > Patches 1-2 are updated versions of Christoph's initial ARB_draw_indirect > patches, adjusted only to resolve rebase issues, etc. > > Patches 3-7 are the meat of the implemen

Re: [Mesa-dev] [PATCH] util/u_format: take normalized flag in consideration in util_format_is_rgba8_variant

2013-11-04 Thread Roland Scheidegger
Am 04.11.2013 18:21, schrieb jfons...@vmware.com: > From: José Fonseca > > Just happened to notice it was missing while looking at it. > --- > src/gallium/auxiliary/util/u_format.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/gallium/auxiliary/util/u_format.h > b/src/gallium/

Re: [Mesa-dev] [PATCH 11/11] i965: Enable ARB_draw_indirect (and ARB_multi_draw_indirect) on Gen7+

2013-11-04 Thread Ian Romanick
On 11/04/2013 01:09 AM, Chris Forbes wrote: > .. and mark them off on the extensions list as done. > > V2: Enable only if pipelined register writes work. If you update docs/relnotes/10.0.html, Reviewed-by: Ian Romanick > Signed-off-by: Chris Forbes > --- > docs/GL3.txt

Re: [Mesa-dev] [RFC PATCH 0/2] i965/gs: Precompile geometry shaders.

2013-11-04 Thread Eric Anholt
Paul Berry writes: > This series adds precompilation for geometry shaders. > > I'm not 100% certain this is worth doing, because: > > (a) I'm aware of very few programs out in the wild that actually use > geometry shaders right now. > > (b) Since i965 hardware has no ability to remap vertex shade

Re: [Mesa-dev] [PATCH 02/11] mesa: implement GL_ARB_draw_indirect and GL_ARB_multi_draw_indirect

2013-11-04 Thread Ian Romanick
On 11/04/2013 10:56 AM, Ian Romanick wrote: > On 11/04/2013 01:09 AM, Chris Forbes wrote: >> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c >> index 1f55061..69ea1c0 100644 >> --- a/src/mesa/main/bufferobj.c >> +++ b/src/mesa/main/bufferobj.c >> @@ -86,6 +86,10 @@ get_buffer_tar

Re: [Mesa-dev] [PATCH 3/5] i965/fs: New peephole optimization to generate SEL.

2013-11-04 Thread Paul Berry
On 4 November 2013 10:31, Eric Anholt wrote: > Matt Turner writes: > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp > b/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp > > new file mode 100644 > > index 000..9626751 > > --- /dev/null > > +++ b/src/mesa/drivers/dri/i965/br

Re: [Mesa-dev] [PATCH 02/11] mesa: implement GL_ARB_draw_indirect and GL_ARB_multi_draw_indirect

2013-11-04 Thread Ian Romanick
On 11/04/2013 01:09 AM, Chris Forbes wrote: > From: Christoph Bumiller > > v2: > Removed some stray extern qualifiers. > > Documented use of Draw*IndirectCommand sizes. > > Removed separate extension enable flag for ARB_multi_draw_indirect > since this can always be supported by looping. > > K

Re: [Mesa-dev] [PATCH 5/5] i965/fs: Emit a MOV instead of a SEL if the sources are the same.

2013-11-04 Thread Matt Turner
On Mon, Nov 4, 2013 at 10:33 AM, Eric Anholt wrote: > Matt Turner writes: > >> One program affected. >> >> instructions in affected programs: 436 -> 428 (-1.83%) >> >> Reviewed-by: Paul Berry > > Couldn't we just detect this in opt_algebraic() in general? Yes. Would you prefer to drop this

Re: [Mesa-dev] [PATCH 5/5] mesa: Fix bug about "what if we didn't find the VBO"?

2013-11-04 Thread Eric Anholt
Fredrik Höglund writes: > On Thursday 31 October 2013, Eric Anholt wrote: >> There was some spec text, and what there isn't text for we have obvious >> intended behavior from other buffer object bindings. > > The first revision of the specification didn't say anything about it, > but the intent i

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

2013-11-04 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/01/2013 04:12 PM, Francisco Jerez wrote: > Ian Romanick writes: > >> On 11/01/2013 02:04 PM, Courtney Goeltzenleuchter wrote: >>> [...] >> More often, the dd_function_table functions allow core Mesa to >> signal the driver driver that something

Re: [Mesa-dev] [PATCH] glsl: Don't generate misleading debug names when packing gs inputs.

2013-11-04 Thread Eric Anholt
Paul Berry writes: > Previously, when packing geometry shader input varyings like this: > > in float foo[3]; > in float bar[3]; > > lower_packed_varyings would declare a packed varying like this: > > (declare (shader_in flat) (array ivec4 3) packed:foo[0],bar[0]) > > That's confusing,

Re: [Mesa-dev] [PATCH 4/5] i965/fs: Extend SEL peephole to handle only matching MOVs.

2013-11-04 Thread Eric Anholt
Paul Berry writes: > On 31 October 2013 18:57, Matt Turner wrote: > >> Before this patch, the following code would not be optimized even though >> the first two instructions were common to the then and else blocks: >> >>(+f0) IF >>MOV dst0 ... >>MOV dst1 ... >>MOV dst2 ... >>

Re: [Mesa-dev] [PATCH 5/5] i965/fs: Emit a MOV instead of a SEL if the sources are the same.

2013-11-04 Thread Eric Anholt
Matt Turner writes: > One program affected. > > instructions in affected programs: 436 -> 428 (-1.83%) > > Reviewed-by: Paul Berry Couldn't we just detect this in opt_algebraic() in general? pgpv6tl4BZCNH.pgp Description: PGP signature ___ mesa-

Re: [Mesa-dev] [PATCH 3/5] i965/fs: New peephole optimization to generate SEL.

2013-11-04 Thread Eric Anholt
Matt Turner writes: > diff --git a/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp > b/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp > new file mode 100644 > index 000..9626751 > --- /dev/null > +++ b/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp > +bool > +fs_visitor::opt_peephole

Re: [Mesa-dev] [PATCH 2/5] i965: Add a pass to remove dead control flow.

2013-11-04 Thread Eric Anholt
Matt Turner writes: > Removes IF/ENDIF and IF/ELSE/ENDIF with no intervening instructions. > > total instructions in shared programs: 1360393 -> 1360387 (-0.00%) > instructions in affected programs: 157 -> 151 (-3.82%) > > (no change in vertex shaders) > > Reviewed-by: Paul Berry [v1] > v2:

Re: [Mesa-dev] [PATCH 3/3] radeon / r200: Don't pass unused parameters to radeon_viewport

2013-11-04 Thread Alex Deucher
On Fri, Nov 1, 2013 at 3:44 PM, Ian Romanick wrote: > From: Ian Romanick > > The x, y, width, and height parameters aren't used by radeon_viewport, > so don't pass them. This should make future changes to the > dd_function_table::Viewport interface a little easier. > > Signed-off-by: Ian Romanic

[Mesa-dev] [PATCH] util/u_format: take normalized flag in consideration in util_format_is_rgba8_variant

2013-11-04 Thread jfonseca
From: José Fonseca Just happened to notice it was missing while looking at it. --- src/gallium/auxiliary/util/u_format.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/util/u_format.h b/src/gallium/auxiliary/util/u_format.h index dc777c3..31283e5 100644 --- a/src/ga

Re: [Mesa-dev] [PATCH] r600/llvm: Store inputs in function arguments

2013-11-04 Thread Tom Stellard
On Sun, Nov 03, 2013 at 06:58:18PM +0100, Vincent Lejeune wrote: > --- > src/gallium/drivers/r600/r600_llvm.c | 125 > - > src/gallium/drivers/r600/r600_shader.c | 2 + > src/gallium/drivers/radeon/radeon_llvm.h | 1 + > .../drivers/rade

Re: [Mesa-dev] [PATCH] clover: fix build with LLVM 3.4

2013-11-04 Thread Tom Stellard
On Fri, Nov 01, 2013 at 10:25:43AM -0500, Aaron Watry wrote: > dso_list was added as an argument for createInternalizePass in 3.4, and then > it was removed again in the same llvm version. I've pushed this patch, thanks! -Tom > --- > src/gallium/state_trackers/clover/llvm/invocation.cpp | 5 ---

Re: [Mesa-dev] [PATCH] gallivm: Remove llvm::DisablePrettyStackTrace for LLVM >= 3.4.

2013-11-04 Thread Brian Paul
On 11/03/2013 09:35 PM, Vinson Lee wrote: LLVM 3.4 r193971 removed llvm::DisablePrettyStackTrace and made the pretty stack trace opt-in rather than opt-out. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/g

Re: [Mesa-dev] [PATCH 02/11] mesa: implement GL_ARB_draw_indirect and GL_ARB_multi_draw_indirect

2013-11-04 Thread Brian Paul
On 11/04/2013 02:09 AM, Chris Forbes wrote: From: Christoph Bumiller v2: Removed some stray extern qualifiers. Documented use of Draw*IndirectCommand sizes. Removed separate extension enable flag for ARB_multi_draw_indirect since this can always be supported by looping. Kept generation of GL

Re: [Mesa-dev] [PATCH 10/11] vbo: map indirect buffer and extract params if doing sw primitive restart

2013-11-04 Thread Brian Paul
On 11/04/2013 02:09 AM, Chris Forbes wrote: Signed-off-by: Chris Forbes --- src/mesa/vbo/vbo_primitive_restart.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/src/mesa/vbo/vbo_primitive_restart.c b/src/mesa/vbo/vbo_primitive_restart.c index 48d04e1..ffe0c41

Re: [Mesa-dev] [PATCH] gallivm: Remove llvm::DisablePrettyStackTrace for LLVM >= 3.4.

2013-11-04 Thread Alex Deucher
On Mon, Nov 4, 2013 at 9:41 AM, Tom Stellard wrote: > On Sun, Nov 03, 2013 at 08:35:47PM -0800, Vinson Lee wrote: >> LLVM 3.4 r193971 removed llvm::DisablePrettyStackTrace and made the >> pretty stack trace opt-in rather than opt-out. >> > > Could you add a comment explaining that the default valu

[Mesa-dev] [PATCH 2/4] mesa: remove BUILD_FOR_SNAP bits

2013-11-04 Thread Brian Paul
--- src/mesa/main/compiler.h | 10 -- src/mesa/main/glheader.h |2 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h index d806d5b..2490ee3 100644 --- a/src/mesa/main/compiler.h +++ b/src/mesa/main/compiler.h @@ -92,

[Mesa-dev] [PATCH 3/4] mesa: remove Centerline C support from gl.h

2013-11-04 Thread Brian Paul
--- include/GL/gl.h |4 1 file changed, 4 deletions(-) diff --git a/include/GL/gl.h b/include/GL/gl.h index 2235f22..0efa6ef 100644 --- a/include/GL/gl.h +++ b/include/GL/gl.h @@ -113,10 +113,6 @@ #define GLAPIENTRYP GLAPIENTRY * #endif -#ifdef CENTERLINE_CLPP -#define signed -#endif

Re: [Mesa-dev] [PATCH] gallivm: Remove llvm::DisablePrettyStackTrace for LLVM >= 3.4.

2013-11-04 Thread Tom Stellard
On Sun, Nov 03, 2013 at 08:35:47PM -0800, Vinson Lee wrote: > LLVM 3.4 r193971 removed llvm::DisablePrettyStackTrace and made the > pretty stack trace opt-in rather than opt-out. > Could you add a comment explaining that the default value of DisablePrettyStackTrace has changed to true in LLVM 3.4

[Mesa-dev] [PATCH 1/4] mesa: remove SciTech stuff from gl.h

2013-11-04 Thread Brian Paul
--- include/GL/gl.h |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/include/GL/gl.h b/include/GL/gl.h index 6b94e3f..2235f22 100644 --- a/include/GL/gl.h +++ b/include/GL/gl.h @@ -33,11 +33,8 @@ /*

[Mesa-dev] [PATCH 4/4] mesa: remove Watcom C support

2013-11-04 Thread Brian Paul
--- src/mesa/main/compiler.h | 35 --- src/mesa/math/m_debug_util.h |2 -- src/mesa/x86/assyntax.h |8 3 files changed, 45 deletions(-) diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h index 2490ee3..61ce5db 100644 --- a/

[Mesa-dev] [PATCH 03/11] mesa: add is_indirect to _mesa_prim

2013-11-04 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/vbo/vbo.h| 3 ++- src/mesa/vbo/vbo_exec_array.c | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h index 113374a..942b34a 100644 --- a/src/mesa/vbo/vbo.h +++ b/src/mesa/vbo/vbo.h @@

[Mesa-dev] [PATCH 06/11] i965: flag new indirect buffer in brw_try_draw_prims

2013-11-04 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_draw.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index e6c3508..9f8ad45 100644 --- a/src/mesa/drivers/dri/i965/brw_draw.c ++

[Mesa-dev] [PATCH 10/11] vbo: map indirect buffer and extract params if doing sw primitive restart

2013-11-04 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/vbo/vbo_primitive_restart.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/src/mesa/vbo/vbo_primitive_restart.c b/src/mesa/vbo/vbo_primitive_restart.c index 48d04e1..ffe0c41 100644 --- a/src/mesa/vbo/vbo_primitive_restart

[Mesa-dev] [PATCH 11/11] i965: Enable ARB_draw_indirect (and ARB_multi_draw_indirect) on Gen7+

2013-11-04 Thread Chris Forbes
.. and mark them off on the extensions list as done. V2: Enable only if pipelined register writes work. Signed-off-by: Chris Forbes --- docs/GL3.txt | 4 ++-- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) di

[Mesa-dev] [PATCH 08/11] i965: pass indirect buffer to primitive restart check

2013-11-04 Thread Chris Forbes
--- src/mesa/drivers/dri/i965/brw_draw.c | 2 +- src/mesa/drivers/dri/i965/brw_draw.h | 3 ++- src/mesa/drivers/dri/i965/brw_primitive_restart.c | 5 +++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/driv

[Mesa-dev] [PATCH 09/11] mesa: pass indirect buffer to sw primitive restart

2013-11-04 Thread Chris Forbes
--- src/mesa/drivers/dri/i965/brw_primitive_restart.c | 2 +- src/mesa/vbo/vbo.h| 3 ++- src/mesa/vbo/vbo_exec_array.c | 2 +- src/mesa/vbo/vbo_primitive_restart.c | 3 ++- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 05/11] i965: add state atom for indirect buffer

2013-11-04 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_context.h | 10 + src/mesa/drivers/dri/i965/brw_draw_upload.c | 32 src/mesa/drivers/dri/i965/brw_state.h| 1 + src/mesa/drivers/dri/i965/brw_state_upload.c | 2 ++ 4 files changed,

[Mesa-dev] [PATCH 04/11] i965: Add new defines for indirect draws

2013-11-04 Thread Chris Forbes
- MMIO registers for draw parameters - New bit in 3DPRIMITIVE command to enable indirection Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_defines.h | 1 + src/mesa/drivers/dri/i965/intel_reg.h | 8 2 files changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 07/11] i965: implement indirect drawing for Gen7

2013-11-04 Thread Chris Forbes
Just prior to emitting the 3DPRIMITIVE command, we load each of the indirect registers. The values loaded are either from offsets into the current indirect BO, or constant zero if the parameter is not used for this draw. Enabling use of the indirect registers is done by turning on a bit in the fir

[Mesa-dev] [PATCH 02/11] mesa: implement GL_ARB_draw_indirect and GL_ARB_multi_draw_indirect

2013-11-04 Thread Chris Forbes
From: Christoph Bumiller v2: Removed some stray extern qualifiers. Documented use of Draw*IndirectCommand sizes. Removed separate extension enable flag for ARB_multi_draw_indirect since this can always be supported by looping. Kept generation of GL_INVALID_OPERATION in display list compile. Th

[Mesa-dev] [PATCH 01/11] mesa: add indirect drawing buffer parameter to draw functions

2013-11-04 Thread Chris Forbes
From: Christoph Bumiller Split from patch implementing ARB_draw_indirect. v2: Const-qualify the struct gl_buffer_object *indirect argument. v3: Fix up some more draw calls for new argument. v4: Fix up rebase conflicts in i965. --- src/mesa/drivers/dri/i965/brw_draw.c | 3 ++- src/

[Mesa-dev] [PATCH 00/11] ARB_draw_indirect support for i965

2013-11-04 Thread Chris Forbes
This series adds support for ARB_[multi_]draw_indirect on IVB and later. Patches 1-2 are updated versions of Christoph's initial ARB_draw_indirect patches, adjusted only to resolve rebase issues, etc. Patches 3-7 are the meat of the implementation; the indirect buffer is referenced from the batch