On Wed, Jan 16, 2013 at 03:03:41PM -0800, Ian Romanick wrote:
> From: Kenneth Graunke
>
> The GLSL 1.40 spec says:
>
> "Uniform block names and variable names declared within uniform
> blocks are scoped at the program level."
>
> Track the block name in the symbol table and emit errors
On Wed, Jan 16, 2013 at 03:14:14PM -0800, Matt Turner wrote:
[...]
> diff --git a/src/glsl/Makefile.am b/src/glsl/Makefile.am
> index fa09c5e..07fcf96 100644
> --- a/src/glsl/Makefile.am
> +++ b/src/glsl/Makefile.am
> @@ -19,7 +19,11 @@
> # FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE US
https://bugs.freedesktop.org/show_bug.cgi?id=59501
Priority: medium
Bug ID: 59501
Keywords: regression
CC: i...@freedesktop.org
Assignee: mesa-dev@lists.freedesktop.org
Summary: mesa/main/api_exec.c:286: undefined reference to
https://bugs.freedesktop.org/show_bug.cgi?id=59499
Priority: medium
Bug ID: 59499
Keywords: regression
CC: anuj.pho...@gmail.com
Assignee: mesa-dev@lists.freedesktop.org
Summary: SIGSEGV src/mesa/swrast/s_blit.c:546
Sev
No, no regress in piglit i've seen at all, only better... i even
played whole Drawn 2 game:
http://www.drawngame.com/games/dark-flight
under wine in OpenGL mode, it works perfectly now, needs culling under
fbo which is fixed now and this fix to display text and so works
exactly the same as with n
The sampler appears to ignore writemasks (even when correcting the
WRITEMASK_XYZW in brw_vec4_emit.cpp to the proper writemask) and just
always writes all four values.
To cope with this, just texture into a temporary, then MOV out into a
register that has the proper number of components.
NOTE: Th
Previously it was left undefined, causing us to select a random LOD.
NOTE: This is a candidate for stable branches (and requires the previous
commit as well).
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 7 +--
1 file changed, 5 insertions(+), 2 deleti
This is purely a refactor. However, in a moment, we'll want to set
lod_type to float for ir_tex, where ir->lod_info.lod is NULL.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/sr
On 01/16/2013 03:03 PM, Ian Romanick wrote:
This is the "warm up" series before my series to make UBOs with
instances names (and arrays of UBOs) work. These are both required
features of GLSL ES 3.00 that are not added to desktop GLSL until 1.50.
This series is just a bunch of minor fixes and sm
https://bugs.freedesktop.org/show_bug.cgi?id=59450
Brian Paul changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On 01/16/2013 07:19 AM, Brian Paul wrote:
Ah, yes. I always forget about that. I can't wait until Eric finishes
separating the dispatch tables so that we never have to do this again.
Reviewed-by: Ian Romanick
---
src/mesa/main/formatquery.c |3 +++
1 files changed, 3 insertions(+),
From: Ian Romanick
Filtering of DEPTH_COMPONENT and DEPTH_STENCIL for TEXTURE_3D is already
done in texture_error_check because these combinations aren't allowed on
desktop GL either.
Signed-off-by: Ian Romanick
---
src/mesa/main/glformats.c | 9 +
src/mesa/main/glformats.h | 3 +--
sr
From: Ian Romanick
Just like DEPTH_COMPONENT.
Signed-off-by: Ian Romanick
---
src/mesa/main/teximage.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index eeb977e..7a15196 100644
--- a/src/mesa/main/teximage.c
+++ b/sr
On 01/16/2013 01:49 PM, Kenneth Graunke wrote:
ES 3.0 supports 2D array textures, which are populated via TexImage3D.
Fixes es3conform's shadow_execution_frag test.
Actually, this should be handled by other checks already in
texture_error_check. Search for "additional checks for depth textur
On Wed, Jan 16, 2013 at 2:38 PM, Ian Romanick wrote:
> These checks are suck. :( Won't this let you specify depth component
> textures for GL_TEXTURE_3D textures too?
Looks like it, since packed_pixels_pixelstore is failing with this patch.
___
mesa-de
---
Makefile.am |1 -
configure.ac |1 -
src/glsl/Makefile.am | 38 --
src/glsl/tests/Makefile.am | 35 ---
src/glsl/tests/optimization-test | 10 --
Removing the subdirectory recursion provides a small speed up.
---
configure.ac|1 -
src/glsl/.gitignore |4 +-
src/glsl/Makefile.am| 108 ++-
src/glsl/Makefile.sources |8 ++--
src/glsl/glcpp/Makefi
Reduces the number of times that src/glsl/ is compiled when not cross
compiling.
Cc: Thierry Reding
---
configure.ac |2 ++
src/glsl/.gitignore |1 +
src/glsl/Makefile.am | 29 +++--
3 files changed, 30 insertions(+), 2 deletions(-)
diff --git a/config
Use glslparsertest from piglit instead.
---
Alternatively, does automake offer any options for generating rules
to build a target without adding it to the default build? I'd be nice
to leave glsl_compiler out of the build but still be able to do
make glsl_compiler
src/glsl/Makefile.am |9 -
Fixes missing options.h when doing 'make check' in dri/common before
'make' has been run.
---
src/mesa/drivers/dri/common/xmlpool/Makefile.am |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/mesa/drivers/dri/common/xmlpool/Makefile.am
b/src/mesa/drivers/dri/common/xml
---
src/glsl/Makefile.am |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/glsl/Makefile.am b/src/glsl/Makefile.am
index 1d93ac4..36af90e 100644
--- a/src/glsl/Makefile.am
+++ b/src/glsl/Makefile.am
@@ -35,7 +35,8 @@ AM_LFLAGS = --nounistd -o$(LEX_OUTPUT_ROOT).c
inclu
---
src/glsl/Makefile.am |2 --
src/glsl/glcpp/Makefile.am |2 --
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/src/glsl/Makefile.am b/src/glsl/Makefile.am
index 0f545d5..1d93ac4 100644
--- a/src/glsl/Makefile.am
+++ b/src/glsl/Makefile.am
@@ -25,9 +25,7 @@ AM_CPPFLA
From: Ian Romanick
This is required by OpenGL ES 3.0 and desktop OpenGL 4.2. Previous
version were ambiguous. This also matches the behavior of NVIDIA's
closed-source driver (version 304.64).
Fixed gles3conformance test uniform_buffer_object_getactiveuniformsiv
and uniform_buffer_object_struct
From: Ian Romanick
This is required by OpenGL ES 3.0 and desktop OpenGL 4.2. Previous
version were ambiguous. This also matches the behavior of NVIDIA's
closed-source driver (version 304.64).
Fixed gles3conformance test uniform_buffer_object_getactiveuniform.
Several piglit tests expect glGet
From: Ian Romanick
We currently have a bug in this code, and I don't want to fix it in two
places.
Signed-off-by: Ian Romanick
---
src/mesa/main/uniform_query.cpp | 2 +-
src/mesa/main/uniforms.c| 12 ++--
src/mesa/main/uniforms.h| 5 +
3 files changed, 16 inserti
From: Ian Romanick
It always returns true, so there's no point in having a return value.
Signed-off-by: Ian Romanick
---
src/glsl/link_uniforms.cpp | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp
index aa8a8b3..
From: Ian Romanick
Signed-off-by: Ian Romanick
---
src/glsl/ast_function.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp
index b56a3c7..dc7a58b 100644
--- a/src/glsl/ast_function.cpp
+++ b/src/glsl/ast_function.cp
From: Ian Romanick
Signed-off-by: Ian Romanick
---
src/glsl/ast_to_hir.cpp | 1 -
src/mesa/main/mtypes.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 31dd51a..de3ce90 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.
From: Ian Romanick
Signed-off-by: Ian Romanick
---
src/glsl/ir_clone.cpp | 4
1 file changed, 4 deletions(-)
diff --git a/src/glsl/ir_clone.cpp b/src/glsl/ir_clone.cpp
index 4314efa..c62c1fc 100644
--- a/src/glsl/ir_clone.cpp
+++ b/src/glsl/ir_clone.cpp
@@ -36,10 +36,6 @@ ir_rvalue::clone
From: Ian Romanick
This looks like a copy-and-paste left over.
Signed-off-by: Ian Romanick
---
src/glsl/linker.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index 70f3d5b..63548e0 100644
--- a/src/glsl/linker.cpp
+++ b/src
From: Ian Romanick
About both row_major and column_major layout qualifiers, the GLSL spec
says:
"It only affects the layout of matrices."
However, the OpenGL ES 3.0 conformance tests have taken this to mean it
is an error use it elsewhere. This seems logical given that
'layout(row_major) v
From: Kenneth Graunke
The GLSL 1.40 spec says:
"Uniform block names and variable names declared within uniform
blocks are scoped at the program level."
Track the block name in the symbol table and emit errors when conflicts
exist.
Fixes es3conform's uniform_buffer_object_block_name_con
This is the "warm up" series before my series to make UBOs with
instances names (and arrays of UBOs) work. These are both required
features of GLSL ES 3.00 that are not added to desktop GLSL until 1.50.
This series is just a bunch of minor fixes and small refactors.
This series fixes 4 gles3confo
On 01/16/2013 01:49 PM, Kenneth Graunke wrote:
ES 3.0 supports 2D array textures, which are populated via TexImage3D.
Fixes es3conform's shadow_execution_frag test.
Signed-off-by: Kenneth Graunke
---
src/mesa/main/glformats.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -
ES 3.0 supports 2D array textures, which are populated via TexImage3D.
Fixes es3conform's shadow_execution_frag test.
Signed-off-by: Kenneth Graunke
---
src/mesa/main/glformats.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/gl
On Tue, Jan 15, 2013 at 3:49 PM, Ian Romanick wrote:
> On 01/11/2013 08:54 PM, Eric Anholt wrote:
>>
>> The previous solution of transcoding to ARGB gave exact results, but
>> below the expected performance. Given that the user has gone out of
>> their way to give us compressed data for perfo
Fixes regressions since commit 899017fc54c40c969b5239b33f3a17b311878b0d
Author: Kenneth Graunke
Date: Fri Jan 4 07:53:09 2013 -0800
i965: Use Haswell's sample_d_c for textureGrad with shadow samplers.
That patch assumed that all instances were lowered. However, we weren't
lowering texture
https://bugs.freedesktop.org/show_bug.cgi?id=59364
--- Comment #1 from Tom Stellard ---
Note that in order to reproduce this, you will have to run make clean or even
make distclean, because the indirect.h file might be left over from a previous
build.
--
You are receiving this mail because:
You
Ian Romanick writes:
> On 01/11/2013 08:54 PM, Eric Anholt wrote:
>> The previous solution of transcoding to ARGB gave exact results, but
>> below the expected performance. Given that the user has gone out of
>> their way to give us compressed data for performance reasons, try to
>> respect
On Wed, Jan 16, 2013 at 6:18 AM, Christian König
wrote:
> From: Christian König
>
> Added with automake conversion, but makes no sense at all.
Not according to git...? See e3b2160a1ffcfba0ff60cb47c17bd1a41afb63db.
It looks like it was in the old Makefile too.
In fact, it looks like libdridrm ha
For the series: Reviewed-by: Marek Olšák
Marek
On Wed, Jan 16, 2013 at 4:58 PM, Brian Paul wrote:
> 1. Loop over multiple destination color buffers. If we set
> glDrawBuffers(GL_FRONT_AND_BACK) we need to loop over multiple color
> buffers, blitting to each.
>
> 2. Add checks for null src/dst
1. Loop over multiple destination color buffers. If we set
glDrawBuffers(GL_FRONT_AND_BACK) we need to loop over multiple color
buffers, blitting to each.
2. Add checks for null src/dst surface pointers. This fixes a crash
in the piglit fbo-missing-attachment-blit test.
See bug http://bugs.freed
Use the renderbuffer attachment pointers that we grabbed earlier.
---
src/mesa/state_tracker/st_cb_blit.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mesa/state_tracker/st_cb_blit.c
b/src/mesa/state_tracker/st_cb_blit.c
index 603c8d4..d6194bf 100644
--- a/s
---
src/mesa/main/formatquery.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c
index f08ab66..bd895e8 100644
--- a/src/mesa/main/formatquery.c
+++ b/src/mesa/main/formatquery.c
@@ -22,6 +22,7 @@
*/
#include
From: Adrian Marius Negreanu
this helps when compiling mesa for Android, but
the mesa sources resides outside of the Android tree.
Signed-off-by: Adrian Marius Negreanu
---
src/mapi/mapi/mapi_abi.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mapi/mapi/mapi_abi.py b
On 16.01.2013 15:27, Michel Dänzer wrote:
From: Michel Dänzer
Signed-off-by: Michel Dänzer
---
v2: Leave the target parameter unnamed to prevent noisy if harmless
build error messages.
For both patches:
Reviewed-by Christian König
lib/Target/R600/SIInstructions.td |6 +++---
li
On Mit, 2013-01-16 at 12:16 +0100, Christian König wrote:
> On 16.01.2013 10:42, Michel Dänzer wrote:
> > From: Michel Dänzer
> >
> >
> > Signed-off-by: Michel Dänzer
> > ---
> >
> > This is a prerequisite for patch 3 (and probably more similar changes in the
> > future). Unfortunately, it intro
From: Michel Dänzer
Signed-off-by: Michel Dänzer
---
v2: Leave the target parameter unnamed to prevent noisy if harmless
build error messages.
lib/Target/R600/R600Instructions.td |7 +++
lib/Target/R600/SIInstructions.td |6 ++
2 files changed, 13 insertions(+)
diff --git
From: Michel Dänzer
Signed-off-by: Michel Dänzer
---
v2: Leave the target parameter unnamed to prevent noisy if harmless
build error messages.
lib/Target/R600/SIInstructions.td |6 +++---
lib/Target/R600/SIIntrinsics.td |2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff
On Tuesday, January 15, 2013 02:05:00 PM Eric Anholt wrote:
> > +static void
> > +intel_image_set_level_info(__DRIimage *image, struct intel_mipmap_tree
> > *mt, + int level, int slice,
> > + uint32_t mask_x, uint32_t mask_y)
> > +{
> > + image
2013/1/16 Christian König :
> From: Christian König
>
> Added with automake conversion, but makes no sense at all.
>
> Signed-off-by: Christian König
Reviewed-by: Andreas Boll
> ---
> src/gallium/targets/vdpau-radeonsi/Makefile.am |1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src
From: Christian König
Added with automake conversion, but makes no sense at all.
Signed-off-by: Christian König
---
src/gallium/targets/vdpau-radeonsi/Makefile.am |1 -
1 file changed, 1 deletion(-)
diff --git a/src/gallium/targets/vdpau-radeonsi/Makefile.am
b/src/gallium/targets/vdpau-r
On 16.01.2013 11:55, Michel Dänzer wrote:
From: Michel Dänzer
Signed-off-by: Michel Dänzer
For this series: Reviewed-by: Christian König
---
src/gallium/drivers/radeonsi/si_state.c | 182 ---
1 file changed, 71 insertions(+), 111 deletions(-)
diff --git a/
On 16.01.2013 10:42, Michel Dänzer wrote:
From: Michel Dänzer
Signed-off-by: Michel Dänzer
---
This is a prerequisite for patch 3 (and probably more similar changes in the
future). Unfortunately, it introduces a couple of (non-fatal) error messages
such as below during the R600 target build.
On 16.01.2013 10:42, Michel Dänzer wrote:
From: Michel Dänzer
Signed-off-by: Michel Dänzer
Reviewed-by: Christian König
---
lib/Target/R600/SIIntrinsics.td |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/lib/Target/R600/SIIntrinsics.td b/lib/Target/R600/
From: Michel Dänzer
20-odd more piglits.
Signed-off-by: Michel Dänzer
---
src/gallium/drivers/radeonsi/si_state.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/gallium/drivers/radeonsi/si_state.c
index cc9f7ae..f
From: Michel Dänzer
About half a dozen more piglits.
Signed-off-by: Michel Dänzer
---
src/gallium/drivers/radeonsi/si_state.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/gallium/drivers/radeonsi/si_state.c
index 2ec8
From: Michel Dänzer
Instead of deriving it from the colour buffer formats only.
Fixes a number of piglit tests which export depth from the pixel shader.
Signed-off-by: Michel Dänzer
---
src/gallium/drivers/radeonsi/radeonsi_pipe.h |1 -
src/gallium/drivers/radeonsi/radeonsi_shader.c |
From: Michel Dänzer
Enabling it for all resources still seems to cause problems, but depth/stencil
buffers are always accessed with tiling by the DB block.
Signed-off-by: Michel Dänzer
---
src/gallium/drivers/radeonsi/r600_texture.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
From: Michel Dänzer
Signed-off-by: Michel Dänzer
---
src/gallium/drivers/radeonsi/si_state.c | 182 ---
1 file changed, 71 insertions(+), 111 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/gallium/drivers/radeonsi/si_state.c
index 2b574f3.
From: Michel Dänzer
Fixes piglit 'spec/ARB_depth_buffer_float/fbo-clear-formats stencil' crash.
Signed-off-by: Michel Dänzer
---
src/gallium/drivers/radeonsi/si_state.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/galli
From: Michel Dänzer
Signed-off-by: Michel Dänzer
---
src/gallium/drivers/radeonsi/radeonsi_shader.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c
b/src/gallium/drivers/radeonsi/radeonsi_shader.c
index 5dab46e..48433
From: Michel Dänzer
Signed-off-by: Michel Dänzer
---
lib/Target/R600/R600Instructions.td |7 +++
lib/Target/R600/SIInstructions.td |6 ++
2 files changed, 13 insertions(+)
diff --git a/lib/Target/R600/R600Instructions.td
b/lib/Target/R600/R600Instructions.td
index 64bab18..
From: Michel Dänzer
Signed-off-by: Michel Dänzer
---
This is a prerequisite for patch 3 (and probably more similar changes in the
future). Unfortunately, it introduces a couple of (non-fatal) error messages
such as below during the R600 target build. Tom or anyone, any ideas for
silencing thes
From: Michel Dänzer
Signed-off-by: Michel Dänzer
---
lib/Target/R600/SIIntrinsics.td |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/lib/Target/R600/SIIntrinsics.td b/lib/Target/R600/SIIntrinsics.td
index c322fef..0d1064e 100644
--- a/lib/Target/R600/SIIntrinsics
From: Johannes Obermayr
Reviewed-by: Andreas Boll
(cherry picked from commit ebcabb88cfd19b35cd1b0a327fa055fff0c1b2be)
Additionally it fixes the missing $(top_srcdir)/include in
src/glsl/tests/Makefile.am
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59383
---
src/glsl/tests/Makefile
https://bugs.freedesktop.org/show_bug.cgi?id=59383
Andreas Boll changed:
What|Removed |Added
Summary|src/glsl/tests/Makefile.am |src/glsl/tests/Makefile.am
On Tue, Jan 15, 2013 at 7:29 PM, Mike Lothian wrote:
> Silly question but what does:
>
> OpenGL context flags: (none)
> OpenGL core profile context flags: (none)
>
> Actually mean?
Check out context_flags_string() in the patch. The current options are
forward-compatible and robust-access.
___
68 matches
Mail list logo