[Mesa-dev] [PATCH] glu: src/libtess: memory has been freed using uninitialized pointer

2012-12-19 Thread Mike Gorchak
Hi ! I've attached the patch which fixes access to unitialized pointer during memory free operation. pqNewPriorityQ() function creates and setups PriorityQ structure, all except for the field "order". It is filled later in function pqInit(). Depending on vertices of polygon which must be tesselat

Re: [Mesa-dev] [PATCH] docs: Document spec quoting practices

2012-12-19 Thread Paul Berry
On 19 December 2012 15:46, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Cc: Paul Berry > Cc: Brian Paul > --- > docs/devinfo.html | 42 ++ > 1 file changed, 42 insertions(+) > > diff --git a/docs/devinfo.html b/docs/devinf

Re: [Mesa-dev] [PATCH 3/4] queryobj: Add IsQuery flag, making ISQuery() return false before BeginQuery()

2012-12-19 Thread Paul Berry
On 19 December 2012 20:17, Matt Turner wrote: > On Mon, Dec 17, 2012 at 2:24 PM, Carl Worth wrote: > > + GLboolean IsQuery; /**< query object is an actual query (see spec.) > */ > > I don't mean to bikeshed this, but I'm doing this patch for the other > Is* functions and I'm thinking that Is*

[Mesa-dev] [Bug 58548] [swrast] SIGSEGV src/mesa/swrast/s_texfetch.c:100

2012-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=58548 Vinson Lee changed: What|Removed |Added Keywords||have-backtrace --- Comment #1 from Vinson L

[Mesa-dev] When is a sampler object not a sampler object?

2012-12-19 Thread Matt Turner
The ES 3.0 and GL 3.3+ specs say: A new sampler object is created by binding an unused name to a texture unit. [...] The names are marked as used, for the purposes of GenSamplers only, but they acquire state only when they are first used as a parameter to BindSampler, SamplerParameter*, GetSampl

Re: [Mesa-dev] [PATCH] mesa: Use GL_RED for DEPTH_TEXTURE_MODE for everything but legacy GL.

2012-12-19 Thread Ian Romanick
On 12/19/2012 05:59 PM, Paul Berry wrote: On 19 November 2012 11:06, Kenneth Graunke mailto:kenn...@whitecape.org>> wrote: On 11/18/2012 05:43 PM, Ian Romanick wrote: On Nov 17, 2012, at 11:26 PM, Kenneth Graunke mailto:kenn...@whitecape.org>> wrote: According t

Re: [Mesa-dev] [PATCH 3/4] queryobj: Add IsQuery flag, making ISQuery() return false before BeginQuery()

2012-12-19 Thread Matt Turner
On Mon, Dec 17, 2012 at 2:24 PM, Carl Worth wrote: > + GLboolean IsQuery; /**< query object is an actual query (see spec.) */ I don't mean to bikeshed this, but I'm doing this patch for the other Is* functions and I'm thinking that Is* is a really bad name for this field. Vertex array objects

Re: [Mesa-dev] [PATCH 1/4] softpipe: Use os_time_get_nano() everywhere.

2012-12-19 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Thu, Dec 20, 2012 at 12:26 AM, wrote: > From: José Fonseca > > --- > src/gallium/drivers/softpipe/sp_query.c |8 > src/gallium/drivers/softpipe/sp_screen.c |2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff

Re: [Mesa-dev] [PATCH] mesa: Use GL_RED for DEPTH_TEXTURE_MODE for everything but legacy GL.

2012-12-19 Thread Paul Berry
On 19 November 2012 11:06, Kenneth Graunke wrote: > On 11/18/2012 05:43 PM, Ian Romanick wrote: > >> On Nov 17, 2012, at 11:26 PM, Kenneth Graunke >> wrote: >> >> According to page 163 of the ES 3.0 spec: >>> >>> "Texture lookups involving textures with depth component data generate >>> a textu

Re: [Mesa-dev] [PATCH] mesa: Allow glReadBuffer(GL_NONE) for winsys framebuffers.

2012-12-19 Thread Paul Berry
On 19 December 2012 16:36, Ian Romanick wrote: > On 12/19/2012 01:07 PM, Paul Berry wrote: > >> Previously, Mesa code assumed that glReadBuffer(GL_NONE) was only >> valid for user-created framebuffer objects. However, the spec is >> quite clear that is should also be valid for the default frameb

[Mesa-dev] [Bug 58548] New: [swrast] SIGSEGV src/mesa/swrast/s_texfetch.c:100

2012-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=58548 Priority: medium Bug ID: 58548 Keywords: regression CC: bri...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [swrast] SIGSEGV src/mesa/swrast/s_texfetch.c:100

Re: [Mesa-dev] [PATCH 3/8] egl/gbm: Implement EGL_EXT_buffer_age

2012-12-19 Thread Kristian Høgsberg
On Wed, Dec 19, 2012 at 11:17 PM, Eric Anholt wrote: > Kristian Høgsberg writes: > >> On Sat, Dec 15, 2012 at 2:44 AM, Kristian Høgsberg >> wrote: >>> On Fri, Dec 14, 2012 at 04:54:32PM -0800, Eric Anholt wrote: Kristian Høgsberg writes: > --- > src/egl/drivers/dri2/egl_dr

Re: [Mesa-dev] [PATCH] mesa: Allow glReadBuffer(GL_NONE) for winsys framebuffers.

2012-12-19 Thread Ian Romanick
On 12/19/2012 01:07 PM, Paul Berry wrote: Previously, Mesa code assumed that glReadBuffer(GL_NONE) was only valid for user-created framebuffer objects. However, the spec is quite clear that is should also be valid for the default framebuffer. From section 18.2.1 ("Obtaining Pixels from the Fram

[Mesa-dev] [Bug 58545] New: [llvmpipe] src/gallium/auxiliary/gallivm/lp_bld_tgsi_info.c:75:analyse_src: Assertion `src->Index < (sizeof(ctx->imm)/sizeof((ctx->imm)[0]))' failed.

2012-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=58545 Priority: medium Bug ID: 58545 Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] src/gallium/auxiliary/gallivm/lp_bld_tgsi_info.c:75:an alyse_src: Assert

Re: [Mesa-dev] [PATCH 3/4] mesa/st: Implement GL_TIME_ELAPSED w/ PIPE_QUERY_TIMESTAMP.

2012-12-19 Thread Brian Paul
On 12/19/2012 04:26 PM, jfons...@vmware.com wrote: From: José Fonseca ARB/EXT_timer_query's definition of GL_TIME_ELAPSED match precisely the subtraction of two GL_TIMESTAMP queries. And for a lot of drivers, that's precisely how they have to implement internally -- by emitting two hardware tim

Re: [Mesa-dev] [PATCH 2/4] gallium: s/PIPE_CAP_TIMER_QUERY/PIPE_CAP_QUERY_TIME_ELAPSED/

2012-12-19 Thread Brian Paul
On 12/19/2012 04:26 PM, jfons...@vmware.com wrote: From: José Fonseca To better reflect what it iis being advertised. iis -> is Reviewed-by: Brian Paul ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/li

Re: [Mesa-dev] [PATCH 3/4] queryobj: Add IsQuery flag, making ISQuery() return false before BeginQuery()

2012-12-19 Thread Carl Worth
Matt Turner writes: >> + if (q->IsQuery) >>return GL_TRUE; >> else >>return GL_FALSE; > > Just return q->IsQuery here? It's already declared as GLboolean. Yes, definitely. This code resulted from the squashing of two previous commits, so it wasn't as obvious as that when I w

Re: [Mesa-dev] [PATCH 4/4] i965: Force even an empty query to flush all previous queries.

2012-12-19 Thread Carl Worth
Ian Romanick writes: > Do we potentially have this same problem for timer queries? Quite possibly. I'll try to take a look at that as well. -Carl pgpRlUbqUVEKJ.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org ht

[Mesa-dev] [PATCH 11/11] mesa: Add extension tracking for {ARB, OES}_get_program_binary

2012-12-19 Thread Ian Romanick
From: Ian Romanick The ARB_get_program_binary spec says "OpenGL 3.0 is required." The nearly identical OES_get_program_binary extension is available for OpenGL ES 2.0, so I don't see how / why OpenGL 3.0 is a requirement for the ARB version. Let's just enable whenever GL_ARB_shader_objects is a

[Mesa-dev] [PATCH 10/11] mesa: Add GetProgramiv support for GL_PROGRAM_BINARY_LENGTH

2012-12-19 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/shaderapi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 39a883e..c7934d7 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c @@ -595,6 +595,

[Mesa-dev] [PATCH 09/11] mesa: Add Get support for PROGRAM_BINARY_FORMATS and NUM_PROGRAM_BINARY_FORMATS

2012-12-19 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/get_hash_params.py | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index 9f67466..c9717c1 100644 --- a/src/mesa/main/get_hash_params.py +++ b/src/mesa/mai

[Mesa-dev] [PATCH 08/11] mesa: Add tracking for GL_PROGRAM_BINARY_RETRIEVABLE_HINT state

2012-12-19 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/mtypes.h| 5 + src/mesa/main/shaderapi.c | 57 +++ 2 files changed, 62 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 097cdc1..1a2ed19 100644

[Mesa-dev] [PATCH 07/11] mesa: Emit errors for geometry shader enums when ARB_gs4 is not supported

2012-12-19 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/shaderapi.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 550018e..53f593a 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/me

[Mesa-dev] [PATCH 06/11] glapi: Emit dispatch for {ARB, OES}_get_program_binary

2012-12-19 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mapi/glapi/gen/ARB_get_program_binary.xml | 9 +++-- src/mesa/main/tests/dispatch_sanity.cpp | 19 +-- 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_get_program_binary.xml

[Mesa-dev] [PATCH 05/11] glapi: Remove spurious space from end of extension name

2012-12-19 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mapi/glapi/gen/ARB_get_program_binary.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_get_program_binary.xml b/src/mapi/glapi/gen/ARB_get_program_binary.xml index 7db1665..b268302 100644 --- a

[Mesa-dev] [PATCH 04/11] mesa: Add stub implementations of glGetProgramBinary and glProgramBinary

2012-12-19 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/shaderapi.c | 50 +++ src/mesa/main/shaderapi.h | 8 2 files changed, 58 insertions(+) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 19fa6fc..550018

[Mesa-dev] [PATCH 02/11] glapi: Reorder and clean up some of the includes and comments

2012-12-19 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mapi/glapi/gen/gl_API.xml | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index a47316a..6781067 100644 --- a/src/mapi/glapi/gen/gl_API.xml +++ b/s

[Mesa-dev] [PATCH 03/11] mesa: Fix the naming of _mesa_ProgramParameteriARB

2012-12-19 Thread Ian Romanick
From: Ian Romanick After recent changes in the XML, the dispatch generators will expect this function to be named _mesa_ProgramParameteri. Signed-off-by: Ian Romanick --- src/mesa/main/shaderapi.c | 4 ++-- src/mesa/main/shaderapi.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) d

[Mesa-dev] [PATCH 01/11] mesa: Fix GL_SHADER_BINARY_FORMATS query

2012-12-19 Thread Ian Romanick
From: Ian Romanick There were two bugs here. First, this and several other queries were not available in a desktop GL context with GL_ARB_ES2_compatibility. Second, GL_NUM_SHADER_BINARY_FORMATS returns zero, but GL_SHADER_BINARY_FORMATS writes one element of data to the buffer. If NUM is zero,

[Mesa-dev] [PATCH 00/11] Implement GL_ARB_get_program_binary

2012-12-19 Thread Ian Romanick
GL_ARB_get_program_binary is a required part of OpenGL ES 3.0, and this series impelments it for all Mesa drivers. We take the same approach of implementing the interface with zero binary formats that we take with GL_ARB_get_shader_binary / OpenGL ES 2.0. This series passes all of the GL_ARB_get_

Re: [Mesa-dev] [PATCH 3/4] queryobj: Add IsQuery flag, making ISQuery() return false before BeginQuery()

2012-12-19 Thread Carl Worth
Matt Turner writes: > The 4.2 and 4.3 specs say > > ... but no object is associated with them until the first time they > are used by BeginQuery, BeginQueryIndexed, or QueryCounter. > > BeginQuery vs BeginQueryIndexed are no problem, since _mesa_BeginQuery > internally is implemented with the -Ind

[Mesa-dev] [PATCH 9/9] intel: Enable GL_ARB_internalformat_query

2012-12-19 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_context.c | 23 +++ src/mesa/drivers/dri/intel/intel_extensions.c | 1 + 2 files changed, 24 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH 8/9] mesa: Add driver method to determine the possible sample counts

2012-12-19 Thread Ian Romanick
From: Ian Romanick Use this method in _mesa_GetInternalformativ for both GL_SAMPLES and GL_NUM_SAMPLE_COUNTS. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/driverfuncs.c | 1 + src/mesa/main/dd.h| 19 +++ src/mesa/main/formatquery.c | 20

[Mesa-dev] [PATCH 6/9] mesa: Add extension tracking bit for GL_ARB_internalformat_query

2012-12-19 Thread Ian Romanick
From: Ian Romanick Though, I'm tempted to always expose this extension when GL_ARB_framebuffer_object is exposed. In that case, it would share the same enable bit. Signed-off-by: Ian Romanick --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions

[Mesa-dev] [PATCH 7/9] mesa: Add dispatch and extension XML for GL_ARB_internalformat_query

2012-12-19 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mapi/glapi/gen/ARB_internalformat_query.xml | 21 + src/mapi/glapi/gen/gl_API.xml | 6 +++--- src/mapi/glapi/gen/gl_genexec.py| 1 + src/mesa/main/tests/dispatch_sanity.cpp |

[Mesa-dev] [PATCH 5/9] mesa: Add skeleton implementation of glGetInternalformativ

2012-12-19 Thread Ian Romanick
From: Ian Romanick This is for the GL_ARB_internalformat_query extension and GLES 3.0. Signed-off-by: Ian Romanick --- src/mesa/main/formatquery.c | 119 src/mesa/main/formatquery.h | 35 + src/mesa/sources.mak| 1 + 3 files c

[Mesa-dev] [PATCH 4/9] intel: Fix copy-and-paste bug setting gl_constants::MaxSamples

2012-12-19 Thread Ian Romanick
From: Ian Romanick gl_constants::MaxSamples is an integer, so setting it to 1.0 is just silly. Signed-off-by: Ian Romanick Reviewed-by: Kenneth Graunke Reviewed-by: Chris Forbes --- src/mesa/drivers/dri/intel/intel_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[Mesa-dev] [PATCH 3/9] mesa: Disallow R, RG, or RGB integer and unsigned formats in OpenGL ES 3.0

2012-12-19 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Reviewed-by: Marek Olšák Reviewed-by: Kenneth Graunke Reviewed-by: Eric Anholt --- src/mesa/main/fbobject.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index ab53b

[Mesa-dev] [PATCH 2/9] mesa: Disallow SNORM formats for renderbuffers in OpenGL ES

2012-12-19 Thread Ian Romanick
From: Ian Romanick v2: Move {RED,RG,RGB,RGBA}_SNORM changes from the previous commit to this commit. Based on suggestions from Ken. Signed-off-by: Ian Romanick Reviewed-by: Marek Olšák Reviewed-by: Kenneth Graunke Reviewed-by: Eric Anholt --- src/mesa/main/fbobject.c | 20 -

[Mesa-dev] [PATCH 1/9] mesa: Disallow deprecated SNORM formats for renderbuffers

2012-12-19 Thread Ian Romanick
From: Ian Romanick The OpenGL 3.2 core profile spec says: "The following base internal formats from table 3.11 are color-renderable: RED, RG, RGB, and RGBA. The sized internal formats from table 3.12 that have a color-renderable base internal format are also color-renderable. No

[Mesa-dev] [PATCH 0/9] Implement GL_ARB_internalformat_query

2012-12-19 Thread Ian Romanick
GL_ARB_internalformat_query is a required part of OpenGL ES 3.0, and this series impelments it in core Mesa and the i965 driver. Implementation for Gallium drivers should be trivial. With this series all of the GL_ARB_internalformat_query recently pushed to piglit pass *execpt* the SNORM part of

Re: [Mesa-dev] [PATCH] mesa: Allow glReadBuffer(GL_NONE) for winsys framebuffers.

2012-12-19 Thread Eric Anholt
Paul Berry writes: > Previously, Mesa code assumed that glReadBuffer(GL_NONE) was only > valid for user-created framebuffer objects. However, the spec is > quite clear that is should also be valid for the default framebuffer. > From section 18.2.1 ("Obtaining Pixels from the Framebuffer") of the

[Mesa-dev] [PATCH] docs: Document spec quoting practices

2012-12-19 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Cc: Paul Berry Cc: Brian Paul --- docs/devinfo.html | 42 ++ 1 file changed, 42 insertions(+) diff --git a/docs/devinfo.html b/docs/devinfo.html index 8f4aeef..eb4c897 100644 --- a/docs/devinfo.html +++ b/

Re: [Mesa-dev] [PATCH 1/4] softpipe: Use os_time_get_nano() everywhere.

2012-12-19 Thread Dave Airlie
Looks fine to me, Reviewed-by: Dave Airlie I'll let Marek look at the timer query stuff, he has a better idea how the drivers use it. On Thu, Dec 20, 2012 at 9:26 AM, wrote: > From: José Fonseca > > --- > src/gallium/drivers/softpipe/sp_query.c |8 > src/gallium/drivers/softpi

Re: [Mesa-dev] [PATCH 1/4] r600g: use r600_get_temp to get temporaries for CLIPDIST shader outputs

2012-12-19 Thread Dave Airlie
All 4 look good to me, Reviewed-by: Dave Airlie On Thu, Dec 20, 2012 at 2:24 AM, Marek Olšák wrote: > I need this to be able to use r600_get_temp in the function later. > --- > src/gallium/drivers/r600/r600_shader.c | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > >

[Mesa-dev] [PATCH 4/4] llvmpipe: Drop PIPE_QUERY_TIME_ELAPSED support.

2012-12-19 Thread jfonseca
From: José Fonseca It was slightly wrong: we were computing the longest duration of the query among all the rasterizer tasks. Regardless, for tile-based implementations such as llvmpipe, time differences will never be very useful, because rendering before/during/after the query is all interleave

[Mesa-dev] [PATCH 3/4] mesa/st: Implement GL_TIME_ELAPSED w/ PIPE_QUERY_TIMESTAMP.

2012-12-19 Thread jfonseca
From: José Fonseca ARB/EXT_timer_query's definition of GL_TIME_ELAPSED match precisely the subtraction of two GL_TIMESTAMP queries. And for a lot of drivers, that's precisely how they have to implement internally -- by emitting two hardware timestamp queries. So, to simplify driver implementati

[Mesa-dev] [PATCH 2/4] gallium: s/PIPE_CAP_TIMER_QUERY/PIPE_CAP_QUERY_TIME_ELAPSED/

2012-12-19 Thread jfonseca
From: José Fonseca To better reflect what it iis being advertised. --- src/gallium/docs/source/screen.rst |2 +- src/gallium/drivers/galahad/glhd_context.c |2 +- src/gallium/drivers/i915/i915_screen.c |2 +- src/gallium/drivers/llvmpipe/lp_screen.c |2 +- s

[Mesa-dev] [PATCH 1/4] softpipe: Use os_time_get_nano() everywhere.

2012-12-19 Thread jfonseca
From: José Fonseca --- src/gallium/drivers/softpipe/sp_query.c |8 src/gallium/drivers/softpipe/sp_screen.c |2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/softpipe/sp_query.c b/src/gallium/drivers/softpipe/sp_query.c index c173736..39

Re: [Mesa-dev] [PATCH 1/4] i965: Add perf debug for texture relayout.

2012-12-19 Thread Ian Romanick
Strong work. Series is Reviewed-by: Ian Romanick On 12/18/2012 01:35 PM, Eric Anholt wrote: Relayout is expensive, so it's something developers (both us and others) should know about when it happens. --- src/mesa/drivers/dri/intel/intel_tex_validate.c |5 + 1 file changed, 5 insert

Re: [Mesa-dev] [PATCH 2/2] r600g: texture buffer object + glsl 1.40 enable support

2012-12-19 Thread Tom Stellard
On Wed, Dec 19, 2012 at 02:07:22PM -0500, Jerome Glisse wrote: > On Wed, Dec 19, 2012 at 12:33 PM, Tom Stellard wrote: > > On Sun, Dec 16, 2012 at 08:33:23PM +1000, Dave Airlie wrote: > >> From: Dave Airlie > >> > >> This adds TBO support to r600g, and with GLSL 1.40 enabled, > >> we now get 3.1

Re: [Mesa-dev] [PATCH 6/6] mesa: Fix framebuffer blitting to GL_COLOR_ATTACHMENTi when i!=0

2012-12-19 Thread Anuj Phogat
On Tue, Dec 18, 2012 at 11:57 AM, Kenneth Graunke wrote: > On 12/17/2012 07:35 PM, Anuj Phogat wrote: >> >> This patch fixes a case when blitting to a framebuffer with >> renderbuffers/textures attached to GL_COLOR_ATTACHMENT{1, 2, ...}. >> Earlier we were incorrectly blitting to GL_COLOR_ATTACHME

Re: [Mesa-dev] [PATCH 3/8] egl/gbm: Implement EGL_EXT_buffer_age

2012-12-19 Thread Eric Anholt
Kristian Høgsberg writes: > On Sat, Dec 15, 2012 at 2:44 AM, Kristian Høgsberg > wrote: >> On Fri, Dec 14, 2012 at 04:54:32PM -0800, Eric Anholt wrote: >>> Kristian Høgsberg writes: >>> >>> > --- >>> > src/egl/drivers/dri2/egl_dri2.h |1 + >>> > src/egl/drivers/dri2/platform_drm.c |

Re: [Mesa-dev] [PATCH 3/5] glsl: Plumb through is_parameter to apply_type_qualifier_to_variable()

2012-12-19 Thread Matt Turner
On Wed, Dec 19, 2012 at 1:53 PM, Eric Anholt wrote: > Matt Turner writes: > >> On Wed, Dec 19, 2012 at 9:41 AM, Paul Berry wrote: >>> On 19 December 2012 09:13, Matt Turner wrote: On Wed, Dec 19, 2012 at 8:42 AM, Paul Berry wrote: > This patch adds logic to allow the ast_to

Re: [Mesa-dev] [PATCH 3/4] queryobj: Add IsQuery flag, making ISQuery() return false before BeginQuery()

2012-12-19 Thread Matt Turner
On Mon, Dec 17, 2012 at 2:24 PM, Carl Worth wrote: > + /* OpenGL 3.1 § 2.13 says about GenQueries, "These names are marked as > + * used, but no object is associated with them until the first time > they > + * are used by BeginQuery." Since our implementation actually does > +

Re: [Mesa-dev] [PATCH 3/5] glsl: Plumb through is_parameter to apply_type_qualifier_to_variable()

2012-12-19 Thread Eric Anholt
Matt Turner writes: > On Wed, Dec 19, 2012 at 9:41 AM, Paul Berry wrote: >> On 19 December 2012 09:13, Matt Turner wrote: >>> >>> On Wed, Dec 19, 2012 at 8:42 AM, Paul Berry >>> wrote: >>> > This patch adds logic to allow the ast_to_hir function >>> > apply_type_qualifier_to_variable() to tell

[Mesa-dev] [PATCH] mesa: Allow glReadBuffer(GL_NONE) for winsys framebuffers.

2012-12-19 Thread Paul Berry
Previously, Mesa code assumed that glReadBuffer(GL_NONE) was only valid for user-created framebuffer objects. However, the spec is quite clear that is should also be valid for the default framebuffer. >From section 18.2.1 ("Obtaining Pixels from the Framebuffer") of the GL 4.3 spec: "When REA

Re: [Mesa-dev] [PATCH 3/4] queryobj: Add IsQuery flag, making ISQuery() return false before BeginQuery()

2012-12-19 Thread Matt Turner
On Mon, Dec 17, 2012 at 2:24 PM, Carl Worth wrote: > This flag allows for the specified behavior that GenQueries reserves a name, > but does not associate an object with it until BeginQuery. We allocate the > object immediately with the new IsQuery flag set to false, and then set the > flag to tru

Re: [Mesa-dev] [PATCH 3/5] glsl: Plumb through is_parameter to apply_type_qualifier_to_variable()

2012-12-19 Thread Matt Turner
On Wed, Dec 19, 2012 at 9:41 AM, Paul Berry wrote: > On 19 December 2012 09:13, Matt Turner wrote: >> >> On Wed, Dec 19, 2012 at 8:42 AM, Paul Berry >> wrote: >> > This patch adds logic to allow the ast_to_hir function >> > apply_type_qualifier_to_variable() to tell whether it is acting on a >>

Re: [Mesa-dev] [PATCH 3/8] egl/gbm: Implement EGL_EXT_buffer_age

2012-12-19 Thread Kristian Høgsberg
On Sat, Dec 15, 2012 at 2:44 AM, Kristian Høgsberg wrote: > On Fri, Dec 14, 2012 at 04:54:32PM -0800, Eric Anholt wrote: >> Kristian Høgsberg writes: >> >> > --- >> > src/egl/drivers/dri2/egl_dri2.h |1 + >> > src/egl/drivers/dri2/platform_drm.c | 23 +++ >> > 2 fil

Re: [Mesa-dev] [PATCH 2/2] r600g: texture buffer object + glsl 1.40 enable support

2012-12-19 Thread Jerome Glisse
On Wed, Dec 19, 2012 at 12:33 PM, Tom Stellard wrote: > On Sun, Dec 16, 2012 at 08:33:23PM +1000, Dave Airlie wrote: >> From: Dave Airlie >> >> This adds TBO support to r600g, and with GLSL 1.40 enabled, >> we now get 3.1 core profiles advertised for r600g. >> >> This code is evergreen only so fa

Re: [Mesa-dev] [PATCH 4/4] i965: Assert that relayout laid out something that won't need it again.

2012-12-19 Thread Eric Anholt
Jordan Justen writes: > On Tue, Dec 18, 2012 at 1:35 PM, Eric Anholt wrote: >> The ETC1 changes failed at this, so let's make sure it will be caught in >> testing next time. >> --- >> src/mesa/drivers/dri/intel/intel_tex_validate.c |6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --

Re: [Mesa-dev] [PATCH 4/4] i965: Assert that relayout laid out something that won't need it again.

2012-12-19 Thread Jordan Justen
On Tue, Dec 18, 2012 at 1:35 PM, Eric Anholt wrote: > The ETC1 changes failed at this, so let's make sure it will be caught in > testing next time. > --- > src/mesa/drivers/dri/intel/intel_tex_validate.c |6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/mesa/drivers/dri/intel/

Re: [Mesa-dev] [PATCH 3/5] glsl: Plumb through is_parameter to apply_type_qualifier_to_variable()

2012-12-19 Thread Paul Berry
On 19 December 2012 09:13, Matt Turner wrote: > On Wed, Dec 19, 2012 at 8:42 AM, Paul Berry > wrote: > > This patch adds logic to allow the ast_to_hir function > > apply_type_qualifier_to_variable() to tell whether it is acting on a > > variable declaration or a function parameter. This will al

Re: [Mesa-dev] [PATCH 2/2] r600g: texture buffer object + glsl 1.40 enable support

2012-12-19 Thread Tom Stellard
On Sun, Dec 16, 2012 at 08:33:23PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This adds TBO support to r600g, and with GLSL 1.40 enabled, > we now get 3.1 core profiles advertised for r600g. > > This code is evergreen only so far, but I don't think there is > much to make it work on r600/

Re: [Mesa-dev] [PATCH] r600g: add cs tracing infrastructure for lockup pin pointing

2012-12-19 Thread Jerome Glisse
On Wed, Dec 19, 2012 at 12:17 PM, wrote: > From: Jerome Glisse > > It's a build time option you need to set R600_TRACE_CS to 1 and it > will print to stderr all cs along as cs trace point value which > gave last offset into a cs process by the GPU. > > Signed-off-by: Jerome Glisse For informat

[Mesa-dev] [PATCH] r600g: add cs tracing infrastructure for lockup pin pointing

2012-12-19 Thread j . glisse
From: Jerome Glisse It's a build time option you need to set R600_TRACE_CS to 1 and it will print to stderr all cs along as cs trace point value which gave last offset into a cs process by the GPU. Signed-off-by: Jerome Glisse --- src/gallium/drivers/r600/r600_hw_context.c | 41 ++

Re: [Mesa-dev] [PATCH 3/5] glsl: Plumb through is_parameter to apply_type_qualifier_to_variable()

2012-12-19 Thread Matt Turner
On Wed, Dec 19, 2012 at 8:42 AM, Paul Berry wrote: > This patch adds logic to allow the ast_to_hir function > apply_type_qualifier_to_variable() to tell whether it is acting on a > variable declaration or a function parameter. This will allow it to > correctly interpret the meaning of "out" and "

[Mesa-dev] [PATCH 1/5] mesa: Add ALIGN() macro to main/macros.h.

2012-12-19 Thread Paul Berry
Previously this macro existed in 3 separate places, some inside the intel driver and some outside of it. It makes more sense to have it in main/macros.h --- src/glsl/linker.cpp| 2 -- src/mesa/drivers/dri/i965/brw_context.h| 1 + src/mesa/drivers/dri/intel/intel_cont

[Mesa-dev] [PATCH 5/5] glsl: Pack flat "varyings" of mixed types together.

2012-12-19 Thread Paul Berry
This patch enhances the varying packing code so that flat varyings of uint, int, and float types can be packed together. We accomplish this in lower_packed_varyings.cpp by making the type of all flat varyings ivec4, and then using information-preserving type conversions (e.g. ir_unop_bitcast_f2i)

[Mesa-dev] [PATCH 4/5] glsl: Prohibit structs and bools from being used as "varyings".

2012-12-19 Thread Paul Berry
The GLSL 1.30 spec only allows vertex shader outputs and fragment shader inputs ("varyings" in pre-GLSL-1.30 parlance) to be of type int, uint, float, or vectors, matrices, or arrays thereof. Bools, bvec's, and structs are prohibited. (Integral varyings were prohibited prior to GLSL 1.30). Previ

[Mesa-dev] [PATCH 3/5] glsl: Plumb through is_parameter to apply_type_qualifier_to_variable()

2012-12-19 Thread Paul Berry
This patch adds logic to allow the ast_to_hir function apply_type_qualifier_to_variable() to tell whether it is acting on a variable declaration or a function parameter. This will allow it to correctly interpret the meaning of "out" and "in" keywords (which have different meanings in those two con

[Mesa-dev] [PATCH 4/4] r600g: refactor and make streamout dumping more informative

2012-12-19 Thread Marek Olšák
--- src/gallium/drivers/r600/r600_shader.c | 33 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 470a345..bca62ad 100644 --- a/src/gallium/drivers/r600/r600_sha

[Mesa-dev] [PATCH 3/4] r600g: try to fix streamout for the cases where BURST_COUNT > 0

2012-12-19 Thread Marek Olšák
The burst was incorrectly used, because ELEM_SIZE was always 0. I don't know if the burst works, because I don't know of any test which uses it. NOTE: This is a candidate for the stable branches. --- src/gallium/drivers/r600/r600_shader.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH 2/4] r600g: lower stream outputs with dst_offset < start_component

2012-12-19 Thread Marek Olšák
This fixes streamout breakage caused by the varying packing. --- src/gallium/drivers/r600/r600_shader.c | 54 +++- 1 file changed, 47 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 0ff

[Mesa-dev] [PATCH 1/4] r600g: use r600_get_temp to get temporaries for CLIPDIST shader outputs

2012-12-19 Thread Marek Olšák
I need this to be able to use r600_get_temp in the function later. --- src/gallium/drivers/r600/r600_shader.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index bcd43f1..0ffa1f

[Mesa-dev] [PATCH automake] gallium/drivers/radeon: Build it as module to fix egl_gallium.so.

2012-12-19 Thread Johannes Obermayr
Otherwise egl_gallium.so fails to load for all drivers if we build r600 and radeonsi together. --- Now we should be able to merge automake branch :) --- src/gallium/drivers/radeon/Makefile.am |9 + 1 Datei geändert, 9 Zeilen hinzugefügt(+) diff --git a/src/gallium/drivers/radeon/Make