Re: [Mesa-dev] gen7 hiz op fixes

On 02/08/2012 03:32 PM, Eric Anholt wrote: gen7 appears to be totally broken at the moment -- GL apps are GPU hanging, and I've been using piglit fdo23670-drawpix_stencil (approximately the first failing test) trying to track it down. Here are a couple of little fixes, but they don't actually fi

Re: [Mesa-dev] [PATCH 3/3] mesa: replace GET_SHINE_TAB_ENTRY() macro with an inline function

Hi Brian, On Wednesday, February 08, 2012 20:13:44 Brian Paul wrote: > --- > src/mesa/main/light.h| 32 +--- > src/mesa/tnl/t_rasterpos.c |3 +-- > src/mesa/tnl/t_vb_lighttmp.h | 27 +++ > 3 files changed, 25 insertions(+), 37

[Mesa-dev] [PATCH] gallivm: Change getExtent and readByte to non-const with llvm-3.1.

Fix build with llvm-3.1svn. llvm-3.1svn r149918 changed BufferMemoryObject::getExtent and BufferMemoryObject::readByte from const member functions to non-const member functions in include/llvm/Support/MemoryObject.h. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp |

[Mesa-dev] [PATCH] i965: Fix border color on Ironlake.

Ironlake appears to check our pointer against the General State Base Address upper bound, rather than ignoring the zero bound as it ought. Unfortunately, since we leave GSBA set to zero, there is no logical upper bound. Set it to the maximum possible value, which should work since our virtual add

[Mesa-dev] [PATCH 3/3] mesa: replace GET_SHINE_TAB_ENTRY() macro with an inline function

--- src/mesa/main/light.h| 32 +--- src/mesa/tnl/t_rasterpos.c |3 +-- src/mesa/tnl/t_vb_lighttmp.h | 27 +++ 3 files changed, 25 insertions(+), 37 deletions(-) diff --git a/src/mesa/main/light.h b/src/mesa/main/light.h index 2

[Mesa-dev] [PATCH 2/3] mesa: make _mesa_invalidate_shine_table() static

--- src/mesa/main/light.c | 13 + src/mesa/main/light.h |2 -- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/light.c b/src/mesa/main/light.c index 39a984b..a16d0e9 100644 --- a/src/mesa/main/light.c +++ b/src/mesa/main/light.c @@ -623,6 +623,11 @@ _

[Mesa-dev] [PATCH 1/3] mesa: remove gl_light::_SpotExpTable field

Just use pow() instead. Spot lights aren't too common and fixed-function lighting isn't as important as it used to me. This saves 32KB per context. Each table was 4KB and there's 8 lights. --- src/mesa/main/light.c| 52 +- src/mesa/main/light.h

[Mesa-dev] [PATCH] meta: replace abort() with _mesa_problem()

--- src/mesa/drivers/common/meta.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index aa5fef8..0cf1028 100644 --- a/src/mesa/drivers/common/meta.c +++ b/src/mesa/drivers/common/meta.c @@ -3029,7 +3029,8 @

[Mesa-dev] [PATCH 3/3] mesa: fix error handling in get_tex_rgba_compressed()

--- src/mesa/main/texgetimage.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index 8bbea83..a02a491 100644 --- a/src/mesa/main/texgetimage.c +++ b/src/mesa/main/texgetimage.c @@ -259,6 +259,8 @@ get_tex_rgba_com

[Mesa-dev] [PATCH 2/3] mesa: use _mesa_format_matches_format_and_type() in get_tex_memcpy()

--- src/mesa/main/texgetimage.c | 47 +- 1 files changed, 6 insertions(+), 41 deletions(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index a69c4ff..8bbea83 100644 --- a/src/mesa/main/texgetimage.c +++ b/src/mesa/main/texgetima

[Mesa-dev] [PATCH 1/3] mesa: push row stride adjustment down into _mesa_decompress_image()

There's a mismatch in row strides for compressed textures between what Driver.MapTextureImage() returns and what the software fetch-texel functions use. Move it down a layer. The next step would be to fix this in the fetch-texel functions. --- src/mesa/main/texcompress.c | 12 +++- src

Re: [Mesa-dev] gen7 hiz op fixes

On 02/08/2012 03:32 PM, Eric Anholt wrote: > gen7 appears to be totally broken at the moment -- GL apps are GPU > hanging, and I've been using piglit fdo23670-drawpix_stencil > (approximately the first failing test) trying to track it down. Here > are a couple of little fixes, but they don't actua

[Mesa-dev] [PATCH 5/6] egl/main: Convert to automake.

The drivers/ walk-through-subdirs makefile is converted as well so I didn't need to keep EGL_DRIVERS_DIRS along with the per-driver HAVE_EGL_DRIVER_WHATEVER. --- configs/autoconf.in |1 - configs/default |3 - configs/linux-dri |3 - conf

[Mesa-dev] [PATCH 2/6] egl: Drop _EGL_MAIN entrypoint obfuscation.

--- src/egl/drivers/dri2/Android.mk |1 - src/egl/drivers/dri2/Makefile |1 - src/egl/drivers/dri2/egl_dri2.c |2 +- src/egl/drivers/glx/Makefile|1 - src/egl/drivers/glx/egl_glx.c |2 +- 5 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/egl/drivers/dri

[Mesa-dev] [PATCH 1/6] glx: Convert to automake.

--- configure.ac|4 ++ src/glx/.gitignore |5 ++ src/glx/Makefile| 119 - src/glx/Makefile.am | 122 +++ src/mesa/Makefile |2 - 5 files changed, 131 insertions(+), 121 dele

[Mesa-dev] [PATCH 3/6] egl: Drop the non-builtin-drivers support.

The two drivers both did builtin mode, so drop the non-builtin build system. --- src/egl/drivers/Makefile.template | 30 ++ src/egl/drivers/dri2/Makefile |2 -- 2 files changed, 2 insertions(+), 30 deletions(-) diff --git a/src/egl/drivers/Makefile.template

[Mesa-dev] [PATCH 4/6] egl: Clean up some flow of EGL platform handling.

The default case code was set up in a separate way, while this makes it more normal. I wanted to add code to the explicit x11 platform and default x11 platform cases in the next commit. --- configure.ac | 33 +++-- 1 files changed, 15 insertions(+), 18 deletions(-)

[Mesa-dev] [PATCH 6/6] egl/drivers: Convert to automake.

--- configure.ac |2 + src/egl/drivers/Makefile.template | 40 src/egl/drivers/dri2/Makefile | 45 -- src/egl/drivers/dri2/Makefile.am | 62 + src/egl/drivers/glx/Makefile

[Mesa-dev] libGL and libEGL to automake

Here's a patch series for converting glx and egl to automake. I've tested the built EGL result for x11 platform (dri2 driver) mode with two configurations: one with the defaults (just x11 platform), and one with all the platforms enabled. I've also tested the wayland platform. I haven't tested t

Re: [Mesa-dev] [PATCH] configure.ac: Enable GLX_USE_TLS if possible.

On Wed, Feb 08, 2012 at 02:46:42PM -0800, Eric Anholt wrote: > On Wed, 8 Feb 2012 16:19:38 +0800, zhigang.g...@linux.intel.com wrote: > > From: Zhigang Gong > > > > If the system support tls, we prefer to enable it by default > > just as xserver does. Actually, the checking code is copied > > fr

Re: [Mesa-dev] [PATCH] mesa: enable remap table when --enable-shared-glapi

On Wed, Feb 8, 2012 at 8:19 PM, Brian Paul wrote: > On 02/08/2012 06:07 PM, Matt Turner wrote: >> >> On Wed, Feb 8, 2012 at 8:03 PM, Brian Paul  wrote: >>> >>> On 02/08/2012 05:39 PM, Matt Turner wrote: On Wed, Feb 8, 2012 at 7:30 PM, Brian Paul    wrote: > > > On 02/08/

Re: [Mesa-dev] [PATCH] mesa: enable remap table when --enable-shared-glapi

On 02/08/2012 06:07 PM, Matt Turner wrote: On Wed, Feb 8, 2012 at 8:03 PM, Brian Paul wrote: On 02/08/2012 05:39 PM, Matt Turner wrote: On Wed, Feb 8, 2012 at 7:30 PM, Brian Paulwrote: On 02/08/2012 09:48 AM, Matt Turner wrote: On Mon, Feb 6, 2012 at 12:05 PM, Matt Turner wrote:

Re: [Mesa-dev] [PATCH] mesa: enable remap table when --enable-shared-glapi

On Wed, Feb 8, 2012 at 8:03 PM, Brian Paul wrote: > On 02/08/2012 05:39 PM, Matt Turner wrote: >> >> On Wed, Feb 8, 2012 at 7:30 PM, Brian Paul  wrote: >>> >>> On 02/08/2012 09:48 AM, Matt Turner wrote: On Mon, Feb 6, 2012 at 12:05 PM, Matt Turner  wrote: > > > From

Re: [Mesa-dev] [PATCH] mesa: enable remap table when --enable-shared-glapi

On 02/08/2012 05:39 PM, Matt Turner wrote: On Wed, Feb 8, 2012 at 7:30 PM, Brian Paul wrote: On 02/08/2012 09:48 AM, Matt Turner wrote: On Mon, Feb 6, 2012 at 12:05 PM, Matt Turnerwrote: From: Chia-I Wu As libGL will use libglapi for function lookups, we need to enable the remap table.

Re: [Mesa-dev] [PATCH] mesa: enable remap table when --enable-shared-glapi

On Wed, Feb 8, 2012 at 7:30 PM, Brian Paul wrote: > On 02/08/2012 09:48 AM, Matt Turner wrote: >> >> On Mon, Feb 6, 2012 at 12:05 PM, Matt Turner  wrote: >>> >>> From: Chia-I Wu >>> >>> As libGL will use libglapi for function lookups, we need to enable the >>> remap >>> table. >>> >>> Tested-by: M

Re: [Mesa-dev] [PATCH] mesa: enable remap table when --enable-shared-glapi

On 02/08/2012 09:48 AM, Matt Turner wrote: On Mon, Feb 6, 2012 at 12:05 PM, Matt Turner wrote: From: Chia-I Wu As libGL will use libglapi for function lookups, we need to enable the remap table. Tested-by: Matt Turner Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=45660 --- configure.a

[Mesa-dev] [PATCH 2/2] i965/gen7: Fix the length of the MULTISAMPLE state packet in the HiZ metaop.

--- src/mesa/drivers/dri/i965/gen6_hiz.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_hiz.c b/src/mesa/drivers/dri/i965/gen6_hiz.c index 4a82d3d..a86c147 100644 --- a/src/mesa/drivers/dri/i965/gen6_hiz.c +++ b/src/mesa/drivers/dri/i965/g

[Mesa-dev] gen7 hiz op fixes

gen7 appears to be totally broken at the moment -- GL apps are GPU hanging, and I've been using piglit fdo23670-drawpix_stencil (approximately the first failing test) trying to track it down. Here are a couple of little fixes, but they don't actually fix the problem. _

[Mesa-dev] [PATCH 1/2] i965/gen7: Fix the length of the DS state packet in the HiZ metaop.

--- src/mesa/drivers/dri/i965/gen7_hiz.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_hiz.c b/src/mesa/drivers/dri/i965/gen7_hiz.c index 271e61e..1b5401f 100644 --- a/src/mesa/drivers/dri/i965/gen7_hiz.c +++ b/src/mesa/drivers/dri/i965/g

Re: [Mesa-dev] [PATCH] configure.ac: Enable GLX_USE_TLS if possible.

On Wed, 8 Feb 2012 16:19:38 +0800, zhigang.g...@linux.intel.com wrote: > From: Zhigang Gong > > If the system support tls, we prefer to enable it by default > just as xserver does. Actually, the checking code is copied > from xserver/configure.ac. > > Signed-off-by: Zhigang Gong > --- > confi

Re: [Mesa-dev] [PATCH] glx/dri2: use GLX prefix to enable INTEL_swap_event

On Feb 8, 2012 8:38 PM, "Chris Wilson" wrote: > > On Wed, 8 Feb 2012 19:49:54 +, Robert Bragg wrote: > > This adds the "GLX_" prefix to the string we pass to > > __glXEnableDirectExtension() otherwise it doesn't match the name we have > > in known_glx_extensions[] in glxextensions.c and does

Re: [Mesa-dev] [PATCH] glapi: Include GLES2 headers for ES2 extension functions

Yep, fixes the issue here. Tested-by: Lucas Stach Am Mittwoch, den 08.02.2012, 13:06 -0800 schrieb Ian Romanick: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > Does this patch fix the problem? It eliminates the warning here, but > I've never gotten the error. > > src/mapi/glap

[Mesa-dev] [PATCH] glapi: Include GLES2 headers for ES2 extension functions

From: Ian Romanick Signed-off-by: Ian Romanick --- Does this patch fix the problem? It eliminates the warning here, but I've never gotten the error. src/mapi/glapi/glapi_priv.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/mapi/glapi/glapi_priv.h b/src

Re: [Mesa-dev] [PATCH] glx/dri2: use GLX prefix to enable INTEL_swap_event

On Wed, 8 Feb 2012 19:49:54 +, Robert Bragg wrote: > This adds the "GLX_" prefix to the string we pass to > __glXEnableDirectExtension() otherwise it doesn't match the name we have > in known_glx_extensions[] in glxextensions.c and doesn't get enabled. > > This mistake wasn't noticed before

Re: [Mesa-dev] updating tex combine for frag program

On Wed, 8 Feb 2012 07:23:02 +, Dave Airlie wrote: > On Tue, Feb 7, 2012 at 10:09 PM, Ian Romanick wrote: > > On 02/07/2012 12:08 PM, Dave Airlie wrote: > >> > >> Hi guys, > >> > >> Is there any reason we need to update tex combiner state if we are > >> using shaders? > >> > >> can we drop upd

[Mesa-dev] [PATCH] i965/fs: Add support for MADs.

Improves nexuiz performance 0.65% +/- .10% (n=5) on my gen6. No statistically significant performance difference on warsow (n=5, but only one shader has MADs). v2: Add support for MADs in 16-wide by using compression control. --- src/mesa/drivers/dri/i965/brw_fs.h |1 + src/mesa/dr

[Mesa-dev] [PATCH] glx/dri2: use GLX prefix to enable INTEL_swap_event

This adds the "GLX_" prefix to the string we pass to __glXEnableDirectExtension() otherwise it doesn't match the name we have in known_glx_extensions[] in glxextensions.c and doesn't get enabled. This mistake wasn't noticed before since GLX_INTEL_swap_event was being implicitly enabled for GLX v1.

Re: [Mesa-dev] [PATCH 1/4] vbo: Remove pedantic warning about 'end' beind out of bounds.

On 02/08/2012 06:59 AM, Brian Paul wrote: On 02/08/2012 06:08 AM, Kenneth Graunke wrote: The application supplied [start, end] range is merely a conservative hint of the ranges of index values inside the index buffer. There is no requirement that all vertices in the range [start, end] be referen

Re: [Mesa-dev] [PATCH] autoconf: Enable missing-prototypes errors when available.

CC'ing Ian, as he was the one who added glDrawBuffersNV. The warning about the missing prototype was there for a long time. Only now with Werror=missing-prototypes it is fatal for the build. Am Dienstag, den 31.01.2012, 13:45 + schrieb Jon TURNEY: > On 27/01/2012 19:58, Eric Anholt wrote: > >

[Mesa-dev] [PATCH 1/4] vl: add a median filter for noise reduction

This is a shader based median filter, generally used for noise reduction, it could still need some improvements, but should usually work out of the box. Signed-off-by: Christian König --- src/gallium/auxiliary/Makefile.sources |1 + src/gallium/auxiliary/vl/vl_median_filter.c | 392 +++

[Mesa-dev] [PATCH 3/4] vl: add a matrix/convolution filter

Can be used for gaussian, mean, laplacian, emboss, sharpness... Signed-off-by: Christian König --- src/gallium/auxiliary/Makefile.sources |1 + src/gallium/auxiliary/vl/vl_matrix_filter.c | 313 +++ src/gallium/auxiliary/vl/vl_matrix_filter.h | 64 ++ 3 fi

[Mesa-dev] [PATCH 4/4] st/vdpau: use matrix filter to blur/sharpen video

Signed-off-by: Christian König --- src/gallium/state_trackers/vdpau/mixer.c | 78 -- src/gallium/state_trackers/vdpau/query.c |1 + src/gallium/state_trackers/vdpau/vdpau_private.h |9 ++- 3 files changed, 81 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH 2/4] st/vdpau: use median filter for noise reduction

And while at it implement the rest of the feature querying also. Signed-off-by: Christian König --- src/gallium/state_trackers/vdpau/mixer.c | 286 +- src/gallium/state_trackers/vdpau/query.c | 12 +- src/gallium/state_trackers/vdpau/vdpau_private.h | 10

Re: [Mesa-dev] [PATCH 3/4] vbo: Rework checking of 'end' against _MaxElement.

Am 08.02.2012 14:08, schrieb Kenneth Graunke: > This failed to take basevertex into account: > > If basevertex < 0: >(end + basevertex) might actually be in-bounds while 'end' is not. >We would have clamped in this case when we probably shouldn't. >This could break application drawing.

Re: [Mesa-dev] [PATCH 2/4] vbo: Ignore invalid element ranges where 'start' is past the end.

Am 08.02.2012 14:08, schrieb Kenneth Graunke: > Some applications, such as Regnum Online, appear to pass invalid > start/end values to glDrawRangeElements. In particular, the 'start' > index sometimes exceeds the maximum array element. This is clearly > invalid behavior, and although the spec isn

Re: [Mesa-dev] [PATCH] mesa: fixes for DrawRangeElements[BaseVertex] index validation

Am 08.02.2012 14:08, schrieb Kenneth Graunke: > On 02/05/2012 05:08 PM, Roland Scheidegger wrote: >> In vbo_exec_DrawRangeElementsBaseVertex, take into account the >> basevertex. >> As far as I can tell it is completely ok (though maybe stupid) to have >> start/end of 100/199, with _MaxElement bein

Re: [Mesa-dev] [PATCHv3] r600g: Use a fake reloc to sleep for fences

On Fre, 2012-02-03 at 17:32 +, Simon Farnsworth wrote: > r300g is able to sleep until a fence completes rather than busywait because > it creates a special buffer object and relocation that stays busy until the > CS containing the fence is finished. > > Copy the idea into r600g, and use it to

Re: [Mesa-dev] [PATCH] r600g: fix handling of outputs as TEX addr sources

On 08.02.2012 14:52, Alex Deucher wrote: 2012/2/6 Christian König: Outputs should be treated in the same way as inputs and temporaries here. Signed-off-by: Christian König Looks good. Should probably go to the 8.0 stable branch as well? Not necessarily, since its an optimization and not a re

Re: [Mesa-dev] [PATCH] mesa: enable remap table when --enable-shared-glapi

On Mon, Feb 6, 2012 at 12:05 PM, Matt Turner wrote: > From: Chia-I Wu > > As libGL will use libglapi for function lookups, we need to enable the remap > table. > > Tested-by: Matt Turner > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=45660 > --- >  configure.ac |    3 +++ >  1 files chang

Re: [Mesa-dev] [PATCH 6/9] gallivm: enable stores of integer types. (v2)

On 02/08/2012 05:17 AM, Dave Airlie wrote: From: Dave Airlie Infer from the operand the type of value to store. MOV is untyped but we use the float store path. v2: make MOV use float store path. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 47 +++

Re: [Mesa-dev] [PATCH] st/mesa: exit the update fragment samplers/textures loops early.

On 02/08/2012 07:28 AM, Dave Airlie wrote: From: Dave Airlie If we have no more enabled samplers and we've reset all the previously used ones, no need to keep going around this loop. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_atom_sampler.c | 12 src/mesa/state_t

Re: [Mesa-dev] [PATCH 4/4] vbo: Eliminate short-circuiting in invalid-start case.

On 02/08/2012 06:08 AM, Kenneth Graunke wrote: Now that we have a index_range_invalid flag, we can just use that rather than calling vbo_validated_drawrangeelements directly and returning. NOTE: This is a candidate for release branches. Signed-off-by: Kenneth Graunke --- src/mesa/vbo/vbo_exec

Re: [Mesa-dev] [PATCH 3/4] vbo: Rework checking of 'end' against _MaxElement.

On 02/08/2012 06:08 AM, Kenneth Graunke wrote: This failed to take basevertex into account: If basevertex< 0: (end + basevertex) might actually be in-bounds while 'end' is not. We would have clamped in this case when we probably shouldn't. This could break application drawing. If b

Re: [Mesa-dev] [PATCH 2/4] vbo: Ignore invalid element ranges where 'start' is past the end.

On 02/08/2012 06:08 AM, Kenneth Graunke wrote: Some applications, such as Regnum Online, appear to pass invalid start/end values to glDrawRangeElements. In particular, the 'start' index sometimes exceeds the maximum array element. This is clearly invalid behavior, and although the spec isn't cl

Re: [Mesa-dev] [PATCH 1/4] vbo: Remove pedantic warning about 'end' beind out of bounds.

On 02/08/2012 06:08 AM, Kenneth Graunke wrote: The application supplied [start, end] range is merely a conservative hint of the ranges of index values inside the index buffer. There is no requirement that all vertices in the range [start, end] be referenced. Passing an 'end' value larger than t

Re: [Mesa-dev] [PATCH] st/mesa: fixup NDEBUG vs DEBUG causing debug path to get taken.

On 02/08/2012 05:46 AM, Dave Airlie wrote: From: Dave Airlie From what I can see we were taking the debug path all the time, when we probably only want it for enable debug path. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_atom.c |6 +++--- 1 files changed, 3 insertions(+),

[Mesa-dev] [PATCH] st/mesa: exit the update fragment samplers/textures loops early.

From: Dave Airlie If we have no more enabled samplers and we've reset all the previously used ones, no need to keep going around this loop. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_atom_sampler.c | 12 src/mesa/state_tracker/st_atom_texture.c | 12 +---

Re: [Mesa-dev] Config fails on Radeon

On 02/08/2012 07:43 AM, Kenneth Graunke wrote: > On 02/08/2012 04:28 AM, Kevin H. Hobbs wrote: >> >> configure: error: Package requirements (libdrm_radeon>= 2.4.31) >> were not met: >> > > Does it work if you add --with-gallium-drivers='' as well? > It does. It also looks like --with-gallium-d

Re: [Mesa-dev] [PATCH] r600g: fix handling of outputs as TEX addr sources

2012/2/6 Christian König : > Outputs should be treated in the same way as > inputs and temporaries here. > > Signed-off-by: Christian König Looks good. Should probably go to the 8.0 stable branch as well? Reviewed-by: Alex Deucher > --- >  src/gallium/drivers/r600/r600_shader.c |    3 ++- >  

Re: [Mesa-dev] Print error message when switching to indirect rendering

On 06/02/2012 23:14, Carl Worth wrote: > On 2012-02-04, Jon TURNEY wrote: >> It looks like these error messages will always be emitted when >> software-direct >> and indirect are the only paths available (e.g. when ./configured with >> --with-dri-drivers=swrast or --disable-driglx-direct). > > Th

[Mesa-dev] [PATCH 3/4] vbo: Rework checking of 'end' against _MaxElement.

This failed to take basevertex into account: If basevertex < 0: (end + basevertex) might actually be in-bounds while 'end' is not. We would have clamped in this case when we probably shouldn't. This could break application drawing. If basevertex > 0: 'end' might be in-bounds while (en

[Mesa-dev] [PATCH 1/4] vbo: Remove pedantic warning about 'end' beind out of bounds.

The application supplied [start, end] range is merely a conservative hint of the ranges of index values inside the index buffer. There is no requirement that all vertices in the range [start, end] be referenced. Passing an 'end' value larger than the maximum legal index is perfectly acceptible; a

[Mesa-dev] [PATCH 4/4] vbo: Eliminate short-circuiting in invalid-start case.

Now that we have a index_range_invalid flag, we can just use that rather than calling vbo_validated_drawrangeelements directly and returning. NOTE: This is a candidate for release branches. Signed-off-by: Kenneth Graunke --- src/mesa/vbo/vbo_exec_array.c |6 +- 1 files changed, 1 insert

[Mesa-dev] [PATCH 2/4] vbo: Ignore invalid element ranges where 'start' is past the end.

Some applications, such as Regnum Online, appear to pass invalid start/end values to glDrawRangeElements. In particular, the 'start' index sometimes exceeds the maximum array element. This is clearly invalid behavior, and although the spec isn't clear, seems to result in undefined, implementation

Re: [Mesa-dev] [PATCH] mesa: fixes for DrawRangeElements[BaseVertex] index validation

On 02/05/2012 05:08 PM, Roland Scheidegger wrote: In vbo_exec_DrawRangeElementsBaseVertex, take into account the basevertex. As far as I can tell it is completely ok (though maybe stupid) to have start/end of 100/199, with _MaxElement being 100, if the basevertex is -100 (since the start/end are

[Mesa-dev] [PATCH] st/mesa: fixup NDEBUG vs DEBUG causing debug path to get taken.

From: Dave Airlie >From what I can see we were taking the debug path all the time, when we probably only want it for enable debug path. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_atom.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_t

Re: [Mesa-dev] Config fails on Radeon

On 02/08/2012 04:28 AM, Kevin H. Hobbs wrote: Config of the git repository fails because it can't find Radeon libraries This is despite the configure line being : ./autogen.sh \ --prefix=/home/kevin/mesa_xlib/ \ --disable-dri \ --enable-glx \ --enable-xlib-glx \ --disable-osmesa

[Mesa-dev] Config fails on Radeon

Config of the git repository fails because it can't find Radeon libraries This is despite the configure line being : ./autogen.sh \ --prefix=/home/kevin/mesa_xlib/ \ --disable-dri \ --enable-glx \ --enable-xlib-glx \ --disable-osmesa checking for RADEON... no configure: error: Package r

[Mesa-dev] [PATCH 7/9] gallivm: fetch immediates to correct type (v2)

From: Dave Airlie Fetch float/uint/int immediates. v2: bitcast to uint/int to floats as per Jose's suggestions. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 25 -- 1 files changed, 22 insertions(+), 3 deletions(-) diff --git a/src/gal

[Mesa-dev] [PATCH 9/9] gallivm: only use the mul/rcp for floats.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/gallium/auxiliary/gallivm/lp_bld_arit.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_arit.c b/src/gallium/auxiliary/gallivm/lp_bld_arit.c index a15dcb0..f3e8ae4 100644 --- a/s

[Mesa-dev] [PATCH 8/9] gallivm: use undef integer in broadcast.

From: Dave Airlie This adds an undefined int type and uses it for broadcasting instead of the float type. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/gallivm/lp_bld_swizzle.c | 15 +++ src/gallium/auxiliary/gallivm/lp_bld_type.c|1 + src/gallium/auxiliary/gallivm

[Mesa-dev] [PATCH 5/9] gallivm: enable fetch for integer opcodes. (v2)

From: Dave Airlie The infers the type of data required using the opcode, and casts the input to the appropriate type. So far this only handles non-indirect constant and temporaries. v2: as per Jose suggestion, fetch immediates via floats Signed-off-by: Dave Airlie --- src/gallium/auxiliary/g

[Mesa-dev] [PATCH 4/9] gallivm: add uint/int bld to the base builder. (v2)

From: Dave Airlie These are used inside the action handlers for the integer opcodes. v2: use uint_bld/int_bld, drop higher level uint_bld. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/gallivm/lp_bld_tgsi.h |6 +++--- src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c |2 ++ s

[Mesa-dev] [PATCH 6/9] gallivm: enable stores of integer types. (v2)

From: Dave Airlie Infer from the operand the type of value to store. MOV is untyped but we use the float store path. v2: make MOV use float store path. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 47 +-- 1 files changed, 43 insertions

[Mesa-dev] [PATCH 3/9] gallivm: fix build gather to take a bld context

From: Dave Airlie Then pass the correct build context to it. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c b/src/gallium/aux

[Mesa-dev] [PATCH 1/9] tgsi: add source/destination type from opcodes. (v2)

From: Dave Airlie These two functions produce the src/dst types for an opcode. MOV is special since it can be used to mov float->float and int->int, so just return VOID. v2: use a new enum for the opcode type as per Jose's suggestion. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi

[Mesa-dev] gallivm integer support base pieces v2

This is a second send of the gallivm integer opcode support. This doesn't add the opcodes yet, just sets the basic gallivm infrastructure changes that are needed to add the opcodes. I've gone with Jose's suggestion to make MOV use floats and cast the const vecs, his llvm-fu is way better than min

[Mesa-dev] [PATCH 2/9] gallivm: pass build context to exec_mask_store.

From: Dave Airlie For now just pass the current context, but when we want to store int or unsigned we need to pass those later. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/s

Re: [Mesa-dev] [PATCH] mesa: fixes for DrawRangeElements[BaseVertex] index validation

On 02/07/2012 05:18 PM, Roland Scheidegger wrote: Ping? I don't want to commit that without anyone looking at it. Sorry, got distracted the last few days. I'm planning to review this soon. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org htt

[Mesa-dev] [PATCH] configure.ac: Enable GLX_USE_TLS if possible.

From: Zhigang Gong If the system support tls, we prefer to enable it by default just as xserver does. Actually, the checking code is copied from xserver/configure.ac. Signed-off-by: Zhigang Gong --- configure.ac | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/