Re: [Mesa-dev] [PATCH] mesa: silence some compilation warnings.

2011-05-12 Thread zhigang gong
Thanks for your suggestion. Jose already revised my patch to use uintptr_t instead of long. On Fri, May 13, 2011 at 1:48 AM, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 05/12/2011 01:49 AM, zhigang gong wrote: >> glu.h: typedef void (GLAPIENTRYP _GLUfuncptr)(); ca

[Mesa-dev] [PATCH 11/11] i965: Instead of fallback on missing region, just bind a null renderbuffer.

2011-05-12 Thread Eric Anholt
The change for GPU hanging in 13bab58f04c1ec6d0d52760eab490a0997d9abe2 fell back even when rb == NULL, which is wrong for GLES2 and caused segfaulting in GLES2 conformance. For the GPU hang case (where the broken 2D driver failed to allocate a BO for the window system renderbuffer), it also would

[Mesa-dev] [PATCH 10/11] i965/gen6: Add support for point min/max size from ARB_point_parameters.

2011-05-12 Thread Eric Anholt
Fixes glean pointAtten. --- src/mesa/drivers/dri/i965/gen6_sf_state.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_sf_state.c b/src/mesa/drivers/dri/i965/gen6_sf_state.c index 50a5ad3..f96cfe5 100644 --- a/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 09/11] i965/fs: Don't emit a header on gen5+ sample messages unless required.

2011-05-12 Thread Eric Anholt
Improves glbenchmark egypt performance 0.6% +/- 0.4% (n=6). --- src/mesa/drivers/dri/i965/brw_fs.cpp | 26 +++--- 1 files changed, 19 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 126081b..d9ecc6

[Mesa-dev] [PATCH 07/11] i965: Add support for correct GL_CLAMP behavior by clamping coordinates.

2011-05-12 Thread Eric Anholt
This removes the stupid strict-conformance fallback code I broke when adding ARB_sampler_objects. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=36572 --- src/mesa/drivers/dri/i965/brw_draw.c | 36 src/mesa/drivers/dri/i965/brw_fs.cpp | 17

[Mesa-dev] [PATCH 08/11] i965/fs: Fix GPU hang on texture2d-bias on pre-Ironlake.

2011-05-12 Thread Eric Anholt
In the 16-wide rework, I missed that we were setting some things to be SIMD16 mode (corresponding to their setup in emit_texture_gen4()). --- src/mesa/drivers/dri/i965/brw_fs.cpp | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp

[Mesa-dev] [PATCH 06/11] i965/fs: Drop the viewport index/rtai clearing in gen6 fb writes.

2011-05-12 Thread Eric Anholt
These fields are documented to be in the payload, and though the FB write docs say they *aren't* in the payload, for all other fields the payload and header is structured so that no overwriting is required except for non-default options. --- src/mesa/drivers/dri/i965/brw_fs.cpp |6 -- 1 fi

[Mesa-dev] [PATCH 03/11] i965/gen6: Fix blending state when no color buffer is bound.

2011-05-12 Thread Eric Anholt
This is part of fixing fbo-alphatest-nocolor -- a regression in 35e8fe5c99b285f348cb8a1bba2931f120f7c0a1 after the initial regression, that had us using a garbage BLEND_STATE[0] (in particular, the alpha test enable) if no color buffer was bound. --- src/mesa/drivers/dri/i965/gen6_cc.c | 12

[Mesa-dev] [PATCH 04/11] i965/fs: Fix discard and alpha test in 16-wide.

2011-05-12 Thread Eric Anholt
As of gen6, alt-mode (which we use) MOVs of floats are not raw -- they'll modify infs/nans. This broke discard and alpha test in 16-wide, where apparently the upper 8 bits of the pixel enables being set were causing the whole value to get trashed upon being moved. Treating the values as UD instead

[Mesa-dev] [PATCH 01/11] i965/fs: Fix compiler warnings about dead code from 963431829055f63ec94d

2011-05-12 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 19 --- 1 files changed, 0 insertions(+), 19 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 21eb9e4..2e7f810 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++ b/src/mesa/

[Mesa-dev] [PATCH 02/11] i965/fs: Cut an instruction and a temporary from gen6 discard statements.

2011-05-12 Thread Eric Anholt
I thought I was thwarted initially when I couldn't do conditional mod on a MOV, and couldn't use two immediate constants in one instruction. But g0 != g0 is also a way to produce a failing comparison. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 53 +++-- src/mesa/drive

[Mesa-dev] [PATCH 05/11] i965/fs: Add support for "if" statements in 16-wide mode.

2011-05-12 Thread Eric Anholt
It turns out there's nothing in the hardware preventing this, it was just the lame backend we used to have. Improves glbenchmark Egypt framerate 4.4% +/- 0.3% (n=3), and Pro by 2.6% +/- 0.6% (n=3). --- src/mesa/drivers/dri/i965/brw_eu_emit.c |6 +- src/mesa/drivers/dri/i965/brw_fs.cpp

[Mesa-dev] [PATCH] r600g: reduce flushes so only when texture and CB overlap.

2011-05-12 Thread Dave Airlie
From: Dave Airlie We only need to do this when the texture and CB are using the same memory area. Signed-off-by: Dave Airlie --- src/gallium/winsys/r600/drm/r600_hw_context.c | 23 +++ src/gallium/winsys/r600/drm/r600_priv.h |2 ++ 2 files changed, 17 insertions

[Mesa-dev] [Bug 36651] mesa requires bison and flex to build but configure does not check for them

2011-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36651 Brian Paul changed: What|Removed |Added Attachment #46450|0 |1 is obsolete|

[Mesa-dev] [Bug 37150] sRGB textures are too bright in Starcraft 2

2011-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37150 --- Comment #1 from Pavel Ondračka 2011-05-12 14:16:44 PDT --- I forgot to mention: OpenGL renderer string: Gallium 0.4 on ATI RV530 OpenGL version string: 2.1 Mesa 7.11-devel (git-32a95cb) -- Configure bugmail: https://bugs.freedesktop.org/us

[Mesa-dev] [Bug 37150] New: sRGB textures are too bright in Starcraft 2

2011-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37150 Summary: sRGB textures are too bright in Starcraft 2 Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium

[Mesa-dev] [Bug 36738] Openarena crash with r300g, swrastg + llvm > 2.8

2011-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36738 --- Comment #21 from Iaroslav 2011-05-12 13:24:19 PDT --- > I've always used openarenа 0.8.1 from I've always used openarenа 0.8.1 from openarena.ws -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are rec

[Mesa-dev] [Bug 36738] Openarena crash with r300g, swrastg + llvm > 2.8

2011-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36738 --- Comment #20 from Iaroslav 2011-05-12 13:21:27 PDT --- (In reply to comment #19) > I have: > - setup a VM with > - single vcpu > - cpuid bits sse3, ssse3, sse4_1, and sse4_2 masked > - booted your ISO (both i686 and x86_64 versions) > - r

[Mesa-dev] [Bug 37147] Compile error in nouveau if --enable-shared-dricore is set

2011-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37147 Johannes Obermayr changed: What|Removed |Added Attachment #46645|text/x-log |text/plain mime type|

[Mesa-dev] [Bug 37147] New: Compile error in nouveau if --enable-shared-dricore is set

2011-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37147 Summary: Compile error in nouveau if --enable-shared-dricore is set Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: block

Re: [Mesa-dev] [PATCH] mesa: silence some compilation warnings.

2011-05-12 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/12/2011 01:49 AM, zhigang gong wrote: > glu.h: typedef void (GLAPIENTRYP _GLUfuncptr)(); causes the following >warning: function declaration isn't a prototype. > egl: When convert a (void *) to a int type, it's better to >conver

Re: [Mesa-dev] [PATCH] mesa: silence some compilation warnings.

2011-05-12 Thread Jose Fonseca
I agree with Patrick concerning the int casts. Zhigang, I've commited your changes have tweaking the int casts. Plus a few other warning fixes. I did only a test compile here, so let me know if I broke anything. Jose - Original Message - > I would be wary of assuming you can typec

Re: [Mesa-dev] threads and X.org/AIGLX drivers

2011-05-12 Thread Daniel Stone
On Thu, May 12, 2011 at 09:45:14AM -0400, Kristian Høgsberg wrote: > A different solution could be to use the input thread idea and stop > taking SIGIO. The input thread needs a lot of work though - we don't do any locking at all. So try doing device creation/destruction in a loop, or changing th

Re: [Mesa-dev] [PATCH] mesa: silence some compilation warnings.

2011-05-12 Thread Patrick Baggett
I would be wary of assuming you can typecast long -> pointer, or pointer -> long. On 64-bit Windows, sizeof(int) == sizeof(long) == 4 but sizeof(void*) == 8. On 64-bit Linux (gcc), sizeof(int) == 4, sizeof(long) == sizeof(void*) == 8. It would be better to use with uintptr_t -- it was designed to

Re: [Mesa-dev] threads and X.org/AIGLX drivers

2011-05-12 Thread Kristian Høgsberg
On Wed, May 11, 2011 at 2:53 AM, Dave Airlie wrote: > Hey, > > So we got a bug reported against F15 where we were getting an illegal > input event type 0, after passing it around the RH X team I eventually > came to look at it. > > The problem appears to be that we are using llvmpipe as our swrast

[Mesa-dev] [Bug 36738] Openarena crash with r300g, swrastg + llvm > 2.8

2011-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36738 --- Comment #19 from José Fonseca 2011-05-12 06:07:22 PDT --- I have: - setup a VM with - single vcpu - cpuid bits sse3, ssse3, sse4_1, and sse4_2 masked - booted your ISO (both i686 and x86_64 versions) - ran openarena 0.8.5 - tried all

[Mesa-dev] [PATCH] mesa: silence some compilation warnings.

2011-05-12 Thread zhigang gong
glu.h: typedef void (GLAPIENTRYP _GLUfuncptr)(); causes the following warning: function declaration isn't a prototype. egl: When convert a (void *) to a int type, it's better to convert to long firstly, otherwise in 64 bit envirnonment, it causes compilation warning. --- inc