Bo Peng wrote:
>> Index: frontends/gtk/lyx_gui.C
>> ===
>> Index: frontends/gt3/lyx_gui.C
>> ===
>> Index: frontends/xforms/lyx_gui.C
>> ==
Bo Peng wrote:
> Also, if -geometry is going to override everything, can not we do
>
> if (geometry option present) {
> width = -1;
> height = -1;
> start(... width, height, isMaximized)
> }
>
> Bo
>
>
I also thought about this, and I also preferred it first
because then I don't have to p
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Andre Poenitz wrote:
| > On Thu, Jun 15, 2006 at 12:39:32PM +0200, Abdelrazak Younes wrote:
| >> Minus potential compilation problems with gtk and/or xforms I think
| >> I am ready to merge my branch with trunk. Please fi
Peter Kümmel wrote:
Abdelrazak Younes wrote:
So Linux is faster on your machine than windows! That's a surprise since
many complained that it was damn slow on linux. Helge Hafting, you were
the more vocal among them ;-), could you try again?
Maybe he had used a non optimized build.
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Abdelrazak Younes wrote:
| > Andre Poenitz wrote:
| >> On Thu, Jun 15, 2006 at 12:39:32PM +0200, Abdelrazak Younes wrote:
| >>> Minus potential compilation problems with gtk and/or xforms I
| >>> think I am ready to merge
On Monday 19 June 2006 09:28, Abdelrazak Younes wrote:
> > No. Time.
>
> What does that that mean?
Give us (Lars ;-) time to see the changes. :-)
--
José Abílio
Jose' Matos wrote:
On Monday 19 June 2006 09:28, Abdelrazak Younes wrote:
No. Time.
What does that that mean?
Give us (Lars ;-) time to see the changes. :-)
I thought it meant "No. Period."
I have no problem with waiting but note that I've asked Lars multiple
times for comments and he _
Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
> Angus Leeming <[EMAIL PROTECTED]> writes:
> | Using boost::any closes that door.
> bs.
Sigh. Lars, you have this frustrating habit of posting a patch for some whizzy
new behaviour with absolutely minimal description of how you intend it to be
used,
Bo Peng wrote:
Abdel,
Attached patch adds
$BUILDDIR/config/config.h
$BUILDDIR/config/boost_config.h
with the following behaviors:
1. boost only uses boost_config.h
2. config.h includes boost_config.h
3. different builds have different config.h (nls etc may change from
build to build).
Tested
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>> Done. I propose this for trunk and 1.4 (Jean-Marc?), as it fixes a
>> rendering bug.
Martin> Committed for trunk. Jean-Marc?
OK.
JMarc
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> That looks all very nice Bo :-). I was very frustrated to
Abdelrazak> have to recompile everything when I switched compilers.
Abdelrazak> I'll try to test it sometime today.
It seems much safer to have two build trees
Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> That looks all very nice Bo :-). I was very frustrated to
Abdelrazak> have to recompile everything when I switched compilers.
Abdelrazak> I'll try to test it sometime today.
It seems much safe
Abdelrazak Younes wrote:
> Of course that's what I have (actually I have 4 build trees). The
> problem was that "config.h" was placed in the source tree. So does
> autotools IIRC.
No, it goes to the build tree with autotools, and scons should do the same.
Georg
Georg Baum wrote:
Abdelrazak Younes wrote:
Of course that's what I have (actually I have 4 build trees). The
problem was that "config.h" was placed in the source tree. So does
autotools IIRC.
No, it goes to the build tree with autotools, and scons should do the same.
I may have to check tha
Am Montag, 19. Juni 2006 11:50 schrieb Abdelrazak Younes:
> Jean-Marc Lasgouttes wrote:
> >> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> >
> > Abdelrazak> That looks all very nice Bo :-). I was very frustrated to
> > Abdelrazak> have to recompile everything when I switched c
Am Montag, 19. Juni 2006 12:02 schrieb Peter Kümmel:
> Am Montag, 19. Juni 2006 11:50 schrieb Abdelrazak Younes:
> > Jean-Marc Lasgouttes wrote:
> > >> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> > >
> > > Abdelrazak> That looks all very nice Bo :-). I was very frustrated to
"Bo Peng" <[EMAIL PROTECTED]> writes:
| > You can read about conventions in the GNU make manual
| >
http://www.sunsite.ualberta.ca/Documentation/Gnu/GNUinfo/html_node/standards_46.html
| >
http://www.sunsite.ualberta.ca/Documentation/Gnu/GNUinfo/html_node/standards_47.html
| >
| > Many unix admi
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Index: QLPainter.C
| ===
| --- QLPainter.C (revision 14065)
| +++ QLPainter.C (working copy)
| @@ -41,8 +41,13 @@
| }
|
| QLPainter::QLPainter(WorkArea * qwa)
| - : P
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> Am Sonntag, 18. Juni 2006 13:54 schrieb Uwe Stöhr:
>> Many thanks Georg for your prompt fix. Is it possible to patch also
>> the LyX 1.4 tree?
Georg> Of course. As always, Jean-Marc will tell if that is OK.
The path which is passed t
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Angus Leeming wrote:
| > Abdelrazak Younes wrote:
| >> Peter Kümmel wrote:
| >>> Abdelrazak Younes wrote:
| Please commit to "trunk" and...
| >
| >>> Do you think I could commit it now,
| >>> or should I wait for more comments?
| >
| >> I think
> "Uwe" == Uwe Stöhr <[EMAIL PROTECTED]> writes:
Uwe> Hello LyXers, I found two issues that should/could be fixed
Uwe> before LyX 1.4.2 comes out:
Uwe> - http://bugzilla.lyx.org/show_bug.cgi?id=2653 Simple fix for
Uwe> broken doc file
The fix to the tutorial is straightforward, but the same
"Bo Peng" <[EMAIL PROTECTED]> writes:
| > I just have to replace DEST_DIR with dest_dir right?
|
| Use DEST_DIR since I want to mimic autotools behavior. It might be
| better to allow both DEST_DIR and dest_dir though.
Then you should use DESTDIR...
--
Lgb
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> Here's the patch you've been looking for... it simplifies
Martin> things which is always a good sign.
Instead of using Wide(), isn't it possible to use display()?
I agree this is better, nevertheless.
JMarc
"Bo Peng" <[EMAIL PROTECTED]> writes:
| Dear all,
|
| I am also looking at msvc pch. I find that our source code does not
| really conform with the convention. Usually, we should have
|
| 1. pch.h (we have)
| 2. pch.cpp with
|#include
why?
| 3. every source file
| #include
no. (pch sh
"Bo Peng" <[EMAIL PROTECTED]> writes:
| > Does it make sense to sdd #include ?
|
| I do not understand why we do not add pch.h in all source files, and
| include pch.h only with pch=yes. I notice that, for example,
| src/mathed/pch.h does not really hold headers that all source files
| will use s
Angus Leeming <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
| > Angus Leeming <[EMAIL PROTECTED]> writes:
| > | Using boost::any closes that door.
| > bs.
|
| Sigh. Lars, you have this frustrating habit of posting a patch for some whizzy
| new behaviour with absol
Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
> Yes, but we have been through this ealier as well. Remember that this
> is not the first time I have posted the any patch.
Only vaguely (as in I remember a patch but not what it contained). It was about
a year ago, no? Judging from the comments of
On Mon, 2006-06-19 at 11:21 +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> >> Done. I propose this for trunk and 1.4 (Jean-Marc?), as it fixes a
> >> rendering bug.
>
> Martin> Committed for trunk. Jean-Marc?
>
> OK.
No.
I found a better w
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Index: QLPainter.C
| ===
| --- QLPainter.C (revision 14065)
| +++ QLPainter.C (working copy)
| @@ -41,8 +41,13 @@
| }
|
| QLPainter::QLPainte
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Angus Leeming wrote:
| > Abdelrazak Younes wrote:
| >> Peter Kümmel wrote:
| >>> Abdelrazak Younes wrote:
| Please commit to "trunk" and...
| >
| >>> Do you think I could commit it now,
| >>> or should I wait for mor
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Hello,
|
| Minus potential compilation problems with gtk and/or xforms I think I
| am ready to merge my branch with trunk. Please find attached the
| complete patch. I will wait for some green lights before applying.
|
| Abdel.
| Index: src/Buffer
Jean-Marc Lasgouttes wrote:
> The path which is passed to edit or view is of the internal type, I
> guess. Shouldn't we do something special before putting it on the
> command line?
Yes, we should. This was already wrong before (but will hurt more often with
the full path). I simply overlooked th
Juergen Spitzmueller wrote:
> I'm not really sure if we should provide a gui for that. I never seen
> someone using or proposing a value like "scaled=0.945", and in terms of
> the goal of this option (adjusting the font height to the roman one), I
> don't think this is needed (because the differen
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
|
| #include "frontends/Alert.h"
| +#include "frontends/Clipboard.h"
| #include "frontends/Dialogs.h"
| #include "frontends/FileDialog.h"
| #include "frontends/font_metrics.h"
| #include "frontends/LyXView.h"
| -#inc
On Mon, 2006-06-19 at 12:52 +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> Martin> Here's the patch you've been looking for... it simplifies
> Martin> things which is always a good sign.
>
> Instead of using Wide(), isn't it possible to use d
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > (and Qt3 AFAIC)
|
| As Far As I Can ... ?
As Far As I Care :-)
--
Lgb
Angus Leeming <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
| > Yes, but we have been through this ealier as well. Remember that this
| > is not the first time I have posted the any patch.
|
| Only vaguely (as in I remember a patch but not what it contained). It w
Bo Peng wrote:
Abdel,
Attached patch adds
$BUILDDIR/config/config.h
$BUILDDIR/config/boost_config.h
with the following behaviors:
1. boost only uses boost_config.h
2. config.h includes boost_config.h
3. different builds have different config.h (nls etc may change from
build to build).
Tested
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | |// Build temporary cursor.
| > | - cmd.y = min(max(cmd.y,-1), workarea().workHeight());
| > | + cmd.y = min(max(cmd.y,-1), workarea().height());
| > spacing
|
| You mean:
|
| cmd.y = min(max(cmd.y, -1), workarea().height());
|
Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
> Note that unicode is currently held up by the inability to send
> anything else than std::string as args to FuncRequest. (And I don't
> want to convert back and forth uft-8 <-> ucs-4 (or utf-16) all the
> time.)
> So I am currently stalled by boost
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| | > | + lyx::frontend::WorkArea * work_area_;
| | > Do we want bald pointers? Even just as cache?
| |
| | I can't use reference because I want to be able to change work_area_
| | at run-time. This work_area_ is not created nor deleted here s
Georg Baum wrote:
> It would only make sense with GUI support. If that would mean that a
> QSpinbox can't be used then I think it is not worth it.
There are plenty of (unofficial) QFloatSpinboxes around in the Web. Perhaps we
should just implement one of those (or derive our own) eventually, if t
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | + lyx::frontend::WorkArea * work_area_;
| > Do we want bald pointers? Even just as cache?
|
| I can't use reference because I want to be able to change work_area_
| at run-time. This work_area_ is not created
Lars Gullik Bjønnes wrote:
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| | > | +lyx::frontend::WorkArea * work_area_;
| | > Do we want bald pointers? Even just as cache?
| |
| | I can't use reference because I want to be able to change work_area_
| | at run-time. This work_area_ is not
Abdelrazak Younes wrote:
Bo Peng wrote:
Abdel,
Attached patch adds
$BUILDDIR/config/config.h
$BUILDDIR/config/boost_config.h
with the following behaviors:
1. boost only uses boost_config.h
2. config.h includes boost_config.h
3. different builds have different config.h (nls etc may change from
On 6/19/06, Abdelrazak Younes <[EMAIL PROTECTED]> wrote:
Abdelrazak Younes wrote:
> Bo Peng wrote:
>> Abdel,
>>
>> Attached patch adds
>>
>> $BUILDDIR/config/config.h
>> $BUILDDIR/config/boost_config.h
>>
>> with the following behaviors:
>> 1. boost only uses boost_config.h
>> 2. config.h include
Abdelrazak Younes wrote:
I have fixed with brute force the manifest problem. Feel free to find a
better solution.
Patch attached.
Sorry, this patch was against my branch. Please find attached the patch
against trunk.
Abdel.
Index: SConstruct
===
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
|
| > | > | + lyx::frontend::WorkArea * work_area_;
| > | > Do we want bald pointers? Even just as cache?
| > | | I can't use reference because I want to be able to cha
Bo Peng wrote:
intl should have its own config.h. Do you see that generated
(intl/config.h)
Yes it is in trunk/intl/config.h which is bad (see my other mail). The
problem lies in the include options I think.
One scenario this fails is that the first run does not have
gettext=included, s
Bo Peng wrote:
Abdel,
Attached patch adds
$BUILDDIR/config/config.h
$BUILDDIR/config/boost_config.h
with the following behaviors:
1. boost only uses boost_config.h
2. config.h includes boost_config.h
3. different builds have different config.h (nls etc may change from
build to build).
Tested
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
|
| > | > | + lyx::frontend::WorkArea * work_area_;
| > | > Do we want bald pointers? Even just as cache?
| > | | I can't use reference becaus
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> On Mon, 2006-06-19 at 12:52 +0200, Jean-Marc Lasgouttes wrote:
>> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>>
Martin> Here's the patch you've been looking for... it simplifies
Martin> things which is always a
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| UniqueGui
| UniqueGuiInstance
| GuiImplementation
| GuiInstance
| LarsGui
Ahh... you are tickling my ego.
| LyXGui
| GuiGui
| MyGui
| MyGuiIsBig
I think I liked 'GuiInstance'
| If you really insist I will use MainGui because the kernel won't see
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| Abdelrazak Younes <[EMAIL PROTECTED]> writes:
|
| | UniqueGui
| | UniqueGuiInstance
| | GuiImplementation
| | GuiInstance
| | LarsGui
|
| Ahh... you are tickling my ego.
|
| | LyXGui
| | GuiGui
| | MyGui
| | MyGuiIsBig
|
| I think I liked 'GuiI
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| UniqueGui
| UniqueGuiInstance
| GuiImplementation
| GuiInstance
| LarsGui
Ahh... you are tickling my ego.
;-)
| LyXGui
| GuiGui
| MyGui
| MyGuiIsBig
I think I liked 'GuiInstance'
Good.
| If you really insist I
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | LyXGui
| > | GuiGui
| > | MyGui
| > | MyGuiIsBig
| > I think I liked 'GuiInstance'
|
| Good.
|
| > | If you really insist I will use MainGui because the kernel won't
| > see
| > | it anyway and the rest will just use "theApp->gui()".
| > with q
Lars Gullik Bjønnes wrote:
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| Abdelrazak Younes <[EMAIL PROTECTED]> writes:
|
| | UniqueGui
| | UniqueGuiInstance
| | GuiImplementation
| | GuiInstance
| | LarsGui
|
| Ahh... you are tickling my ego.
|
| | LyXGui
| | GuiGui
| | MyGui
| | MyGuiI
On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote:
On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote:
On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote:
...
PS Getting rid of Wide() would only be possible if you have, inside
insettext, access to the _maximum_ left a
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | LyXGui
| > | GuiGui
| > | MyGui
| > | MyGuiIsBig
| > I think I liked 'GuiInstance'
|
| Good.
|
| > | If you really insist I will use MainGui because the kernel won't
| > see
| > | it anyway and the rest will just u
On Jun 17, 2006, at 12:55 PM, Juergen Spitzmueller wrote:
Please find attached the completed and fully functional version of
the font
selection rewrite (posted patch + working screen font family switch
+ scale
gui implementation + lyx2lyx from Georg (modified) + xforms & qt4
gui +
support
On Mon, Jun 19, 2006 at 02:28:31PM +0200, Georg Baum wrote:
> Jean-Marc Lasgouttes wrote:
>
> > The path which is passed to edit or view is of the internal type, I
> > guess. Shouldn't we do something special before putting it on the
> > command line?
>
> Yes, we should. This was already wrong be
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| > | Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | | | UniqueGui
| > | | UniqueGuiInstance
| > | | GuiImplementation
| > | | GuiInstance
| > | | LarsGui
| > | | Ahh
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | > | LyXGui
| > | > | GuiGui
| > | > | MyGui
| > | > | MyGuiIsBig
| > | > I think I liked 'GuiInstance'
| > | | Good.
| > | | > | If you really insist I will use MainGu
> "Massimiliano" == Massimiliano Sist <[EMAIL PROTECTED]> writes:
Massimiliano> Hi I'm an italian user of lyx. Sorry for my english. I
Massimiliano> find a possible bug in lyx 1.4.1. I use debian etch
Massimiliano> (testing). This error appear in italian version of lyx,
Massimiliano> but I tra
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
|
| This has nothing to do with the "theApp" global variable.
I have not mentioned TheApp one single time... only TheGui.
Man, we were talking about the "theApp" pointer! You were answering to
my remark:
| If you re
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| > | Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | | | UniqueGui
| > | | UniqueGuiInstance
| > | | GuiImplementation
| > | | GuiInstanc
I think that instead of config/ subdir, you should put
- boost_config.h in scons/build_dir/boost
- intl config.h in scons/build_dir/intl (instead of the source dir)
- lyx config.h in scons/build_dir/common
Sounds reasonable. I will do it.
Bo
Abdelrazak Younes wrote:
Bo Peng wrote:
intl should have its own config.h. Do you see that generated
(intl/config.h)
Yes it is in trunk/intl/config.h which is bad (see my other mail). The
problem lies in the include options I think.
Yes that's an include path problem. With the unpatched
Please find attached a patch for restore the old behaviour for gcc/debug
(by default we don't have debug libraries with mingw).
I will change the patch.
I have a problem with MSVC/debug. The binary complains about missing
MSVCP80D.dll. I think you have to link with QtCored4.dll.manifest and
Qt
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| | Index: src/frontends/gtk/GView.h
| | ===
| | --- src/frontends/gtk/GView.h (revision 14120)
| | +++ src/frontends/gtk/GView.h (working copy)
| | @@ -12,9 +12,12 @@
| | #
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > Then QtGui (Oh!)
|
| I really don't like it but that's the only thing that would please you Ok.
I am not sure that I like it either but I am also unsure if we are
discussing the same thing; ref other mail.
| We kind of agreed to stay wit
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > Then QtGui (Oh!)
|
| I really don't like it but that's the only thing that would please you Ok.
I am not sure that I like it either but I am also unsure if we are
discussing the same thing; ref other mail.
Bennett Helm wrote:
> Wow -- a very nice feature!
thanks.
> Of course, now that you've whetted my
> appetite, I want more.
>
> The standard TeX distributions on Mac now include support for various
> standard Mac fonts, such as Baskerville, Didot, Georgia, Hoefler,
> Gill Sans, Futura, Lucida Gr
and how will that change if you include pch.h in all the source files,
excepti being overly intrusive? or having some files compiled iwth pch
and some not...=?
I do not think this is a matter of intrusiveness.
By definition, PCH separates commonly used headers from all source
files, compile the
If I add /ID:\devel\lyx\GUI\src to it, it compiles fine.
Why intl needs to include $TOP_SRCDIR/src?
Bo
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| > | Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | | | UniqueGui
| > | | UniqueGuiInstance
| > | | GuiImplementation
| > | | GuiInstanc
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | Lars Gullik Bjønnes wrote:
| > | > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| > | > | Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | > | | | UniqueGui
| >
Bo Peng wrote:
If I add /ID:\devel\lyx\GUI\src to it, it compiles fine.
Why intl needs to include $TOP_SRCDIR/src?
This was with the version in trunk, that is before your config.h
separation. I guess that with your patch you need to add
$TOP_SRCDIR/intl to the include path.
Abdel.
"Bo Peng" <[EMAIL PROTECTED]> writes:
| > and how will that change if you include pch.h in all the source files,
| > excepti being overly intrusive? or having some files compiled iwth pch
| > and some not...=?
|
| I do not think this is a matter of intrusiveness.
| By definition, PCH separates
On Mon, Jun 19, 2006 at 04:16:20PM +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> Martin> On Mon, 2006-06-19 at 12:52 +0200, Jean-Marc Lasgouttes wrote:
> >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
> >>
> Martin> Here's t
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| By the way, this is written nowhere and I had the impression that
| "gui_instance_" style was the rule in the current code. Could you
| confirm that please because I used the "gui_instance_" style
| everywhere already :
Abdelrazak Younes wrote:
Really if you look at current source code it is mostly this style:
class ThisIsOneClass
{
void thisIsOneMethod(OneType one_type);
OneType one_type_;
}
I think this coding style is nice as it is not misleading. So either we
update the code rules or we change t
some sourcefiles will get includes
they strictly speaking did not need.
That is what I meant. our pch.h contains headers that are not commonly
used. (and in pch mode, they are included.)
| In pch mode,
| --include=pch.h is passed. This will *not* work with msvc since msvc
| scans source file f
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
|
| > | By the way, this is written nowhere and I had the impression that
| > | "gui_instance_" style was the rule in the current code. Could you
| > | confirm that please
Hello,
With this patch I am satisfying Lars desiderata. The only remaining
issue is the naming of the TheGui class. Lars, could you please make up
your mind about that: MainGui, QtGui, GuiInstance ?
Abdel.
Log:
* Use work_area_ member instead of workarea() access method.
* Correct some spaci
"Bo Peng" <[EMAIL PROTECTED]> writes:
| > some sourcefiles will get includes
| > they strictly speaking did not need.
|
| That is what I meant. our pch.h contains headers that are not commonly
| used. (and in pch mode, they are included.)
Then they should be regenerated/reviewed.
| > | In pch m
On Mon, Jun 19, 2006 at 10:44:27AM -0400, Bennett Helm wrote:
> On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote:
...
> >Here's the patch you've been looking for... it simplifies things which
> >is always a good sign.
>
> This is much faster on Mac than the previous patches, but still a bit
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| I need good examples to understand this properly.
|
|
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_PREDIR_hdrstop.asp
|
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vccore/html/_core_.2f.yc.a
On Sat, Jun 17, 2006 at 08:52:12AM +0200, Abdelrazak Younes wrote:
> Andre Poenitz wrote:
> >On Thu, Jun 15, 2006 at 12:39:32PM +0200, Abdelrazak Younes wrote:
> >>Minus potential compilation problems with gtk and/or xforms I think I am
> >>ready to merge my branch with trunk. Please find attached
On Sat, Jun 17, 2006 at 09:15:01AM -, [EMAIL PROTECTED] wrote:
> Author: younes
> Date: Sat Jun 17 11:14:58 2006
> New Revision: 14136
>
> Log:
> Those classes (and their associated [Ch] files) are renamed :
>
> QLAction -> Action
> lcolorcache -> ColorCache
> qfont_loader.C -> FontLoader
Go
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
|
| Do you mean this one:
|
| > - Long variables are named like thisLongVariableName.
|
| So without the trailing underscore then?
No.
Private class member variables get a _ at the end.
Where is that wr
| That is what I meant. our pch.h contains headers that are not commonly
| used. (and in pch mode, they are included.)
Then they should be regenerated/reviewed.
I actually only looked at src/mathed/pch.h. But if pch.h indeed has
headers that are commonly included, why not include it and remove
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Hello,
|
| With this patch I am satisfying Lars desiderata. The only remaining
| issue is the naming of the TheGui class. Lars, could you please make
| up your mind about that: MainGui, QtGui, GuiInstance ?
Hmm da hmm
class GuiImplementation :
Feels that some intrusiveness is required to make this work...
We should try hard to avoid that.
According to the link I sent to you, the best solution, as far as I know, is
1. make pch.h contains commonly used header files
2. include pch.h in all source files
3. have a pch.cpp with #include p
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Hello,
|
| With this patch I am satisfying Lars desiderata. The only remaining
| issue is the naming of the TheGui class. Lars, could you please make
| up your mind about that: MainGui, QtGui, GuiInstance ?
Hmm da hmm.
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | | Do you mean this one:
| > | | > - Long variables are named like thisLongVariableName.
| > | | So without the trailing underscore then?
| > No. Private cla
On Jun 19, 2006, at 12:36 PM, Martin Vermeer wrote:
On Mon, Jun 19, 2006 at 10:44:27AM -0400, Bennett Helm wrote:
On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote:
...
Here's the patch you've been looking for... it simplifies things
which
is always a good sign.
This is much faster on M
"Bo Peng" <[EMAIL PROTECTED]> writes:
| > | stdafx.h contains all commonly used headers. msvc knows from a
| > | compiler flag (or by default) that stdafx.h (stopping header) is
| > | pre-processed and skip it.
| >
| > Use #pragma hdrstop instead.
|
| We do not have this in .C either.
This would
"Bo Peng" <[EMAIL PROTECTED]> writes:
| > Feels that some intrusiveness is required to make this work...
| > We should try hard to avoid that.
| >
|
| According to the link I sent to you, the best solution, as far as I know, is
|
| 1. make pch.h contains commonly used header files
| 2. include p
| As I have said, I see no reason why
| not include pch.h.
I do.
by adding pch.h and removing the now duplicated headers you no longer
have control over the actually required headers for that particular
source file.
I still do not get it. pch.h has only headers that are needed for
every source
1 - 100 of 136 matches
Mail list logo
