Martin Vermeer wrote:
> Hmmm. Both will be optimized... but which of the two boolean
> expressions is most often false? That one should come first.
> I really wouldn't know.
I believe that they will generate identical assembly code, with or
without optimisation. As I said, "Truly minor".
--
Ang
On Mon, Oct 06, 2003 at 12:48:40PM +0100, Angus Leeming spake thusly:
>
> Martin Vermeer wrote:
> > OK, attached the patch that I intend to commit this evening if no
> > grave objections are brought forward. It differs only cosmetically
> > from the previous one (order of initializers in InsetBoxP
Martin Vermeer wrote:
> OK, attached the patch that I intend to commit this evening if no
> grave objections are brought forward. It differs only cosmetically
> from the previous one (order of initializers in InsetBoxParams c'tor
> to get rid of warnings; use empty string instead of misleading "box
On Thu, Oct 02, 2003 at 09:50:34PM +, Angus Leeming spake thusly:
>
> Martin Vermeer wrote:
>
> >> xforms/Dialogs.C is my code that happens to use a different string label
> >> to ascertain which dialog to open.
> >
> > Yes, but where is it actually set?
>
> Remember this?
> string InsetBo
Martin Vermeer wrote:
>> xforms/Dialogs.C is my code that happens to use a different string label
>> to ascertain which dialog to open.
>
> Yes, but where is it actually set?
Remember this?
string InsetBoxMailer::name_ = "box";
> And (I believe unrelatedly) where does my above "box" go to?
>
On Thu, Oct 02, 2003 at 04:46:31PM +, Angus Leeming spake thusly:
> Martin Vermeer wrote:
>
> >> Ain't this "Boxed"? (That's why using the enum is safer...)
> >>
> >> src/frontends/controllers/ControlBox.C
> >> +bool ControlBox::initialiseParams(string const & data)
> >> +{
> >> + Ins
Martin Vermeer wrote:
>> Ain't this "Boxed"? (That's why using the enum is safer...)
>>
>> src/frontends/controllers/ControlBox.C
>> +bool ControlBox::initialiseParams(string const & data)
>> +{
>> + InsetBoxParams params("box");
>
> I'm not sure if it's actually used. But look at xforms/D
On Thu, Oct 02, 2003 at 04:18:19PM +, Angus Leeming spake thusly:
>
> Martin Vermeer wrote:
> > Okay, here is then my latest. Anything left to do with this except
> > committing?
>
> Ain't this "Boxed"? (That's why using the enum is safer...)
>
> src/frontends/controllers/ControlBox.C
> +boo
Martin Vermeer wrote:
> Okay, here is then my latest. Anything left to do with this except
> committing?
Ain't this "Boxed"? (That's why using the enum is safer...)
src/frontends/controllers/ControlBox.C
+bool ControlBox::initialiseParams(string const & data)
+{
+ InsetBoxParams params("box
On Wed, Oct 01, 2003 at 04:01:26PM +, Angus Leeming spake thusly:
>
> >> You must be sick to the back teeth of my suggestions ;-)
> > Yes. That's why I'll leave a little for you ;-)
>
> Hmpfff!
>
> --
> Angus
Okay, here is then my latest. Anything left to do with this except
committing?
-
Martin Vermeer wrote:
>> What's wrong with
>> InsetBox::Params::Params(string const & label);
>
> Don't understand.
I meant that this is nasty:
InsetBox::InsetBox(BufferParams const & bp, string const & label)
: InsetCollapsable(bp)
{
params_.type = label;
}
And should b
On Wed, Oct 01, 2003 at 02:09:24PM +, Angus Leeming spake thusly:
> Martin Vermeer wrote:
> [A lot. You've been busy!]
>
> >> This stuff belongs in the InsetBoxParams constructor.
> >> Index: src/insets/insetbox.C
> >> +InsetBox::InsetBox(BufferParams const & bp, string const & label)
> >> +
Martin Vermeer wrote:
[A lot. You've been busy!]
>> This stuff belongs in the InsetBoxParams constructor.
>> Index: src/insets/insetbox.C
>> +InsetBox::InsetBox(BufferParams const & bp, string const & label)
>> + : InsetCollapsable(bp)
>> +{
>> + params_.type = label;
>> + params
On Wed, Oct 01, 2003 at 04:02:19PM +0300, Martin Vermeer wrote:
> See attached (and it still works!). Sorry for the added files
> separately, this is my read-only CVS tree using gcc3.
Starts to look ok.
I wonder a bit what the benefit of the string creations in
int j = fl_get_choice(dia
On Tue, Sep 30, 2003 at 03:42:12PM +, Angus Leeming spake thusly:
>
> Martin Vermeer wrote:
>
> > On Mon, Sep 29, 2003 at 09:47:17AM +0100, Angus Leeming spake thusly:
> >
> > Next version. Hit it hard. Unless bad bugs come up, I think this is
> > about ready to go in.
>
> > BTW I think th
On Wednesday 01 October 2003 9:06 am, Martin Vermeer wrote:
> > Do you need the '[0]' bit. Suggests a broken data file.
> > + hor_pos = lex.getString()[0];
>
> I need the first and only char from this string. Do you know a better
> (cleaner/...) way?
My misunderstanding. Mayb
On Tue, Sep 30, 2003 at 03:42:12PM +, Angus Leeming spake thusly:
...
> Really?
> Index: src/frontends/controllers/ControlBox.C
> Index: src/frontends/controllers/ControlBox.h
> + * \author Angus Leeming
I copied/adapted it from Note, which has your pugmark on it.
...
> Replace this
> +i
On Tuesday 30 September 2003 21:56, Garst R. Reese wrote:
>
> You disagree with?
> A. BTW
> B. That's
> C. Yes
> ?
Do I have multiple choices? ;-)
I disagree with Martin when we says "Yes, I am behind the times." since we
gave us new toys^H^Hols... ;-)
> Garst
--
José Abílio
Jose' Matos wrote:
>
> On Tuesday 30 September 2003 15:59, Martin Vermeer wrote:
> >
> > > > BTW I think this should replace the existing minipage, which means
> > > > reLyX should be adapted to convert the old docs.
> > >
> > > That's lyx2lyx business.
> >
> > Yes, I am behind the times.
>
> I
Kornel Benko wrote:
> I vote pro, if I am alloved to.
Of course you're allowed to ;-)
--
Angus
-BEGIN PGP SIGNED MESSAGE-
On Dienstag, 30. September 2003 16:04, Martin Vermeer wrote:
> On Mon, Sep 29, 2003 at 09:47:17AM +0100, Angus Leeming spake thusly:
>
> Next version. Hit it hard. Unless bad bugs come up, I think this is
> about ready to go in.
I like it. Only the yet missing b
On Tuesday 30 September 2003 15:59, Martin Vermeer wrote:
>
> > > BTW I think this should replace the existing minipage, which means
> > > reLyX should be adapted to convert the old docs.
> >
> > That's lyx2lyx business.
>
> Yes, I am behind the times.
I am sorry but I disagree here, and as me o
Martin Vermeer wrote:
> On Mon, Sep 29, 2003 at 09:47:17AM +0100, Angus Leeming spake thusly:
>
> Next version. Hit it hard. Unless bad bugs come up, I think this is
> about ready to go in.
> BTW I think this should replace the existing minipage
stdmenus.ui will need the minipage entry removed
On Tue, Sep 30, 2003 at 03:59:52PM +0200, Andre Poenitz spake thusly:
> On Tue, Sep 30, 2003 at 05:04:58PM +0300, Martin Vermeer wrote:
> > On Mon, Sep 29, 2003 at 09:47:17AM +0100, Angus Leeming spake thusly:
> >
> > Next version. Hit it hard. Unless bad bugs come up, I think this is
> > about
On Tuesday 30 September 2003 14:59, Andre Poenitz wrote:
>
> > BTW I think this should replace the existing minipage, which means
> > reLyX should be adapted to convert the old docs.
>
> That's lyx2lyx business.
Agreed. We don't need to touch reLyX for it to work.
> Andre'
--
José Abílio
LyX
On Tue, Sep 30, 2003 at 05:04:58PM +0300, Martin Vermeer wrote:
> On Mon, Sep 29, 2003 at 09:47:17AM +0100, Angus Leeming spake thusly:
>
> Next version. Hit it hard. Unless bad bugs come up, I think this is
> about ready to go in.
This looks... erm... sub-optimal.
int InsetBox::linuxd
On Mon, Sep 29, 2003 at 09:47:17AM +0100, Angus Leeming spake thusly:
Next version. Hit it hard. Unless bad bugs come up, I think this is
about ready to go in.
BTW I think this should replace the existing minipage, which means
reLyX should be adapted to convert the old docs.
- Martin
--
Marti
On Mon, Sep 29, 2003 at 09:47:17AM +0100, Angus Leeming spake thusly:
>
> Martin Vermeer wrote:
>
> > Here it is... works for me. All of parbox/minipage and all the
> > fancybox standard boxes implemented. (And yes Jean-Marc, you *can*
> > draw a square frame around something :-)
> >
> > For you
On Mon, Sep 29, 2003 at 12:35:24PM +0300, Martin Vermeer wrote:
> Thanks... this and a few others fixed.
>
> > Andre'
>
> Are we in nitpicking mode already? I suppose that's a good sign :-)
No, that's what usually puts me off when reading patches.
Andre'
On Mon, Sep 29, 2003 at 09:44:46AM +0200, Andre Poenitz spake thusly:
> On Sat, Sep 27, 2003 at 11:02:39AM +0300, Martin Vermeer wrote:
> > Here it is... works for me. All of parbox/minipage and all the
> > fancybox standard boxes implemented. (And yes Jean-Marc, you *can*
> > draw a square frame
Martin Vermeer wrote:
> Here it is... works for me. All of parbox/minipage and all the
> fancybox standard boxes implemented. (And yes Jean-Marc, you *can*
> draw a square frame around something :-)
>
> For your benevolent consideration :-)
Why is their a Params::write and no Params::read?
+voi
On Sat, Sep 27, 2003 at 11:02:39AM +0300, Martin Vermeer wrote:
> Here it is... works for me. All of parbox/minipage and all the
> fancybox standard boxes implemented. (And yes Jean-Marc, you *can*
> draw a square frame around something :-)
>
> For your benevolent consideration :-)
You should try
Kornel Benko <[EMAIL PROTECTED]> writes:
>
| #if !defined(QT_NO_DEBUG) && !defined(QT_DEBUG)
| # define QT_DEBUG // display debug messages
| # if !defined(QT_NO_COMPAT)// compatibility with Qt 2
| #if !defined(NO_DEBUG) && !defined(DEBUG)
| #
Martin Vermeer <[EMAIL PROTECTED]> writes:
>> ../../../src/support/debugstream.h:28: parse error before `=' token
>> ../../../src/support/debugstream.h:30: missing ';' before right brace
>> ...
>>
>> Here I had to comment line 28 of src/support/debugstream.h
>>
>> // DEBUG = 8,
>>
>> ...
-BEGIN PGP SIGNED MESSAGE-
On Samstag, 27. September 2003 15:00, Juergen Spitzmueller wrote:
> Am Samstag, 27. September 2003 14:47 schrieb Kornel Benko:
> > > Lars's latest stuff...
> >
> > Yes, but it compiles without your patch. (BTW, I did not detect why,
> > there is no #define DEBUG
On Sat, Sep 27, 2003 at 02:59:12PM +0200, Kornel Benko spake thusly:
...
> I (we?) have to thank.
"We" is otherwise occupied by spending the weekend in an enjoyable
fashion. And so would we (i.e., you + I) be, if we were wise :-)
> Kornel
- Martin
pgp0.pgp
Description: PGP signa
Am Samstag, 27. September 2003 14:47 schrieb Kornel Benko:
> > Lars's latest stuff...
>
> Yes, but it compiles without your patch. (BTW, I did not detect why,
> there is no #define DEBUG or something similar)
It does not compile here without Martin's stuff either (but it does with your
"fix").
J
-BEGIN PGP SIGNED MESSAGE-
On Samstag, 27. September 2003 15:03, Martin Vermeer wrote:
This is the minipage I meant vv
> Yes... you need almost always a parbox/minipage inside. You can
> manually set the width however, which will work either though the
> par
-BEGIN PGP SIGNED MESSAGE-
On Samstag, 27. September 2003 14:51, Martin Vermeer wrote:
> >
> > Here I had to comment line 28 of src/support/debugstream.h
> >
> > // DEBUG = 8,
> >
> > ...
> > Kornel
>
> Lars's latest stuff...
Yes, but it compiles without your patch. (BTW
On Sat, Sep 27, 2003 at 02:16:41PM +0200, Kornel Benko spake thusly:
> -BEGIN PGP SIGNED MESSAGE-
>
> On Samstag, 27. September 2003 10:02, Martin Vermeer wrote:
> > For your benevolent consideration :-)
> >
>
> I like this feature very much. Good work Martin, IMHO.
Thanks Kornel.
>
On Sat, Sep 27, 2003 at 12:31:47PM +0200, Kornel Benko spake thusly:
> -BEGIN PGP SIGNED MESSAGE-
>
> On Samstag, 27. September 2003 10:02, Martin Vermeer wrote:
> > Here it is... works for me. All of parbox/minipage and all the
> > fancybox standard boxes implemented. (And yes Jean-Marc
On Sat, Sep 27, 2003 at 12:13:32PM +0200, Kornel Benko spake thusly:
> -BEGIN PGP SIGNED MESSAGE-
>
> On Samstag, 27. September 2003 10:02, Martin Vermeer wrote:
> > Here it is... works for me. All of parbox/minipage and all the
> > fancybox standard boxes implemented. (And yes Jean-Marc
-BEGIN PGP SIGNED MESSAGE-
On Samstag, 27. September 2003 10:02, Martin Vermeer wrote:
> For your benevolent consideration :-)
>
I like this feature very much. Good work Martin, IMHO.
What I have seen so far ...
Empty boxes have minimal width, all other boxes have the maximal column wid
-BEGIN PGP SIGNED MESSAGE-
On Samstag, 27. September 2003 10:02, Martin Vermeer wrote:
> Here it is... works for me. All of parbox/minipage and all the
> fancybox standard boxes implemented. (And yes Jean-Marc, you *can*
> draw a square frame around something :-)
>
> For your benevolent c
-BEGIN PGP SIGNED MESSAGE-
On Samstag, 27. September 2003 10:02, Martin Vermeer wrote:
> Here it is... works for me. All of parbox/minipage and all the
> fancybox standard boxes implemented. (And yes Jean-Marc, you *can*
> draw a square frame around something :-)
>
> For your benevolent c
Here it is... works for me. All of parbox/minipage and all the
fancybox standard boxes implemented. (And yes Jean-Marc, you *can*
draw a square frame around something :-)
For your benevolent consideration :-)
- Martin
--
Martin Vermeer [EMAIL PROTECTED]
Helsinki University of Technology
Dept.
46 matches
Mail list logo
