On Wed, Oct 01, 2003 at 04:02:19PM +0300, Martin Vermeer wrote: > See attached (and it still works!). Sorry for the added files > separately, this is my read-only CVS tree using gcc3.
Starts to look ok. I wonder a bit what the benefit of the string creations in int j = fl_get_choice(dialog_->choice_pos); char c = string("tcb")[j - 1]; controller().params().pos = c; j = fl_get_choice(dialog_->choice_inner_pos); c = string("tcbs")[j - 1]; controller().params().inner_pos = c; j = fl_get_choice(dialog_->choice_hor_pos); c = string("lcrs")[j - 1]; controller().params().hor_pos = c; over int j = fl_get_choice(dialog_->choice_pos); controller().params().pos = "tcb"[j - 1]; j = fl_get_choice(dialog_->choice_inner_pos); controller().params().inner_pos = "tcbs"[j - 1]; j = fl_get_choice(dialog_->choice_hor_pos); controller().params().hor_pos = "lcrs"[j - 1]; or even controller().params().pos = "tcb"[fl_get_choice(dialog_->choice_pos) - 1]; controller().params().inner_pos = "tcbs"[fl_get_choice(dialog_->choice_inner_pos) - 1]; controller().params().hor_pos = "lcrs"[fl_get_choice(dialog_->choice_hor_pos) - 1]; is, but surely UI code can waste cycles at will... Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)