On Mon, Oct 06, 2003 at 12:48:40PM +0100, Angus Leeming spake thusly: > > Martin Vermeer wrote: > > OK, attached the patch that I intend to commit this evening if no > > grave objections are brought forward. It differs only cosmetically > > from the previous one (order of initializers in InsetBoxParams c'tor > > to get rid of warnings; use empty string instead of misleading "box" > > in two places) > > + * \author Martin Vermeer (with useful hints from Angus leeming) > > That's a capital 'L' ;-) > > Truly minor. Would this: > +void InsetBox::metrics(MetricsInfo & mi, Dimension & dim) const > + if (params_.inner_box) > + if (isOpen()) > + dim.wid = mi.base.textwidth; > be better as this: > if (params_.inner_box && isOpen()) > dim.wid = mi.base.textwidth; > ?
Hmmm. Both will be optimized... but which of the two boolean expressions is most often false? That one should come first. I really wouldn't know. Of course the lower code looks cleaner. OK. > Fantastic effort! Thanks :-) > -- > Angus > - Martin
pgp00000.pgp
Description: PGP signature
