On Tue, Sep 30, 2003 at 05:04:58PM +0300, Martin Vermeer wrote:
> On Mon, Sep 29, 2003 at 09:47:17AM +0100, Angus Leeming spake thusly:
>  
> Next version. Hit it hard. Unless bad bugs come up, I think this is
> about ready to go in.


This looks... erm... sub-optimal.

        int InsetBox::linuxdoc(Buffer const & buf, std::ostream & os) const
        {
                                 int i = 0;
                                 string const pt = params_.type;
                                 
                                 i = inset.linuxdoc(buf, os);
                                 return i;
        }
         
         
        int InsetBox::docbook(Buffer const & buf, std::ostream & os, bool mixcont)
        const
        {
                                 int i = 0;
                                 string const pt = params_.type;
                                                                 
                                 i = inset.docbook(buf, os, mixcont);
                                                                 
                                 return i;
        }              

what about

        int InsetBox::linuxdoc(Buffer const & buf, std::ostream & os) const
        {
                                 return inset.linuxdoc(buf, os);
        }
         

If you want you could file this cleanup as separate patch - including
a fix to the place where this code came from.

> BTW I think this should replace the existing minipage, which means
> reLyX should be adapted to convert the old docs.

That's lyx2lyx business.

Andre'

-- 
Those who desire to give up Freedom in order to gain Security, will not have,
nor do they deserve, either one.     (T. Jefferson or B. Franklin or both...)

Reply via email to