Re: The Compleat Box

[Angus Leeming]

Martin Vermeer wrote:

>> What's wrong with
>>         InsetBox::Params::Params(string const & label);
> 
> Don't understand.

I meant that this is nasty:
InsetBox::InsetBox(BufferParams const & bp, string const & label)
        : InsetCollapsable(bp)
{
        params_.type = label;
}

And should be changed to this:
InsetBox::InsetBox(BufferParams const & bp, string const & label)
        : InsetCollapsable(bp), params_(label)
{}

InsetBoxParams::InsetBoxParams(string const & label)
        : type(label),
          use_parbox(false),
          inner_box(true),
          width(LyXLength("100col%")),
          special("none"),
          pos('t'),
          hor_pos('c'),
          inner_pos('t'),
          height(LyXLength("1in")),
          height_special("totalheight") // default is 1\\totalheight
{}

(If you insist on keeping the type as a string...)

>> You must be sick to the back teeth of my suggestions ;-)
> Yes. That's why I'll leave a little for you ;-)

Hmpfff!

-- 
Angus