Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-10 Thread Abdelrazak Younes
Alfredo Braunstein wrote: I don't have time either unfortunately. I'll be a rather busy (read traveling) in the next 30 days or so... IMHO, (if you agree) we should just revert the full patch series if possible. Hum, looks like I did not see this proposal, sorry. I've changed already TextMetri

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-07 Thread Alfredo Braunstein
Martin Vermeer wrote: > Just adjustment... and I collided with Abdel. That's why two changesets, > 20102 and 20103. Ok these were included in the (revised) list. A/

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-07 Thread Martin Vermeer
On Fri, 07 Sep 2007 10:24:20 +0200 Alfredo Braunstein <[EMAIL PROTECTED]> wrote: > Martin Vermeer wrote: > > > On Thu, Sep 06, 2007 at 11:33:52PM +0200, Alfredo Braunstein wrote: > >> Alfredo Braunstein wrote: > >> > >> >> I don't have time to act on this until saturday so feel free to change >

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-07 Thread Alfredo Braunstein
Martin Vermeer wrote: > On Thu, Sep 06, 2007 at 11:33:52PM +0200, Alfredo Braunstein wrote: >> Alfredo Braunstein wrote: >> >> >> I don't have time to act on this until saturday so feel free to change >> >> that if you want. >> > >> > I don't have time either unfortunately. I'll be a rather busy

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Martin Vermeer
On Thu, Sep 06, 2007 at 11:33:52PM +0200, Alfredo Braunstein wrote: > Alfredo Braunstein wrote: > > >> I don't have time to act on this until saturday so feel free to change > >> that if you want. > > > > I don't have time either unfortunately. I'll be a rather busy (read > > traveling) in the ne

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > Alfredo Braunstein wrote: > >>> I don't have time to act on this until saturday so feel free to change >>> that if you want. >> >> I don't have time either unfortunately. I'll be a rather busy (read >> traveling) in the next 30 days or so... IMHO, (if you agree) we sh

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Alfredo Braunstein
Alfredo Braunstein wrote: >> I don't have time to act on this until saturday so feel free to change >> that if you want. > > I don't have time either unfortunately. I'll be a rather busy (read > traveling) in the next 30 days or so... IMHO, (if you agree) we should > just revert the full patch se

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Alfredo Braunstein
Andre Poenitz wrote: >> Yes, this is what I was trying to convince Abdel to (I was trying to use >> actual arguments though...) > > An interesting aproach. Don't get me wrong, the hammer surely works better at "convincing" people. The trouble is, when you realize that they may have been right it

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Alfredo Braunstein wrote: >> Andre Poenitz wrote: >> It seems pretty much a mess to me. >>> whatEverDraw(x, y) should draw the baseline of the first embedded line >>> on y. Everything else should be changed to adhere to that scheme. >> >> Yes, this is what I was t

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Andre Poenitz
On Thu, Sep 06, 2007 at 08:18:40PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > >> It seems pretty much a mess to me. > > > > whatEverDraw(x, y) should draw the baseline of the first embedded line > > on y. Everything else should be changed to adhere to that scheme. > > Yes, this

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Andre Poenitz wrote: It seems pretty much a mess to me. whatEverDraw(x, y) should draw the baseline of the first embedded line on y. Everything else should be changed to adhere to that scheme. Yes, this is what I was trying to convince Abdel to (I was trying to use

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Alfredo Braunstein
Andre Poenitz wrote: >> It seems pretty much a mess to me. > > whatEverDraw(x, y) should draw the baseline of the first embedded line > on y. Everything else should be changed to adhere to that scheme. Yes, this is what I was trying to convince Abdel to (I was trying to use actual arguments thou

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Andre Poenitz
On Thu, Sep 06, 2007 at 02:22:59PM +0200, Alfredo Braunstein wrote: > Abdelrazak Younes wrote: > > > Alfredo Braunstein wrote: > >> Abdelrazak Younes wrote: > >>> I think there is a misundertanding here... I agree that the baseline is > >>> the reference and I did not change that philosophy I thin

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Andre Poenitz
On Thu, Sep 06, 2007 at 11:55:08AM +0200, Abdelrazak Younes wrote: > Alfredo Braunstein wrote: > >Abdelrazak Younes wrote: > > > >>Alfredo Braunstein wrote: > >>>conveys all the information. I'm not religious about this, but now we > >>>have some methods that receive baselines and some others that

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Alfredo Braunstein wrote: >> Abdelrazak Younes wrote: >>> I think there is a misundertanding here... I agree that the baseline is >>> the reference and I did not change that philosophy I think. For me the >>> baseline is the baseline of the inset, not the baseline of the

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: I think there is a misundertanding here... I agree that the baseline is the reference and I did not change that philosophy I think. For me the baseline is the baseline of the inset, not the baseline of the inner Text. The fact that InsetCollapsa

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Alfredo Braunstein
Abdelrazak Younes wrote: >> Ok. Note that I nobody disagrees with the general view (I don't know if I >> explained myself enough before). Sorry. I started to write in first person but then I realized that everyone would agree. ;-) So take out the 'I'. > I cannot parse what's above ;-) > >> It's

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: Alfredo Braunstein wrote: conveys all the information. I'm not religious about this, but now we have some methods that receive baselines and some others that receive frames... I will correct the remaining problems. Ok. Note that I nobody di

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Alfredo Braunstein wrote: >> conveys all the information. I'm not religious about this, but now we >> have some methods that receive baselines and some others that receive >> frames... > > I will correct the remaining problems. Ok. Note that I nobody disagrees with the

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Abdelrazak Younes
Alfredo Braunstein wrote: conveys all the information. I'm not religious about this, but now we have some methods that receive baselines and some others that receive frames... I will correct the remaining problems. Abdel.

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Alfredo Braunstein wrote: >> Abdelrazak Younes wrote: >> >>> Alfredo Braunstein wrote: Abdelrazak Younes wrote: > I just now understand what you mean... But it is too late now to cure > that, maybe tomorrow... No worries :-) >>> It was pretty easy

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: Alfredo Braunstein wrote: Abdelrazak Younes wrote: I just now understand what you mean... But it is too late now to cure that, maybe tomorrow... No worries :-) It was pretty easy to solve actually, the moment you know how to solve it I mea

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-06 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Alfredo Braunstein wrote: >> Abdelrazak Younes wrote: >> >>> I just now understand what you mean... But it is too late now to cure >>> that, maybe tomorrow... >> >> No worries :-) > > It was pretty easy to solve actually, the moment you know how to solve > it I mean..

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-05 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: I just now understand what you mean... But it is too late now to cure that, maybe tomorrow... No worries :-) It was pretty easy to solve actually, the moment you know how to solve it I mean... Abdel.

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-05 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > I just now understand what you mean... But it is too late now to cure > that, maybe tomorrow... No worries :-) A/

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-05 Thread Abdelrazak Younes
Alfredo Braunstein wrote: [EMAIL PROTECTED] wrote: Author: younes Date: Wed Sep 5 15:45:58 2007 New Revision: 20068 URL: http://www.lyx.org/trac/changeset/20068 Log: * TextMetrics::draw(): get rid of the first par ascent offset. * BufferView::draw(): adapt to above change. * InsetCollapsabl

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-05 Thread Abdelrazak Younes
Alfredo Braunstein wrote: [EMAIL PROTECTED] wrote: Author: younes Date: Wed Sep 5 15:45:58 2007 New Revision: 20068 URL: http://www.lyx.org/trac/changeset/20068 Log: * TextMetrics::draw(): get rid of the first par ascent offset. * BufferView::draw(): adapt to above change. * InsetCollapsabl

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-05 Thread Abdelrazak Younes
Alfredo Braunstein wrote: [EMAIL PROTECTED] wrote: Author: younes Date: Wed Sep 5 15:45:58 2007 New Revision: 20068 URL: http://www.lyx.org/trac/changeset/20068 Log: * TextMetrics::draw(): get rid of the first par ascent offset. * BufferView::draw(): adapt to above change. * InsetCollapsabl

Re: r20068 - in /lyx-devel/trunk/src: BufferView.cpp TextMetr...

2007-09-05 Thread Alfredo Braunstein
[EMAIL PROTECTED] wrote: > Author: younes > Date: Wed Sep  5 15:45:58 2007 > New Revision: 20068 > > URL: http://www.lyx.org/trac/changeset/20068 > Log: > * TextMetrics::draw(): get rid of the first par ascent offset. > > * BufferView::draw(): adapt to above change. > > * InsetCollapsable::draw