Alfredo Braunstein wrote:
[EMAIL PROTECTED] wrote:
Author: younes
Date: Wed Sep 5 15:45:58 2007
New Revision: 20068
URL: http://www.lyx.org/trac/changeset/20068
Log:
* TextMetrics::draw(): get rid of the first par ascent offset.
* BufferView::draw(): adapt to above change.
* InsetCollapsable::draw(): ditto -> get rid of textdim_ member.
I think I don't like this change. Doesn't this mean that text inside inlined
insets is not correctly aligned anymore with the surrounding text? What are
the advantages of this?
Now, it just mean that I got rid of adding an offset which was
immediately subtracted in TextMetrics::draw(), i.e this:
in InsetCollapsable::draw():
y += tm.ascent();
tm.draw(x, y);
in TextMetrics::draw()
y -= acsent()
...
The textdim_ cache member was wrong in a multiview world...
Abdel.
A/
