Re: [patch] more cursor stuff

Andre Poenitz <[EMAIL PROTECTED]> writes: | On Tue, Nov 04, 2003 at 01:18:31PM +0100, Lars Gullik Bjønnes wrote: >> Andre Poenitz <[EMAIL PROTECTED]> writes: >> >> | But's easier to build up a stack of insets at position (x,y) and go >> | inside-out until the first inset shouts 'I can handle it!'

Re: [patch] more cursor stuff

On Tue, Nov 04, 2003 at 01:18:31PM +0100, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | But's easier to build up a stack of insets at position (x,y) and go > | inside-out until the first inset shouts 'I can handle it!'. > | The effect is the same and the implementat

Re: [patch] more cursor stuff

Andre Poenitz <[EMAIL PROTECTED]> writes: | But's easier to build up a stack of insets at position (x,y) and go | inside-out until the first inset shouts 'I can handle it!'. | The effect is the same and the implementation is much simpler. Won't you need a back pointer then? All insets must know

Re: [patch] more cursor stuff

On Tue, Nov 04, 2003 at 12:49:10PM +0100, Lars Gullik Bjønnes wrote: > | Suppose a user clicks on C. What should happen? > > depends really... > I guess that in most cases B should react. Everything else would be a surprise. > A::dispatch [neston] -> B::dispatch [neston] -> > C::dispatch [unhand

Re: [patch] more cursor stuff

Andre Poenitz <[EMAIL PROTECTED]> writes: | On Tue, Nov 04, 2003 at 12:27:14PM +0100, Lars Gullik Bjønnes wrote: >> Andre Poenitz <[EMAIL PROTECTED]> writes: >> >> | No, jsut inset->dispatch() and finally bv->text->dispatch. >> >> right... (sorry: misread.) >> >> should it do even that? > | Sur

Re: [patch] more cursor stuff

On Tue, Nov 04, 2003 at 12:21:52PM +0100, Lars Gullik Bjønnes wrote: > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: > > >>> Actually I don't like the dispatch changes at all... should the cursor > >>> _ever_ call the BufferView::dispatch? (IMHO no) > >> > | | Indeed. > >> > | | And it does not.

Re: [patch] more cursor stuff

On Tue, Nov 04, 2003 at 12:27:14PM +0100, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | No, jsut inset->dispatch() and finally bv->text->dispatch. > > right... (sorry: misread.) > > should it do even that? Sure. > That would probably be ok... but I am not quite s

Re: [patch] more cursor stuff

[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: >>> Actually I don't like the dispatch changes at all... should the cursor >>> _ever_ call the BufferView::dispatch? (IMHO no) >> | | Indeed. >> | | And it does not. > | I thought I saw a bv()->dispatch(...) there... Like so: + + lyxerr << "t

Re: [patch] more cursor stuff

Andre Poenitz <[EMAIL PROTECTED]> writes: | No, jsut inset->dispatch() and finally bv->text->dispatch. right... (sorry: misread.) should it do even that? That would probably be ok... but I am not quite sure. Anyway what I have decided/realized is that no dispatch function should call another di

Re: [patch] more cursor stuff

On Tue, Nov 04, 2003 at 12:18:45PM +0100, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Tue, Nov 04, 2003 at 10:53:53AM +0100, Lars Gullik Bjønnes wrote: > >> Andre Poenitz <[EMAIL PROTECTED]> writes: > >> > >> | I also moved part of the LFUN_INSET_EDIT stuff out

Re: [patch] more cursor stuff

On Tue, Nov 04, 2003 at 11:21:07AM +, Angus Leeming wrote: > Andre Poenitz wrote: > > Grrr. > > Windmills. > > Don't let your blood pressure rise so. My blood pressure is jsut fine. > (Anyway, I found one real bug, so one silly question is surely > allowed ;-) Sure ;-) Andre'

Re: [patch] more cursor stuff

Andre Poenitz <[EMAIL PROTECTED]> writes: | On Tue, Nov 04, 2003 at 10:53:53AM +0100, Lars Gullik Bjønnes wrote: >> Andre Poenitz <[EMAIL PROTECTED]> writes: >> >> | I also moved part of the LFUN_INSET_EDIT stuff out of Inset::dispatch >> | again into edit() functions. Reason is mainly separating

Re: [patch] more cursor stuff

Andre Poenitz wrote: > Grrr. > Windmills. Don't let your blood pressure rise so. Remember, I have conciously avoided digging into the core, so I just ask 'em as I see 'em. (Anyway, I found one real bug, so one silly question is surely allowed ;-) -- Angus

Re: [patch] more cursor stuff

On Tue, Nov 04, 2003 at 10:53:53AM +0100, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | I also moved part of the LFUN_INSET_EDIT stuff out of Inset::dispatch > | again into edit() functions. Reason is mainly separating two separate > | ideas: 1. edit means 'open some

Re: [patch] more cursor stuff

Andre Poenitz <[EMAIL PROTECTED]> writes: | I also moved part of the LFUN_INSET_EDIT stuff out of Inset::dispatch | again into edit() functions. Reason is mainly separating two separate | ideas: 1. edit means 'open some dialog' (this is still in dispatch()) | and 2. edt means 'enter some text inse

Re: [patch] more cursor stuff

On Tue, Nov 04, 2003 at 11:33:03AM +0100, Lars Gullik Bjønnes wrote: > Where what you "if (0)" reverts changes I just made. Better? Index: lyxfunc.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/lyxfunc.C,v retrieving revision 1

Re: [patch] more cursor stuff

Andre Poenitz <[EMAIL PROTECTED]> writes: | It is porbably possible. But it takes an amount of time I am not | willing to spend on that issue. _if_ you had thought of that when doing the changes: different things different patches. Makes it easier for all of us. -- Lgb

Re: [patch] more cursor stuff

On Tue, Nov 04, 2003 at 10:36:51AM +, Angus Leeming wrote: > Andre Poenitz wrote: > > Woo! Things move on bloody quickly! > > I find it frankly amazing that the LCursor class shrinks to almost > nothing. I even feel I understand how it works which is just > gob-smacking! > > > Index: curs

Re: [patch] more cursor stuff

Andre Poenitz <[EMAIL PROTECTED]> writes: >> LCursor::dispatch > | This is my playground. It's not even active right now. so? | i.e. six or seven lines combined to a single one and wrapped in 'if (0)'. Where what you "if (0)" reverts changes I just made. >> I'd really like to see Cursor chan

Re: [patch] more cursor stuff

On Tue, Nov 04, 2003 at 11:28:28AM +0100, Lars Gullik Bjønnes wrote: > But it not only that... you are also doing stuff with dispatch that > goes in just the oposite direction that I am going. I don't think so. You can consider all of cursor.[Ch] non-exitent for the time being. With respect to the

Re: [patch] more cursor stuff

Andre Poenitz wrote: Woo! Things move on bloody quickly! I find it frankly amazing that the LCursor class shrinks to almost nothing. I even feel I understand how it works which is just gob-smacking! Index: cursor.h + /// mainly used as stack, but wee need random access Swap wee for we.

Re: [patch] more cursor stuff

Andre Poenitz <[EMAIL PROTECTED]> writes: | On Tue, Nov 04, 2003 at 11:07:15AM +0100, Lars Gullik Bjønnes wrote: >> I just thought that if it is a typedef we don't really have to change >> the Cursor name.. but I guess that is easiest... > | I don't care about names too much right now. Fair enoug

Re: [patch] more cursor stuff

Andre Poenitz <[EMAIL PROTECTED]> writes: | On Tue, Nov 04, 2003 at 11:11:45AM +0100, Lars Gullik Bjønnes wrote: >> Andre Poenitz <[EMAIL PROTECTED]> writes: >> >> | What part? >> >> All disptch changes really... >> >> | Why? >> >> You are interfering with my work. > | So do your work and tel

Re: [patch] more cursor stuff

On Tue, Nov 04, 2003 at 11:11:45AM +0100, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | What part? > > All disptch changes really... > > | Why? > > You are interfering with my work. So do your work and tell me when you are done. Andre'

Re: [patch] more cursor stuff

On Tue, Nov 04, 2003 at 11:09:50AM +0100, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Tue, Nov 04, 2003 at 10:58:28AM +0100, Lars Gullik Bjønnes wrote: > >> Andre Poenitz <[EMAIL PROTECTED]> writes: > >> > >> | Failures are indicated by '### CURSOR OUT OF SYNC:

Re: [patch] more cursor stuff

Andre Poenitz <[EMAIL PROTECTED]> writes: | What part? All disptch changes really... | Why? You are interfering with my work. -- Lgb

Re: [patch] more cursor stuff

Andre Poenitz <[EMAIL PROTECTED]> writes: | On Tue, Nov 04, 2003 at 10:58:28AM +0100, Lars Gullik Bjønnes wrote: >> Andre Poenitz <[EMAIL PROTECTED]> writes: >> >> | Failures are indicated by '### CURSOR OUT OF SYNC:' messages. As this >> | happens often, dispatch() uses now the old route again,

Re: [patch] more cursor stuff

On Tue, Nov 04, 2003 at 11:07:15AM +0100, Lars Gullik Bjønnes wrote: > I just thought that if it is a typedef we don't really have to change > the Cursor name.. but I guess that is easiest... I don't care about names too much right now. Andre' -- Those who desire to give up Freedom in order to

Re: [patch] more cursor stuff

On Tue, Nov 04, 2003 at 10:52:00AM +0100, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | Several things that are not easily separated: > > > | This changes tactics: Instead of creating the 'global' cursor from the > | inset locking information (which won't be availabl

Re: [patch] more cursor stuff

Andre Poenitz <[EMAIL PROTECTED]> writes: | On Tue, Nov 04, 2003 at 10:50:14AM +0100, Lars Gullik Bjønnes wrote: >> Andre Poenitz <[EMAIL PROTECTED]> writes: >> >> | I had to rename Cursor to LCursor it since there is some name clash >> | with some X header. >> >> I find this unfortunate. That i

Re: [patch] more cursor stuff

On Tue, Nov 04, 2003 at 10:58:28AM +0100, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | Failures are indicated by '### CURSOR OUT OF SYNC:' messages. As this > | happens often, dispatch() uses now the old route again, so the patch > | should be safe. > > And you ar

Re: [patch] more cursor stuff

Alfredo Braunstein wrote: > Andre Poenitz wrote: > >> /usr/X11/include/X11/X.h:typedef XID Cursor; >> >> /usr/X11/include/X11/X.h:typedef unsigned long XID; >> /usr/X11/include/X11/Xdefs.h:typedef unsigned long XID; >> >> Not really usable as LyX cursor... > > ;-) I mean: PosIterator p = buf

Re: [patch] more cursor stuff

Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | I had to rename Cursor to LCursor it since there is some name > | clash with some X header. > > I find this unfortunate. That is this Cursor from X? a defne? or a > typedef? It's not really unfortunate. It provides add

Re: [patch] more cursor stuff

Andre Poenitz <[EMAIL PROTECTED]> writes: | Several things that are not easily separated: > | This changes tactics: Instead of creating the 'global' cursor from the | inset locking information (which won't be available after IL is | removed) this tries to keep it up-to-date all the time. > | Failu

Re: [patch] more cursor stuff

Andre Poenitz <[EMAIL PROTECTED]> writes: | Failures are indicated by '### CURSOR OUT OF SYNC:' messages. As this | happens often, dispatch() uses now the old route again, so the patch | should be safe. And you are replacing part of my new dispatch code with your old not updated one. --

Re: [patch] more cursor stuff

Andre Poenitz wrote: > /usr/X11/include/X11/X.h:typedef XID Cursor; > > /usr/X11/include/X11/X.h:typedef unsigned long XID; > /usr/X11/include/X11/Xdefs.h:typedef unsigned long XID; > > Not really usable as LyX cursor... ;-)

Re: [patch] more cursor stuff

On Tue, Nov 04, 2003 at 10:50:14AM +0100, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | I had to rename Cursor to LCursor it since there is some name clash > | with some X header. > > I find this unfortunate. That is this Cursor from X? a defne? or a > typedef? /us

Re: [patch] more cursor stuff

Andre Poenitz <[EMAIL PROTECTED]> writes: | I had to rename Cursor to LCursor it since there is some name clash | with some X header. I find this unfortunate. That is this Cursor from X? a defne? or a typedef? -- Lgb