On Tue, Nov 04, 2003 at 11:09:50AM +0100, Lars Gullik Bjønnes wrote:
> Andre Poenitz <[EMAIL PROTECTED]> writes:
> 
> | On Tue, Nov 04, 2003 at 10:58:28AM +0100, Lars Gullik Bjønnes wrote:
> >> Andre Poenitz <[EMAIL PROTECTED]> writes:
> >> 
> >> | Failures are indicated by '### CURSOR OUT OF SYNC:' messages.  As this
> >> | happens often, dispatch() uses now the old route again, so the patch
> >> | should be safe.
> >> 
> >> And you are replacing part of my new dispatch code with your old not
> >> updated one.
> >
> | Where?
> 
> LCursor::dispatch

This is my playground. It's not even active right now.

> LyXFunc::dispatch

That's just

        @@ -882,16 +882,15 @@ void LyXFunc::dispatch(FuncRequest const
                        view()->hideCursor();
         
         #if 1
        -       {
        -               Cursor cursor;
        -               buildCursor(cursor, *view());
        -               DispatchResult result =
        -                       cursor.dispatch(FuncRequest(func, view()));
        -
        -               if (result.dispatched()) {
        -                       if (result.update()) {
        -                               view()->update();
        -                       }
        +       if (view()->theLockingInset() != view()->cursor().innerInset()) {
        +               lyxerr << "### CURSOR OUT OF SYNC: tli: " << 
view()->theLockingInset()
        +                       << "\ncursor:\n" << view()->cursor() << endl;
        +               
        +       }
        +
        +       // not active yet...
        +       if (0) {
        +               if (view()->cursor().dispatch(FuncRequest(func, 
view())).dispatched()) {
                                lyxerr << "dispatched by Cursor::dispatch()\n";
                                goto exit_with_message;
                        }

i.e. six or seven lines combined to a single one and wrapped in 'if (0)'.
 
> I'd really like to see Cursor changes and Dispatch changes in
> different patches...

Waste of time IMO.

*shrug* 

Andre'

Reply via email to