Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Enrico Forestieri
On Wed, Apr 04, 2007 at 05:36:10PM +0200, Abdelrazak Younes wrote: > Richard Heck wrote: > > Abdelrazak Younes wrote: > >> Richard Heck wrote: > >>> Attached are some screen shots of the new dialog, which I've updated on > >>> the basis of the now restored old version. Comments welcome. > >> Looks

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Abdelrazak Younes
Richard Heck wrote: Abdelrazak Younes wrote: Richard Heck wrote: Attached are some screen shots of the new dialog, which I've updated on the basis of the now restored old version. Comments welcome. Looks good and better than what we have currently. I miss some explanations for the "Set width

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Abdelrazak Younes
Enrico Forestieri wrote: On Wed, Apr 04, 2007 at 03:16:44PM +0200, Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: I've restored the horizontal layout now. it is still not ok Really? It's perfect on my screen... really weir

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Enrico Forestieri
On Wed, Apr 04, 2007 at 03:16:44PM +0200, Abdelrazak Younes wrote: > Edwin Leuven wrote: > > Abdelrazak Younes wrote: > >> Edwin Leuven wrote: > >>> Abdelrazak Younes wrote: > I've restored the horizontal layout now. > >>> > >>> it is still not ok > >> > >> Really? It's perfect on my screen...

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Richard Heck
Abdelrazak Younes wrote: > Richard Heck wrote: >> Attached are some screen shots of the new dialog, which I've updated on >> the basis of the now restored old version. Comments welcome. > Looks good and better than what we have currently. > > I miss some explanations for the "Set width" and "Set h

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Abdelrazak Younes
Richard Heck wrote: Attached are some screen shots of the new dialog, which I've updated on the basis of the now restored old version. Comments welcome. Looks good and better than what we have currently. I miss some explanations for the "Set width" and "Set height" options... I don't know wh

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: I've restored the horizontal layout now. it is still not ok Really? It's perfect on my screen... really weird! try to resize the dialog Ah... yes, you're right! But the problem is more general...

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Edwin Leuven
Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: I've restored the horizontal layout now. it is still not ok Really? It's perfect on my screen... really weird! try to resize the dialog

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: I've restored the horizontal layout now. it is still not ok Really? It's perfect on my screen... really weird! will commit a fix... Fine. Abdel.

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Edwin Leuven
Abdelrazak Younes wrote: I've restored the horizontal layout now. it is still not ok will commit a fix...

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Abdelrazak Younes
Uwe Stöhr wrote: > the bug introduced by 17625 and 17626 by reverting these > changesets because 1) they introduced a bug and 2) they don't do what > advertised, rather the contrary. I checked this both on Windows (with > Qt4.1.4 and Qt4.2.2) and Solaris (with Qt4.2.2). See the attached imag

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Abdelrazak Younes
Richard Heck wrote: Enrico Forestieri wrote: Please, can you wait with this patch? Before you commit it I would like to see resolved the bug introduced by 17625 and 17626 by reverting these changesets because 1) they introduced a bug and 2) they don't do what advertised, rather the contrary. I c

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-03 Thread Uwe Stöhr
> the bug introduced by 17625 and 17626 by reverting these > changesets because 1) they introduced a bug and 2) they don't do what > advertised, rather the contrary. I checked this both on Windows (with > Qt4.1.4 and Qt4.2.2) and Solaris (with Qt4.2.2). See the attached images. That's weird, what

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-03 Thread Richard Heck
Enrico Forestieri wrote: Please, can you wait with this patch? Before you commit it I would like to see resolved the bug introduced by 17625 and 17626 by reverting these changesets because 1) they introduced a bug and 2) they don't do what advertised, rather the contrary. I checked this both on W

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-03 Thread Enrico Forestieri
On Tue, Apr 03, 2007 at 05:55:29PM -0400, Richard Heck wrote: > > Attached is what is hopefully the penultimate version of this patch. > Please note that the diff was run from src/frontends/qt4/. > > The changes at the beginning of QGraphicsDialog.C are less extensive > than they appear. I had to

[PATCH] Bug 3215: Graphics Dialog

2007-04-03 Thread Richard Heck
Attached is what is hopefully the penultimate version of this patch. Please note that the diff was run from src/frontends/qt4/. The changes at the beginning of QGraphicsDialog.C are less extensive than they appear. I had to re-arrange this so I could make sense of it. The only real changes are ad

Re: Bug 3215: Graphics Dialog, Again

2007-03-31 Thread Uwe Stöhr
> are u sure it doesn't work with: > > QGraphicsDialog::on_Width_textChanged(const QString &) Thanks, now I get it. Patch comes tomorrow. regards Uwe

Re: Bug 3215: Graphics Dialog, Again

2007-03-31 Thread Edwin Leuven
Uwe Stöhr wrote: This is simple and logic. I wrote it down here in Pseudocode as I still fail to implement this easy code in GraphicsDialog.C (I fail to manage that QGraphicsDialog::on_Width_textChanged() is really called when the text is changed - I' too stupid!). are u sure it doesn't work

Re: Bug 3215: Graphics Dialog, Again

2007-03-30 Thread Uwe Stöhr
Here's my solution in Pseudocode: void QGraphicsDialog::on_aspectration_toggled() begin // set the same unit for width and height if Index(widthUnit) != Index(heightUnit) then Index(heightUnit) = Index(widthUnit); // only the smaller value is used by LaTeX when aspectratio is on // therefor

Re: Bug 3215: Graphics Dialog, Again

2007-03-30 Thread Uwe Stöhr
Richard Heck schrieb: Attached is a patch that PARTIALLY addresses this issue. Hi Richard, I'm currently working on a different solution but needs a day for this as I'm new to Qt. I'll send you something as soon it's ready (I hope tomorrow). regards Uwe

Bug 3215: Graphics Dialog, Again

2007-03-30 Thread Richard Heck
Attached is a patch that PARTIALLY addresses this issue. I say "partially" because the work is not complete. In particular, I HAVE NOT CHECKED to make sure that the dialog actually works: That is, that if you say "Scale 50%" you get the right LaTeX output. The changes made to QGraphics::apply() ar

Bug 3215: Graphics Dialog

2007-03-30 Thread Richard Heck
Discussion of bug 3215 http://bugzilla.lyx.org/show_bug.cgi?id=3215 revealed some problems with the current UI in the graphics dialog. Attached is a screenshot of an idea for a new organization. The "Set width" and "Set height" checkboxes are enabled only when "Scale graphic" is not; when they