On Tue, Apr 03, 2007 at 05:55:29PM -0400, Richard Heck wrote: > > Attached is what is hopefully the penultimate version of this patch. > Please note that the diff was run from src/frontends/qt4/. > > The changes at the beginning of QGraphicsDialog.C are less extensive > than they appear. I had to re-arrange this so I could make sense of it. > The only real changes are added connections for the new width and height > checkboxes and the aspectratio checkbox, and adding a validator for the > Scale field. And the changes to MarginsUi.ui are not so extensive > either, though QtDesigner seems to save the XML in a pretty random > order, so it's hard to see that. As Enrico pointed out, there is > something wrong with this file that is causing the dialog not to report > a preferred size. We'll get that fixed before final update.
Please, can you wait with this patch? Before you commit it I would like to see resolved the bug introduced by 17625 and 17626 by reverting these changesets because 1) they introduced a bug and 2) they don't do what advertised, rather the contrary. I checked this both on Windows (with Qt4.1.4 and Qt4.2.2) and Solaris (with Qt4.2.2). See the attached images. -- Enrico
solaris_before_17625-6.png
Description: PNG image
solaris_after_17625-6.png
Description: PNG image
windows_before_17625-6.png
Description: PNG image
windows_after_17625-6.png
Description: PNG image
