Re: babel handling completely broken!!! - was: Re: [patch] support for Mongolian

2008-10-12 Thread Uwe Stöhr
Abdelrazak Younes schrieb: My opinion: this code is a mess and is very fragile because it _is_ a mess; if we don't fix it now, it will turn out to be a source of a lot of unpredictable bugs. I spent a lot time getting the babel code bug free. Maybe the code is not the best looking, but it is

Re: babel handling completely broken!!! - was: Re: [patch] support for Mongolian

2008-10-12 Thread Abdelrazak Younes
On 12/10/2008 20:02, Abdelrazak Younes wrote: On 12/10/2008 19:22, Uwe Stöhr wrote: I wrote: I fear you have to revert your commit, as you broke the whole babel handling. That means currently only English documents are output correctly as babel is not loaded! This problem turned out to be r

Re: babel handling completely broken!!! - was: Re: [patch] support for Mongolian

2008-10-12 Thread Abdelrazak Younes
On 12/10/2008 20:07, Abdelrazak Younes wrote: On 12/10/2008 20:02, Abdelrazak Younes wrote: On 12/10/2008 19:22, Uwe Stöhr wrote: I wrote: I fear you have to revert your commit, as you broke the whole babel handling. That means currently only English documents are output correctly as babel i

Re: babel handling completely broken!!! - was: Re: [patch] support for Mongolian

2008-10-12 Thread Abdelrazak Younes
On 12/10/2008 20:02, Abdelrazak Younes wrote: On 12/10/2008 19:22, Uwe Stöhr wrote: I wrote: I fear you have to revert your commit, as you broke the whole babel handling. That means currently only English documents are output correctly as babel is not loaded! This problem turned out to be r

Re: babel handling completely broken!!! - was: Re: [patch] support for Mongolian

2008-10-12 Thread Abdelrazak Younes
On 12/10/2008 19:22, Uwe Stöhr wrote: I wrote: I fear you have to revert your commit, as you broke the whole babel handling. That means currently only English documents are output correctly as babel is not loaded! This problem turned out to be really serious as it makes certain documents un

Re: [patch] support for Mongolian

2008-10-12 Thread Abdelrazak Younes
On 12/10/2008 15:16, Uwe Stöhr wrote: Abdelrazak Younes schrieb: I did some cleanup so that this can be done easily now. The advantage would be that any new special babel language could be added easily if we put this info in lib/languages. I'm not happy about this. Your patch is the step in

Re: babel handling completely broken!!! - was: Re: [patch] support for Mongolian

2008-10-12 Thread Uwe Stöhr
I wrote: I fear you have to revert your commit, as you broke the whole babel handling. That means currently only English documents are output correctly as babel is not loaded! This problem turned out to be really serious as it makes certain documents uncompilable. To be able to work on the d

Re: babel handling completely broken!!! - was: Re: [patch] support for Mongolian

2008-10-12 Thread Pavel Sanda
Uwe Stöhr wrote: > I fear you have to revert your commit, as you broke the whole babel > handling. That means currently only English documents are output correctly > as babel is not loaded! i agree with Uwe thats quite dangerous to touch the babel bussiness in rc mode. pavel

babel handling completely broken!!! - was: Re: [patch] support for Mongolian

2008-10-12 Thread Uwe Stöhr
I wrote: Abdelrazak Younes wrote: I did some cleanup so that this can be done easily now. The advantage would be that any new special babel language could be added easily if we put this info in lib/languages. I'm not happy about this. Your patch is the step in the right direction, so I'm n

Re: [patch] support for Mongolian

2008-10-12 Thread Uwe Stöhr
Abdelrazak Younes schrieb: I did some cleanup so that this can be done easily now. The advantage would be that any new special babel language could be added easily if we put this info in lib/languages. I'm not happy about this. Your patch is the step in the right direction, so I'm not against

Re: [patch] support for Mongolian

2008-10-12 Thread Abdelrazak Younes
On 12/10/2008 01:37, Uwe Stöhr wrote: > I don't like to see so many special cases on the code. Would not it be > possible to put this information directly into lib/languages and to read it > from there? In principle yes, but this is something for LyX 1.7 as this would change a lot. I did so

Re: [patch] support for Mongolian

2008-10-11 Thread Uwe Stöhr
> I don't like to see so many special cases on the code. Would not it be > possible to put this information directly into lib/languages and to read it > from there? In principle yes, but this is something for LyX 1.7 as this would change a lot. regards Uwe

Re: [patch] support for Mongolian

2008-10-11 Thread Uwe Stöhr
> in the page i read "Install the packages mongolian-babel and > miktex-hyph-mongolian using MiKTeX's Package Manager." > > does it mean that mongolian support is miktex only thing? No. "mongolian-babel" is an official LaTeX package also included in TeXLive: http://tug.ctan.org/cgi-bin/ctanPackag

Re: [patch] support for Mongolian

2008-10-11 Thread José Matos
On Saturday 11 October 2008 21:24:53 Uwe Stöhr wrote: > As yesterday requested by a Mongolian user on this list, the following > patch add support for Mongolian. Using Mongolian is surprisingly easy and > its support is the same as we already do for Vietnamese, Latvian, and > Lithuanian. Neverthele

Re: [patch] support for Mongolian

2008-10-11 Thread Pavel Sanda
Uwe Stöhr wrote: > As yesterday requested by a Mongolian user on this list, the following > patch add support for Mongolian. > Using Mongolian is surprisingly easy and its support is the same as we > already do for Vietnamese, Latvian, and Lithuanian. Nevertheless, it is a > fileformat change. >

Re: [patch] support for Mongolian

2008-10-11 Thread Andre Poenitz
On Sat, Oct 11, 2008 at 10:55:24PM +0200, Pavel Sanda wrote: > Andre Poenitz wrote: > > Can you make it smell a bit like "fixing a bug"? > > i think the main argument is that its fileformat change > and can't be incorporated later in branch. And it looks pretty straight-forward, too. Well, if it

Re: [patch] support for Mongolian

2008-10-11 Thread Pavel Sanda
Andre Poenitz wrote: > Can you make it smell a bit like "fixing a bug"? i think the main argument is that its fileformat change and can't be incorporated later in branch. pavel

Re: [patch] support for Mongolian

2008-10-11 Thread Uwe Stöhr
Andre Poenitz schrieb: Can you make it smell a bit like "fixing a bug"? If so, it's fine with me... Try this then ;-): Currently we support all languages that are directly supported by babel or where LaTeX-packages are available that provide babel support. Unfortunately I missed that this is

Re: [patch] support for Mongolian

2008-10-11 Thread Andre Poenitz
On Sat, Oct 11, 2008 at 10:24:53PM +0200, Uwe Stöhr wrote: > As yesterday requested by a Mongolian user on this list, the following patch > add support for Mongolian. > Using Mongolian is surprisingly easy and its support is the same as we > already do for Vietnamese, Latvian, and Lithuanian. Nev

[patch] support for Mongolian

2008-10-11 Thread Uwe Stöhr
As yesterday requested by a Mongolian user on this list, the following patch add support for Mongolian. Using Mongolian is surprisingly easy and its support is the same as we already do for Vietnamese, Latvian, and Lithuanian. Nevertheless, it is a fileformat change. OK to go in? (As always,