Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Enrico Forestieri
On Wed, Apr 04, 2007 at 05:36:10PM +0200, Abdelrazak Younes wrote: > Richard Heck wrote: > > Abdelrazak Younes wrote: > >> Richard Heck wrote: > >>> Attached are some screen shots of the new dialog, which I've updated on > >>> the basis of the now restored old version. Comments welcome. > >> Looks

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Abdelrazak Younes
Richard Heck wrote: Abdelrazak Younes wrote: Richard Heck wrote: Attached are some screen shots of the new dialog, which I've updated on the basis of the now restored old version. Comments welcome. Looks good and better than what we have currently. I miss some explanations for the "Set width

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Abdelrazak Younes
Enrico Forestieri wrote: On Wed, Apr 04, 2007 at 03:16:44PM +0200, Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: I've restored the horizontal layout now. it is still not ok Really? It's perfect on my screen... really weir

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Enrico Forestieri
On Wed, Apr 04, 2007 at 03:16:44PM +0200, Abdelrazak Younes wrote: > Edwin Leuven wrote: > > Abdelrazak Younes wrote: > >> Edwin Leuven wrote: > >>> Abdelrazak Younes wrote: > I've restored the horizontal layout now. > >>> > >>> it is still not ok > >> > >> Really? It's perfect on my screen...

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Richard Heck
Abdelrazak Younes wrote: > Richard Heck wrote: >> Attached are some screen shots of the new dialog, which I've updated on >> the basis of the now restored old version. Comments welcome. > Looks good and better than what we have currently. > > I miss some explanations for the "Set width" and "Set h

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Abdelrazak Younes
Richard Heck wrote: Attached are some screen shots of the new dialog, which I've updated on the basis of the now restored old version. Comments welcome. Looks good and better than what we have currently. I miss some explanations for the "Set width" and "Set height" options... I don't know wh

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: I've restored the horizontal layout now. it is still not ok Really? It's perfect on my screen... really weird! try to resize the dialog Ah... yes, you're right! But the problem is more general...

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Edwin Leuven
Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: I've restored the horizontal layout now. it is still not ok Really? It's perfect on my screen... really weird! try to resize the dialog

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: I've restored the horizontal layout now. it is still not ok Really? It's perfect on my screen... really weird! will commit a fix... Fine. Abdel.

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Edwin Leuven
Abdelrazak Younes wrote: I've restored the horizontal layout now. it is still not ok will commit a fix...

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Abdelrazak Younes
Uwe Stöhr wrote: > the bug introduced by 17625 and 17626 by reverting these > changesets because 1) they introduced a bug and 2) they don't do what > advertised, rather the contrary. I checked this both on Windows (with > Qt4.1.4 and Qt4.2.2) and Solaris (with Qt4.2.2). See the attached imag

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-04 Thread Abdelrazak Younes
Richard Heck wrote: Enrico Forestieri wrote: Please, can you wait with this patch? Before you commit it I would like to see resolved the bug introduced by 17625 and 17626 by reverting these changesets because 1) they introduced a bug and 2) they don't do what advertised, rather the contrary. I c

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-03 Thread Uwe Stöhr
> the bug introduced by 17625 and 17626 by reverting these > changesets because 1) they introduced a bug and 2) they don't do what > advertised, rather the contrary. I checked this both on Windows (with > Qt4.1.4 and Qt4.2.2) and Solaris (with Qt4.2.2). See the attached images. That's weird, what

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-03 Thread Richard Heck
Enrico Forestieri wrote: Please, can you wait with this patch? Before you commit it I would like to see resolved the bug introduced by 17625 and 17626 by reverting these changesets because 1) they introduced a bug and 2) they don't do what advertised, rather the contrary. I checked this both on W

Re: [PATCH] Bug 3215: Graphics Dialog

2007-04-03 Thread Enrico Forestieri
On Tue, Apr 03, 2007 at 05:55:29PM -0400, Richard Heck wrote: > > Attached is what is hopefully the penultimate version of this patch. > Please note that the diff was run from src/frontends/qt4/. > > The changes at the beginning of QGraphicsDialog.C are less extensive > than they appear. I had to

[PATCH] Bug 3215: Graphics Dialog

2007-04-03 Thread Richard Heck
Attached is what is hopefully the penultimate version of this patch. Please note that the diff was run from src/frontends/qt4/. The changes at the beginning of QGraphicsDialog.C are less extensive than they appear. I had to re-arrange this so I could make sense of it. The only real changes are ad