Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-24 Thread Scott Kostyshak
On Sun, Jun 24, 2018 at 05:10:10PM +, Kornel Benko wrote: > OK. Done at 03fef44b. Scott signature.asc Description: PGP signature

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-24 Thread Kornel Benko
Am Sonntag, 24. Juni 2018 12:39:27 CEST schrieb Scott Kostyshak : > On Sun, Jun 24, 2018 at 07:39:23AM +, Kornel Benko wrote: > > Am Sonntag, 24. Juni 2018 02:48:06 CEST schrieb Scott Kostyshak > > : > > > On Sun, Jun 24, 2018 at 06:15:08AM +, Kornel Benko wrote: > > > > > > > Thanks, I

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-24 Thread Scott Kostyshak
On Sun, Jun 24, 2018 at 07:39:23AM +, Kornel Benko wrote: > Am Sonntag, 24. Juni 2018 02:48:06 CEST schrieb Scott Kostyshak > : > > On Sun, Jun 24, 2018 at 06:15:08AM +, Kornel Benko wrote: > > > > > Thanks, I take it as '+1'. Scott? > > > > Yes, +1. > > > > Thanks, > > > > Scott > >

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-24 Thread Kornel Benko
Am Sonntag, 24. Juni 2018 02:48:06 CEST schrieb Scott Kostyshak : > On Sun, Jun 24, 2018 at 06:15:08AM +, Kornel Benko wrote: > > > Thanks, I take it as '+1'. Scott? > > Yes, +1. > > Thanks, > > Scott Done at 889d10c Kornel signature.asc Description: This is a digitally signe

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-23 Thread Scott Kostyshak
On Sun, Jun 24, 2018 at 06:15:08AM +, Kornel Benko wrote: > Thanks, I take it as '+1'. Scott? Yes, +1. Thanks, Scott signature.asc Description: PGP signature

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-23 Thread Kornel Benko
Am Samstag, 23. Juni 2018 22:53:08 CEST schrieb Stephan Witt : > Am 15.06.2018 um 23:04 schrieb Kornel Benko : > > > > Am Freitag, 15. Juni 2018 22:29:47 CEST schrieb Stephan Witt > > : > > > Am 14.06.2018 um 19:56 schrieb Scott Kostyshak : > > > > > > > > On Thu, Jun 14, 2018 at 12:05:08PM +000

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-23 Thread Stephan Witt
Am 15.06.2018 um 23:04 schrieb Kornel Benko : > > Am Freitag, 15. Juni 2018 22:29:47 CEST schrieb Stephan Witt > : > > Am 14.06.2018 um 19:56 schrieb Scott Kostyshak : > > > > > > On Thu, Jun 14, 2018 at 12:05:08PM +, Kornel Benko wrote: > > >> Am Mittwoch, 13. Juni 2018 14:52:43 CEST schrie

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-22 Thread Kornel Benko
Am Freitag, 15. Juni 2018 23:04:25 CEST schrieb Kornel Benko : > Am Freitag, 15. Juni 2018 22:29:47 CEST schrieb Stephan Witt > : ... > > I don’t have tried any of the offered options. ATM I don’t have a problem > > to build 2.3.x. And on Mac I’ll stick to stable Qt 5.9 until Qt 5.12 is > > availa

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-15 Thread Scott Kostyshak
On Fri, Jun 15, 2018 at 08:29:47PM +, Stephan Witt wrote: > I don’t have tried any of the offered options. ATM I don’t have a problem > to build 2.3.x. And on Mac I’ll stick to stable Qt 5.9 until Qt 5.12 is > available if possible. Makes sense. I'm still on 5.6 for my main computer. [The res

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-15 Thread Kornel Benko
Am Freitag, 15. Juni 2018 22:29:47 CEST schrieb Stephan Witt : > Am 14.06.2018 um 19:56 schrieb Scott Kostyshak : > > > > On Thu, Jun 14, 2018 at 12:05:08PM +, Kornel Benko wrote: > >> Am Mittwoch, 13. Juni 2018 14:52:43 CEST schrieb Scott Kostyshak > >> : > It is possible, the commit d6

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-15 Thread Stephan Witt
Am 14.06.2018 um 19:56 schrieb Scott Kostyshak : > > On Thu, Jun 14, 2018 at 12:05:08PM +, Kornel Benko wrote: >> Am Mittwoch, 13. Juni 2018 14:52:43 CEST schrieb Scott Kostyshak >> : It is possible, the commit d6b21e2 does exactly that. Does not raise the minimal cmake version, in

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-15 Thread Stephan Witt
Am 14.06.2018 um 17:50 schrieb Jürgen Spitzmüller : > > Am Mittwoch, den 13.06.2018, 21:43 +0200 schrieb Stephan Witt: >>> I do think we should support Qt 5.11 on 2.3.x because 2.3.x will >>> probably be around for a while. >> >> I’m not against support for Qt 5.11 but it will be around until 5.1

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-14 Thread Scott Kostyshak
On Thu, Jun 14, 2018 at 12:05:08PM +, Kornel Benko wrote: > Am Mittwoch, 13. Juni 2018 14:52:43 CEST schrieb Scott Kostyshak > : > > > It is possible, the commit d6b21e2 does exactly that. Does not raise the > > > minimal cmake version, instead > > > it copies some statements from original qt

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-14 Thread Jürgen Spitzmüller
Am Mittwoch, den 13.06.2018, 21:43 +0200 schrieb Stephan Witt: > > I do think we should support Qt 5.11 on 2.3.x because 2.3.x will > > probably be around for a while. > > I’m not against support for Qt 5.11 but it will be around until 5.12 > what > is announced as next stable release by Qt folks,

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-14 Thread Kornel Benko
Am Mittwoch, 13. Juni 2018 14:52:43 CEST schrieb Scott Kostyshak : > > It is possible, the commit d6b21e2 does exactly that. Does not raise the > > minimal cmake version, instead > > it copies some statements from original qt5_use_modules() into our > > cmake-handling. > > Ah good to know. So t

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-13 Thread Kornel Benko
Am Mittwoch, 13. Juni 2018 21:45:20 CEST schrieb Stephan Witt : > Am 13.06.2018 um 21:43 schrieb Stephan Witt : > > > > Am 13.06.2018 um 20:06 schrieb Scott Kostyshak : > >> > >> On Wed, Jun 13, 2018 at 01:41:03PM +, Richard Kimberly Heck wrote: > >>> On 06/13/2018 03:29 AM, Scott Kostyshak w

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-13 Thread Stephan Witt
Am 13.06.2018 um 21:43 schrieb Stephan Witt : > > Am 13.06.2018 um 20:06 schrieb Scott Kostyshak : >> >> On Wed, Jun 13, 2018 at 01:41:03PM +, Richard Kimberly Heck wrote: >>> On 06/13/2018 03:29 AM, Scott Kostyshak wrote: On Wed, Jun 13, 2018 at 06:02:21AM +, Kornel Benko wrote: >>>

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-13 Thread Stephan Witt
Am 13.06.2018 um 20:06 schrieb Scott Kostyshak : > > On Wed, Jun 13, 2018 at 01:41:03PM +, Richard Kimberly Heck wrote: >> On 06/13/2018 03:29 AM, Scott Kostyshak wrote: >>> On Wed, Jun 13, 2018 at 06:02:21AM +, Kornel Benko wrote: Am Dienstag, 12. Juni 2018 21:10:26 CEST schrieb Korn

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-13 Thread Scott Kostyshak
On Wed, Jun 13, 2018 at 06:47:42PM +, Kornel Benko wrote: > Am Mittwoch, 13. Juni 2018 14:06:39 CEST schrieb Scott Kostyshak > : > > On Wed, Jun 13, 2018 at 01:41:03PM +, Richard Kimberly Heck wrote: > > > On 06/13/2018 03:29 AM, Scott Kostyshak wrote: > > > > On Wed, Jun 13, 2018 at 06:02

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-13 Thread Kornel Benko
Am Mittwoch, 13. Juni 2018 14:06:39 CEST schrieb Scott Kostyshak : > On Wed, Jun 13, 2018 at 01:41:03PM +, Richard Kimberly Heck wrote: > > On 06/13/2018 03:29 AM, Scott Kostyshak wrote: > > > On Wed, Jun 13, 2018 at 06:02:21AM +, Kornel Benko wrote: > > >> Am Dienstag, 12. Juni 2018 21:10

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-13 Thread Scott Kostyshak
On Wed, Jun 13, 2018 at 01:41:03PM +, Richard Kimberly Heck wrote: > On 06/13/2018 03:29 AM, Scott Kostyshak wrote: > > On Wed, Jun 13, 2018 at 06:02:21AM +, Kornel Benko wrote: > >> Am Dienstag, 12. Juni 2018 21:10:26 CEST schrieb Kornel Benko > >> : > >>> Am Dienstag, 12. Juni 2018 21:05

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-13 Thread Richard Kimberly Heck
On 06/13/2018 03:29 AM, Scott Kostyshak wrote: > On Wed, Jun 13, 2018 at 06:02:21AM +, Kornel Benko wrote: >> Am Dienstag, 12. Juni 2018 21:10:26 CEST schrieb Kornel Benko >> : >>> Am Dienstag, 12. Juni 2018 21:05:10 CEST schrieb Jürgen Spitzmüller >>> : Kornel Benko schrieb am Di., >>>

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-13 Thread Scott Kostyshak
On Wed, Jun 13, 2018 at 06:02:21AM +, Kornel Benko wrote: > Am Dienstag, 12. Juni 2018 21:10:26 CEST schrieb Kornel Benko > : > > Am Dienstag, 12. Juni 2018 21:05:10 CEST schrieb Jürgen Spitzmüller > > : > > > Kornel Benko schrieb am Di., > > > > > > > > > > > > > > > My feeling is that the

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-12 Thread Kornel Benko
Am Dienstag, 12. Juni 2018 21:10:26 CEST schrieb Kornel Benko : > Am Dienstag, 12. Juni 2018 21:05:10 CEST schrieb Jürgen Spitzmüller > : > > Kornel Benko schrieb am Di., > > > > > > > > > > > My feeling is that the need to compile with QT5.11 is only important for > > > the future releases (e.g

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-12 Thread Kornel Benko
Am Dienstag, 12. Juni 2018 21:05:10 CEST schrieb Jürgen Spitzmüller : > Kornel Benko schrieb am Di., > > > > > > > My feeling is that the need to compile with QT5.11 is only important for > > the future releases (e.g >= 2.4) > > > > But some distros already ship Qt 5.11. I cannot compile 2.3.x

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-12 Thread Jürgen Spitzmüller
Kornel Benko schrieb am Di., > > > My feeling is that the need to compile with QT5.11 is only important for > the future releases (e.g >= 2.4) > But some distros already ship Qt 5.11. I cannot compile 2.3.x here with cmake (openSuse Tumbleweed) Jürgen > > Kornel > > > > > > >

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-12 Thread Kornel Benko
Am Sonntag, 10. Juni 2018 14:25:58 CEST schrieb Scott Kostyshak : > On Sun, Jun 10, 2018 at 05:05:48PM +, Kornel Benko wrote: > > > Oh, yes, you are right. In master. Will you do it? > > Done at cb08d4a8. Thanks. > Are we planning to backport 72a2f922? If not, we should mention the > minim

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-10 Thread Scott Kostyshak
On Sun, Jun 10, 2018 at 05:05:48PM +, Kornel Benko wrote: > Oh, yes, you are right. In master. Will you do it? Done at cb08d4a8. Are we planning to backport 72a2f922? If not, we should mention the minimum requirement change in the release notes of master branch. Scott signature.asc Descri

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-10 Thread Kornel Benko
Am Sonntag, 10. Juni 2018 12:38:09 CEST schrieb Scott Kostyshak : > On Sun, Jun 10, 2018 at 10:23:31AM +, Kornel Benko wrote: > > Am Samstag, 9. Juni 2018 23:51:17 CEST schrieb Scott Kostyshak > > : > > > On Sat, Jun 09, 2018 at 10:09:32PM +, Kornel Benko wrote: > > > > commit 72a2f922393

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-10 Thread Scott Kostyshak
On Sun, Jun 10, 2018 at 10:23:31AM +, Kornel Benko wrote: > Am Samstag, 9. Juni 2018 23:51:17 CEST schrieb Scott Kostyshak > : > > On Sat, Jun 09, 2018 at 10:09:32PM +, Kornel Benko wrote: > > > commit 72a2f922393f8029b658fffe3c5a2e3e2c81ac1d > > > Author: Kornel Benko > > > Date: Sat J

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-10 Thread Kornel Benko
Am Samstag, 9. Juni 2018 23:51:17 CEST schrieb Scott Kostyshak : > On Sat, Jun 09, 2018 at 10:09:32PM +, Kornel Benko wrote: > > commit 72a2f922393f8029b658fffe3c5a2e3e2c81ac1d > > Author: Kornel Benko > > Date: Sat Jun 9 23:59:47 2018 +0200 > > > > Cmake build: Simplify use of qt5 mod

Re: [LyX/master] Cmake build: Simplify use of qt5 modules

2018-06-09 Thread Scott Kostyshak
On Sat, Jun 09, 2018 at 10:09:32PM +, Kornel Benko wrote: > commit 72a2f922393f8029b658fffe3c5a2e3e2c81ac1d > Author: Kornel Benko > Date: Sat Jun 9 23:59:47 2018 +0200 > > Cmake build: Simplify use of qt5 modules > > According to this page: > http://doc.qt.io/qt-5/cmake-