On Sat, Jun 09, 2018 at 10:09:32PM +0000, Kornel Benko wrote: > commit 72a2f922393f8029b658fffe3c5a2e3e2c81ac1d > Author: Kornel Benko <kor...@lyx.org> > Date: Sat Jun 9 23:59:47 2018 +0200 > > Cmake build: Simplify use of qt5 modules > > According to this page: > http://doc.qt.io/qt-5/cmake-manual.html > the way to replace use of qt5_use_modules() for module "_mod" and target > "_target" > is to use > 1.) cmake_minimum_required(VERSION 3.1.0) > 2.) find_package(Qt5${_mod} CONFIG REQUIRED) > 3.) target_link_libraries(${_target} Qt5::${_mod}) > The last one sets all reguired libraries, compile flags and needed > includes for the ${_target} > --- > -cmake_minimum_required(VERSION 2.6.4) > +cmake_minimum_required(VERSION 3.1.0)
Should we change the minimum version also in the following? development/Win32/vld/cmake/CMakeLists.txt INSTALL.cmake Scott
signature.asc
Description: PGP signature