On Sun, Jun 10, 2018 at 10:23:31AM +0000, Kornel Benko wrote: > Am Samstag, 9. Juni 2018 23:51:17 CEST schrieb Scott Kostyshak > <[email protected]>: > > On Sat, Jun 09, 2018 at 10:09:32PM +0000, Kornel Benko wrote: > > > commit 72a2f922393f8029b658fffe3c5a2e3e2c81ac1d > > > Author: Kornel Benko <[email protected]> > > > Date: Sat Jun 9 23:59:47 2018 +0200 > > > > > > Cmake build: Simplify use of qt5 modules > > > > > > According to this page: > > > http://doc.qt.io/qt-5/cmake-manual.html > > > the way to replace use of qt5_use_modules() for module "_mod" and > > > target "_target" > > > is to use > > > 1.) cmake_minimum_required(VERSION 3.1.0) > > > 2.) find_package(Qt5${_mod} CONFIG REQUIRED) > > > 3.) target_link_libraries(${_target} Qt5::${_mod}) > > > The last one sets all reguired libraries, compile flags and needed > > > includes for the ${_target} > > > --- > > > -cmake_minimum_required(VERSION 2.6.4) > > > +cmake_minimum_required(VERSION 3.1.0) > > > > Should we change the minimum version also in the following? > > > > development/Win32/vld/cmake/CMakeLists.txt > > I suppose not. From my POV, all needed QT settings are already processed. > If this CMakeLists.txt is not used as top-level in some other project, we > could also > remove the line there. > In the 3rdparty folder we also have some cmake_minimum_required settings, and > it does not interfere.
OK thanks for checking. > > INSTALL.cmake > > ?? We currently have the following text: Install CMake from www.cmake.org or your distribution (version >= 2.6.4). I was referring to whether we should change "2.6.4" to "3.1.0". Scott
signature.asc
Description: PGP signature
