Re: equation labels in 2.1.0beta1

On Mon, Aug 5, 2013 at 9:41 AM, Richard Heck wrote: > On 08/05/2013 09:32 AM, Richard Heck wrote: >> >> On 08/05/2013 06:10 AM, Pavel Sanda wrote: >>> >>> John Kennan wrote: When instant preview is on, an equation label with square brackets shows up as hex codes. >>> >>> Confir

role of export tests in 'make test'

Pavel and Vincent have reminded me (thank you!) that "make test" should not run the same tests that I might want to run personally. My question is -- what should the role of export tests in 'make test' be? Should 'make test' run export tests at all? If so, which LaTeX dependencies should they dep

Re: [PATCH] CMake: tests now fail if no default_output_format

On Mon, Aug 5, 2013 at 3:10 PM, Pavel Sanda wrote: > Kornel Benko wrote: >> I do not agree. We should check attic too IMHO (or else do not provide it). >> Therefore I prefer you to commit :) > > We "provide it" :) > Have you ever looked at the junk in development/attic? It's almost definition > th

Re: [PATCH] CMake: tests now fail if no default_output_format

On Mon, Aug 5, 2013 at 7:48 AM, Kornel Benko wrote: > Am Montag, 5. August 2013 um 07:41:31, schrieb Scott Kostyshak > > >> On Mon, Aug 5, 2013 at 7:34 AM, Kornel Benko wrote: > >> > Am Montag, 5. August 2013 um 07:07:58, schrieb Scott Kostyshak > >> > > >> > > >> >> On Mon, Aug 5, 2013 at 6:02

Re: [PATCH] Fix Viewing of XHTML with Math as Images

On 08/05/2013 05:45 PM, Vincent van Ravesteijn wrote: Op 5 aug. 2013 23:25 schreef "Richard Heck" > het volgende: > > On 08/04/2013 05:43 PM, Richard Heck wrote: >> >> >> The attached patch explains the problem and offers a simple solution. This is master-only, and it n

Re: [PATCH] Fix Viewing of XHTML with Math as Images

Op 5 aug. 2013 23:25 schreef "Richard Heck" het volgende: > > On 08/04/2013 05:43 PM, Richard Heck wrote: >> >> >> The attached patch explains the problem and offers a simple solution. This is master-only, and it needs to go into 2.1. OK? > > > Someone want to approve this? or not? > >> Richard >>

Re: [PATCH] Fix Viewing of XHTML with Math as Images

On 08/04/2013 05:43 PM, Richard Heck wrote: The attached patch explains the problem and offers a simple solution. This is master-only, and it needs to go into 2.1. OK? Someone want to approve this? or not? Richard

Re: [LyX/master] * cs.po

Op 5 aug. 2013 22:21 schreef "Pavel Sanda" het volgende: > > Pavel Sanda wrote: > > -"POT-Creation-Date: 2013-08-05 13:08-0700\n" > > +"POT-Creation-Date: 2013-08-05 13:11-0700\n" > > BTW Vincent, what version of gettext you use? > Got lot of merge conflicts last time. > Pavel Default of Ubuntu 1

Re: [LyX/master] * cs.po

Pavel Sanda wrote: > -"POT-Creation-Date: 2013-08-05 13:08-0700\n" > +"POT-Creation-Date: 2013-08-05 13:11-0700\n" BTW Vincent, what version of gettext you use? Got lot of merge conflicts last time. Pavel

Re: [PATCH] CMake: tests now fail if no default_output_format

Kornel Benko wrote: > I do not agree. We should check attic too IMHO (or else do not provide it). > Therefore I prefer you to commit :) We "provide it" :) Have you ever looked at the junk in development/attic? It's almost definition that we put files there if they are no more functional. The only

Re: Row by Row sliding (review of 095060cfcaa8f)

Dear Hashini, I did see several copies of your answer. Unfortunately, I am not able to do much more than read the messages on myvphone. It is difficult to me to give useful advice without the source code and a proper keyboard... Tommaso, can ypu help ? JMarc Hashini Senaratne a écrit : >Hel

Re: Row by Row sliding (review of 095060cfcaa8f)

On 08/05/2013 08:38 AM, Hashini Senaratne wrote: Hello Jean-Marc, I continue my backwards visit of history. Although I posted some replies to mailing list last week, they do not seems to appear to the outside yet. So I am re-sending those replies. They did arrive here. It's just that JMarc i

Re: Row by Row sliding (review of

On 08/01/2013 02:00 PM, Hashini Senaratne wrote: Hello Jean-Marc, +++ b/src/Cursor.cpp -278,7 +278,7 CursorData::CursorData(DocIterator const & dit) // bv functions are not yet available! Cursor::Cursor(BufferView & bv) : CursorData(&bv.buffer()), bv_(&bv), -

Re: Row by Row sliding (review of 095060cfcaa8f)

On 08/01/2013 01:15 PM, Hashini Senaratne wrote: + BufferView & bv = cur.bv(); + You are defining bv, whereas you already have bv_, which is a BufferView const *. Advice: always check whether a variable is needed before defining it. However in this case the situation is different

Re: equation labels in 2.1.0beta1

On 08/05/2013 09:32 AM, Richard Heck wrote: On 08/05/2013 06:10 AM, Pavel Sanda wrote: John Kennan wrote: When instant preview is on, an equation label with square brackets shows up as hex codes. Confirmed as regression to 2.0.x. Please can you create bug and attach the file there so it's not

Re: equation labels in 2.1.0beta1

On 08/05/2013 06:10 AM, Pavel Sanda wrote: John Kennan wrote: When instant preview is on, an equation label with square brackets shows up as hex codes. Confirmed as regression to 2.0.x. Please can you create bug and attach the file there so it's not forgotten? If you look at View> Source, yo

Re: [PATCH] CMake: tests now fail if no default_output_format

Am Montag, 5. August 2013 um 14:50:19, schrieb Vincent van Ravesteijn > Op 5-8-2013 14:37, Kornel Benko schreef: > > > > Am Montag, 5. August 2013 um 08:22:19, schrieb Scott Kostyshak > > > > > > > On Mon, Aug 5, 2013 at 8:09 AM, Kornel Benko wrote: > > > > > > Am Montag, 5. August 2013 um 08:

Re: [PATCH] CMake: tests now fail if no default_output_format

On Mon, Aug 5, 2013 at 8:53 AM, Vincent van Ravesteijn wrote: > Op 3-8-2013 9:54, Scott Kostyshak schreef: > >> On Fri, Aug 2, 2013 at 2:36 PM, Kornel Benko wrote: >>> >>> Am Freitag, 2. August 2013 um 20:06:40, schrieb Vincent van Ravesteijn >>> >>> > Why should we update? This is also the

Re: [PATCH] CMake: tests now fail if no default_output_format

On Mon, Aug 5, 2013 at 8:50 AM, Vincent van Ravesteijn wrote: > Op 5-8-2013 14:37, Kornel Benko schreef: > > Am Montag, 5. August 2013 um 08:22:19, schrieb Scott Kostyshak > > >> On Mon, Aug 5, 2013 at 8:09 AM, Kornel Benko wrote: > >> > Am Montag, 5. August 2013 um 08:01:08, schrieb Scott Kosty

Re: [PATCH] CMake: tests now fail if no default_output_format

Op 3-8-2013 9:54, Scott Kostyshak schreef: On Fri, Aug 2, 2013 at 2:36 PM, Kornel Benko wrote: Am Freitag, 2. August 2013 um 20:06:40, schrieb Vincent van Ravesteijn Why should we update? This is also the test for lyx2lyx, isn't it? No, this is not the way to test lyx2lyx. Vincent Sorry,

Re: [PATCH] CMake: tests now fail if no default_output_format

Am Montag, 5. August 2013 um 14:40:12, schrieb Vincent van Ravesteijn > Op 5-8-2013 13:07, Scott Kostyshak schreef: > > On Mon, Aug 5, 2013 at 6:02 AM, Vincent van Ravesteijn wrote: > >> Op 4-8-2013 22:23, Scott Kostyshak schreef: > >> > >>> On Sat, Aug 3, 2013 at 3:54 AM, Scott Kostyshak wrote

Re: [PATCH] CMake: tests now fail if no default_output_format

Op 5-8-2013 14:37, Kornel Benko schreef: Am Montag, 5. August 2013 um 08:22:19, schrieb Scott Kostyshak > On Mon, Aug 5, 2013 at 8:09 AM, Kornel Benko wrote: > > Am Montag, 5. August 2013 um 08:01:08, schrieb Scott Kostyshak > > > > > >> On Mon, Aug 5, 2013 at 5:56 AM, Pavel Sanda wro

Re: Row by Row sliding (review of

Hello Jean-Marc, > +++ b/src/Cursor.cpp > -278,7 +278,7 CursorData::CursorData(DocIterator const & dit) > // bv functions are not yet available! > Cursor::Cursor(BufferView & bv) > : CursorData(&bv.buffer()), bv_(&bv), > - x_target_(-1), textTargetOffset_(0) > +

Re: [PATCH] CMake: tests now fail if no default_output_format

Op 5-8-2013 13:07, Scott Kostyshak schreef: On Mon, Aug 5, 2013 at 6:02 AM, Vincent van Ravesteijn wrote: Op 4-8-2013 22:23, Scott Kostyshak schreef: On Sat, Aug 3, 2013 at 3:54 AM, Scott Kostyshak wrote: On Fri, Aug 2, 2013 at 5:58 AM, Vincent van Ravesteijn wrote: On Fri, Aug 2, 2013 at

Re: Row by Row sliding (review of 095060cfcaa8f)

Hello Jean-Marc, > > I continue my backwards visit of history. Although I posted some replies to mailing list last week, they do not seems to appear to the outside yet. So I am re-sending those replies. I carefully followed your reviews and modified the code accordingly. Your comments on them we

Re: [PATCH] CMake: tests now fail if no default_output_format

Am Montag, 5. August 2013 um 08:22:19, schrieb Scott Kostyshak > On Mon, Aug 5, 2013 at 8:09 AM, Kornel Benko wrote: > > Am Montag, 5. August 2013 um 08:01:08, schrieb Scott Kostyshak > > > > > >> On Mon, Aug 5, 2013 at 5:56 AM, Pavel Sanda wrote: > > > >> > Scott Kostyshak wrote: > > > >> >>

Re: [PATCH] CMake: tests now fail if no default_output_format

On Mon, Aug 5, 2013 at 8:09 AM, Kornel Benko wrote: > Am Montag, 5. August 2013 um 08:01:08, schrieb Scott Kostyshak > > >> On Mon, Aug 5, 2013 at 5:56 AM, Pavel Sanda wrote: > >> > Scott Kostyshak wrote: > >> >> > Sorry, I meant "This is also a test for lyx2lyx, isn't it?" > >> >> > >> >> My op

Re: [PATCH] CMake: tests now fail if no default_output_format

Am Montag, 5. August 2013 um 08:01:08, schrieb Scott Kostyshak > On Mon, Aug 5, 2013 at 5:56 AM, Pavel Sanda wrote: > > Scott Kostyshak wrote: > >> > Sorry, I meant "This is also a test for lyx2lyx, isn't it?" > >> > >> My opinion is that we should update those documents. I agree that it > > > >

Re: [PATCH] CMake: tests now fail if no default_output_format

On Mon, Aug 5, 2013 at 5:56 AM, Pavel Sanda wrote: > Scott Kostyshak wrote: >> > Sorry, I meant "This is also a test for lyx2lyx, isn't it?" >> >> My opinion is that we should update those documents. I agree that it > > attic is just garbage and it is somewhat absurd that test should fail > becaus

Re: [PATCH] CMake: tests now fail if no default_output_format

Am Montag, 5. August 2013 um 07:41:31, schrieb Scott Kostyshak > On Mon, Aug 5, 2013 at 7:34 AM, Kornel Benko wrote: > > Am Montag, 5. August 2013 um 07:07:58, schrieb Scott Kostyshak > > > > > >> On Mon, Aug 5, 2013 at 6:02 AM, Vincent van Ravesteijn > >> wrote: > > > > [snip] > > > >> > As f

Re: [PATCH] CMake: tests now fail if no default_output_format

On Mon, Aug 5, 2013 at 7:34 AM, Kornel Benko wrote: > Am Montag, 5. August 2013 um 07:07:58, schrieb Scott Kostyshak > > >> On Mon, Aug 5, 2013 at 6:02 AM, Vincent van Ravesteijn >> wrote: > > [snip] > >> > As far as I see it, it cannot happen that there is no >> > default_output_format. > >> >

Re: [PATCH] CMake: tests now fail if no default_output_format

Am Montag, 5. August 2013 um 07:07:58, schrieb Scott Kostyshak > On Mon, Aug 5, 2013 at 6:02 AM, Vincent van Ravesteijn wrote: [snip] > > As far as I see it, it cannot happen that there is no default_output_format. > > > Only if there are lyx files with an old file format. In that case: > > > >

Re: equation labels in 2.1.0beta1

John Kennan wrote: > When instant preview is on, an equation label with square brackets shows up > as hex codes. Confirmed as regression to 2.0.x. Please can you create bug and attach the file there so it's not forgotten? Pavel

Re: lyx-2.1.0beta1 preview ghostscript errors

Neal Becker wrote: > Just trying lyx-2.1.0beta1 on fedora 19 linux. > > Loading up an old file, I got lots of errors related to image previews. > These > are all pdfs, and all produced by matplotlib. Strangely, the 1st file I > loaded Does it mean that the same document worked in 2.0.x seri

Re: [PATCH] CMake: tests now fail if no default_output_format

Am Montag, 5. August 2013 um 12:02:00, schrieb Vincent van Ravesteijn > Op 4-8-2013 22:23, Scott Kostyshak schreef: > > On Sat, Aug 3, 2013 at 3:54 AM, Scott Kostyshak wrote: > >> On Fri, Aug 2, 2013 at 5:58 AM, Vincent van Ravesteijn > >> wrote: > >>> On Fri, Aug 2, 2013 at 11:45 AM, Kornel B

Re: [PATCH] CMake: tests now fail if no default_output_format

Scott Kostyshak wrote: > > Sorry, I meant "This is also a test for lyx2lyx, isn't it?" > > My opinion is that we should update those documents. I agree that it attic is just garbage and it is somewhat absurd that test should fail because of some contents in there. Please create proper tests for t

Re: [PATCH] CMake: tests now fail if no default_output_format

Op 4-8-2013 22:23, Scott Kostyshak schreef: On Sat, Aug 3, 2013 at 3:54 AM, Scott Kostyshak wrote: On Fri, Aug 2, 2013 at 5:58 AM, Vincent van Ravesteijn wrote: On Fri, Aug 2, 2013 at 11:45 AM, Kornel Benko wrote: About the patch... why do we care about malformed LyX documents ? How can thi

Re: [PATCH] CMake: tests now fail if no default_output_format

On Mon, Aug 5, 2013 at 6:02 AM, Vincent van Ravesteijn wrote: > Op 4-8-2013 22:23, Scott Kostyshak schreef: > >> On Sat, Aug 3, 2013 at 3:54 AM, Scott Kostyshak wrote: >>> >>> On Fri, Aug 2, 2013 at 5:58 AM, Vincent van Ravesteijn >>> wrote: On Fri, Aug 2, 2013 at 11:45 AM, Kornel Benk

Re: 6 advanced find tests are failing on master

On Sun, Jul 28, 2013 at 8:15 AM, Tommaso Cucinotta wrote: > On 28/07/13 06:59, Scott Kostyshak wrote: Let non-ASCII chars within regexp insets match their occurrence within TEXT, rather than MATHS (seems the most recurrently needed scenario). >> >>> As for the release, I ca